[tor-bugs] #3814 [Tor Relay]: Duplicate mark_for_close when running server with bufferevents

[Tor Bug Tracker & Wiki]

#3814: Duplicate mark_for_close when running server with bufferevents
-----------------------+----------------------------------------------------
 Reporter:  nickm      |          Owner:                    
     Type:  defect     |         Status:  new               
 Priority:  normal     |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:  #3561             
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------
 It  looks like there's a double-close going on when running a server with
 bufferevents:

 [warn] Bug: Duplicate call to connection_mark_for_close at
 directory.c:3549 (first at directory.c:3549)

 This is in connection_dir_finished_flushing(), in the
 DIR_CONN_STATE_SERVER_WRITING code.  So that implies that
 connection_dir_finished_flushing() is getting called twice for a directory
 connection.  That shouldn't happen: we should only call that from
 connection_handle_write_cb().  This could be a real bug, and imply
 premature closing of a directory connection.

 Perhaps this has something to do with the fact that the directory
 connections here are implemented with a bufferevent_pair in typical use.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3814>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online