Hi Michael,
I'm cc'ing tor-relays for the discussion here, because I figured if you're okay with sharing the patch, you're probably also okay with a public discussion of it. :)
On 7/21/12 4:19 PM, Michael Zeltner wrote:
Hi Karsten,
On my way out, and I would otherwise forget but here you go, maybe you'd like this.
Best from Metalab/Vienna, Michael
Thanks for sending the patch! Most of it looks good, but I took out the --family-for-fp option which, I think, isn't entirely correct. This option looks for relays having the given fingerprint in their family line, but it doesn't cross-check if the given relay has those relays in its family line, too. The option also doesn't look at nicknames (of relays with the Named flag) in family lines, which means it might miss some family members. Oh, and it would be really cool to have a -F or --by-family option to aggregate by families. I wonder if we should do the whole family-calculating business inside Onionoo and add a family_number field which has the same number for relays in the same family. The script could then look up the family number of the given relay and display all relays with that family number. Would that make sense? Want to extend the script once Onionoo has such a field?
Thanks! Karsten
Excerpts from Karsten Loesing's message of 2012-07-23 08:59:20 +0200:
I'm cc'ing tor-relays for the discussion here, because I figured if you're okay with sharing the patch, you're probably also okay with a public discussion of it. :)
Indeed!
Thanks for sending the patch! Most of it looks good, but I took out the --family-for-fp option which, I think, isn't entirely correct. This option looks for relays having the given fingerprint in their family line, but it doesn't cross-check if the given relay has those relays in its family line, too. The option also doesn't look at nicknames (of relays with the Named flag) in family lines, which means it might miss some family members.
Yes, I noticed the first bit as well, and have since better understood how families work - the attached patch should fix that. It looks for mutually listed relays via both fingerprints and nicknames (in case the relays have the named flag).
I hope I nailed it this time round.
Oh, and it would be really cool to have a -F or --by-family option to aggregate by families.
Yeah, I'd like that too. I haven't worked on grouping yet but I'll look into it soon.
I wonder if we should do the whole family-calculating business inside Onionoo and add a family_number field which has the same number for relays in the same family. The script could then look up the family number of the given relay and display all relays with that family number. Would that make sense? Want to extend the script once Onionoo has such a field?
It'd certainly make it quicker to filter out the relays one wants to take a closer look at - if one is interested in the impact of families. And sure. It'd certainly make the grouping business easier because there's a family-uid one can easily group by :)
Best, Michael
On 7/28/12 9:30 PM, Michael Zeltner wrote:
Thanks for sending the patch! Most of it looks good, but I took out the --family-for-fp option which, I think, isn't entirely correct. This option looks for relays having the given fingerprint in their family line, but it doesn't cross-check if the given relay has those relays in its family line, too. The option also doesn't look at nicknames (of relays with the Named flag) in family lines, which means it might miss some family members.
Yes, I noticed the first bit as well, and have since better understood how families work - the attached patch should fix that. It looks for mutually listed relays via both fingerprints and nicknames (in case the relays have the named flag).
I hope I nailed it this time round.
Thanks for the patch! I rebased your patch to current master and rewrote some parts of it. Please take a look at the task-6329-family branch in my public metrics-tasks repository:
https://gitweb.torproject.org/karsten/metrics-tasks.git/shortlog/refs/heads/...
If you like it, I'll squash our two commits, making you the commit author, and will push it to the official repo.
Oh, and it would be really cool to have a -F or --by-family option to aggregate by families.
Yeah, I'd like that too. I haven't worked on grouping yet but I'll look into it soon.
I wonder if we should do the whole family-calculating business inside Onionoo and add a family_number field which has the same number for relays in the same family. The script could then look up the family number of the given relay and display all relays with that family number. Would that make sense? Want to extend the script once Onionoo has such a field?
It'd certainly make it quicker to filter out the relays one wants to take a closer look at - if one is interested in the impact of families. And sure. It'd certainly make the grouping business easier because there's a family-uid one can easily group by :)
Okay, I'll look into adding this new family_number field soon. Hard to say if I mean this week or this month by that. ;) If you come up with a patch for --by-family before that, let's merge that one first.
Thanks! Karsten
Excerpts from Karsten Loesing's message of 2012-08-01 16:13:41 +0200:
https://gitweb.torproject.org/karsten/metrics-tasks.git/shortlog/refs/heads/...
If you like it, I'll squash our two commits, making you the commit author, and will push it to the official repo.
The changes all look very reasonable make it easier to read - feel free to commit them anyway you like! I'm not really after any particular credits.
Okay, I'll look into adding this new family_number field soon. Hard to say if I mean this week or this month by that. ;) If you come up with a patch for --by-family before that, let's merge that one first.
A wild challenge appears! I hope I'll find some time soon ;)
Michael
On 8/3/12 12:10 PM, Michael Zeltner wrote:
Excerpts from Karsten Loesing's message of 2012-08-01 16:13:41 +0200:
https://gitweb.torproject.org/karsten/metrics-tasks.git/shortlog/refs/heads/...
If you like it, I'll squash our two commits, making you the commit author, and will push it to the official repo.
The changes all look very reasonable make it easier to read - feel free to commit them anyway you like! I'm not really after any particular credits.
Squashed and merged. Thanks!
Okay, I'll look into adding this new family_number field soon. Hard to say if I mean this week or this month by that. ;) If you come up with a patch for --by-family before that, let's merge that one first.
A wild challenge appears! I hope I'll find some time soon ;)
Great. :)
Best, Karsten
tor-relays@lists.torproject.org
-
Karsten Loesing -
Michael Zeltner