Re: [tor-dev] Proposal: only parse .torrc files in torrc.d directory
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Therefore, may I propose to let Tor parse only the files whose name ends with .torrc ?
Yes, this is standard behaviour among many tools.
Or maybe even only parse number_filename.torrc for better consistency and for more clear priority order?
No, this is counter-intuitive. It will confuse many users. It is not how most other tools work.
Thank you so much for the feedback, teor! I have opened the ticket #25140 for this. Shall I try to make a patch on this? Or is it preferred to leave it to developers from TPO? Thank you very much! Best Regards, iry -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEzKSpZKlpRovTotu+oUtNvG3N1TwFAlp2hnAACgkQoUtNvG3N 1Tz3GBAAghKBKm7JVd5PyO7HGBClshO/fUOG2ippVm5hY9sgmzVPxVauJC+CWJN9 RH6YfJwyLJeAHu0o3YD1+LBHvccxTKKQYL48q8aopfWkh8ALk4h9+O5hwpPPIsGC qV7iJ+v4QfpxYkhAUFh8FOy+m5WqsOurScBzcjEnmu2IpIkpnwv1NKLaVrArpMv9 lrGtQds/7dCYC57boSUNgTTJtbuqgNhRBM1oqkGisHsKBiLYExvztS22aLj9uVEX km5c+JJuwEKuuordP4YiFMdES1UYx9Bdm/LrUNWG4dB/ZfjwZYSu/KPsqQcDwmNy 25iovL5KUkVg8S05QwdcCnXm2B5oofLMJ4hW0bkjozjLUt3na131uJumOR7Q2W9f 9aKAGwRzQ624rDHn3SWCC1HKMhP0Y6EhCDyzX5914kRakikas6hmtUWmrSqFvZLO p0WzWuNB05BdRXImTXxPdLyOxasB/eMt31mQXKBSSiwdzJxe3rfnDb//P2vcv9ex ofQNx672qtAgmHp9WWeKY6qas36sZeckEigIlcUN27KFBwDyCGfCebk5tPIGDzC9 aAqmiTqqYCqphHb3i/xX3WwGwk6+Q1ixezOfYFxbAOa96NUDV2ldYIXgBcsAWh/+ RbZ8hI/oOwAug/C9ig5xFpZAy86bbqDApG6wrGNg5gp3qVKDlnA= =zlMh -----END PGP SIGNATURE-----
On 4 Feb 2018, at 15:04, iry <iry@riseup.net> wrote:
Therefore, may I propose to let Tor parse only the files whose name ends with .torrc ?
Yes, this is standard behaviour among many tools.
To be more precise, most tools accept files ending in ".conf". We might want tor to accept ".conf" for consistency. I suggest we also accept files called "torrc", or ending in ".torrc". This should probably also include files called literally ".torrc". Since this is a breaking change, we might want to check if any distribution has adopted another naming scheme, and avoid breaking that naming scheme.
Or maybe even only parse number_filename.torrc for better consistency and for more clear priority order?
No, this is counter-intuitive. It will confuse many users. It is not how most other tools work.
Thank you so much for the feedback, teor!
I have opened the ticket #25140 for this. Shall I try to make a patch on this? Or is it preferred to leave it to developers from TPO?
We accept patches from anyone. If you'd like your patch to be reviewed quickly: * put the ticket in 0.3.3, because it's a bugfix * change the status to "needs review" once you have a patch Thanks! T
participants (2)
-
iry -
teor