[PATCH] fix GCC 7 implicit fallthroug warnings
Hello, 6 patches that fix -Wimplicit-fallthrough in GCC 7 on master, by adding __attribute__ ((fallthrough)); or break, as required. Additionally, the patch fixes the same on maint-0.3.0, the warning is no longer present in master. 0001-Fix-implicit-fallthrough-warning-in-GCC-7-in-tor_gzi.patch Please review, Andreas -- Andreas Stieger <astieger@suse.com> Project Manager Security SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
Hello, On 05/28/2017 11:01 PM, Andreas Stieger wrote:
__attribute__ ((fallthrough));
It turns out that this may not be as portable as I thought. Instead, the attached patch adds magic comments recognized by default -Wimplicit-fallthrough=3 or break, as required. Andreas -- Andreas Stieger <astieger@suse.com> Project Manager Security SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
On Sun, May 28, 2017 at 5:52 PM, Andreas Stieger <astieger@suse.com> wrote:
Hello,
On 05/28/2017 11:01 PM, Andreas Stieger wrote:
__attribute__ ((fallthrough));
It turns out that this may not be as portable as I thought. Instead, the attached patch adds magic comments recognized by default -Wimplicit-fallthrough=3 or break, as required.
Hi! I've applied this one to master, and opened https://trac.torproject.org/projects/tor/ticket/22446#no5 to track it. yrs, -- Nick
participants (2)
-
Andreas Stieger -
Nick Mathewson