Hello Philipp and David, I'm sending you an email because you are the people who are currently developing obfsproxy modules. We are thinking of slightly changing the API of obfsproxy, so that it becomes more friendly to transport authors (or at least we hope so). Specifically, we are thinking of having the circuit be an element of the transport class, instead of being passed as an argument in the receivedDownstream and receivedUpstream methods. I think David and Leif were also thinking of this change. Furthermore, we are also thinking of renaming the 'handshake' method to 'circuitConnected'. (More details can be found in #10342.) Do you agree with the changes? If yes, I will merge Ximin's patch for #10342, and you will have to update your transport codebase appropriately. Please let me know. Thanks!
On Wed, Dec 11, 2013 at 09:33:47PM +0000, George Kadianakis wrote:
Do you agree with the changes? If yes, I will merge Ximin's patch for #10342, and you will have to update your transport codebase appropriately. Please let me know.
For the record, I'm OK with this and replied here: https://trac.torproject.org/projects/tor/ticket/10342#comment:7 Cheers, Philipp
Excellent! I was thinking of making this change but lately I haven't had much time. Merging that patch specified in the 1st ticket comment? That looks good. I'd be happy to update the bananaphone transport to use the new api! Cheers, David On Wed, Dec 11, 2013 at 10:33 PM, George Kadianakis <desnacked@riseup.net>wrote:
Hello Philipp and David,
I'm sending you an email because you are the people who are currently developing obfsproxy modules.
We are thinking of slightly changing the API of obfsproxy, so that it becomes more friendly to transport authors (or at least we hope so).
Specifically, we are thinking of having the circuit be an element of the transport class, instead of being passed as an argument in the receivedDownstream and receivedUpstream methods. I think David and Leif were also thinking of this change. Furthermore, we are also thinking of renaming the 'handshake' method to 'circuitConnected'. (More details can be found in #10342.)
Do you agree with the changes? If yes, I will merge Ximin's patch for #10342, and you will have to update your transport codebase appropriately. Please let me know.
Thanks!
David Stainton <dstainton415@gmail.com> writes:
Excellent! I was thinking of making this change but lately I haven't had much time. Merging that patch specified in the 1st ticket comment? That looks good.
I'd be happy to update the bananaphone transport to use the new api!
Cheers,
David
The change is now merged and pushed :)
On 12/12/13 23:40, George Kadianakis wrote:
David Stainton <dstainton415@gmail.com> writes:
Excellent! I was thinking of making this change but lately I haven't had much time. Merging that patch specified in the 1st ticket comment? That looks good.
I'd be happy to update the bananaphone transport to use the new api!
Cheers,
David
The change is now merged and pushed :)
When updating your transport, don't forget to - call super(YourTransport, self).__init__() in your own __init__ - rename handshake() -> circuitConnected() as well as renaming the local "circuit" params. X -- GPG: 4096R/1318EFAC5FBBDBCE git://github.com/infinity0/pubkeys.git
participants (4)
-
David Stainton -
George Kadianakis -
Philipp Winter -
Ximin Luo