Hi, I am one of the volunteer from Whonix project, a third party application. We want to use tor and modify it to parse the folder /etc/tor.d/ for configuration files. Please take a look at https://trac.torproject.org/projects/tor/ticket/8291 What is the process to get it approved and check in the file. I have modified the file src/or/config.c Who should I talk to? Thanks
On Mon, Aug 26, 2013 at 5:08 PM, Bao Nguyen <nguybao@yahoo.com> wrote:
Hi, I am one of the volunteer from Whonix project, a third party application. We want to use tor and modify it to parse the folder /etc/tor.d/ for configuration files. Please take a look at https://trac.torproject.org/projects/tor/ticket/8291 What is the process to get it approved and check in the file. I have modified the file src/or/config.c Who should I talk to? Thanks
Hi! I've made some design comments on that ticket. To get new features merged, make sure that it's in the form of a patch or a branch that can be merged into the current Tor git master branch (where new features are added), and then either attach the patch on the ticket, or add a link to the patch or the branch in a comment. The doc/HACKING file[1] in git master needs some editing, but it also has some good advice on what a patch needs and what format it should have in the "Coding Conventions" section. [1] https://gitweb.torproject.org/tor.git/blob_plain/HEAD:/doc/HACKING best wishes, -- Nick
On Mon, Aug 26, 2013 at 6:50 PM, Nick Mathewson <nickm@alum.mit.edu> wrote: Oh, and one more thing! After sending my last message, I realize that I've just rattled off a long list of "make sure you do this" and "make sure you don't do that" items. But I forgot to mention: * Don't worry if you don't get everything perfectly on the first try. It usually takes a few rounds of review before any nontrivial patch is ready for inclusion. * Thanks for writing code to help with Tor! yrs, -- Nick
Bao Nguyen:
I am one of the volunteer from Whonix project, a third party application. We want to use tor and modify it to parse the folder /etc/tor.d/ for configuration files. Please take a look at https://trac.torproject.org/projects/tor/ticket/8291 What is the process to get it approved and check in the file. I have modified the file src/or/config.c Who should I talk to? Thanks
This is actually a duplicate of #1922, opened 3 years ago. The proper process is likely to submit a patch and set the ticket to the "needs_review" status. -- Lunar <lunar@torproject.org>
Lunar, How do you submit a patch? Can I attach the patch to the ticket? then set the ticket status. *From:* Lunar <lunar@torproject.org> *Date:* Tuesday, August 27, 2013 12:29 AM *To:* tor-dev@lists.torproject.org *Subject:* [tor-dev] Trac Ticket 8291 This is actually a duplicate of #1922, opened 3 years ago. The proper process is likely to submit a patch and set the ticket to the "needs_review" status. _______________________________________________ tor-dev mailing list tor-dev@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev
participants (3)
-
Bao Nguyen -
Lunar -
Nick Mathewson