RPM: "hardcoded" config options in /usr/bin/torctl
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hi Ondrej, I filed a bug regarding the rpm packages [1]: "hardcoding" config options in torctl. Please let me also know what you think about migrating to systemd. thanks! [1] https://trac.torproject.org/projects/tor/ticket/12834 -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJT5kYQAAoJEDcK3SCCSvoefxoP/04Ac6/zFFg0cb8XjeNHdvjW qQAKWjKiWXRY00LWmCzeFsKp8MIyIVMDIDGja2XeaLcQd360iG/zbEKtHUm6RtXa AEH0OAzrG5eK7fUXoqXvpnSoAEkr/0cqdI1dcBJ9wUpUAMT+W6h8awpya3IuOfXv E/4V3g/C1PeQp9ISsaJIJTkn7E6enZ7teyPgW4gXx//+rljhW/mTgwGH94h2UDRE /JpH91VfBmO3zZipT1T/soIiWl8F5lm2FobOlJx5JPm9zfeeYntxVVHN7tbo6I4W xcs5Piq5O8cRvyBHliAH4i7uir/g/Fq8dwNJtRZGvyW+LLOVd98Djw+sdpqQ5Ddn zthNYU2/XUEDT1pHNYD73qrbA4fY1Thk1wU8MuYciiJvDL6uclEUFt2CBx1haAcN KJd3XiupUgY0nxpB53qUEqbX9hRmqWy8P7hbjguD5xk+exYH60VAkDBHT+HVjJS6 eWwMDiZcddPq5lNWyY1kHX0Px5xHiZWHBRUbw7OBZ/ImJAItLMIj47OTz3vD8nT/ CA5Rb5fLsJMGm1mmnqHH0wXX8ZqE60b3iBYbT/7U3fXejkqav4+PqMx3JVvN6xN6 1yb+1swrX0ZPIhKRH9CA5WGJOvrZwau9xlDj0R86U2PoV7KE7y52S9a9ywPMT/WY 2KYM9ebQa0HdPY5NeR5P =Ev1C -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Nusenu:
Hi Ondrej,
I filed a bug regarding the rpm packages [1]: "hardcoding" config options in torctl.
Please let me also know what you think about migrating to systemd.
While reading fedora's tor.spec [1], I noticed #8368 [2] and the fact that tor includes already a systemd service file but the RPMs do not make use of it yet? [1] http://pkgs.fedoraproject.org/cgit/tor.git/tree/tor.spec [2] https://trac.torproject.org/projects/tor/ticket/8368 [3] https://gitweb.torproject.org/tor.git/blob/HEAD:/contrib/dist/tor.service.in -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJT5zATAAoJEDcK3SCCSvoeSukP/19piNay1bmCZQD+LVQZQYH4 OVVSpcUKIKjhWmEHRS+ly+dGaY5hkp8zL4jMHgcEdtJt5AJ161BVTgk0HFqbayvc 54ruA8pcOpkAaPhS2u0EFb8dVT2qolZCWVSabVzwQZOpPKvFBu3xO1CvcJ1LMY+e pOg/eGpp3H5SZfl3ryBBzLqlwghyfO1tDCWY3illYNnuldNZc/O3aTnAJtcsvldk bo4QXZFCXcaazcEH9/jZqe8Td13F+XefRqDUzlCAhAjCI/uojPLG5EvIscibQ1Df 3T+RzGSI1L3oXUU/qZ6v2/zUpl6urgXXiQxEcHSL/CLlHWKcfrOs1BU9+QHQP4jQ 3WQjktb1gP2qR1GsB8OhBGhV69fiPLPU9PKFfgn6HcqK2iY2UD0atT02xlKCOStT DUsrngyVdIMil/BE44FfXW2vKd6FxZNihvYQyaPuIpRe6j1uJKjJVyBls/cDRV5J fuxjbiwwX3nNbcyekZX/schGUyKNjfn3Lp3atlY03arCOIfFflfIhCs4ZngvFbvn MWTxhBsJf+VDGaaZVuyC9BOcTw5J5/whiV6SHXAX6KPKx4jTyAdGNBawdueTKG8e Uk9wBlyIKSIajer2+QWaVbQqpEHOfpNzPkmdNP87/0+lX2wbIBim+gsPWCp6m3xl SFB4DzGZuIyT5lxT8LYm =bqKj -----END PGP SIGNATURE-----
On 08/10/2014 10:40 AM, Nusenu wrote:
Nusenu: While reading fedora's tor.spec [1], I noticed #8368 [2] and the fact that tor includes already a systemd service file but the RPMs do not make use of it yet?
I have looked at the tor.spec files - current one, EPEL one and Fedora one, trying to make up a way to combine it - so that it both supports the old scripts for EL6 and systemd for Fedora. I don't know that much about systemd, but at least sections like preinstall, postinstall and dependencies would need heavy ifdef-ing. It used to be this way for EL5 support which is now obsoleted since it required more special handling each time until it became unbearable. If possible, I'd like to avoid the if-defs. Do you perhaps have a tip how to make the spec file "nice" and have it work both with old startup script and systemd? Maybe some patch? Concerning hardcoded defaults in torctl - yeah, I should find time to fix that. I've already had a branch that was supposed to fix it, but got stuck on Fedora last time (don't remember exactly what wasn't working). I'll try to look at my old patches if they can be reused. Ondrej
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Ondrej Mikle:
If possible, I'd like to avoid the if-defs. Do you perhaps have a tip how to make the spec file "nice" and have it work both with old startup script and systemd? Maybe some patch?
I would not mind having clean separated per-distribution spec files. That way you can basically reuse the complete spec file from the distribution and you would have systemd support without having to think about it - they probably have had their fair amount of testing. The only difference would probably be that your repo provides new releases faster then native distribution repos. -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJT6kUyAAoJEDcK3SCCSvoewtEQAJJkMCA2VoityTYht1qUFx31 V969YQ9UNAvsDRVyrtxSWy52/ZlqaQkOE/O5neeDkP83vBKeNIkFu3q3XxMBHia6 pMAQguHhcKHAp3W8J0po7cBAQXB8cBM2k8cMG6gngqJnhDRyGE+BoU5ODSvMn4DG VMscAqCvfvJFk0XnpO+ZIYy48SWYwnnsGIhJO+kWLAlOJPVKRBzp++sR9WAN6EYD JlmO5PSwXS3Cxykiw0yfNqghnAPni4jl65Ovi/VGFFdIxl05PiHS9Y1plNSSOUJw n3VwHrtR4K3LLeWaqUXxStYj3HepgAMpB88qDOoEAJGzISM91m9FHzPMQkairAbS Y1hSQD365drxANk15Bvd7PcnPhVAIJMhg8wTo2YpMKiUtuOcO8Z9UpIsmKj3blGQ iqf/YEG4bMUZoTfs510OJRJcyltIhWyNbUWge8laoIPLlewx9IZc1a6CmNHXP/xY 3qFW/z9iPf3/Ld4CTIMCZSEh1QkQAtNJ2LGgk/MN4nfLihxI8atEVUT+E3XOzWfa gsYZnV2p70GgPm6hL9SOfuEpjtG5Rr/XwDZ4fwSl9JS5iPSut4JBlPjilBt6D0ne mjHQ3XuzrcI9UDFJf/xzgIBmILZI9dRodoB9mJb/z3Z6GVKQ0xHyBeaz2Js/y2gD LstaHSQrH8M50HJtRGCy =g+0P -----END PGP SIGNATURE-----
On Tue, Aug 12, 2014 at 6:47 PM, Nusenu < BM-2D8wMEVgGVY76je1WXNPfo8SrpZt5yGHES@bitmessage.ch> wrote:
Ondrej Mikle:
If possible, I'd like to avoid the if-defs. Do you perhaps have a tip how to make the spec file "nice" and have it work both with old startup script and systemd? Maybe some patch?
I would not mind having clean separated per-distribution spec files. That way you can basically reuse the complete spec file from the distribution and you would have systemd support without having to think about it - they probably have had their fair amount of testing.
I spent about a day adjusting and merging the Fedora's systemd tor.spec. However, it won't build the git source (e.g. with LIBS=-lrt ./autogen.sh && ./configure && make dist-rpm). There is something missing in the .spec which makes rpmbuild fail on not finding the correct source directory, but I wasn't able to figure why that happens as rpmbuild is quite hard to debug. Ondrej
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Ondrej Mikle:
If possible, I'd like to avoid the if-defs. Do you perhaps have a tip how to make the spec file "nice" and have it work both with old startup script and systemd? Maybe some patch?
I would not mind having clean separated per-distribution spec files. That way you can basically reuse the complete spec file from the distribution and you would have systemd support without having to think about it - they probably have had their fair amount of testing.
I spent about a day adjusting and merging the Fedora's systemd tor.spec. However, it won't build the git source (e.g. with LIBS=-lrt ./autogen.sh && ./configure && make dist-rpm). There is something missing in the .spec which makes rpmbuild fail on not finding the correct source directory, but I wasn't able to figure why that happens as rpmbuild is quite hard to debug.
I'd like to have a look at your attempts. Is there something wrong with the rpm-tor git repo? git clone https://gitweb.torproject.org/user/hiviah/rpm-tor.git Cloning into 'rpm-tor'... fatal: https://gitweb.torproject.org/user/hiviah/rpm-tor.git/info/refs not valid: is this a git repository? -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJT7MwXAAoJEDcK3SCCSvoecqsQAIkwLSKdSw9G9TPvD55Q7DZH c3KaJJbFmeIWONKpzfdMgdTC4h3e8ksOJIGBBp8oTFOzE315DkJFb/h5Trl8UQgm a3cXVKrWktli0rPwiFFrUDEtTXd4mT9xrmgIzivlSEjyTJRCzKWSc3/pX0r4W+Vp X/e6TCDqBOxIZ/9BgAd5ZkbAiMZBisdZxbbzB3ZdfarbLbHvPLmFAtiPPWEVJMpD LLGkdM2VRjZCInS7Em0HQj44FCrfbDu29ctbTAd9safP+UmV+aztqrj9hewjH3sc jTC7Ng00crR9Fa4iNGnCSAFiW5S4bT35tttxIGWlBnFaqAWegNL93Mdeb7YJk+6N GuHz3kbklQfOXhcycnb3UnsyLUt4x/W5doR5VdOCOBazGAHwkypmR3mWc7ydnKbA D3fuI1hpEo1Awwa+1XFnmoaz+A8b5vHJbZJj4aOJ3CF8RJzHZP+sHtDNdtANJV0b fpYjuCYL9e+sAJi04s/WjwLCqhj+d63OuryFF5czpF2cxg70tiYRgTegl8zG3hoE wm4TPspigvNbeYzu/DYn0lhhrYv3aJfs9+Z6FtBGaOdMYVerRwJqaHee5ylllfFn qEMEAFh0zSFugtbs6OCq4ZRExddoQStETXveqBJUNcSi19er2/udUkr1JNc3zrSE P0GaJ7s8hJtdVOtb+BBe =wChQ -----END PGP SIGNATURE-----
On Thu, Aug 14, 2014 at 4:47 PM, Nusenu < BM-2D8wMEVgGVY76je1WXNPfo8SrpZt5yGHES@bitmessage.ch> wrote:
Ondrej Mikle:
If possible, I'd like to avoid the if-defs. Do you perhaps have a tip how to make the spec file "nice" and have it work both with old startup script and systemd? Maybe some patch?
I would not mind having clean separated per-distribution spec files. That way you can basically reuse the complete spec file from the distribution and you would have systemd support without having to think about it - they probably have had their fair amount of testing.
I spent about a day adjusting and merging the Fedora's systemd tor.spec. However, it won't build the git source (e.g. with LIBS=-lrt ./autogen.sh && ./configure && make dist-rpm). There is something missing in the .spec which makes rpmbuild fail on not finding the correct source directory, but I wasn't able to figure why that happens as rpmbuild is quite hard to debug.
I'd like to have a look at your attempts.
Is there something wrong with the rpm-tor git repo?
git clone https://gitweb.torproject.org/user/hiviah/rpm-tor.git Cloning into 'rpm-tor'... fatal: https://gitweb.torproject.org/user/hiviah/rpm-tor.git/info/refs
The url is a bit diferent: git clone https://git.torproject.org/user/hiviah/rpm-tor.git git checkout rpm-release-0.2.5 This is diff from one of the testing dirs: http://pastie.org/9475746 There's more stuff to be done e.g. in Makefile.am in dist-rpm target (if some files are said as Source in the .spec, Makefile needs to copy them - sorry I have the changes only in generated makefiles for testing). Ondrej
On 08/09/2014 06:02 PM, Nusenu wrote:
Hi Ondrej,
I filed a bug regarding the rpm packages [1]: "hardcoding" config options in torctl.
I re-packaged 0.2.5.6 in tor-testing repo with the --defaults-torrc option and updated torctl file so that there are no hardcoded defaults. Seems to work on my machines, but I guess it could use some testing. (Update will happen automatically if you're on the tor-testing repo). Ondrej
participants (2)
-
Nusenu -
Ondrej Mikle