Orbot's inclusion of Privoxy (was: [tor-commits] r24630: {} adding binaries to res/raw folder (in projects/android/trunk/Orbot/res: . raw))
Nathan Freitas <nathan@freitas.net> wrote:
Log: adding binaries to res/raw folder
This seems to be (or based on) Privoxy 3.0.12 released in 2009. What's the rationale for not using a more recent version? Is this vanilla Privoxy or are there any custom patches? I get the impression that you are currently distributing the Privoxy binary as part of Orbot without even mentioning the license. Is that correct, or am I missing something?
Privoxy 3.0.12 already supports SOCKS5 which allows superior error messages in case of connection failures. Note that this requires the templates to be available and according to https://trac.torproject.org/projects/tor/ticket/2168 at least some of them aren't.
FEATURE_COOKIE_JAR shouldn't be supported in the vanilla 3.0.12 release. It has been removed in 3.0.11 due to being useless.
+#debug 1 +#debug 0 # show each GET/POST/CONNECT request
debug 0 has no effect.
Are the iptables rules used documented somewhere? Did you run into any issues with Privoxy on Android in general? Are the considerations that lead to the use of Privoxy documented somewhere? Thanks Fabian
Thanks for the note, Fabian. On 04/16/2011 06:24 AM, Fabian Keil wrote:
This seems to be (or based on) Privoxy 3.0.12 released in 2009. What's the rationale for not using a more recent version?
At this point, that is the latest version we have successfully cross-compiled for Android. We are working on updating our build process to the new Android Native Dev Kit cross-compiler, and updating all relevant components. I will admit that our focus on keep bundled versions current have been more focused on Tor, than on Privoxy. I will make sure that we keep as close tabs on that component, as well. We have not included the binary files in the repo historically. However, there have been a number of Android app/UI developers who wished to contribute code there, but were unable to setup the entire OS build chain on their Mac or Windows machines, that is required to build the C binaries. If we provide them pre-built binaries for dev purposes, it increases the likelihood we will have more contributors.
Is this vanilla Privoxy or are there any custom patches?
It is vanilla, save for one setting: export ac_cv_func_setpgrp_void=yes as documented here: https://svn.torproject.org/svn/projects/android/trunk/Orbot/BUILD
We mention the inclusion in our app About screen, but you are current that our inclusion is not mentioned in the license file or screens. This is an unfortunate oversight, that I will address today. Best, Nathan
Nathan Freitas <nathan@freitas.net> wrote:
Great. Please let me know if you run into any issues.
Makes sense.
Interesting. I see that you aren't copying the template files Privoxy uses for the CGI messages. Is this intentional because of space constraints or just an oversight?
Thanks. Fabian
participants (2)
-
Fabian Keil -
Nathan Freitas