On 27-01-13 22:46, Jacob Appelbaum wrote:

I've merged this patch and as a result, I've also taken the liberty of cleaning up some autotools noise and bumping the version number.

Thus, I am declaring the following tar.gz to be the RC for 1.3:

https://people.torproject.org/~ioerror/src/torsocks-1.3.tar.gz

% sha1sum torsocks-1.3.tar.gz ebf71e2849edec20d7826b72c28b7aa4c4471936 torsocks-1.3.tar.gz

I believe that if no one has any objections and if intrigeri, nickm, Oscar and/or meejah sign off on it, I'll call it a release, tag it and push it the tag to master with no other changes.

All the best, Jacob

Checked it, it works fine.

Thus, I am declaring the following tar.gz to be the final RC for 1.3:

Though I don't actually use it on FreeBSD RELENG_4 anymore, it doesn't compile there. If someone has old routers or something based on that they should speak up.

On RELENG_8 it's fine but for a few small things...

# make test_torsocks.c:145: warning: 'txtquery' defined but not used

# autoreconf -fiv libtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to configure.in and libtoolize: Consider adding `-I m4' to ACLOCAL_AMFLAGS in Makefile.am.

I add them as line 1 to the respective files. Been carrying them for a while. +AC_CONFIG_MACRO_DIR([m4]) +ACLOCAL_AMFLAGS = -I m4

Do you have the compiler output from RELENG_4?

make all-recursive Making all in src source='torsocks.c' object='torsocks.lo' libtool=yes DEPDIR=.deps depmode=gcc /bin/sh ../depcomp /bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -c -o torsocks.lo torsocks.c libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -c torsocks.c -Wp,-MD,.deps/torsocks.TPlo -fPIC -DPIC -o .libs/torsocks.o torsocks.c: In function `torsocks_init': torsocks.c:144: warning: assignment discards qualifiers from pointer target type In file included from torsocks.c:148: expansion_table.h:77: warning: assignment discards qualifiers from pointer target type expansion_table.h:78: warning: assignment discards qualifiers from pointer target type expansion_table.h:79: warning: assignment discards qualifiers from pointer target type expansion_table.h:80: warning: assignment discards qualifiers from pointer target type expansion_table.h:82: warning: assignment discards qualifiers from pointer target type expansion_table.h:83: warning: assignment discards qualifiers from pointer target type expansion_table.h:84: warning: assignment discards qualifiers from pointer target type expansion_table.h:86: warning: assignment discards qualifiers from pointer target type expansion_table.h:88: warning: assignment discards qualifiers from pointer target type expansion_table.h:93: warning: assignment discards qualifiers from pointer target type expansion_table.h:98: warning: assignment discards qualifiers from pointer target type expansion_table.h:105: warning: assignment discards qualifiers from pointer target type expansion_table.h:114: warning: assignment discards qualifiers from pointer target type expansion_table.h:119: warning: assignment discards qualifiers from pointer target type expansion_table.h:124: warning: assignment discards qualifiers from pointer target type In file included from torsocks.c:240: expansion_table.h: In function `__res_query': expansion_table.h:77: warning: assignment discards qualifiers from pointer target type expansion_table.h: In function `__res_search': expansion_table.h:78: warning: assignment discards qualifiers from pointer target type expansion_table.h: In function `__res_send': expansion_table.h:79: warning: assignment discards qualifiers from pointer target type expansion_table.h: In function `__res_querydomain': expansion_table.h:80: warning: assignment discards qualifiers from pointer target type expansion_table.h: In function `gethostbyname': expansion_table.h:82: warning: assignment discards qualifiers from pointer target type expansion_table.h: In function `gethostbyaddr': expansion_table.h:83: warning: assignment discards qualifiers from pointer target type expansion_table.h: In function `getaddrinfo': expansion_table.h:84: warning: assignment discards qualifiers from pointer target type expansion_table.h: In function `getipnodebyname': expansion_table.h:86: warning: assignment discards qualifiers from pointer target type expansion_table.h: In function `sendto': expansion_table.h:88: warning: assignment discards qualifiers from pointer target type expansion_table.h: In function `sendmsg': expansion_table.h:93: warning: assignment discards qualifiers from pointer target type expansion_table.h: In function `connect': expansion_table.h:98: warning: assignment discards qualifiers from pointer target type expansion_table.h: In function `select': expansion_table.h:105: warning: assignment discards qualifiers from pointer target type expansion_table.h: In function `poll': expansion_table.h:114: warning: assignment discards qualifiers from pointer target type expansion_table.h: In function `close': expansion_table.h:119: warning: assignment discards qualifiers from pointer target type expansion_table.h: In function `getpeername': expansion_table.h:124: warning: assignment discards qualifiers from pointer target type torsocks.c: In function `__res_init': torsocks.c:855: warning: assignment discards qualifiers from pointer target type torsocks.c: In function `torsocks___res_query_guts': torsocks.c:877: warning: assignment discards qualifiers from pointer target type torsocks.c: In function `torsocks___res_querydomain_guts': torsocks.c:903: warning: assignment discards qualifiers from pointer target type torsocks.c: In function `torsocks___res_search_guts': torsocks.c:929: warning: assignment discards qualifiers from pointer target type torsocks.c: In function `torsocks___res_send_guts': torsocks.c:955: warning: assignment discards qualifiers from pointer target type libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -c torsocks.c -Wp,-MD,.deps/torsocks.TPlo -o torsocks.o >/dev/null 2>&1 source='common.c' object='common.lo' libtool=yes DEPDIR=.deps depmode=gcc /bin/sh ../depcomp /bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -c -o common.lo common.c libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -c common.c -Wp,-MD,.deps/common.TPlo -fPIC -DPIC -o .libs/common.o In file included from common.c:42: /usr/include/arpa/inet.h:89: warning: parameter has incomplete type /usr/include/arpa/inet.h:92: warning: parameter has incomplete type /usr/include/arpa/inet.h:96: warning: parameter has incomplete type libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -c common.c -Wp,-MD,.deps/common.TPlo -o common.o >/dev/null 2>&1 source='parser.c' object='parser.lo' libtool=yes DEPDIR=.deps depmode=gcc /bin/sh ../depcomp /bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -c -o parser.lo parser.c libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -c parser.c -Wp,-MD,.deps/parser.TPlo -fPIC -DPIC -o .libs/parser.o libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -c parser.c -Wp,-MD,.deps/parser.TPlo -o parser.o >/dev/null 2>&1 source='dead_pool.c' object='dead_pool.lo' libtool=yes DEPDIR=.deps depmode=gcc /bin/sh ../depcomp /bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -c -o dead_pool.lo dead_pool.c libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -c dead_pool.c -Wp,-MD,.deps/dead_pool.TPlo -fPIC -DPIC -o .libs/dead_pool.o In file included from dead_pool.c:23: /usr/include/sys/socket.h:52: syntax error before `sa_family_t' /usr/include/sys/socket.h:52: warning: type defaults to `int' in declaration of `sa_family_t' /usr/include/sys/socket.h:52: warning: data definition has no type or storage class /usr/include/sys/socket.h:163: syntax error before `u_char' /usr/include/sys/socket.h:174: syntax error before `u_short' /usr/include/sys/socket.h:188: syntax error before `u_char' /usr/include/sys/socket.h:190: `int64_t' undeclared here (not in a function) /usr/include/sys/socket.h:190: `u_char' undeclared here (not in a function) /usr/include/sys/socket.h:190: size of array `__ss_pad1' is too large /usr/include/sys/socket.h:191: syntax error before `int64_t' /usr/include/sys/socket.h:192: `u_char' undeclared here (not in a function) /usr/include/sys/socket.h:192: `int64_t' undeclared here (not in a function) /usr/include/sys/socket.h:192: `u_char' undeclared here (not in a function) /usr/include/sys/socket.h:192: `int64_t' undeclared here (not in a function) /usr/include/sys/socket.h:359: syntax error before `pid_t' /usr/include/sys/socket.h:364: syntax error before `gid_t' /usr/include/sys/socket.h:399: syntax error before `u_short' /usr/include/sys/socket.h:407: syntax error before `caddr_t' /usr/include/sys/socket.h:411: syntax error before `caddr_t' /usr/include/sys/socket.h:444: syntax error before `recv' /usr/include/sys/socket.h:444: warning: type defaults to `int' in declaration of `recv' /usr/include/sys/socket.h:444: warning: data definition has no type or storage class /usr/include/sys/socket.h:445: syntax error before `recvfrom' /usr/include/sys/socket.h:445: warning: type defaults to `int' in declaration of `recvfrom' /usr/include/sys/socket.h:445: warning: data definition has no type or storage class /usr/include/sys/socket.h:446: syntax error before `recvmsg' /usr/include/sys/socket.h:446: warning: type defaults to `int' in declaration of `recvmsg' /usr/include/sys/socket.h:446: warning: data definition has no type or storage class /usr/include/sys/socket.h:447: syntax error before `send' /usr/include/sys/socket.h:447: warning: type defaults to `int' in declaration of `send' /usr/include/sys/socket.h:447: warning: data definition has no type or storage class /usr/include/sys/socket.h:448: syntax error before `sendto' /usr/include/sys/socket.h:449: warning: type defaults to `int' in declaration of `sendto' /usr/include/sys/socket.h:449: warning: data definition has no type or storage class /usr/include/sys/socket.h:450: syntax error before `sendmsg' /usr/include/sys/socket.h:450: warning: type defaults to `int' in declaration of `sendmsg' /usr/include/sys/socket.h:450: warning: data definition has no type or storage class /usr/include/sys/socket.h:451: syntax error before `off_t' *** Error code 1