24 Jan
2019
24 Jan
'19
7:48 a.m.
On Thu, Jan 24, 2019 at 07:44:48AM +0000, Yawning Angel wrote:
On 1/24/19 7:38 AM, David Fifield wrote:
I see, you're right. It has to do with the reuse of the initConn.
A proper "general" solution that solves that problem and the ALPN issue is to have a `initConn` and `http.RoundTripper` instance per destination host, and some additional locking.
With more implementation cleverness this could be brought down to two `http.RoundTripper` instances, and a host -> pointer + net.Conn map, and some locking.
But for something like meek_lite where the number of destination hosts is not large, the existing wrapper works fine and I don't see much reason to over engineer it.
I don't disagree, it's fine for this use case.