On 08/10/2014 10:40 AM, Nusenu wrote:
Nusenu: While reading fedora's tor.spec [1], I noticed #8368 [2] and the fact that tor includes already a systemd service file but the RPMs do not make use of it yet?
I have looked at the tor.spec files - current one, EPEL one and Fedora one, trying to make up a way to combine it - so that it both supports the old scripts for EL6 and systemd for Fedora.
I don't know that much about systemd, but at least sections like preinstall, postinstall and dependencies would need heavy ifdef-ing. It used to be this way for EL5 support which is now obsoleted since it required more special handling each time until it became unbearable.
If possible, I'd like to avoid the if-defs. Do you perhaps have a tip how to make the spec file "nice" and have it work both with old startup script and systemd? Maybe some patch?
Concerning hardcoded defaults in torctl - yeah, I should find time to fix that. I've already had a branch that was supposed to fix it, but got stuck on Fedora last time (don't remember exactly what wasn't working). I'll try to look at my old patches if they can be reused.
Ondrej