Re: [tor-dev] [Twisted-Python] please can haz code review -> Tor-ified Twisted Python HTTP proxy server - txtorhttpproxy

Dear Aaon Gallagher,

Thanks for the helpful observation. i'm going to make the correction soon and then we'll be underscore free.

On Wed, Aug 12, 2015 at 7:06 AM, Aaron Gallagher _@habnab.it wrote:

David Stainton dstainton415@gmail.com writes:

...

If I get rid of this last terrible import: from twisted.web._newclient import ResponseDone

then I'm not sure how to detect when to call the finish() method here: https://github.com/david415/txtorhttpproxy/blob/master/txtorhttpproxy/proxy....

Fortunately, ResponseDone is re-exported by twisted.web.client:

>>> import twisted.web.client
>>> twisted.web.client.ResponseDone is twisted.web._newclient.ResponseDone
True
>>> twisted.__version__
'11.0.0'

I couldn't get 9.0 to compile in the five seconds I tried, but 11.0 is still pretty old. I think it always was re-exported like this.