commit 1416dd47a994fb9f3ff5108be8517270352c9699 Author: Roger Dingledine arma@torproject.org Date: Sun Jan 8 09:03:03 2012 -0500

add a note from wanoskarnet

he disagrees about what the code that we decided not to use would do --- src/common/tortls.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/src/common/tortls.c b/src/common/tortls.c index ef61f71..37074de 100644 --- a/src/common/tortls.c +++ b/src/common/tortls.c @@ -781,6 +781,11 @@ tor_tls_context_new(crypto_pk_env_t *identity, unsigned int key_lifetime, * with clients that are configured to use SSLv23_method(), so we should * probably never use it. */ + /* XXX wanoskarnet says this comment is bunk -- that even if we turn + * this line on, clients configured to use SSLv23 would still able to + * talk to us. But he also says it's ok to leave it out. I suggest we + * delete this whole clause (the one that's #if 0'ed out). I'll leave + * it in place until Nick expresses an opinion. -RD */ if (!(result->ctx = SSL_CTX_new(TLSv1_method()))) goto error; #endif