commit fee9038c3f0903760900118c215b79e8a84bebbc Author: David Fifield <david@bamsoftware.com> Date: Mon Jan 28 02:02:57 2013 -0800 Move websocket lib bug URLs to websocket.go. --- websocket-transport/README | 19 ------------------- websocket-transport/websocket.go | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 19 deletions(-) diff --git a/websocket-transport/README b/websocket-transport/README deleted file mode 100644 index fedde17..0000000 --- a/websocket-transport/README +++ /dev/null @@ -1,19 +0,0 @@ -ClientTransportPlugin websocket exec ./websocket-client -Bridge websocket tor1.bamsoftware.com:9901 -UseBridges 1 - -ServerTransportPlugin websocket exec ./websocket-server - -"Denial of Service Protection in Go HTTP Servers" -https://code.google.com/p/go/issues/detail?id=2093 - -"go.websocket: Read/Copy fail with long frames" -https://code.google.com/p/go/issues/detail?id=2134 - -http://golang.org/pkg/net/textproto/#pkg-bugs -"To let callers manage exposure to denial of service attacks, Reader -should allow them to set and reset a limit on the number of bytes read -from the connection." - -"websocket.Dial doesn't limit response header length as http.Get does" -https://groups.google.com/forum/?fromgroups=#!topic/golang-nuts/2Tge6U8-QYI diff --git a/websocket-transport/websocket.go b/websocket-transport/websocket.go index 70bd67d..0e66405 100644 --- a/websocket-transport/websocket.go +++ b/websocket-transport/websocket.go @@ -4,6 +4,20 @@ // to partially read a frame. WebsocketConfig.MaxMessageSize affords control of // the maximum buffering of messages. // +// The reason for using this custom implementation instead of +// code.google.com/p/go.net/websocket is that the latter has problems with long +// messages and does not support server subprotocols. +// "Denial of Service Protection in Go HTTP Servers" +// https://code.google.com/p/go/issues/detail?id=2093 +// "go.websocket: Read/Copy fail with long frames" +// https://code.google.com/p/go/issues/detail?id=2134 +// http://golang.org/pkg/net/textproto/#pkg-bugs +// "To let callers manage exposure to denial of service attacks, Reader should +// allow them to set and reset a limit on the number of bytes read from the +// connection." +// "websocket.Dial doesn't limit response header length as http.Get does" +// https://groups.google.com/forum/?fromgroups=#!topic/golang-nuts/2Tge6U8-QYI +// // Example usage: // // func doSomething(ws *Websocket) {