This is an automated email from the git hooks/post-receive script.
pierov pushed a change to branch tor-browser-102.4.0esr-12.0-2 in repository tor-browser.
from f8d051d6f08f fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser new 03b200a1d401 Bug 41454: Move focus after calling openPreferences for a sub-category. new fb128239c335 fixup! Bug 40925: Implemented the Security Level component
The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
Summary of changes: browser/components/preferences/preferences.js | 11 +++++++++++ .../securitylevel/content/securityLevelPreferences.inc.xhtml | 7 +++++-- 2 files changed, 16 insertions(+), 2 deletions(-)
This is an automated email from the git hooks/post-receive script.
pierov pushed a commit to branch tor-browser-102.4.0esr-12.0-2 in repository tor-browser.
commit 03b200a1d40158a22750a6d335c4bebbdb0834d8 Author: Henry Wilkes henry@torproject.org AuthorDate: Tue Nov 15 11:48:04 2022 +0000
Bug 41454: Move focus after calling openPreferences for a sub-category.
Temporary fix until mozilla bug 1799153 gets a patch upstream. --- browser/components/preferences/preferences.js | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/browser/components/preferences/preferences.js b/browser/components/preferences/preferences.js index 5f327eacf513..7aeb97f6a895 100644 --- a/browser/components/preferences/preferences.js +++ b/browser/components/preferences/preferences.js @@ -466,6 +466,17 @@ async function scrollAndHighlight(subcategory, category) { } let header = getClosestDisplayedHeader(element);
+ // We assign a tabindex=-1 to the element so that we can focus it. This allows + // us to move screen reader's focus to an arbitrary position on the page. + // See tor-browser#41454 and bug 1799153. + element.setAttribute("tabindex", "-1"); + // The element is not always immediately focusable, so we wait until the next + // loop. + setTimeout(() => { + Services.focus.setFocus(element, Services.focus.FLAG_NOSCROLL); + element.removeAttribute("tabindex"); + }); + scrollContentTo(header); element.classList.add("spotlight"); }
This is an automated email from the git hooks/post-receive script.
pierov pushed a commit to branch tor-browser-102.4.0esr-12.0-2 in repository tor-browser.
commit fb128239c33532ad494efe06d4276ab83f2752de Author: Henry Wilkes henry@torproject.org AuthorDate: Tue Nov 15 11:54:27 2022 +0000
fixup! Bug 40925: Implemented the Security Level component
Move the "data-subcategory" attribute one level up in the DOM so that the entire section is highlighted and the groupbox receives focus when we call openPreferences("privacy-securitylevel"). --- .../securitylevel/content/securityLevelPreferences.inc.xhtml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml b/browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml index 07d9a1d3b32d..7ee3d955683b 100644 --- a/browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml +++ b/browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml @@ -1,6 +1,9 @@ -<groupbox id="securityLevel-groupbox" data-category="panePrivacy" hidden="true"> +<groupbox id="securityLevel-groupbox" + data-category="panePrivacy" + data-subcategory="securitylevel" + hidden="true"> <label>html:h2/</label> - <vbox data-subcategory="securitylevel" flex="1"> + <vbox flex="1"> <description flex="1"> <html:span id="securityLevel-overview" class="tail-with-learn-more"/> <label id="securityLevel-learnMore"
tor-commits@lists.torproject.org