asciiwolf pushed to branch main at The Tor Project / Applications / torbrowser-launcher

Commits: 9f55ecec by intrigeri at 2024-10-15T11:17:37+00:00 AppArmor: remove duplicate rule

We include the gnome abstraction, which itself includes the X abstraction, so at least in theory including the X abstraction explicitly should be a no-op.

It looks like adding this line was done based on an incorrect assumption (that Lubuntu does not include the gnome abstraction), and even if that assumption were correct, adding this line would not fix the problem (because the parser would fail to compile the profile regardless).

- https://gitlab.torproject.org/tpo/applications/torbrowser-launcher/-/merge_r... - https://gitlab.torproject.org/tpo/applications/torbrowser-launcher/-/merge_r...

If there's ever evidence of a system where this line actually solves a problem, we can reconsider, and I'll be very curious to understand why.

- - - - - a82c1a02 by asciiwolf at 2024-10-31T10:16:38+00:00 Merge branch 'remove-duplicate-rule' into 'main'

AppArmor: remove duplicate rule

See merge request tpo/applications/torbrowser-launcher!18 - - - - -

1 changed file:

- apparmor/torbrowser.Browser.firefox

Changes:

===================================== apparmor/torbrowser.Browser.firefox ===================================== @@ -12,7 +12,6 @@ profile torbrowser_firefox @{torbrowser_firefox_executable} { #include <abstractions/opencl> #include if exists <abstractions/vulkan> #include if exists <abstractions/dbus-session> - #include if exists <abstractions/X>

deny capability sys_ptrace,

View it on GitLab: https://gitlab.torproject.org/tpo/applications/torbrowser-launcher/-/compare...