commit d865a50296de2dc3114946e2effcae9f8a781dcb Author: Nick Mathewson nickm@torproject.org Date: Mon Feb 24 10:12:47 2020 -0500

Extract most of dirauth_sched_get_next_valid_after_time()

Most of this function was about recreating a voting schedule on demand if it didn't exist yet or was not up-to-date. I've made that into its own function. --- src/feature/dirauth/voting_schedule.c | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-)

diff --git a/src/feature/dirauth/voting_schedule.c b/src/feature/dirauth/voting_schedule.c index 783d407fa..25714c00c 100644 --- a/src/feature/dirauth/voting_schedule.c +++ b/src/feature/dirauth/voting_schedule.c @@ -24,7 +24,7 @@ * voting. The object is allocated on the heap and it's the responsibility of * the caller to free it. Can't fail. */ static voting_schedule_t * -get_voting_schedule(const or_options_t *options, time_t now, int severity) +create_voting_schedule(const or_options_t *options, time_t now, int severity) { int interval, vote_delay, dist_delay; time_t start; @@ -95,9 +95,13 @@ voting_schedule_free_(voting_schedule_t *voting_schedule_to_free)

voting_schedule_t voting_schedule;

-/* Using the time <b>now</b>, return the next voting valid-after time. */ -time_t -dirauth_sched_get_next_valid_after_time(void) +/** + * Return the current voting schedule, recreating it if necessary. + * + * Dirauth only. + **/ +static const voting_schedule_t * +dirauth_get_voting_schedule(void) { time_t now = approx_time(); bool need_to_recalculate_voting_schedule = false; @@ -127,7 +131,16 @@ dirauth_sched_get_next_valid_after_time(void) voting_schedule.created_on_demand = 1; }

- return voting_schedule.interval_starts; + return &voting_schedule; +} + +/** Return the next voting valid-after time. + * + * Dirauth only. */ +time_t +dirauth_sched_get_next_valid_after_time(void) +{ + return dirauth_get_voting_schedule()->interval_starts; }

/** Set voting_schedule to hold the timing for the next vote we should be @@ -139,7 +152,7 @@ dirauth_sched_recalculate_timing(const or_options_t *options, time_t now) voting_schedule_t *new_voting_schedule;

/* get the new voting schedule */ - new_voting_schedule = get_voting_schedule(options, now, LOG_INFO); + new_voting_schedule = create_voting_schedule(options, now, LOG_INFO); tor_assert(new_voting_schedule);

/* Fill in the global static struct now */