morgan pushed to branch mullvad-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser

Commits: 81867153 by Timothy Nikkel at 2024-08-26T21:12:22+02:00 Bug 1899180. If a channel is not nsIPrivateBrowsingChannel and has no load context, use the private browsing field from it's origin attributes. r=necko-reviewers,anti-tracking-reviewers,valentin

If the channel is not a nsIPrivateBrowsingChannel, and it also has no load context (eg inside svg images) then we will over write a non-zero mPrivateBrowsingId on the OriginAttributes of the channel with 0, making NS_UsePrivateBrowsing return false for the channel.

Differential Revision: https://phabricator.services.mozilla.com/D212083 - - - - - c5ac1a5f by Jon Coppeard at 2024-08-26T21:12:24+02:00 Bug 1904011 - Ignore finalized scripts when iterating code covarage tables r=iain

Differential Revision: https://phabricator.services.mozilla.com/D214799 - - - - - 9c1466c0 by Arturo Mejia at 2024-08-26T21:12:24+02:00 Bug 1908344 - Improve prompts showing a=dmeehan - BP, tor-browser#43005

Original Revision: https://phabricator.services.mozilla.com/D216996

Differential Revision: https://phabricator.services.mozilla.com/D217718

- - - - - 326b38a5 by hackademix at 2024-08-26T21:12:25+02:00 fixup! Bug 1908344 - Improve prompts showing a=dmeehan - BP, tor-browser#43005

Bug 43005: followup, fix backporting conflict.

- - - - - 7ced890b by Henry Wilkes at 2024-08-26T21:12:25+02:00 Bug 41454: Move focus after calling openPreferences for a sub-category.

Temporary fix until mozilla bug 1799153 gets a patch upstream.

- - - - - 7b237363 by hackademix at 2024-08-26T21:12:25+02:00 Bug 42194: Fix blank net error page on failed DNS resolution with active proxy.

- - - - - f9f5c90d by Henry Wilkes at 2024-08-26T21:12:26+02:00 Bug 41483: Remove the firefox override for appstrings.properties

Remove this patch after upstream bugzilla bug 1790187

- - - - - 7000fce3 by Marco Simonelli at 2024-08-26T21:12:26+02:00 Bug 41459: WebRTC fails to build under mingw (Part 1)

- properly define NOMINMAX for just MSVC builds

- - - - - 69d98181 by Marco Simonelli at 2024-08-26T21:12:26+02:00 Bug 41459: WebRTC fails to build under mingw (Part 2)

- fixes required to build third_party/libwebrtc

- - - - - 3d7cf0e4 by Marco Simonelli at 2024-08-26T21:12:27+02:00 Bug 41459: WebRTC fails to build under mingw (Part 3)

- fixes required to build third_party/sipcc

- - - - - bea8bfcc by Marco Simonelli at 2024-08-26T21:12:27+02:00 Bug 41459: WebRTC fails to build under mingw (Part 4)

- fixes requried to build netwerk/sctp

- - - - - 9c4d59e2 by Marco Simonelli at 2024-08-26T21:12:28+02:00 Bug 41459: WebRTC fails to build under mingw (Part 5)

- fixes required to build dom/media/webrtc

- - - - - b6a3022c by Marco Simonelli at 2024-08-26T21:12:28+02:00 Bug 41459: WebRTC fails to build under mingw (Part 6)

- fixes required to build dom/media/systemservices

- - - - - 92d6849a by hackademix at 2024-08-26T21:12:28+02:00 Bug 41854: Allow overriding download spam protection.

- - - - - 56c3973e by hackademix at 2024-08-26T21:12:29+02:00 Bug 42835: Create an actor to filter file data transfers

- - - - - eb3e3c90 by hackademix at 2024-08-26T21:12:29+02:00 fixup! Bug 42835: Create an actor to filter file data transfers

Bug 43064: Make file filtering more specific

- - - - - f381d9db by Beatriz Rizental at 2024-08-26T21:12:29+02:00 Bug 42728: Modify ./mach lint to skip unused linters

- - - - - 4b0af395 by Gaba at 2024-08-26T21:12:30+02:00 Adding issue and merge request templates

- - - - - 6d7c931c by Morgan at 2024-08-26T21:12:30+02:00 fixup! Adding issue and merge request templates

add QA issue templates for tor browser desktop and android

- - - - - 58787061 by Richard Pospesel at 2024-08-26T21:12:30+02:00 Bug 42683: Create script to generate issue triage csv file from bugzilla query and git logs

- - - - - 79f1bf40 by Beatriz Rizental at 2024-08-26T21:12:31+02:00 fixup! Bug 42683: Create script to generate issue triage csv file from bugzilla query and git logs

- - - - - 6e97802f by Beatriz Rizental at 2024-08-26T21:12:31+02:00 Add CI for Base Browser

- - - - - cd9ef577 by Beatriz Rizental at 2024-08-26T21:12:32+02:00 fixup! Add CI for Base Browser

Bug 42997: Reduce the number of git fetches by fetching during a setup job and passing that initial fetch around as a git bundle to other jobs through the Gitlab artifacts. Further reduce the number of fetches by creating a list of changed files in the setup job and passing that around as well as an artifact.

- - - - - c267bf8a by Beatriz Rizental at 2024-08-26T21:12:32+02:00 fixup! Add CI for Base Browser

Fix issue that prevents the create-bundle job from succeeding when there is already a branch with the same name as the one being pushed to in the CI -- mostly happens on protected branches.

- - - - - 848f259f by Pier Angelo Vendrame at 2024-08-26T21:12:32+02:00 Base Browser's .mozconfigs.

Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan.

Bug 21849: Don't allow SSL key logging.

Bug 25741 - TBA: Disable features at compile-time

Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION

Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds

This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android.

Bug 29859: Disable HLS support for now

Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING

Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT

Bug 33734: Set MOZ_NORMANDY to False

Bug 33851: Omit Parental Controls.

Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files

Bug 41584: Move some configuration options to base-browser level

- - - - - 67a2bcb5 by Pier Angelo Vendrame at 2024-08-26T21:12:33+02:00 Tweaks to the build system

Bug 40857: Modified the fat .aar creation file

This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build.

We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770.

Bug 41458: Prevent `mach package-multi-locale` from actually creating a package

macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it.

- - - - - 70d0346a by Pier Angelo Vendrame at 2024-08-26T21:12:33+02:00 Bug 29320: Replace the gnu target with gnullvm for Rust.

- - - - - d8b62e8d by Pier Angelo Vendrame at 2024-08-26T21:12:33+02:00 Bug 42616: Remove VideoCaptureTest.kt.

This is a workaround to fix the GeckoView build with WebRTC disabled. We should replace this workaround with a proper solution, that excludes this test when MOZ_WEBRTC is undefined/False.

- - - - - a45d24a9 by Pier Angelo Vendrame at 2024-08-26T21:12:34+02:00 Bug 41108: Remove privileged macOS installation from 102

- - - - - ce7b48bb by Dan Ballard at 2024-08-26T21:12:34+02:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies

- - - - - d51aa221 by Matthew Finkel at 2024-08-26T21:12:35+02:00 Bug 24796: Comment out excess permissions from GeckoView

The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing.

- - - - - 50628576 by Matthew Finkel at 2024-08-26T21:12:35+02:00 Bug 28125: Prevent non-Necko network connections

- - - - - 94b32f36 by Mike Perry at 2024-08-26T21:12:35+02:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth

The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602

- - - - - 2cef1eb7 by Alex Catarineu at 2024-08-26T21:12:36+02:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899

- - - - - bc4e9049 by Morgan at 2024-08-26T21:12:36+02:00 fixup! Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots

- Revert 612d54e8e97017891865db8003826d8688ad5a9b

- - - - - d0d68da7 by Georg Koppen at 2024-08-26T21:12:36+02:00 Bug 16285: Exclude ClearKey system for now

In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past.

- - - - - bf415a82 by Kathy Brade at 2024-08-26T21:12:37+02:00 Bug 21431: Clean-up system extensions shipped in Firefox

Only ship the pdfjs extension.

- - - - - 86c1085d by Kathy Brade at 2024-08-26T21:12:37+02:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc.

Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps.

Disable the "Create New Login" button when security.nocertdb is true.

- - - - - c7124709 by Alex Catarineu at 2024-08-26T21:12:37+02:00 Bug 41457: Remove Mozilla permissions

Bug 40025: Remove Mozilla add-on install permissions

- - - - - a0a00486 by Kathy Brade at 2024-08-26T21:12:38+02:00 Bug 40002: Remove about:ion

Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser.

Bug 41662: Disable about:sync-logs

Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component.

- - - - - 0bb8c9d1 by Arthur Edelstein at 2024-08-26T21:12:38+02:00 Bug 26353: Prevent speculative connect that violated FPI.

Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term.

- - - - - edf279fa by Alex Catarineu at 2024-08-26T21:12:40+02:00 Bug 31740: Remove some unnecessary RemoteSettings instances

More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls.

Avoid creating instance for 'anti-tracking-url-decoration'.

If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'.

Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps.

We also clear the collections database on the v2 -> v3 migration.

- - - - - b7d36508 by cypherpunks1 at 2024-08-26T21:12:41+02:00 Bug 41092: Add a RemoteSettings JSON dump for query-stripping

- - - - - 9d771026 by Pier Angelo Vendrame at 2024-08-26T21:12:41+02:00 Bug 41635: Disable the Normandy component

Do not include Normandy at all whenever MOZ_NORMANDY is False.

- - - - - 49915074 by Georg Koppen at 2024-08-26T21:12:42+02:00 Bug 30541: Disable WebGL readPixel() for web content

Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034

- - - - - e66875f2 by Alex Catarineu at 2024-08-26T21:12:42+02:00 Bug 28369: Stop shipping pingsender executable

- - - - - 5e200391 by cypherpunks1 at 2024-08-26T21:12:42+02:00 Bug 41568: Disable LaterRun

- - - - - 9a87dbae by cypherpunks1 at 2024-08-26T21:12:43+02:00 Bug 40717: Hide Windows SSO in settings

- - - - - 0c7995af by Pier Angelo Vendrame at 2024-08-26T21:12:43+02:00 Bug 41599: Always return an empty string as network ID

Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users.

We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756

- - - - - fc809659 by Richard Pospesel at 2024-08-26T21:12:43+02:00 Bug 41327: Disable UrlbarProviderInterventions

- - - - - 754cab93 by Richard Pospesel at 2024-08-26T21:12:44+02:00 Bug 42037: Disable about:firefoxview page

- - - - - 63b0d2b6 by Mike Perry at 2024-08-26T21:12:44+02:00 Firefox preference overrides.

This hack directly includes our preference changes in omni.ja.

Bug 18292: Staged updates fail on Windows

Temporarily disable staged updates on Windows.

Bug 18297: Use separate Noto JP,KR,SC,TC fonts

Bug 23404: Add Noto Sans Buginese to the macOS whitelist

Bug 23745: Set dom.indexedDB.enabled = true

Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera@riseup.net>)

Bug 17252: Enable session identifiers with FPI

Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers".

The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049)

Bug 14952: Enable http/2 and AltSvc

In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2".

Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well.

(All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.)

However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false.

"network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197.

Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites

Enable ReaderView mode again (#27281).

Bug 29916: Make sure enterprise policies are disabled

Bug 2874: Block Components.interfaces from content

Bug 26146: Spoof HTTP User-Agent header for desktop platforms

In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs.

Bug 12885: Windows Jump Lists fail for Tor Browser

Jumplist entries are stored in a binary file in: %APPDATA%\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms

The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller.

However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past.

The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted.

Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996.

Bug 30845: Make sure default themes and other internal extensions are enabled

Bug 28896: Enable extensions in private browsing by default

Bug 31065: Explicitly allow proxying localhost

Bug 31598: Enable letterboxing

Disable Presentation API everywhere

Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels.

Bug 32321: Disable Mozilla's MitM pings

Bug 19890: Disable installation of system addons

By setting the URL to "" we make sure that already installed system addons get deleted as well.

Bug 22548: Firefox downgrades VP9 videos to VP8.

On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8.

This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available".

Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs

Bug 16441: Suppress "Reset Tor Browser" prompt.

Bug 29120: Use the in-memory media cache and increase its maximum size.

Bug 33697: use old search config based on list.json

Bug 33855: Ensure that site-specific browser mode is disabled.

Bug 30682: Disable Intermediate CA Preloading.

Bug 40061: Omit the Windows default browser agent from the build

Bug 40322: Consider disabling network.connectivity-service.enabled

Bug 40408: Disallow SVG Context Paint in all web content

Bug 40308: Disable network partitioning until we evaluate dFPI

Bug 40322: Consider disabling network.connectivity-service.enabled

Bug 40383: Disable dom.enable_event_timing

Bug 40423: Disable http/3

Bug 40177: Update prefs for Fx91esr

Bug 40700: Disable addons and features recommendations

Bug 40682: Disable network.proxy.allow_bypass

Bug 40736: Disable third-party cookies in PBM

Bug 19850: Enabled HTTPS-Only by default

Bug 40912: Hide the screenshot menu

Bug 41292: Disable moreFromMozilla in preferences page

Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector

Bug 24686: Set network.http.tailing.enabled to true

Bug 40183: Disable TLS ciphersuites using SHA-1

Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102

We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them.

- - - - - ab3d9eee by Pier Angelo Vendrame at 2024-08-26T21:12:44+02:00 fixup! Firefox preference overrides.

Add some notes about live-reload, discovered while investigating some localization issues.

- - - - - a2c5db09 by Pier Angelo Vendrame at 2024-08-26T21:12:45+02:00 fixup! Firefox preference overrides.

Bug 42814: Opt out from Firefox relay by default.

- - - - - 64dd51aa by Pier Angelo Vendrame at 2024-08-26T21:12:45+02:00 fixup! Firefox preference overrides.

Bug 42792: Explicitly turn off Pocket suggestions in the URL bar

- - - - - a64af102 by Pier Angelo Vendrame at 2024-08-26T21:12:45+02:00 fixup! Firefox preference overrides.

Bug 42810: Explicitly disable address and credit card filling.

- - - - - bd13ad68 by Pier Angelo Vendrame at 2024-08-26T21:12:46+02:00 fixup! Firefox preference overrides.

Bug 42886: Disable trending results.

In this way we are consistent with weather and addons.

- - - - - 4f6744b3 by Pier Angelo Vendrame at 2024-08-26T21:12:46+02:00 fixup! Firefox preference overrides.

Bug 43051: Hide the checkbox to open the browser automatically on Windows startup.

- - - - - c55ab11c by Pier Angelo Vendrame at 2024-08-26T21:12:46+02:00 fixup! Firefox preference overrides.

Bug 42596: Add preferences for log levels.

Added a comment to start a section where we can put the various default log levels.

- - - - - 5eca2524 by Morgan at 2024-08-26T21:12:47+02:00 fixup! Firefox preference overrides.

Bug 42604: Remove safe-browsing google prefs

- - - - - 6e38aef1 by Pier Angelo Vendrame at 2024-08-26T21:12:47+02:00 fixup! Firefox preference overrides.

Bug 42611: Set clipboard.imageAsFile.enabled to false

In this way, when you copy an image to the clipboard, its URL is not copied as well. This replaces a patch we used to have in the previous versions after Mozilla implemented this preference in Firefox 120.

- - - - - 3d7617e5 by Pier Angelo Vendrame at 2024-08-26T21:12:47+02:00 fixup! Firefox preference overrides.

Bug 42830: Enable Web Audio API.

We were concerned about fingerprintability of these APIs. However, Mozilla switched to the same Math library for all platforms, so these concerns are less reduced (and are mostly about different architectures, that probably leak anyway). So, for compatibility, we decided to enable Web Audio.

- - - - - a72df0ec by Pier Angelo Vendrame at 2024-08-26T21:12:48+02:00 Bug 41043: Hardcode the UI font on Linux

The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version.

Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese).

- - - - - a72b7149 by Pier Angelo Vendrame at 2024-08-26T21:12:48+02:00 Bug 41901: Hardcode normalized FontSubstitutes.

Windows has a system to set font aliases through the registry. This allows some customization that could be used as a fingerprinting vector. Moreover, this mechanism is used by Windows itself, and different SKUs might have different default FontSubstitutes.

- - - - - 9a8da4ec by Alex Catarineu at 2024-08-26T21:12:49+02:00 Bug 30605: Honor privacy.spoof_english in Android

This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly.

Bug 40198: Expose privacy.spoof_english pref in GeckoView

- - - - - f165a887 by Pier Angelo Vendrame at 2024-08-26T21:12:49+02:00 Bug 42562: Normalized the Accepted Languages on Android.

The OS language might be outside the list of actually supported languages and it might leak the user's region. Therefore, we force the locale reported in Accept-Language to match one we support with translations, even when it means using a not exact region tag.

- - - - - 2912d408 by Alex Catarineu at 2024-08-26T21:12:49+02:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware

- - - - - f2747a92 by Alex Catarineu at 2024-08-26T21:12:50+02:00 Bug 26345: Hide tracking protection UI

- - - - - 0bc53aca by Henry Wilkes at 2024-08-26T21:12:50+02:00 fixup! Bug 26345: Hide tracking protection UI

Bug 42679: Revert change to hide tracking protection toolbar icon and preferences.

- - - - - 62c98d07 by Henry Wilkes at 2024-08-26T21:12:50+02:00 fixup! Bug 26345: Hide tracking protection UI

Bug 42679: Re-hide the tracking protections UI.

We hide the toolbar button with CSS.

We hide the preferences using data-hidden-from-search.

- - - - - 40f0a39c by Pier Angelo Vendrame at 2024-08-26T21:12:51+02:00 Bug 9173: Change the default Firefox profile directory to be relative.

This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows.

On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle.

This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS).

- - - - - c95f4a40 by Alex Catarineu at 2024-08-26T21:12:51+02:00 Bug 27604: Fix addon issues when moving the profile directory

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838

- - - - - 63dedfae by Mike Perry at 2024-08-26T21:12:51+02:00 Bug 13028: Prevent potential proxy bypass cases.

It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident.

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509

- - - - - ee693d0f by Pier Angelo Vendrame at 2024-08-26T21:12:52+02:00 Bug 40309: Avoid using regional OS locales

Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled.

- - - - - 40d60411 by Pier Angelo Vendrame at 2024-08-26T21:12:52+02:00 fixup! Bug 40309: Avoid using regional OS locales

Bug 42349: Change the RFPTarget in the region spoofing.

One of our patches makes sure that when spoof English is not in use, we report the same locale as the app language, instead of reporting the OS locale (which is Firefox's default behavior when the app and OS languages are the same).

When rebasing onto 128, we broke this patch because we had to specify an RFPTarget, and I chose RFPTarget::JSLocale. This is the only target that can be disabled even when running RFP instead of FFP, because it is controlled by privacy.spoof_english.

- - - - - e5b640ed by Matthew Finkel at 2024-08-26T21:12:52+02:00 Bug 40432: Prevent probing installed applications

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084

- - - - - 9d804773 by cypherpunks1 at 2024-08-26T21:12:53+02:00 Bug 33955: When copying an image only copy the image contents to the clipboard

- - - - - 862cf0a0 by cypherpunks1 at 2024-08-26T21:12:53+02:00 Bug 41791: Omit the source URL when copying page contents to the clipboard

- - - - - 7308931b by hackademix at 2024-08-26T21:12:53+02:00 Bug 42288: Allow language spoofing in status messages.

- - - - - 2df1ea2b by Richard Pospesel at 2024-08-26T21:12:54+02:00 Bug 41659: Add canonical color definitions to base-browser

- - - - - 02a1403b by Henry Wilkes at 2024-08-26T21:12:54+02:00 fixup! Bug 41659: Add canonical color definitions to base-browser

Bug 41817: Drop browser-colors.css.

- - - - - 8e7161c9 by Pier Angelo Vendrame at 2024-08-26T21:12:55+02:00 Base Browser strings

This commit adds all the strings needed by following Base Browser patches.

- - - - - 7ae65523 by Pier Angelo Vendrame at 2024-08-26T21:12:57+02:00 fixup! Base Browser strings

This reverts commit 900fb923a95ec97a9c843085759fa08d961bd92c.

- - - - - fa9a86d7 by Pier Angelo Vendrame at 2024-08-26T21:12:57+02:00 Bug 41369: Improve Firefox language settings for multi-lingual packages

Change the language selector to be sorted by language code, rather than name, and to display the language code to the user.

Bug 41372: Handle Japanese as a special case in preferences on macOS

Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs.

Bug 41378: Tell users that they can change their language at the first start

With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once.

- - - - - ffe235df by p13dz at 2024-08-26T21:12:58+02:00 Bug 40283: Workaround for the file upload bug

- - - - - 942e2690 by Arthur Edelstein at 2024-08-26T21:12:58+02:00 Bug 18905: Hide unwanted items from help menu

Bug 25660: Remove the "New Private Window" option

- - - - - 9c15f42f by Pier Angelo Vendrame at 2024-08-26T21:12:58+02:00 Bug 41739: Remove "Website appearance" from about:preferences.

It is ignored because of RFP and it is confusing for users.

- - - - - 0e5340b6 by hackademix at 2024-08-26T21:12:59+02:00 Bug 42019: Empty browser's clipboard on browser shutdown

- - - - - ea33fa7e by hackademix at 2024-08-26T21:12:59+02:00 Bug 42084: Ensure English spoofing works even if preferences are set out of order.

- - - - - ee2f0e77 by Pier Angelo Vendrame at 2024-08-26T21:12:59+02:00 Bug 41930: Remove the UI to customize accept_languages.

- - - - - 7bdf1f4f by Pier Angelo Vendrame at 2024-08-26T21:13:00+02:00 Bug 42472: Spoof timezone in XSLT.

- - - - - e4be9c6d by hackademix at 2024-08-26T21:13:00+02:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs.

- - - - - afaf8423 by hackademix at 2024-08-26T21:13:00+02:00 Bug 41434: Letterboxing, improve logging.

- - - - - 44885e03 by hackademix at 2024-08-26T21:13:01+02:00 Bug 31064: Letterboxing, exempt browser extensions.

- - - - - 86f677de by hackademix at 2024-08-26T21:13:01+02:00 Bug 32411: Letterboxing, exempt view-source: URIs.

- - - - - ddcb4d9f by hackademix at 2024-08-26T21:13:01+02:00 Bug 42574: Letterboxing, exempt pdf.js.

- - - - - 3d4036dd by hackademix at 2024-08-26T21:13:02+02:00 Bug 32308: Use direct browser sizing for letterboxing.

Bug 30556: align letterboxing with 200x100 new win width stepping

- - - - - cf1f4f84 by hackademix at 2024-08-26T21:13:02+02:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations

- - - - - 5f065803 by hackademix at 2024-08-26T21:13:03+02:00 Bug 41918: Option to reuse last window size when letterboxing is enabled.

- - - - - ca48302c by hackademix at 2024-08-26T21:13:03+02:00 Bug 41916: Letterboxing preferences UI

- - - - - 1830911f by Henry Wilkes at 2024-08-26T21:13:03+02:00 fixup! Bug 41916: Letterboxing preferences UI

Bug 42667: Add the "description-deemphasized" class to our preferences.

- - - - - 916b00d1 by Henry Wilkes at 2024-08-26T21:13:04+02:00 fixup! Bug 41916: Letterboxing preferences UI

Bug 42665: Drop the "tail-with-learn-more" class from our descriptions.

- - - - - 63408484 by hackademix at 2024-08-26T21:13:04+02:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module

- - - - - 97d244d6 by hackademix at 2024-08-26T21:13:04+02:00 Bug 42443: Shrink window to match letterboxing size when the emtpy area is clicked.

- - - - - 340ad1dc by Henry Wilkes at 2024-08-26T21:13:05+02:00 Bug 42528: Don't leak system scrollbar size on windows.

- - - - - 130e1830 by Henry Wilkes at 2024-08-26T21:13:05+02:00 Bug 31575: Disable Firefox Home (Activity Stream)

Treat about:blank as the default home page and new tab page.

Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need.

Bug 41624: Disable about:pocket-* pages.

Bug 40144: Redirect about:privatebrowsing to the user's home

- - - - - 3f6199c2 by Kathy Brade at 2024-08-26T21:13:05+02:00 Bug 4234: Use the Firefox Update Process for Base Browser.

Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909.

Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update.

Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality.

Bug 26048: potentially confusing "restart to update" message

Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string.

Bug 28885: notify users that update is downloading

Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress.

As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process.

Removed #28885 parts of this patch which have been uplifted to Firefox.

- - - - - 44d94c49 by Pier Angelo Vendrame at 2024-08-26T21:13:06+02:00 Bug 42061: Create an alpha update channel.

- - - - - f703c271 by Nicolas Vigier at 2024-08-26T21:13:06+02:00 Bug 41682: Add base-browser nightly mar signing key

- - - - - 15a1850f by Pier Angelo Vendrame at 2024-08-26T21:13:06+02:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL

MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/.

- - - - - faec135c by Pier Angelo Vendrame at 2024-08-26T21:13:07+02:00 Bug 41698: Reword the recommendation badges in about:addons

Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them.

We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead.

Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033

- - - - - 3106a624 by Pier Angelo Vendrame at 2024-08-26T21:13:07+02:00 Bug 42438: Tweaks to the migration wizard.

Remove the items not compatible with our features (such as history) from the migration wizard.

On Linux, allow to specify an alternative home directory, since we usually change $HOME in our startup script.

- - - - - 463c197a by Alex Catarineu at 2024-08-26T21:13:07+02:00 Bug 40069: Add helpers for message passing with extensions

- - - - - d8fc224b by Matthew Finkel at 2024-08-26T21:13:08+02:00 Bug 41598: Prevent NoScript from being removed/disabled.

Bug 40253: Explicitly allow NoScript in Private Browsing mode.

- - - - - 3acb44d0 by Henry Wilkes at 2024-08-26T21:13:08+02:00 Bug 41736: Hide NoScript extension's toolbar button by default.

This hides it from both the toolbar and the unified extensions panel.

We also hide the unified-extension-button if the panel would be empty: not including the NoScript button when it is hidden. As a result, this will be hidden by default until a user installs another extension (or shows the NoScript button and unpins it).

- - - - - 590130a2 by hackademix at 2024-08-26T21:13:09+02:00 Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons

- - - - - 4449518c by Pier Angelo Vendrame at 2024-08-26T21:13:09+02:00 Bug 40925: Implemented the Security Level component

This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings.

Bug 40125: Expose Security Level pref in GeckoView

- - - - - 739d6aa0 by Henry Wilkes at 2024-08-26T21:13:09+02:00 fixup! Bug 40925: Implemented the Security Level component

Bug 42644: Remove redundant separator CSS rules.

- - - - - f1394ce2 by Henry Wilkes at 2024-08-26T21:13:10+02:00 fixup! Bug 40925: Implemented the Security Level component

Bug 42704: Drop the "badged" attribute from the security level button.

- - - - - f3e8e4c7 by Henry Wilkes at 2024-08-26T21:13:10+02:00 fixup! Bug 40925: Implemented the Security Level component

Bug 42699: Drop level="top" attribute.

- - - - - e084e430 by Henry Wilkes at 2024-08-26T21:13:10+02:00 fixup! Bug 40925: Implemented the Security Level component

Bug 42641: Use moz-button-group for panel buttons.

Also tweak the "Learn more" link to have block-end padding to ensure its focus outline is visible, and restrict it to align-start so that it does not span the full width.

Also switch from `em` to `px` units for the vertical spacing.

- - - - - 90011d06 by Henry Wilkes at 2024-08-26T21:13:11+02:00 fixup! Bug 40925: Implemented the Security Level component

Bug 42705: Adopt the same markup as "Enhanced Tracking Protection" and "DNS over HTTPS" for the security level preferences.

We inherit all the rules for spacing and highlighting.

We also update the radio disabled opacity rule following bugzilla bug 1869233.

- - - - - f87dc41f by Henry Wilkes at 2024-08-26T21:13:11+02:00 fixup! Bug 40925: Implemented the Security Level component

Bug 42667: Add the "description-deemphasized" class to our preferences.

- - - - - e433bb32 by Henry Wilkes at 2024-08-26T21:13:13+02:00 fixup! Bug 40925: Implemented the Security Level component

Bug 41817: Drop browser-colors.css.

- - - - - 500fa48c by Henry Wilkes at 2024-08-26T21:13:13+02:00 fixup! Bug 40925: Implemented the Security Level component

Bug 42665: Drop the "tail-with-learn-more" class from our descriptions.

- - - - - 85bf9ccd by Pier Angelo Vendrame at 2024-08-26T21:13:14+02:00 Bug 40926: Implemented the New Identity feature

- - - - - 40bca4c1 by Pier Angelo Vendrame at 2024-08-26T21:13:14+02:00 fixup! Bug 40926: Implemented the New Identity feature

Bug 42596: Add preferences for log levels.

- - - - - b451c170 by Henry Wilkes at 2024-08-26T21:13:15+02:00 Bug 41736: Customize toolbar for base-browser.

- - - - - 608f5e2e by Pier Angelo Vendrame at 2024-08-26T21:13:15+02:00 Bug 42027: Base Browser migration procedures.

This commit implmenents the the Base Browser's version of _migrateUI.

- - - - - c1aee63c by Henry Wilkes at 2024-08-26T21:13:15+02:00 Bug 42583: Modify moz-support-link for Base Browser.

- - - - -

30 changed files:

- .eslintignore - + .gitlab-ci.yml - + .gitlab/ci/docker/base/Dockerfile - + .gitlab/ci/lint.yml - + .gitlab/ci/scripts/helpers.py - + .gitlab/ci/setup.yml - + .gitlab/issue_templates/Emergency Security Issue.md - + .gitlab/issue_templates/QA - Android.md - + .gitlab/issue_templates/QA - Desktop.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - .prettierignore - − browser/actors/RFPHelperChild.sys.mjs - − browser/actors/RFPHelperParent.sys.mjs - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/moz.build - browser/app/permissions - + browser/app/profile/001-base-profile.js - browser/app/profile/firefox.js - browser/base/content/aboutDialog-appUpdater.js - browser/base/content/aboutDialog.js - browser/base/content/aboutDialog.xhtml - browser/base/content/appmenu-viewcache.inc.xhtml - browser/base/content/browser-addons.js - browser/base/content/browser-context.inc - browser/base/content/browser-init.js - browser/base/content/browser-menubar.inc - browser/base/content/browser-safebrowsing.js

The diff was not included because it is too large.

View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/ee0...