morgan pushed to branch tor-browser-128.4.0esr-14.5-1 at The Tor Project / Applications / Tor Browser

Commits: f8cf9f0a by Henry Wilkes at 2024-11-18T12:10:15+00:00 fixup! Bug 7494: Create local home page for TBB.

Bug 42802: Use :has selector to move the focus-visible styling for the search-input to its parent.

No longer need to monitor the focus-visible condition using javascript.

- - - - -

2 changed files:

- browser/components/abouttor/content/aboutTor.css - browser/components/abouttor/content/aboutTor.js

Changes:

===================================== browser/components/abouttor/content/aboutTor.css ===================================== @@ -122,7 +122,7 @@ body:not(.show-tor-check) #tor-check { border-color: var(--in-content-box-border-color); }

-#search-form.search-input-focus-visible { +#search-form:has(#search-input:focus-visible) { outline: var(--focus-outline); }

@@ -209,13 +209,13 @@ body:not(.show-tor-check) #tor-check { border-color: transparent; }

- #search-form.search-input-focus-visible { + #search-form:has(#search-input:focus-visible) { /* Use a light-themed inner-border to contrast with the dark-themed * focus outline. */ border-color: var(--tor-focus-outline-color-light); }

- #search-form.onionized-search:not(.search-input-focus-visible) { + #search-form.onionized-search:has(#search-input:not(:focus-visible)) { box-shadow: 0 4px 40px #9400ff66, 0 4px 16px #9400ff33; }

===================================== browser/components/abouttor/content/aboutTor.js ===================================== @@ -52,18 +52,6 @@ const SearchWidget = { }, { capture: true } ); - - // Focus styling on form. - const searchInput = document.getElementById("search-input"); - const updateInputFocus = () => { - this.searchForm.classList.toggle( - "search-input-focus-visible", - searchInput.matches(":focus-visible") - ); - }; - updateInputFocus(); - searchInput.addEventListener("focus", updateInputFocus); - searchInput.addEventListener("blur", updateInputFocus); },

_updateOnionize() {

View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f8cf9f0a...