commit d4a0c58e12376f2f9e1b1240a066f62d13b7a6a5 Author: Karsten Loesing karsten.loesing@gmx.net Date: Fri Jun 6 11:03:02 2014 +0200

Fix parsing of bridge pool assignments.

When parsing bridge pool assignment files, we check every bridge's details status file to see whether a bridge's pool assignment has changed, and we don't update that bridge's details status file if not. However, `return` ends the entire loop and stops parsing the assignments file at the first assignment that has not changed. What we really want there is `continue`.

Bug introduced in 677c5a3. Spotted by alphawolf. Fixes #12203. --- src/org/torproject/onionoo/NodeDetailsStatusUpdater.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/org/torproject/onionoo/NodeDetailsStatusUpdater.java b/src/org/torproject/onionoo/NodeDetailsStatusUpdater.java index 97cc2ab..72b98cd 100644 --- a/src/org/torproject/onionoo/NodeDetailsStatusUpdater.java +++ b/src/org/torproject/onionoo/NodeDetailsStatusUpdater.java @@ -391,7 +391,7 @@ public class NodeDetailsStatusUpdater implements DescriptorListener, if (detailsStatus == null) { detailsStatus = new DetailsStatus(); } else if (details.equals(detailsStatus.getPoolAssignment())) { - return; + continue; } detailsStatus.setPoolAssignment(details); this.documentStore.store(detailsStatus, fingerprint);