commit 961918843eea02d0ff7d64e1c0a436f55f9ac33e Author: Isis Lovecruft isis@torproject.org Date: Fri Nov 15 15:37:55 2013 +0000

Add an XXX about the odd, hardcoded number of "extra hashrings". --- lib/bridgedb/Dist.py | 3 +++ 1 file changed, 3 insertions(+)

diff --git a/lib/bridgedb/Dist.py b/lib/bridgedb/Dist.py index 66ca438..f599e47 100644 --- a/lib/bridgedb/Dist.py +++ b/lib/bridgedb/Dist.py @@ -103,6 +103,9 @@ class IPBasedDistributor(bridgedb.Bridges.BridgeHolder):

# add splitter and cache the default rings # plus leave room for dynamic filters + # + # XXX Why is the "extra room" hardcoded to be 5? Shouldn't it be some + # fraction of the number of clusters/categories? --isis ring_cache_size = self.nClusters + len(ipCategories) + 5 self.splitter = bridgedb.Bridges.FilteredBridgeSplitter( key2, max_cached_rings=ring_cache_size)