Pier Angelo Vendrame pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser

Commits: 5ff3177a by Pier Angelo Vendrame at 2023-08-22T18:44:59+02:00 Bug 42027: Base Browser migration procedures.

This commit implmenents the the Base Browser's version of _migrateUI.

- - - - - f268423e by Pier Angelo Vendrame at 2023-08-22T18:45:00+02:00 Bug 41739: Remove "Website appearance" from about:preferences.

It is ignored because of RFP and it is confusing for users.

- - - - -

2 changed files:

- browser/components/BrowserGlue.sys.mjs - browser/components/preferences/main.inc.xhtml

Changes:

===================================== browser/components/BrowserGlue.sys.mjs ===================================== @@ -1300,6 +1300,9 @@ BrowserGlue.prototype = { // handle any UI migration this._migrateUI();

+ // Base Browser-specific version of _migrateUI. + this._migrateUIBB(); + // Handle any TBB-specific migration before showing the UI. Keep after // _migrateUI to make sure this._isNewProfile has been defined. this._migrateUITBB(); @@ -4404,6 +4407,25 @@ BrowserGlue.prototype = { Services.prefs.setIntPref("browser.migration.version", UI_VERSION); },

+ _migrateUIBB() { + // Version 1: 13.0a3. Reset layout.css.prefers-color-scheme.content-override + // for tor-browser#41739. + const MIGRATION_VERSION = 1; + const MIGRATION_PREF = "basebrowser.migration.version"; + // We do not care whether this is a new or old profile, since in version 1 + // we just quickly clear a user preference, which should not do anything to + // new profiles. + // Shall we ever raise the version number and have a watershed, we can add + // a check easily (any version > 0 will be an old profile). + const currentVersion = Services.prefs.getIntPref(MIGRATION_PREF, 0); + if (currentVersion < 1) { + Services.prefs.clearUserPref( + "layout.css.prefers-color-scheme.content-override" + ); + } + Services.prefs.setIntPref(MIGRATION_PREF, MIGRATION_VERSION); + }, + // Use this method for any TBB migration that can be run just before showing // the UI. // Anything that critically needs to be migrated earlier should not use this.

===================================== browser/components/preferences/main.inc.xhtml ===================================== @@ -138,7 +138,7 @@ </hbox>

<!-- Website appearance --> -<groupbox id="webAppearanceGroup" data-category="paneGeneral" hidden="true"> +<groupbox id="webAppearanceGroup" data-category="paneGeneral" hidden="true" data-hidden-from-search="true"> <html:h2 data-l10n-id="preferences-web-appearance-header"/> <html:div id="webAppearanceSettings"> <description data-l10n-id="preferences-web-appearance-description"/>

View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/d17f316...