Pier Angelo Vendrame pushed to branch base-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser

Commits: df3f7281 by Henry Wilkes at 2024-08-14T11:20:54+02:00 fixup! Bug 26345: Hide tracking protection UI

Bug 42679: Revert change to hide tracking protection toolbar icon and preferences.

- - - - - c66e7939 by Henry Wilkes at 2024-08-14T11:20:55+02:00 fixup! Bug 26345: Hide tracking protection UI

Bug 42679: Re-hide the tracking protections UI.

We hide the toolbar button with CSS.

We hide the preferences using data-hidden-from-search.

- - - - -

4 changed files:

- browser/base/content/browser-siteIdentity.js - browser/components/preferences/privacy.inc.xhtml - browser/themes/shared/identity-block/identity-block.css - browser/themes/shared/preferences/privacy.css

Changes:

===================================== browser/base/content/browser-siteIdentity.js ===================================== @@ -942,10 +942,10 @@ var gIdentityHandler = { gPermissionPanel.refreshPermissionIcons(); }

- // Bug 26345: Hide tracking protection UI. + // Hide the shield icon if it is a chrome page. gProtectionsHandler._trackingProtectionIconContainer.classList.toggle( "chromeUI", - true + this._isSecureInternalUI ); },

===================================== browser/components/preferences/privacy.inc.xhtml ===================================== @@ -15,7 +15,7 @@ </hbox>

<!-- Tracking / Content Blocking --> -<groupbox id="trackingGroup" data-category="panePrivacy" hidden="true" aria-describedby="contentBlockingDescription" class="highlighting-group"> +<groupbox id="trackingGroup" data-category="panePrivacy" data-hidden-from-search="true" hidden="true" aria-describedby="contentBlockingDescription" class="highlighting-group"> <label id="contentBlockingHeader"><html:h2 data-l10n-id="content-blocking-enhanced-tracking-protection"/></label> <vbox data-subcategory="trackingprotection"> <hbox align="start">

===================================== browser/themes/shared/identity-block/identity-block.css ===================================== @@ -230,6 +230,9 @@ /* TRACKING PROTECTION ICON */

#tracking-protection-icon-container { + /* Always hide the tracking toolbar button in Base Browser. + * tor-browser#26345. */ + display: none !important; padding-inline: var(--urlbar-icon-padding); border-radius: var(--urlbar-icon-border-radius); /* This is needed in order to position the blue dot indicator. */

===================================== browser/themes/shared/preferences/privacy.css ===================================== @@ -63,10 +63,6 @@

/* Content Blocking */

-#trackingGroup { - display: none; -} - /* Override styling that sets descriptions as grey */ #trackingGroup description.indent, #trackingGroup .indent > description {

View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/cf4fca2...