Pier Angelo Vendrame pushed to branch base-browser-115.16.0esr-13.5-1 at The Tor Project / Applications / Tor Browser

Commits: b97760ca by Pier Angelo Vendrame at 2024-09-30T22:06:56+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser.

Bug 42747: Discard unsupported updates earlier.

Firefox's updater has a function to select updates, which checks mainly the version number. Therefore, a more recent update that is unsupported will be chosen over a compatible one. We patch this to be able to provide an alternative update path to Windows 7.

- - - - -

1 changed file:

- toolkit/mozapps/update/UpdateService.sys.mjs

Changes:

===================================== toolkit/mozapps/update/UpdateService.sys.mjs ===================================== @@ -3680,18 +3680,20 @@ UpdateService.prototype = {

switch (aUpdate.type) { case "major": - if (!majorUpdate) { + if (!majorUpdate || majorUpdate.unsupported) { majorUpdate = aUpdate; } else if ( + !aUpdate.unsupported && vc.compare(majorUpdate.appVersion, aUpdate.appVersion) <= 0 ) { majorUpdate = aUpdate; } break; case "minor": - if (!minorUpdate) { + if (!minorUpdate || minorUpdate.unsupported) { minorUpdate = aUpdate; } else if ( + !aUpdate.unsupported && vc.compare(minorUpdate.appVersion, aUpdate.appVersion) <= 0 ) { minorUpdate = aUpdate;

View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b97760ca...