[Git][tpo/applications/tor-browser][base-browser-102.10.0esr-12.5-1] 119 commits: Bug 1774413: Bundled fonts are not picked up on macOS r=jfkthame
Richard Pospesel pushed to branch base-browser-102.10.0esr-12.5-1 at The Tor Project / Applications / Tor Browser
Commits: be0f6ede by Pier Angelo Vendrame at 2023-04-04T10:10:45+02:00 Bug 1774413: Bundled fonts are not picked up on macOS r=jfkthame
Bundled fonts were not picked up because also child processes need to register them. Also, they were assigned User visibility, instead of Base, which was not coherent with other platforms.
Differential Revision: https://phabricator.services.mozilla.com/D150400 - - - - - ae81fad1 by Pier Angelo Vendrame at 2023-04-04T10:10:45+02:00 Bug 1769030: Add a configure flag to load policies only from the local policies.json file r=mkaply,glandium
Add a configuration flag to make Enterprise Policies mechanism only consult a policies.json file (avoiding the Windows Registry, macOS's file system attributes, and /etc/firefox/policies/policies.json on other OS).
Differential Revision: https://phabricator.services.mozilla.com/D146300
- - - - - ff315642 by Jamie Nicol at 2023-04-04T10:10:45+02:00 Bug 1784588 - Fix SplitDriverVersion when the string has less than 4 numbers. r=aosmond
Differential Revision: https://phabricator.services.mozilla.com/D154897 - - - - - f05871e4 by Pier Angelo Vendrame at 2023-04-04T10:10:46+02:00 Bug 1768907 - Part 1: Make browser.privatebrowsing.autostart a static pref. r=handyman,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D157843
- - - - - 29c9a87e by Neill Miller at 2023-04-04T10:10:46+02:00 Bug 1768907 - Part 2: nsTransferable disk-leaks when private browsing mode is enabled by default. r=handyman
nsTransferable was modified to prevent disk leakings when copying data in private browsing mode with Bug 1123480. However, the context is nullptr when it is initialized, so it still leaks if PBM is enabled by default. Our solution is to check the browser.privatebrowsing.autostart in this condition.
Differential Revision: https://phabricator.services.mozilla.com/D157800 - - - - - dee0f57f by Gabriele Svelto at 2023-04-04T10:10:47+02:00 Bug 1670885 - Fix post-fork() handlers for PHC/LogAlloc to work on macOS using unfair locks r=glandium
macOS unfair locks enforce that a lock can only be released by the thread which locked it.
On macOS 11+ this caused the fork()'d child process to raise a SIGILL signal. Confusingly enough this behavior seems to be different on macOS 10.15 and possibly interacted in odd ways with our exception handler if it was installed before fork()-ing.
Differential Revision: https://phabricator.services.mozilla.com/D148287 - - - - - 39e4cc51 by Gabriele Svelto at 2023-04-04T10:10:47+02:00 Bug 1670885 - Replace deprecated NSSpinLocks with os_unfair_locks in the memory allocator r=glandium
Depends on D148287
Differential Revision: https://phabricator.services.mozilla.com/D99280 - - - - - a4f37bbf by Gabriele Svelto at 2023-04-04T10:10:47+02:00 Bug 1774458 - Use undocumented, non-public adaptive spinlocks on macOS 10.15+, revert to user-space spinlocks on older versions r=pbone
Differential Revision: https://phabricator.services.mozilla.com/D149599 - - - - - cd4fb43b by Gabriele Svelto at 2023-04-04T10:10:48+02:00 Bug 1784018 - Remove deprecated OSSpinLocks r=glandium
On macOS versions prior to 10.15 os_unfair_locks cannot spin in kernel-space which degrades performance significantly. To obviate for this we spin in user-space like OSSpinLock does, for the same number of times and invoking x86-specific pause instructions in-between the locking attempts to avoid starving a thread that might be running on the same physical core.
Differential Revision: https://phabricator.services.mozilla.com/D154205 - - - - - ff524e0f by Rob Wu at 2023-04-04T10:12:32+02:00 Bug 1802385 - Use NS_GetFinalChannelURI in FetchDriver r=rpl,valentin
Depends on D164656
Differential Revision: https://phabricator.services.mozilla.com/D166108
- - - - - f441f43c by Kash Shampur at 2023-04-04T10:12:33+02:00 Bug 1803109 - Discard blocks of data that are too big for two chunks. r=canaltinova
Currently, `ReserveAndPutRaw` allocates a second span even if the data would be too big for the chunk. Here a second conditional is added to check if the block of data is too big in this scenario and silently discard the data if so.
Differential Revision: https://phabricator.services.mozilla.com/D167167 - - - - - 30970659 by Pier Angelo Vendrame at 2023-04-04T10:12:33+02:00 Bug 1814416: Generalize the app name in about:buildconfig. r=ahochheiden
Now it displays app display name, instead of having Firefox hardcoded.
Differential Revision: https://phabricator.services.mozilla.com/D168562 - - - - - 8d444ef4 by Pier Angelo Vendrame at 2023-04-04T10:12:33+02:00 Bug 1817756 - Add a seed to the network ID. r=valentin,necko-reviewers
This helps to prevent linkability of users in the same network.
Differential Revision: https://phabricator.services.mozilla.com/D170373 - - - - - 6e89b068 by Georg Koppen at 2023-04-04T10:12:34+02:00 Revert "Bug 1724777, optimize suppressed MicroTask handling, r=mccr8 a=RyanVM"
This reverts commit 1eb1364357ac5bc2a4531337fb5416af39c3793f.
This fixes tor-browser#40721, tor-browser#40698, and tor-browser#40706. However, it is a temporary workaround, that we should revert once https://bugzilla.mozilla.org/show_bug.cgi?id=1744719 is fixed.
- - - - - fe263b2e by Henry Wilkes at 2023-04-04T10:12:34+02:00 Bug 41454: Move focus after calling openPreferences for a sub-category.
Temporary fix until mozilla bug 1799153 gets a patch upstream.
- - - - - bc39624e by Henry Wilkes at 2023-04-04T10:12:35+02:00 Bug 41483: Remove the firefox override for appstrings.properties
Remove this patch after upstream bugzilla bug 1790187
- - - - - badf4b57 by Pier Angelo Vendrame at 2023-04-04T10:12:36+02:00 Bug 41116: Normalize system fonts.
System fonts are an enormous fingerprinting vector. Even with font allow lists and with our custom configuration on Linux, which counter metrics measurements, getComputedStyle leaks several details. This patch counters both these kinds of attacks.
- - - - - 046d4fc2 by Marco Simonelli at 2023-04-04T10:31:37+02:00 Bug 41459: WebRTC fails to build under mingw (Part 1)
- properly define NOMINMAX for just MSVC builds
- - - - - 3daeb2e9 by Marco Simonelli at 2023-04-04T10:31:45+02:00 Bug 41459: WebRTC fails to build under mingw (Part 2)
- fixes required to build third_party/libwebrtc
- - - - - fe48d4a5 by Richard Pospesel at 2023-04-04T10:31:45+02:00 fixup! Bug 41459: WebRTC fails to build under mingw (Part 2)
- - - - - afc62d14 by Marco Simonelli at 2023-04-04T10:31:46+02:00 Bug 41459: WebRTC fails to build under mingw (Part 3)
- fixes required to build third_party/sipcc
- - - - - 21d84125 by Richard Pospesel at 2023-04-04T10:31:46+02:00 fixup! Bug 41459: WebRTC fails to build under mingw (Part 3)
- - - - - f7336951 by Pier Angelo Vendrame at 2023-04-04T10:31:47+02:00 fixup! Bug 41459: WebRTC fails to build under mingw (Part 3)
Fix build error
- - - - - b703e8f5 by Marco Simonelli at 2023-04-04T10:31:47+02:00 Bug 41459: WebRTC fails to build under mingw (Part 4)
- fixes requried to build netwerk/sctp
- - - - - a63f2046 by Marco Simonelli at 2023-04-04T10:31:48+02:00 Bug 41459: WebRTC fails to build under mingw (Part 5)
- fixes required to build dom/media/webrtc
- - - - - 2e29c765 by Marco Simonelli at 2023-04-04T10:31:48+02:00 Bug 41459: WebRTC fails to build under mingw (Part 6)
- fixes required to build dom/media/systemservices
- - - - - 440e5b75 by Gaba at 2023-04-04T10:31:48+02:00 Adding issue and merge request templates
- - - - - 368f79a0 by Pier Angelo Vendrame at 2023-04-04T10:31:49+02:00 Base Browser's .mozconfigs.
Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan.
Bug 21849: Don't allow SSL key logging.
Bug 25741 - TBA: Disable features at compile-time
Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION
Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds
This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android.
Bug 29859: Disable HLS support for now
Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING
Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT
Bug 33734: Set MOZ_NORMANDY to False
Bug 33851: Omit Parental Controls.
Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files
Bug 41584: Move some configuration options to base-browser level
- - - - - 62e78d01 by Pier Angelo Vendrame at 2023-04-04T10:32:59+02:00 fixup! Base Browser's .mozconfigs.
Bug 41647: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros
Removed the --enable-base-browser flag and the BASE_BROWSER macro and added --with-base-browser-version to the -dev mozconfig.
- - - - - b113a46d by Pier Angelo Vendrame at 2023-04-04T10:33:08+02:00 fixup! Base Browser's .mozconfigs.
Bug 41668: Port some updater patches to Base Browser
- - - - - 69918201 by Pier Angelo Vendrame at 2023-04-04T10:33:08+02:00 fixup! Base Browser's .mozconfigs.
Bug 41677: Fix updater settings for Android
- - - - - b15e20cc by Pier Angelo Vendrame at 2023-04-04T10:33:09+02:00 fixup! Base Browser's .mozconfigs.
Bug 41684: Fix Android mozconfigs for local dev builds
- - - - - aa4348d0 by Pier Angelo Vendrame at 2023-04-04T10:33:09+02:00 Tweaks to the build system
Bug 40857: Modified the fat .aar creation file
This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build.
We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch.
See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770.
Bug 41458: Prevent `mach package-multi-locale` from actually creating a package
macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it.
- - - - - 7b597d4c by Dan Ballard at 2023-04-04T10:33:10+02:00 Bug 41117: using MOZ_PROXY_BYPASS_PROTECTION disable share menu on mac and windows, and restore email link on mac
- - - - - 6fa3f206 by Pier Angelo Vendrame at 2023-04-04T10:33:23+02:00 Bug 41108: Remove privileged macOS installation from 102
- - - - - 377f8086 by Pier Angelo Vendrame at 2023-04-04T10:33:23+02:00 fixup! Bug 41108: Remove privileged macOS installation from 102
Bug 41647: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros
Changed BASE_BROWSER with BASE_BROWSER_VERSION.
- - - - - 33eb7e22 by Dan Ballard at 2023-04-04T10:33:24+02:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies
- - - - - c8546adc by Pier Angelo Vendrame at 2023-04-04T10:33:24+02:00 fixup! Bug 41149: Re-enable DLL injection protection in all builds not just nightlies
Bug 41647: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros
Changed BASE_BROWSER with BASE_BROWSER_VERSION.
- - - - - 190712b4 by Matthew Finkel at 2023-04-04T10:33:24+02:00 Bug 24796: Comment out excess permissions from GeckoView
The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing.
- - - - - b8c342fc by Matthew Finkel at 2023-04-04T10:33:25+02:00 Bug 28125: Prevent non-Necko network connections
- - - - - badd81bd by Mike Perry at 2023-04-04T10:33:25+02:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth
The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602
- - - - - 6f004c7d by Alex Catarineu at 2023-04-04T10:33:26+02:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899
- - - - - e5125766 by Georg Koppen at 2023-04-04T10:33:26+02:00 Bug 16285: Exclude ClearKey system for now
In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past.
- - - - - 677d326f by Kathy Brade at 2023-04-04T10:33:26+02:00 Bug 21431: Clean-up system extensions shipped in Firefox
Only ship the pdfjs extension.
- - - - - 4a32ff98 by Kathy Brade at 2023-04-04T10:33:27+02:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc.
Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps.
Disable the "Create New Login" button when security.nocertdb is true.
- - - - - 175494ae by Alex Catarineu at 2023-04-04T10:33:27+02:00 Bug 41457: Remove Mozilla permissions
Bug 40025: Remove Mozilla add-on install permissions
- - - - - 29c25a0f by Kathy Brade at 2023-04-04T10:33:28+02:00 Bug 40002: Remove about:ion
Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser.
Bug 41662: Disable about:sync-logs
Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component.
- - - - - 14e2d8e7 by Arthur Edelstein at 2023-04-04T10:33:28+02:00 Bug 26353: Prevent speculative connect that violated FPI.
Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term.
- - - - - a7228221 by Alex Catarineu at 2023-04-04T10:33:28+02:00 Bug 31740: Remove some unnecessary RemoteSettings instances
More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls.
Avoid creating instance for 'anti-tracking-url-decoration'.
If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'.
Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps.
We also clear the collections database on the v2 -> v3 migration.
- - - - - cbe0efbf by Pier Angelo Vendrame at 2023-04-04T10:33:29+02:00 fixup! Bug 31740: Remove some unnecessary RemoteSettings instances
Bug 41647: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros
Changed BASE_BROWSER with BASE_BROWSER_VERSION.
- - - - - c1ec12a3 by Pier Angelo Vendrame at 2023-04-04T10:33:29+02:00 fixup! Bug 31740: Remove some unnecessary RemoteSettings instances
Bug 40788: Tor Browser is phoning home
The hijack-list component is the only remaining one calling home. This is a temporary workaround, to use the remote settings.
We should do something like this commit at a more generic level, for all RemoteSettings users.
(cherry picked from commit 2a2e87c3dbc2a98a9ff6387dd278cb2643323b6d) - - - - - cde43cca by Pier Angelo Vendrame at 2023-04-04T10:33:30+02:00 fixup! Bug 31740: Remove some unnecessary RemoteSettings instances
Bug 41704: Immediately return on remoteSettings.pollChanges
- - - - - 49bbcf7b by Pier Angelo Vendrame at 2023-04-04T10:33:30+02:00 Revert "fixup! Bug 31740: Remove some unnecessary RemoteSettings instances"
This reverts commit 34ed82f6c02a8dc5ed8390fa664e2f63aeadc303.
- - - - - f870a976 by Pier Angelo Vendrame at 2023-04-04T10:33:30+02:00 Bug 41635: Disable the Normandy component
Do not include Normandy at all whenever MOZ_NORMANDY is False.
- - - - - c7d7d1a4 by Georg Koppen at 2023-04-04T10:33:31+02:00 Bug 30541: Disable WebGL readPixel() for web content
Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034
- - - - - 6e1214e0 by Alex Catarineu at 2023-04-04T10:33:31+02:00 Bug 28369: Stop shipping pingsender executable
- - - - - 1eb3d4c7 by cypherpunks1 at 2023-04-04T10:33:32+02:00 Bug 41565: Gate Telemetry Tasks behind MOZ_TELEMETRY_REPORTING
- - - - - a4b67994 by cypherpunks1 at 2023-04-04T10:33:32+02:00 Bug 41568: Disable LaterRun
- - - - - d5a5ab89 by cypherpunks1 at 2023-04-04T10:33:32+02:00 Bug 40717: Hide Windows SSO in settings
(cherry picked from commit 1bacd26df8a8ffe481e11ec6b8323150fdf2011d) - - - - - 3ab3b57e by Pier Angelo Vendrame at 2023-04-04T10:33:33+02:00 Bug 40788: Prevent nsIURLQueryStrippingListService from calling home when it is not enabled.
The URL query stripping service is enabled only in nightly builds, still it is initialized and remote settings are downloaded. This adds a condition that prevents the service from being initialized if disabled.
Upstream Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1812594 We should remove this patch if Mozilla decides that this is a problem also for them, or if they do not but we decide to use the feature.
- - - - - eff1249f by Pier Angelo Vendrame at 2023-04-04T10:33:33+02:00 Bug 41599: Always return an empty string as network ID
Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users.
We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756
- - - - - 849c3398 by Pier Angelo Vendrame at 2023-04-04T10:33:34+02:00 fixup! Bug 41599: Always return an empty string as network ID
Bug 41647: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros
Changed BASE_BROWSER with BASE_BROWSER_VERSION.
- - - - - bc56c3cb by Mike Perry at 2023-04-04T10:33:34+02:00 Firefox preference overrides.
This hack directly includes our preference changes in omni.ja.
Bug 18292: Staged updates fail on Windows
Temporarily disable staged updates on Windows.
Bug 18297: Use separate Noto JP,KR,SC,TC fonts
Bug 23404: Add Noto Sans Buginese to the macOS whitelist
Bug 23745: Set dom.indexedDB.enabled = true
Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera@riseup.net>)
Bug 17252: Enable session identifiers with FPI
Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers".
The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049)
Bug 14952: Enable http/2 and AltSvc
In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2".
Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well.
(All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.)
However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false.
"network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197.
Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites
Enable ReaderView mode again (#27281).
Bug 29916: Make sure enterprise policies are disabled
Bug 2874: Block Components.interfaces from content
Bug 26146: Spoof HTTP User-Agent header for desktop platforms
In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs.
Bug 12885: Windows Jump Lists fail for Tor Browser
Jumplist entries are stored in a binary file in: %APPDATA%\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms
The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller.
However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past.
The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted.
Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996.
Bug 30845: Make sure default themes and other internal extensions are enabled
Bug 28896: Enable extensions in private browsing by default
Bug 31065: Explicitly allow proxying localhost
Bug 31598: Enable letterboxing
Disable Presentation API everywhere
Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels.
Bug 32321: Disable Mozilla's MitM pings
Bug 19890: Disable installation of system addons
By setting the URL to "" we make sure that already installed system addons get deleted as well.
Bug 22548: Firefox downgrades VP9 videos to VP8.
On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8.
This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available".
Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs
Bug 16441: Suppress "Reset Tor Browser" prompt.
Bug 29120: Use the in-memory media cache and increase its maximum size.
Bug 33697: use old search config based on list.json
Bug 33855: Ensure that site-specific browser mode is disabled.
Bug 30682: Disable Intermediate CA Preloading.
Bug 40061: Omit the Windows default browser agent from the build
Bug 40322: Consider disabling network.connectivity-service.enabled
Bug 40408: Disallow SVG Context Paint in all web content
Bug 40308: Disable network partitioning until we evaluate dFPI
Bug 40322: Consider disabling network.connectivity-service.enabled
Bug 40383: Disable dom.enable_event_timing
Bug 40423: Disable http/3
Bug 40177: Update prefs for Fx91esr
Bug 40700: Disable addons and features recommendations
Bug 40682: Disable network.proxy.allow_bypass
Bug 40736: Disable third-party cookies in PBM
Bug 19850: Enabled HTTPS-Only by default
Bug 40912: Hide the screenshot menu
Bug 41292: Disable moreFromMozilla in preferences page
Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector
Bug 24686: Set network.http.tailing.enabled to true
Bug 40183: Disable TLS ciphersuites using SHA-1
Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102
We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them.
- - - - - 5346b6f8 by Pier Angelo Vendrame at 2023-04-04T10:33:34+02:00 fixup! Firefox preference overrides.
Bug 41647: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros
Changed TOR_BROWSER_VERSION with BASE_BROWSER_VERSION.
- - - - - f4fdbba5 by hackademix at 2023-04-04T10:33:35+02:00 fixup! Firefox preference overrides.
- - - - - aba403e3 by Pier Angelo Vendrame at 2023-04-04T10:33:35+02:00 fixup! Firefox preference overrides.
Bug 41668: Port some updater patches to Base Browser
Do not change app.update.auto in firefox.js, but add it to 001.
- - - - - b8f4b410 by Pier Angelo Vendrame at 2023-04-04T10:33:36+02:00 fixup! Firefox preference overrides.
Bug 41683: Disable the network process on Windows
- - - - - 79f97899 by Pier Angelo Vendrame at 2023-04-04T10:33:36+02:00 fixup! Firefox preference overrides.
Bug 41689: Do not customize startup.homepage_override_url in Base Browser.
(cherry picked from commit eff20896dedc966b4162bfa098a6dc065faf30eb) - - - - - b9584233 by Richard Pospesel at 2023-04-04T10:33:36+02:00 fixup! Firefox preference overrides.
Bug 41701: Reporting an extension does not work
- - - - - a36090e5 by Richard Pospesel at 2023-04-04T10:33:37+02:00 Bug 41659: Add canonical color definitions to base-browser
- - - - - 0b0bae79 by Pier Angelo Vendrame at 2023-04-04T10:33:37+02:00 Bug 41043: Hardcode the UI font on Linux
The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version.
Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese).
- - - - - cac51024 by Alex Catarineu at 2023-04-04T10:33:38+02:00 Bug 30605: Honor privacy.spoof_english in Android
This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly.
Bug 40198: Expose privacy.spoof_english pref in GeckoView
- - - - - 2da3bcd6 by Alex Catarineu at 2023-04-04T10:33:38+02:00 Bug 40199: Avoid using system locale for intl.accept_languages in GeckoView
- - - - - e513c5c2 by Alex Catarineu at 2023-04-04T10:33:38+02:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware
- - - - - 168c6f83 by Alex Catarineu at 2023-04-04T10:33:39+02:00 Bug 26345: Hide tracking protection UI
- - - - - 68369f24 by Pier Angelo Vendrame at 2023-04-04T10:49:14+02:00 Bug 9173: Change the default Firefox profile directory to be relative.
This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows.
On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle.
This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS).
- - - - - 74e04deb by Kathy Brade at 2023-04-04T10:49:26+02:00 Bug 18800: Remove localhost DNS lookup in nsProfileLock.cpp
Instead of using the local computer's IP address within symlink-based profile lock signatures, always use 127.0.0.1.
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1769028
- - - - - b3d8a441 by Alex Catarineu at 2023-04-04T10:49:27+02:00 Bug 27604: Fix addon issues when moving the profile directory
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838
- - - - - e94d25af by Mike Perry at 2023-04-04T10:49:27+02:00 Bug 13028: Prevent potential proxy bypass cases.
It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident.
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509
- - - - - 6e861d14 by Igor Oliveira at 2023-04-04T10:49:28+02:00 Bug 23104: Add a default line height compensation
Many fonts have issues with their vertical metrics. they are used to influence the height of ascenders and depth of descenders. Gecko uses it to calculate the line height (font height + ascender + descender), however because of that idiosyncratic behavior across multiple operating systems, it can be used to identify the user's OS.
The solution proposed in the patch uses a default factor to be multiplied with the font size, simulating the concept of ascender and descender. This way all operating systems will have the same line height only and only if the frame is outside the chrome.
- - - - - 9291cdd2 by Pier Angelo Vendrame at 2023-04-04T10:49:28+02:00 Bug 40309: Avoid using regional OS locales
Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled.
- - - - - e007176f by Matthew Finkel at 2023-04-04T10:49:28+02:00 Bug 40432: Prevent probing installed applications
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084
- - - - - a00f1e14 by hackademix at 2023-04-04T10:49:29+02:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs.
- - - - - b2a64169 by hackademix at 2023-04-04T10:49:29+02:00 Bug 41434: Letterboxing, improve logging.
- - - - - 971255f2 by hackademix at 2023-04-04T10:49:30+02:00 Bug 31064: Letterboxing, exempt browser extensions.
- - - - - 43b855b9 by hackademix at 2023-04-04T10:49:30+02:00 Bug 32411: Letterboxing, exempt view-source: URIs.
- - - - - 1716b70d by hackademix at 2023-04-04T10:49:30+02:00 Bug 32308: use direct browser sizing for letterboxing.
- - - - - ea5fc1ec by hackademix at 2023-04-04T10:49:31+02:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations
- - - - - bff4680a by Pier Angelo Vendrame at 2023-04-04T10:49:31+02:00 Bug 41369: Improve Firefox language settings for multi-lingual packages
Change the language selector to be sorted by language code, rather than name, and to display the language code to the user.
Bug 41372: Handle Japanese as a special case in preferences on macOS
Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs.
Bug 41378: Tell users that they can change their language at the first start
With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once.
- - - - - 1b7d7bca by Pier Angelo Vendrame at 2023-04-04T10:49:32+02:00 fixup! Bug 41369: Improve Firefox language settings for multi-lingual packages
Bug 41698: Reword the recommendation badges in about:addons
We need to add a new commit for all base browser strings
- - - - - 54a43376 by Henry Wilkes at 2023-04-04T10:49:32+02:00 Bug 41371: Temporary hack to fix language selector popup position
- - - - - bad85a45 by Pier Angelo Vendrame at 2023-04-04T10:49:33+02:00 Bug 41417: Always prompt users to restart after changing language
This is a temporary patch that we need until we switch our strings to Fluent. The reason is that we currently set strings when we populate our XUL content. We could rework the whole mechanism, but it is not worth it because we want to switch to Fluent, which will handle everything automatically.
- - - - - 78fa5fee by p13dz at 2023-04-04T10:49:33+02:00 Bug 40283: Workaround for the file upload bug
(cherry picked from commit c23f2f397327ee46a1a4de57acf206fd83e8e170) - - - - - 03ff0ff0 by Arthur Edelstein at 2023-04-04T10:49:33+02:00 Bug 18905: Hide unwanted items from help menu
Bug 25660: Remove the "New Private Window" option
- - - - - 61e43055 by Pier Angelo Vendrame at 2023-04-04T10:49:34+02:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL
MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/.
- - - - - 4aa1f346 by Henry Wilkes at 2023-04-04T10:49:34+02:00 Bug 31575: Disable Firefox Home (Activity Stream)
Treat about:blank as the default home page and new tab page.
Avoid loading AboutNewTab in BrowserGlue.jsm in order to avoid several network requests that we do not need.
Bug 41624: Disable about:pocket-* pages and about:firefoxview.
Bug 40144: Redirect about:privatebrowsing to the user's home
- - - - - 174ebe86 by Pier Angelo Vendrame at 2023-04-04T10:49:35+02:00 fixup! Bug 31575: Disable Firefox Home (Activity Stream)
Bug 41647: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros
Changed BASE_BROWSER with BASE_BROWSER_VERSION.
- - - - - 7bdb54b9 by Pier Angelo Vendrame at 2023-04-04T10:49:35+02:00 Bug 41542: Disable the creation of a default profile
Firefox creates a profile as a fallback for old versions. However, we do not need this, so we want to prevent Firefox from creating the related directories.
We comment out the code, but should Mozilla be interested in a compile-time flag, we could rewrite the patch to add one.
See also https://bugzilla.mozilla.org/show_bug.cgi?id=1770174.
- - - - - 9218fb5e by Pier Angelo Vendrame at 2023-04-04T10:49:35+02:00 fixup! Bug 41542: Disable the creation of a default profile
Bug 41647: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros
Changed TOR_BROWSER_VERSION with BASE_BROWSER_VERSION.
- - - - - eb16c8cc by Kathy Brade at 2023-04-04T10:49:36+02:00 Bug 13379: Allow using NSS to sign and verify MAR signatures
Allow using NSS on all platforms for checking MAR signatures (instead of using OS-native APIs, the default on Mac OS and Windows). So that the NSS and NSPR libraries the updater depends on can be found at runtime, we add the firefox directory to the shared library search path on macOS. On Linux, rpath is used to solve that problem, but that approach won't work on macOS because the updater executable is copied during the update process to a location that can vary.
- - - - - 16f42e30 by Pier Angelo Vendrame at 2023-04-04T10:49:36+02:00 fixup! Bug 13379: Allow using NSS to sign and verify MAR signatures
Bug 41668: Port some updater patches to Base Browser
Use a configure-time flag to force using NSS for MARs signatures.
- - - - - 30ba3988 by Pier Angelo Vendrame at 2023-04-04T10:49:37+02:00 fixup! Bug 13379: Allow using NSS to sign and verify MAR signatures
Bug 41668: Port some updater patches to Base Browser
Avoid using -rpath on macOS.
- - - - - 136387cd by Kathy Brade at 2023-04-04T10:49:37+02:00 Bug 4234: Use the Firefox Update Process for Base Browser.
Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909.
Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update.
Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality.
Bug 26048: potentially confusing "restart to update" message
Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string.
Bug 28885: notify users that update is downloading
Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress.
As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process.
Removed #28885 parts of this patch which have been uplifted to Firefox.
- - - - - 1a2f12fb by Pier Angelo Vendrame at 2023-04-04T10:49:37+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser.
Bug 41647: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros
Changed TOR_BROWSER_VERSION with BASE_BROWSER_VERSION.
- - - - - 27e74537 by Pier Angelo Vendrame at 2023-04-04T10:49:38+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser.
Bug 41668: Port some updater patches to Base Browser
Move the check on the update package version to this other commit.
- - - - - f325a6bc by Pier Angelo Vendrame at 2023-04-04T10:49:38+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser.
Bug 41668: Port some updater patches to Base Browser
Rename TOR_BROWSER_UPDATE to BASE_BROWSER_UPDATE. Also, do not change app.update.auto in firefox.js, but add it to 001.
- - - - - a6ab4b56 by Pier Angelo Vendrame at 2023-04-04T10:49:39+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser.
Bug 41668: Port some updater patches to Base Browser
Changes that will need to remain when actually cherry-picking to base-browser, because they contain name fixes, for example. Or, for UpdateService.jsm, they need to stay because they make the patch more understandable.
- - - - - 32b0c6ed by Pier Angelo Vendrame at 2023-04-04T10:49:39+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser.
Bug 41668: Port some updater patches to Base Browser
Remove Tor Browser-only additions to make the updater patches usable with Base Browser. This commit should be reverted, and become a commit on its own, to further adapt the updater to Tor Browser needs.
- - - - - cfc9319e by Pier Angelo Vendrame at 2023-04-04T10:49:39+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser.
Bug 41668: Port some updater patches to Base Browser
Fix a build error on Windows.
- - - - - 4b5c0a27 by Nicolas Vigier at 2023-04-04T10:49:40+02:00 Bug 41682: Add base-browser nightly mar signing key
- - - - - 48d6f9be by Pier Angelo Vendrame at 2023-04-04T10:49:40+02:00 Base Browser strings
This commit adds all the strings needed by following Base Browser patches.
- - - - - c9cdba48 by hackademix at 2023-04-04T10:49:41+02:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module
- - - - - b1c229b7 by Pier Angelo Vendrame at 2023-04-04T10:49:41+02:00 Bug 41698: Reword the recommendation badges in about:addons
Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them.
We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead.
Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033
- - - - - a63de36d by Alex Catarineu at 2023-04-04T10:49:41+02:00 Bug 40069: Add helpers for message passing with extensions
- - - - - d3becbdf by Matthew Finkel at 2023-04-04T10:49:42+02:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode.
- - - - - 3caac79e by Pier Angelo Vendrame at 2023-04-04T10:49:42+02:00 Bug 40925: Implemented the Security Level component
This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings.
Bug 40125: Expose Security Level pref in GeckoView
- - - - - 0c345330 by Henry Wilkes at 2023-04-04T15:31:59+02:00 fixup! Bug 40925: Implemented the Security Level component
Add cui-widget-panel class to the panel, which gives it the correct font.
- - - - - 622db29f by Pier Angelo Vendrame at 2023-04-04T15:31:59+02:00 Bug 40926: Implemented the New Identity feature
- - - - - b53567eb by Pier Angelo Vendrame at 2023-04-04T15:32:00+02:00 fixup! Bug 40926: Implemented the New Identity feature
Bug 41711: Wait for the new window when doing new identity
- - - - -
30 changed files:
- .eslintignore - + .gitlab/issue_templates/UXBug.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - − browser/actors/RFPHelperChild.jsm - − browser/actors/RFPHelperParent.jsm - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/permissions - + browser/app/profile/001-base-profile.js - browser/app/profile/firefox.js - browser/base/content/aboutDialog-appUpdater.js - browser/base/content/aboutDialog.js - browser/base/content/appmenu-viewcache.inc.xhtml - browser/base/content/browser-menubar.inc - browser/base/content/browser-safebrowsing.js - browser/base/content/browser-sets.inc - browser/base/content/browser-siteIdentity.js - browser/base/content/browser.css - browser/base/content/browser.js - browser/base/content/browser.xhtml - + browser/base/content/languageNotification.js - browser/base/content/main-popupset.inc.xhtml - browser/base/content/navigator-toolbox.inc.xhtml - browser/base/jar.mn - browser/base/moz.build - browser/components/BrowserContentHandler.jsm - browser/components/BrowserGlue.jsm - browser/components/about/AboutRedirector.cpp
The diff was not included because it is too large.
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/0c4c377...
tor-commits@lists.torproject.org
-
Richard Pospesel (＠richard)