brizental pushed to branch tor-browser-153.0esr-16.0-1 at The Tor Project / Applications / Tor Browser Commits: 79698505 by Beatriz Rizental at 2026-07-22T23:28:57+02:00 fixup! Firefox preference overrides. Bug 45120: Disable smartwindow feature - - - - - e693976e by Beatriz Rizental at 2026-07-22T23:28:57+02:00 fixup! BB 44045: Disable ML features. Bug 45120: Disable smartwindow feature Even when disabled, this feature still was using the EngineProcess to download models. I have made this conditional, because trying to use that was causing a runtime error preventing initialization to complete successfully and whenever a new window was opened e.g. through "Open Link In New Window", the browser crashed completely. - - - - - d5e898a5 by Beatriz Rizental at 2026-07-22T23:28:57+02:00 BB 45120: Add tests for Base Browser - - - - - 4 changed files: - browser/app/profile/001-base-profile.js - browser/components/aiwindow/ui/modules/AIWindow.sys.mjs - + testing/base-browser/manifest.toml - + testing/base-browser/test_new_window.py Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -383,6 +383,8 @@ pref("pdfjs.enableAltTextModelDownload", false, locked); pref("browser.urlbar.quicksuggest.mlEnabled", false, locked); // Disable SemanticHistory search. tor-browser#44045. pref("places.semanticHistory.featureGate", false, locked); +// tor-browser#45120: Disable AIWindow +pref("browser.smartwindow.enabled", false); // tor-browser#41945 - disable automatic cookie banners dismissal until ===================================== browser/components/aiwindow/ui/modules/AIWindow.sys.mjs ===================================== @@ -131,7 +131,11 @@ export const AIWindow = { Services.obs.addObserver(this, lazy.ONLOGOUT_NOTIFICATION); Services.obs.addObserver(this, "tabstrip-orientation-change"); lazy.SmartWindowTelemetry.init(); - lazy.getAllModelsData(); // loads model data into cache for about:preferences + if (this.isAIWindowEnabled()) { + // Depends on the ml component, which tor-browser#44045 excludes from + // the build, so only touch it when AI Window is actually enabled. + lazy.getAllModelsData(); // loads model data into cache for about:preferences + } lazy.NimbusFeatures.smartWindow.onUpdate(this.onNimbusUpdate); this._initialized = true; ===================================== testing/base-browser/manifest.toml ===================================== @@ -0,0 +1,4 @@ +[DEFAULT] +tags = "base-browser" + +["test_new_window.py"] ===================================== testing/base-browser/test_new_window.py ===================================== @@ -0,0 +1,25 @@ +from marionette_harness import MarionetteTestCase, WindowManagerMixin + + +class TestNewWindow(WindowManagerMixin, MarionetteTestCase): + def tearDown(self): + self.close_all_windows() + super().tearDown() + + def test_open_new_window(self): + with self.marionette.using_context("chrome"): + new_window = self.open_window() + + self.assertEqual( + len(self.marionette.chrome_window_handles), + len(self.start_windows) + 1, + "A new browser window should have been opened.", + ) + + self.marionette.switch_to_window(new_window) + self.marionette.navigate("about:blank") + self.assertEqual( + self.marionette.get_url(), + "about:blank", + "Should be able to navigate in the newly opened window.", + ) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/3e9c57c... -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/3e9c57c... You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications: https://gitlab.torproject.org/-/profile/notifications | Help: https://gitlab.torproject.org/help