morgan pushed to branch main at The Tor Project / Applications / RBM Commits: 9dedbe52 by Nicolas Vigier at 2025-02-26T13:43:01+01:00 Bug 40082: Fix `fetch: if_needed` to avoid fetching when using a fixed commit Remove trailing newline from output of `git rev-parse` when comparing it with `git_hash`. - - - - - 1 changed file: - lib/RBM.pm Changes: ===================================== lib/RBM.pm ===================================== @@ -427,6 +427,7 @@ sub git_need_fetch { my ($stdout, undef, $success) = capture_exec('git', 'rev-parse', '--verify', "$git_hash^{commit}"); return 1 unless $success; + chomp $stdout; # If rev-parse returns the same as git_hash, then git_hash is # a hash and there is no need to fetch return 0 if $stdout eq $git_hash; View it on GitLab: https://gitlab.torproject.org/tpo/applications/rbm/-/commit/9dedbe520adc16f5... -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/rbm/-/commit/9dedbe520adc16f5... You're receiving this email because of your account on gitlab.torproject.org.