commit 9cdb65f51c2eafcab660c337f587693a85553b7a Author: Karsten Loesing <karsten.loesing@gmx.net> Date: Wed Mar 6 16:37:41 2013 +0100 Exclude authorities on .0 versions from check. Authorities often run not-yet-released tor versions, which have version strings ending in "-dev". We ignore status tags in version checks, so a version string "0.2.4.10-alpha-dev" is okay as long as "0.2.4.10-alpha" is recommended. But "0.2.5.0-alpha-dev" was not okay, because there's no recommended version "0.2.5.0-alpha". Let's pretend versions ending in ".0" (plus status tag) are always okay. Shouldn't produce too many false negatives, but saves us from writing lots of version string parsing code. Fixes #8393. --- src/org/torproject/doctor/Checker.java | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/org/torproject/doctor/Checker.java b/src/org/torproject/doctor/Checker.java index 3adc678..5681e56 100644 --- a/src/org/torproject/doctor/Checker.java +++ b/src/org/torproject/doctor/Checker.java @@ -509,7 +509,8 @@ public class Checker { authorityVersion = authorityVersion.substring("Tor ".length()); } if (!recommendedVersions.contains( - authorityVersion.split("-", 2)[0])) { + authorityVersion.split("-", 2)[0]) && + !authorityVersion.split("-", 2)[0].endsWith(".0")) { unrecommendedVersions.add(nickname + "=" + authorityVersion); } }