morgan pushed to branch tor-browser-128.7.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 983bf5de by Henry Wilkes at 2025-02-10T14:38:02+00:00 fixup! TB 21952: Implement Onion-Location TB 43406: Hide the "onion available" button whilst the "Connect" button is shown. - - - - - 1 changed file: - browser/components/onionservices/content/onionlocation.css Changes: ===================================== browser/components/onionservices/content/onionlocation.css ===================================== @@ -5,3 +5,18 @@ -moz-context-properties: fill; fill: currentColor; } + +#tor-connect-urlbar-button:not([hidden]) ~ #onion-location-box { + /* Hide this button whilst the "Connect" button is shown. tor-browser#43406. + * This should only make a difference when the tor process dies mid-session. + * NOTE: We do not attempt to re-assign focus since the user should already + * have had their attention disrupted when the tor process dies mid-session. + * NOTE: If we hide this whilst the onion location popup is shown, the popup + * will instead become anchored to the site identity (padlock) button instead, + * but will return to the #onion-location-box once the "Connect" button is + * hidden again. In principle we could explicitly call + * PopupNotifications.anchorVisibilityChange() but mozilla code already has + * plenty of entry points to update the anchor position for us. + * Moreover, this scenario is expected to be a very rare. */ + display: none; +} View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/983bf5de... -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/983bf5de... You're receiving this email because of your account on gitlab.torproject.org.