commit 3fbd510c527b64bb83e87d78e81f1ad72def5f5f Author: David Goulet dgoulet@torproject.org Date: Wed May 12 13:31:40 2021 -0400

metrics: One relay metrics was not using metrics_format_label()

This resulted in the labels not being surrounded by double quotes and thus Prometheus not liking it.

Signed-off-by: David Goulet dgoulet@torproject.org --- src/feature/relay/relay_metrics.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/feature/relay/relay_metrics.c b/src/feature/relay/relay_metrics.c index 2c24728d9a..1c5d1fd7cc 100644 --- a/src/feature/relay/relay_metrics.c +++ b/src/feature/relay/relay_metrics.c @@ -288,22 +288,26 @@ fill_oom_values(void)

sentry = metrics_store_add(the_store, rentry->type, rentry->name, rentry->help); - metrics_store_entry_add_label(sentry, "subsys=cell"); + metrics_store_entry_add_label(sentry, + metrics_format_label("subsys", "cell")); metrics_store_entry_update(sentry, oom_stats_n_bytes_removed_cell);

sentry = metrics_store_add(the_store, rentry->type, rentry->name, rentry->help); - metrics_store_entry_add_label(sentry, "subsys=dns"); + metrics_store_entry_add_label(sentry, + metrics_format_label("subsys", "dns")); metrics_store_entry_update(sentry, oom_stats_n_bytes_removed_dns);

sentry = metrics_store_add(the_store, rentry->type, rentry->name, rentry->help); - metrics_store_entry_add_label(sentry, "subsys=geoip"); + metrics_store_entry_add_label(sentry, + metrics_format_label("subsys", "geoip")); metrics_store_entry_update(sentry, oom_stats_n_bytes_removed_geoip);

sentry = metrics_store_add(the_store, rentry->type, rentry->name, rentry->help); - metrics_store_entry_add_label(sentry, "subsys=hsdir"); + metrics_store_entry_add_label(sentry, + metrics_format_label("subsys", "hsdir")); metrics_store_entry_update(sentry, oom_stats_n_bytes_removed_hsdir); }