Matthew Finkel pushed to branch tor-browser-82.0.0b4-10.0-1 at The Tor Project / Applications / fenix Commits: 7edfd5b5 by Alex Catarineu at 2020-10-21T12:51:36+02:00 Bug 40094: Do not use MasterPasswordTipProvider in HomeFragment - - - - - 03b642ac by Matthew Finkel at 2020-10-21T21:46:59+00:00 Merge remote-tracking branch 'acatgl/40094' into tor-browser-82.0.0b4-10.0-1 - - - - - 1 changed file: - app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt Changes: ===================================== app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt ===================================== @@ -87,9 +87,7 @@ import org.mozilla.fenix.components.PrivateShortcutCreateManager import org.mozilla.fenix.components.StoreProvider import org.mozilla.fenix.components.TabCollectionStorage import org.mozilla.fenix.components.metrics.Event -import org.mozilla.fenix.components.tips.FenixTipManager import org.mozilla.fenix.components.tips.Tip -import org.mozilla.fenix.components.tips.providers.MasterPasswordTipProvider import org.mozilla.fenix.components.toolbar.TabCounterMenu import org.mozilla.fenix.components.toolbar.ToolbarPosition import org.mozilla.fenix.ext.components @@ -218,17 +216,6 @@ class HomeFragment : Fragment() { expandedCollections = emptySet(), mode = currentMode.getCurrentMode(), topSites = components.core.topSitesStorage.cachedTopSites, - tip = StrictMode.allowThreadDiskReads().resetPoliciesAfter { - FenixTipManager( - listOf( - MasterPasswordTipProvider( - requireContext(), - ::navToSavedLogins, - ::dismissTip - ) - ) - ).getTip() - }, showCollectionPlaceholder = components.settings.showCollectionsPlaceholderOnHome ) ) @@ -685,17 +672,6 @@ class HomeFragment : Fragment() { collections = components.core.tabCollectionStorage.cachedTabCollections, mode = currentMode.getCurrentMode(), topSites = components.core.topSitesStorage.cachedTopSites, - tip = StrictMode.allowThreadDiskReads().resetPoliciesAfter { - FenixTipManager( - listOf( - MasterPasswordTipProvider( - requireContext(), - ::navToSavedLogins, - ::dismissTip - ) - ) - ).getTip() - }, showCollectionPlaceholder = components.settings.showCollectionsPlaceholderOnHome ) ) View it on GitLab: https://gitlab.torproject.org/tpo/applications/fenix/-/compare/67007f534ee65... -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/fenix/-/compare/67007f534ee65... You're receiving this email because of your account on gitlab.torproject.org.