henry pushed to branch tor-browser-149.0a1-16.0-2 at The Tor Project / Applications / Tor Browser Commits: 31c4bf89 by Henry Wilkes at 2026-03-31T10:20:56+01:00 fixup! BB 43902: Modify the new sidebar for Base Browser. BB 44765: Restore the limited sidebar description. - - - - - 65283c72 by Henry Wilkes at 2026-03-31T10:21:41+01:00 fixup! Base Browser strings BB 44765: Adjust the sidebar description to include the label attribute. - - - - - d44fec0a by Henry Wilkes at 2026-03-31T10:21:42+01:00 fixup! Tor Browser localization migration scripts. TB 44765: Add a Fluent migration. - - - - - 3 changed files: - browser/components/preferences/main.js - toolkit/locales/en-US/toolkit/global/base-browser.ftl - + tools/torbrowser/l10n/migrations/bug-44765-sidebar-description.py Changes: ===================================== browser/components/preferences/main.js ===================================== @@ -3141,7 +3141,9 @@ SettingGroupManager.registerGroups({ }, { id: "browserLayoutShowSidebar", - l10nId: "browser-layout-show-sidebar2", + // Update the sidebar description to remove mentioning features that we + // don't have in Base Browser. See tor-browser#44159. + l10nId: "browser-layout-show-sidebar-limited", }, ], }, ===================================== toolkit/locales/en-US/toolkit/global/base-browser.ftl ===================================== @@ -104,7 +104,11 @@ letterboxing-enable-button = ## Preferences - Sidebar. -browser-layout-show-sidebar-desc-limited = Quickly access bookmarks and more without leaving your main view. +# Here "sidebar" is a term inherited from Firefox. It refers to the panel that is either side of the main browser window, containing the bookmarks and vertical tabs, if they are enabled. +# In general, "Show sidebar" should use the same translation as Firefox translators have chosen for the string "browser-layout-show-sidebar2". See Firefox's translation on Pontoon, using the "LOCALES" tab: https://pontoon.mozilla.org/ar/firefox/browser/browser/preferences/preferenc... . Or use the translation for "sidebar": https://pontoon.mozilla.org/af/terminology/common/?string=212298 . +browser-layout-show-sidebar-limited = + .label = Show sidebar + .description = Quickly access bookmarks and more without leaving your main view. ## Preferences - Contrast Control. ===================================== tools/torbrowser/l10n/migrations/bug-44765-sidebar-description.py ===================================== @@ -0,0 +1,22 @@ +from fluent.migrate.helpers import transforms_from + + +def migrate(ctx): + # NOTE: preferences.ftl comes from firefox-l10n repository, under the path: + # <locale>/browser/browser/preferences/preferences.ftl + # which will need to be added the translations worktree under the path: + # <locale>/preferences.ftl + # prior to running this migration. + ctx.add_transforms( + "base-browser.ftl", + "base-browser.ftl", + transforms_from( + """ +browser-layout-show-sidebar-limited = + .label = { COPY_PATTERN(preferences_path, "browser-layout-show-sidebar2.label") } + .description = { COPY_PATTERN(path, "browser-layout-show-sidebar-desc-limited") } +""", + path="base-browser.ftl", + preferences_path="preferences.ftl", + ), + ) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/1447176... -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/1447176... You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications: https://gitlab.torproject.org/-/profile/notifications | Help: https://gitlab.torproject.org/help