commit fadb2ef6ee0df9ae69ffa5d7de27df2c1a611cf9 Author: David Fifield david@bamsoftware.com Date: Tue Feb 19 20:23:56 2019 -0700
Change --invisible to --headless in the firefox command.
The --help output no longer mentions --invisible. About --headless it says: --headless Run without a GUI.
Also use double dashes in --no-remote and --profile, to match --help output. --- meek-client-torbrowser/meek-client-torbrowser.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meek-client-torbrowser/meek-client-torbrowser.go b/meek-client-torbrowser/meek-client-torbrowser.go index 38a9fc3..6ce7a12 100644 --- a/meek-client-torbrowser/meek-client-torbrowser.go +++ b/meek-client-torbrowser/meek-client-torbrowser.go @@ -197,7 +197,7 @@ func isBrowserProfileUpToDate(templatePath string, profilePath string) bool { func runFirefox() (cmd *exec.Cmd, stdout io.Reader, err error) { // Unset environment variables that Firefox sets after a restart (as // caused by, for example, an update or the installation of an add-on). - // XRE_PROFILE_PATH, in particular, overrides the -profile option that + // XRE_PROFILE_PATH, in particular, overrides the --profile option that // runFirefox sets, causing Firefox to run with profile.default instead // of profile.meek-http-helper, which conflicts with the profile.default // that is already running. See https://bugs.torproject.org/13247, @@ -242,7 +242,7 @@ func runFirefox() (cmd *exec.Cmd, stdout io.Reader, err error) { return }
- cmd = exec.Command(absFirefoxPath, "--invisible", "-no-remote", "-profile", profilePath) + cmd = exec.Command(absFirefoxPath, "--headless", "--no-remote", "--profile", profilePath) osSpecificCommandSetup(cmd) cmd.Stderr = os.Stderr stdout, err = cmd.StdoutPipe()