commit 59877413ec137f44e3de86c5d9185976c6062f14 Author: Damian Johnson atagar@torproject.org Date: Sun Jan 19 14:20:27 2020 -0800
Forgot troubleshoting raise
Oops, this one is purely my bad. I negated this catch-all while troubleshooting other test failures, but forgot to revert it afterward. This caused...
Traceback (most recent call last): File "/home/atagar/Desktop/tor/bridgedb/bridgedb/test/test_bridges.py", line 1253, in test_Bridge_updateFromExtraInfoDescriptor_bad_signature_changed self.bridge.updateFromExtraInfoDescriptor(self.extrainfo) File "/home/atagar/Desktop/tor/bridgedb/bridgedb/bridges.py", line 1764, in updateFromExtraInfoDescriptor self._verifyExtraInfoSignature(descriptor) File "/home/atagar/Desktop/tor/bridgedb/bridgedb/bridges.py", line 1709, in _verifyExtraInfoSignature unpadded = removePKCS1Padding(decryptedBytes) File "/home/atagar/Desktop/tor/bridgedb/bridgedb/crypto.py", line 261, in removePKCS1Padding raise PKCS1PaddingError("Couldn't find PKCS#1 separator byte!") bridgedb.crypto.PKCS1PaddingError: Couldn't find PKCS#1 separator byte!
Test results changed as follows...
before: FAILED (skips=115, failures=27, errors=2, successes=840) after: FAILED (skips=115, failures=27, errors=1, successes=841) --- bridgedb/bridges.py | 1 - 1 file changed, 1 deletion(-)
diff --git a/bridgedb/bridges.py b/bridgedb/bridges.py index 049dbf1..1dc32af 100644 --- a/bridgedb/bridges.py +++ b/bridgedb/bridges.py @@ -1713,7 +1713,6 @@ class Bridge(BridgeBackwardsCompatibility): actualDigest = hashlib.sha1(document.encode('utf-8')).hexdigest()
except Exception as error: - raise logging.debug("Error verifying extrainfo signature: %s" % error) raise InvalidExtraInfoSignature( "Extrainfo signature for %s couldn't be decoded: %s" %