commit 049875766cacc75b993ced357fdd5a6cbeb160c4 Author: Isis Lovecruft isis@torproject.org Date: Thu Nov 1 12:39:23 2012 +0000
* Updated the TODO file. * ...and the Makefile because I moved echo.py and forgot to update its line. --- TODO | 27 ++++++++++----------------- bin/Makefile | 20 ++++++++++++++++---- 2 files changed, 26 insertions(+), 21 deletions(-)
diff --git a/TODO b/TODO index 7f532fd..2686ef7 100644 --- a/TODO +++ b/TODO @@ -9,24 +9,15 @@ Migrate code from old
Migrate all the interesting parts of the old code to the new.
-It's important to make the new code asych and based on gevent. +It's important to make the new code asych and based on Twisted. It should respect the design goals of the new ooni-probe model.
-* All the parts related to HTTP and Squid (old/ooni/http.py) -effort: low, skill: medium - -* Misc scripts to detect censorship that are not written in any - version of OONI (old/ooni/plugins/old_stuff_to_convert/) -effort: low-medium, skill: low-medium - New things to develop ---------------------
These are either components specific to the new refactor of ooni or that we haven't yet figured out how they should work.
-* Design and implement the Worker and the Unit of Work classes - * Design and implement the Node Factory
* Design and implement the Network Node and the Code Exec node classes @@ -34,12 +25,14 @@ or that we haven't yet figured out how they should work. New things to test ------------------
-Please check that the submodules are working correctly. From ../ooni-probe/, -do: - -$ git submodules init && git submodules update +* Some of the tests still give errors. This is top priority.
-Make sure that they clone correctly, and run a few ooni tests to make sure -the import statements haven't broken. +* The submit-patch script is still a bit janky, and could use + some sprucing up.
-Write unittests for *all of the things*. Can anyone suggest a good framework? \ No newline at end of file +* The Makefile that I made to serve a quick check for whether or not the tests + are broken could use some more tests added to it. One thing is that some + tests take certain types of input files, others take none at all, and + nowhere is this presented to someone trying to run a test. So, the informing + users/testers bit can be worked on, and the testing. Obviously we're going + to want something more robust that a 20 LOC Makefile pretty fast. diff --git a/bin/Makefile b/bin/Makefile index 039f596..307e81f 100644 --- a/bin/Makefile +++ b/bin/Makefile @@ -27,10 +27,10 @@ simpled: python -m pdb ../bin/ooniprobe ../nettests/simpletest.py -a ../ooni/assets/hostnames.txt
echot: - ../bin/ooniprobe ../ooni/echo.py -f ../ooni/assets/hostnames.txt + ../bin/ooniprobe ../nettests/core/echo.py -f ../ooni/assets/hostnames.txt
echod: - python -m pdb ../bin/ooniprobe ../ooni/echo.py -f ../ooni/assets/hostnames.txt + python -m pdb ../bin/ooniprobe ../nettests/core/echo.py -f ../ooni/assets/hostnames.txt
captivet: ../bin/ooniprobe ../nettests/core/captiveportal.py -f ../ooni/assets/hostnames.txt @@ -38,5 +38,17 @@ captivet: captived: python -m pdb ../bin/ooniprobe --spew ../nettests/core/captiveportal.py -f ../ooni/assets/hostnames.txt
-mvreports: - for $report in `find ../ -name "report*"`; do mv $report test-results ; done +dnst: + ../bin/ooniprobe ../nettests/core/dnstamper.py -f ../ooni/assets/hostnames.txt + +dnsd: + python -m pdb ../bin/ooniprobe --spew ../nettests/core/dnstamper.py -f ../ooni/assets/hostnames.txt + +squidt: + ../bin/ooniprobe ../nettests/core/squid.py -f ../ooni/assets/hostnames.txt + +squidd: + python -m pdb ../bin/ooniprobe --spew ../nettests/core/squid.py -f ../ooni/assets/hostnames.txt + +#mvreports: +# for $report in `find ../ -name "report*"`; do mv $report test-results #; done