This is an automated email from the git hooks/post-receive script.
pierov pushed a commit to branch geckoview-99.0.1-11.0-1 in repository tor-browser.
commit a6f506346a54345333369432db9ff1dc0deb8507 Author: Daisuke Akatsuka daisuke@birchill.co.jp AuthorDate: Thu Jan 13 00:35:54 2022 +0000
Bug 1749740: Add a tooltip for the X close button. r=adw, a=RyanVM,dsmith
Differential Revision: https://phabricator.services.mozilla.com/D135755 --- browser/components/urlbar/content/firefoxSuggest.ftl | 3 +++ browser/components/urlbar/content/quicksuggestOnboarding.html | 3 ++- .../quicksuggest/browser/browser_quicksuggest_onboardingDialog.js | 3 ++- 3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/browser/components/urlbar/content/firefoxSuggest.ftl b/browser/components/urlbar/content/firefoxSuggest.ftl index 15b9f4b9d6d3a..6d493da40fb17 100644 --- a/browser/components/urlbar/content/firefoxSuggest.ftl +++ b/browser/components/urlbar/content/firefoxSuggest.ftl @@ -110,6 +110,9 @@ firefox-suggest-onboarding-introduction-title-7 =
##
+firefox-suggest-onboarding-introduction-close-button = + .title = Close + firefox-suggest-onboarding-introduction-next-button-1 = Find out how firefox-suggest-onboarding-introduction-next-button-2 = Find out more
diff --git a/browser/components/urlbar/content/quicksuggestOnboarding.html b/browser/components/urlbar/content/quicksuggestOnboarding.html index f179674131941..cdcdf2debcc6d 100644 --- a/browser/components/urlbar/content/quicksuggestOnboarding.html +++ b/browser/components/urlbar/content/quicksuggestOnboarding.html @@ -22,8 +22,9 @@ aria-labelledby="introduction-title"> <section id="introduction-section"> <button id="onboardingClose" + class="ghost-button" tabindex="2" - class="ghost-button"> + data-l10n-id="firefox-suggest-onboarding-introduction-close-button"> <img src="chrome://global/skin/icons/close.svg" /> </button> <span class="logo" role="presentation"></span> diff --git a/browser/components/urlbar/tests/quicksuggest/browser/browser_quicksuggest_onboardingDialog.js b/browser/components/urlbar/tests/quicksuggest/browser/browser_quicksuggest_onboardingDialog.js index 3b9049b96f375..4900a8ac9091e 100644 --- a/browser/components/urlbar/tests/quicksuggest/browser/browser_quicksuggest_onboardingDialog.js +++ b/browser/components/urlbar/tests/quicksuggest/browser/browser_quicksuggest_onboardingDialog.js @@ -176,9 +176,10 @@ add_task(async function close() { info("Calling showOnboardingDialog"); const { win, maybeShowPromise } = await showOnboardingDialog();
- info("Check the visibility of the close button"); + info("Check the status of the close button"); const closeButton = win.document.getElementById("onboardingClose"); Assert.ok(BrowserTestUtils.is_visible(closeButton)); + Assert.equal(closeButton.getAttribute("title"), "Close");
info("Click on the close button"); closeButton.click();