commit c616f457762117cbcbb982a0224d9f8eb2cd9419 Author: teor teor@torproject.org Date: Fri Apr 5 15:10:36 2019 +1000
binascii: Fix the base64_encode_nopad() buffer length requirement
Comment-only change.
Part of 29660. --- src/lib/encoding/binascii.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/lib/encoding/binascii.c b/src/lib/encoding/binascii.c index 187df3424..fc64e014e 100644 --- a/src/lib/encoding/binascii.c +++ b/src/lib/encoding/binascii.c @@ -321,8 +321,10 @@ base64_encode(char *dest, size_t destlen, const char *src, size_t srclen, return (int) enclen; }
-/** As base64_encode, but do not add any internal spaces or external padding - * to the output stream. */ +/** As base64_encode, but do not add any internal spaces, and remove external + * padding from the output stream. + * dest must be at least base64_encode_size(srclen, 0), including space for + * the removed external padding. */ int base64_encode_nopad(char *dest, size_t destlen, const uint8_t *src, size_t srclen)