Richard Pospesel pushed to branch tor-browser-102.10.0esr-12.5-1 at The Tor Project / Applications / Tor Browser
Commits: be0f6ede by Pier Angelo Vendrame at 2023-04-04T10:10:45+02:00 Bug 1774413: Bundled fonts are not picked up on macOS r=jfkthame
Bundled fonts were not picked up because also child processes need to register them. Also, they were assigned User visibility, instead of Base, which was not coherent with other platforms.
Differential Revision: https://phabricator.services.mozilla.com/D150400 - - - - - ae81fad1 by Pier Angelo Vendrame at 2023-04-04T10:10:45+02:00 Bug 1769030: Add a configure flag to load policies only from the local policies.json file r=mkaply,glandium
Add a configuration flag to make Enterprise Policies mechanism only consult a policies.json file (avoiding the Windows Registry, macOS's file system attributes, and /etc/firefox/policies/policies.json on other OS).
Differential Revision: https://phabricator.services.mozilla.com/D146300
- - - - - ff315642 by Jamie Nicol at 2023-04-04T10:10:45+02:00 Bug 1784588 - Fix SplitDriverVersion when the string has less than 4 numbers. r=aosmond
Differential Revision: https://phabricator.services.mozilla.com/D154897 - - - - - f05871e4 by Pier Angelo Vendrame at 2023-04-04T10:10:46+02:00 Bug 1768907 - Part 1: Make browser.privatebrowsing.autostart a static pref. r=handyman,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D157843
- - - - - 29c9a87e by Neill Miller at 2023-04-04T10:10:46+02:00 Bug 1768907 - Part 2: nsTransferable disk-leaks when private browsing mode is enabled by default. r=handyman
nsTransferable was modified to prevent disk leakings when copying data in private browsing mode with Bug 1123480. However, the context is nullptr when it is initialized, so it still leaks if PBM is enabled by default. Our solution is to check the browser.privatebrowsing.autostart in this condition.
Differential Revision: https://phabricator.services.mozilla.com/D157800 - - - - - dee0f57f by Gabriele Svelto at 2023-04-04T10:10:47+02:00 Bug 1670885 - Fix post-fork() handlers for PHC/LogAlloc to work on macOS using unfair locks r=glandium
macOS unfair locks enforce that a lock can only be released by the thread which locked it.
On macOS 11+ this caused the fork()'d child process to raise a SIGILL signal. Confusingly enough this behavior seems to be different on macOS 10.15 and possibly interacted in odd ways with our exception handler if it was installed before fork()-ing.
Differential Revision: https://phabricator.services.mozilla.com/D148287 - - - - - 39e4cc51 by Gabriele Svelto at 2023-04-04T10:10:47+02:00 Bug 1670885 - Replace deprecated NSSpinLocks with os_unfair_locks in the memory allocator r=glandium
Depends on D148287
Differential Revision: https://phabricator.services.mozilla.com/D99280 - - - - - a4f37bbf by Gabriele Svelto at 2023-04-04T10:10:47+02:00 Bug 1774458 - Use undocumented, non-public adaptive spinlocks on macOS 10.15+, revert to user-space spinlocks on older versions r=pbone
Differential Revision: https://phabricator.services.mozilla.com/D149599 - - - - - cd4fb43b by Gabriele Svelto at 2023-04-04T10:10:48+02:00 Bug 1784018 - Remove deprecated OSSpinLocks r=glandium
On macOS versions prior to 10.15 os_unfair_locks cannot spin in kernel-space which degrades performance significantly. To obviate for this we spin in user-space like OSSpinLock does, for the same number of times and invoking x86-specific pause instructions in-between the locking attempts to avoid starving a thread that might be running on the same physical core.
Differential Revision: https://phabricator.services.mozilla.com/D154205 - - - - - ff524e0f by Rob Wu at 2023-04-04T10:12:32+02:00 Bug 1802385 - Use NS_GetFinalChannelURI in FetchDriver r=rpl,valentin
Depends on D164656
Differential Revision: https://phabricator.services.mozilla.com/D166108
- - - - - f441f43c by Kash Shampur at 2023-04-04T10:12:33+02:00 Bug 1803109 - Discard blocks of data that are too big for two chunks. r=canaltinova
Currently, `ReserveAndPutRaw` allocates a second span even if the data would be too big for the chunk. Here a second conditional is added to check if the block of data is too big in this scenario and silently discard the data if so.
Differential Revision: https://phabricator.services.mozilla.com/D167167 - - - - - 30970659 by Pier Angelo Vendrame at 2023-04-04T10:12:33+02:00 Bug 1814416: Generalize the app name in about:buildconfig. r=ahochheiden
Now it displays app display name, instead of having Firefox hardcoded.
Differential Revision: https://phabricator.services.mozilla.com/D168562 - - - - - 8d444ef4 by Pier Angelo Vendrame at 2023-04-04T10:12:33+02:00 Bug 1817756 - Add a seed to the network ID. r=valentin,necko-reviewers
This helps to prevent linkability of users in the same network.
Differential Revision: https://phabricator.services.mozilla.com/D170373 - - - - - 6e89b068 by Georg Koppen at 2023-04-04T10:12:34+02:00 Revert "Bug 1724777, optimize suppressed MicroTask handling, r=mccr8 a=RyanVM"
This reverts commit 1eb1364357ac5bc2a4531337fb5416af39c3793f.
This fixes tor-browser#40721, tor-browser#40698, and tor-browser#40706. However, it is a temporary workaround, that we should revert once https://bugzilla.mozilla.org/show_bug.cgi?id=1744719 is fixed.
- - - - - fe263b2e by Henry Wilkes at 2023-04-04T10:12:34+02:00 Bug 41454: Move focus after calling openPreferences for a sub-category.
Temporary fix until mozilla bug 1799153 gets a patch upstream.
- - - - - bc39624e by Henry Wilkes at 2023-04-04T10:12:35+02:00 Bug 41483: Remove the firefox override for appstrings.properties
Remove this patch after upstream bugzilla bug 1790187
- - - - - badf4b57 by Pier Angelo Vendrame at 2023-04-04T10:12:36+02:00 Bug 41116: Normalize system fonts.
System fonts are an enormous fingerprinting vector. Even with font allow lists and with our custom configuration on Linux, which counter metrics measurements, getComputedStyle leaks several details. This patch counters both these kinds of attacks.
- - - - - 046d4fc2 by Marco Simonelli at 2023-04-04T10:31:37+02:00 Bug 41459: WebRTC fails to build under mingw (Part 1)
- properly define NOMINMAX for just MSVC builds
- - - - - 3daeb2e9 by Marco Simonelli at 2023-04-04T10:31:45+02:00 Bug 41459: WebRTC fails to build under mingw (Part 2)
- fixes required to build third_party/libwebrtc
- - - - - fe48d4a5 by Richard Pospesel at 2023-04-04T10:31:45+02:00 fixup! Bug 41459: WebRTC fails to build under mingw (Part 2)
- - - - - afc62d14 by Marco Simonelli at 2023-04-04T10:31:46+02:00 Bug 41459: WebRTC fails to build under mingw (Part 3)
- fixes required to build third_party/sipcc
- - - - - 21d84125 by Richard Pospesel at 2023-04-04T10:31:46+02:00 fixup! Bug 41459: WebRTC fails to build under mingw (Part 3)
- - - - - f7336951 by Pier Angelo Vendrame at 2023-04-04T10:31:47+02:00 fixup! Bug 41459: WebRTC fails to build under mingw (Part 3)
Fix build error
- - - - - b703e8f5 by Marco Simonelli at 2023-04-04T10:31:47+02:00 Bug 41459: WebRTC fails to build under mingw (Part 4)
- fixes requried to build netwerk/sctp
- - - - - a63f2046 by Marco Simonelli at 2023-04-04T10:31:48+02:00 Bug 41459: WebRTC fails to build under mingw (Part 5)
- fixes required to build dom/media/webrtc
- - - - - 2e29c765 by Marco Simonelli at 2023-04-04T10:31:48+02:00 Bug 41459: WebRTC fails to build under mingw (Part 6)
- fixes required to build dom/media/systemservices
- - - - - 440e5b75 by Gaba at 2023-04-04T10:31:48+02:00 Adding issue and merge request templates
- - - - - 368f79a0 by Pier Angelo Vendrame at 2023-04-04T10:31:49+02:00 Base Browser's .mozconfigs.
Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan.
Bug 21849: Don't allow SSL key logging.
Bug 25741 - TBA: Disable features at compile-time
Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION
Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds
This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android.
Bug 29859: Disable HLS support for now
Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING
Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT
Bug 33734: Set MOZ_NORMANDY to False
Bug 33851: Omit Parental Controls.
Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files
Bug 41584: Move some configuration options to base-browser level
- - - - - 62e78d01 by Pier Angelo Vendrame at 2023-04-04T10:32:59+02:00 fixup! Base Browser's .mozconfigs.
Bug 41647: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros
Removed the --enable-base-browser flag and the BASE_BROWSER macro and added --with-base-browser-version to the -dev mozconfig.
- - - - - b113a46d by Pier Angelo Vendrame at 2023-04-04T10:33:08+02:00 fixup! Base Browser's .mozconfigs.
Bug 41668: Port some updater patches to Base Browser
- - - - - 69918201 by Pier Angelo Vendrame at 2023-04-04T10:33:08+02:00 fixup! Base Browser's .mozconfigs.
Bug 41677: Fix updater settings for Android
- - - - - b15e20cc by Pier Angelo Vendrame at 2023-04-04T10:33:09+02:00 fixup! Base Browser's .mozconfigs.
Bug 41684: Fix Android mozconfigs for local dev builds
- - - - - aa4348d0 by Pier Angelo Vendrame at 2023-04-04T10:33:09+02:00 Tweaks to the build system
Bug 40857: Modified the fat .aar creation file
This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build.
We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch.
See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770.
Bug 41458: Prevent `mach package-multi-locale` from actually creating a package
macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it.
- - - - - 7b597d4c by Dan Ballard at 2023-04-04T10:33:10+02:00 Bug 41117: using MOZ_PROXY_BYPASS_PROTECTION disable share menu on mac and windows, and restore email link on mac
- - - - - 6fa3f206 by Pier Angelo Vendrame at 2023-04-04T10:33:23+02:00 Bug 41108: Remove privileged macOS installation from 102
- - - - - 377f8086 by Pier Angelo Vendrame at 2023-04-04T10:33:23+02:00 fixup! Bug 41108: Remove privileged macOS installation from 102
Bug 41647: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros
Changed BASE_BROWSER with BASE_BROWSER_VERSION.
- - - - - 33eb7e22 by Dan Ballard at 2023-04-04T10:33:24+02:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies
- - - - - c8546adc by Pier Angelo Vendrame at 2023-04-04T10:33:24+02:00 fixup! Bug 41149: Re-enable DLL injection protection in all builds not just nightlies
Bug 41647: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros
Changed BASE_BROWSER with BASE_BROWSER_VERSION.
- - - - - 190712b4 by Matthew Finkel at 2023-04-04T10:33:24+02:00 Bug 24796: Comment out excess permissions from GeckoView
The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing.
- - - - - b8c342fc by Matthew Finkel at 2023-04-04T10:33:25+02:00 Bug 28125: Prevent non-Necko network connections
- - - - - badd81bd by Mike Perry at 2023-04-04T10:33:25+02:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth
The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602
- - - - - 6f004c7d by Alex Catarineu at 2023-04-04T10:33:26+02:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899
- - - - - e5125766 by Georg Koppen at 2023-04-04T10:33:26+02:00 Bug 16285: Exclude ClearKey system for now
In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past.
- - - - - 677d326f by Kathy Brade at 2023-04-04T10:33:26+02:00 Bug 21431: Clean-up system extensions shipped in Firefox
Only ship the pdfjs extension.
- - - - - 4a32ff98 by Kathy Brade at 2023-04-04T10:33:27+02:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc.
Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps.
Disable the "Create New Login" button when security.nocertdb is true.
- - - - - 175494ae by Alex Catarineu at 2023-04-04T10:33:27+02:00 Bug 41457: Remove Mozilla permissions
Bug 40025: Remove Mozilla add-on install permissions
- - - - - 29c25a0f by Kathy Brade at 2023-04-04T10:33:28+02:00 Bug 40002: Remove about:ion
Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser.
Bug 41662: Disable about:sync-logs
Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component.
- - - - - 14e2d8e7 by Arthur Edelstein at 2023-04-04T10:33:28+02:00 Bug 26353: Prevent speculative connect that violated FPI.
Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term.
- - - - - a7228221 by Alex Catarineu at 2023-04-04T10:33:28+02:00 Bug 31740: Remove some unnecessary RemoteSettings instances
More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls.
Avoid creating instance for 'anti-tracking-url-decoration'.
If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'.
Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps.
We also clear the collections database on the v2 -> v3 migration.
- - - - - cbe0efbf by Pier Angelo Vendrame at 2023-04-04T10:33:29+02:00 fixup! Bug 31740: Remove some unnecessary RemoteSettings instances
Bug 41647: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros
Changed BASE_BROWSER with BASE_BROWSER_VERSION.
- - - - - c1ec12a3 by Pier Angelo Vendrame at 2023-04-04T10:33:29+02:00 fixup! Bug 31740: Remove some unnecessary RemoteSettings instances
Bug 40788: Tor Browser is phoning home
The hijack-list component is the only remaining one calling home. This is a temporary workaround, to use the remote settings.
We should do something like this commit at a more generic level, for all RemoteSettings users.
(cherry picked from commit 2a2e87c3dbc2a98a9ff6387dd278cb2643323b6d) - - - - - cde43cca by Pier Angelo Vendrame at 2023-04-04T10:33:30+02:00 fixup! Bug 31740: Remove some unnecessary RemoteSettings instances
Bug 41704: Immediately return on remoteSettings.pollChanges
- - - - - 49bbcf7b by Pier Angelo Vendrame at 2023-04-04T10:33:30+02:00 Revert "fixup! Bug 31740: Remove some unnecessary RemoteSettings instances"
This reverts commit 34ed82f6c02a8dc5ed8390fa664e2f63aeadc303.
- - - - - f870a976 by Pier Angelo Vendrame at 2023-04-04T10:33:30+02:00 Bug 41635: Disable the Normandy component
Do not include Normandy at all whenever MOZ_NORMANDY is False.
- - - - - c7d7d1a4 by Georg Koppen at 2023-04-04T10:33:31+02:00 Bug 30541: Disable WebGL readPixel() for web content
Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034
- - - - - 6e1214e0 by Alex Catarineu at 2023-04-04T10:33:31+02:00 Bug 28369: Stop shipping pingsender executable
- - - - - 1eb3d4c7 by cypherpunks1 at 2023-04-04T10:33:32+02:00 Bug 41565: Gate Telemetry Tasks behind MOZ_TELEMETRY_REPORTING
- - - - - a4b67994 by cypherpunks1 at 2023-04-04T10:33:32+02:00 Bug 41568: Disable LaterRun
- - - - - d5a5ab89 by cypherpunks1 at 2023-04-04T10:33:32+02:00 Bug 40717: Hide Windows SSO in settings
(cherry picked from commit 1bacd26df8a8ffe481e11ec6b8323150fdf2011d) - - - - - 3ab3b57e by Pier Angelo Vendrame at 2023-04-04T10:33:33+02:00 Bug 40788: Prevent nsIURLQueryStrippingListService from calling home when it is not enabled.
The URL query stripping service is enabled only in nightly builds, still it is initialized and remote settings are downloaded. This adds a condition that prevents the service from being initialized if disabled.
Upstream Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1812594 We should remove this patch if Mozilla decides that this is a problem also for them, or if they do not but we decide to use the feature.
- - - - - eff1249f by Pier Angelo Vendrame at 2023-04-04T10:33:33+02:00 Bug 41599: Always return an empty string as network ID
Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users.
We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756
- - - - - 849c3398 by Pier Angelo Vendrame at 2023-04-04T10:33:34+02:00 fixup! Bug 41599: Always return an empty string as network ID
Bug 41647: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros
Changed BASE_BROWSER with BASE_BROWSER_VERSION.
- - - - - bc56c3cb by Mike Perry at 2023-04-04T10:33:34+02:00 Firefox preference overrides.
This hack directly includes our preference changes in omni.ja.
Bug 18292: Staged updates fail on Windows
Temporarily disable staged updates on Windows.
Bug 18297: Use separate Noto JP,KR,SC,TC fonts
Bug 23404: Add Noto Sans Buginese to the macOS whitelist
Bug 23745: Set dom.indexedDB.enabled = true
Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera@riseup.net>)
Bug 17252: Enable session identifiers with FPI
Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers".
The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049)
Bug 14952: Enable http/2 and AltSvc
In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2".
Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well.
(All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.)
However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false.
"network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197.
Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites
Enable ReaderView mode again (#27281).
Bug 29916: Make sure enterprise policies are disabled
Bug 2874: Block Components.interfaces from content
Bug 26146: Spoof HTTP User-Agent header for desktop platforms
In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs.
Bug 12885: Windows Jump Lists fail for Tor Browser
Jumplist entries are stored in a binary file in: %APPDATA%\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms
The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller.
However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past.
The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted.
Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996.
Bug 30845: Make sure default themes and other internal extensions are enabled
Bug 28896: Enable extensions in private browsing by default
Bug 31065: Explicitly allow proxying localhost
Bug 31598: Enable letterboxing
Disable Presentation API everywhere
Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels.
Bug 32321: Disable Mozilla's MitM pings
Bug 19890: Disable installation of system addons
By setting the URL to "" we make sure that already installed system addons get deleted as well.
Bug 22548: Firefox downgrades VP9 videos to VP8.
On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8.
This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available".
Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs
Bug 16441: Suppress "Reset Tor Browser" prompt.
Bug 29120: Use the in-memory media cache and increase its maximum size.
Bug 33697: use old search config based on list.json
Bug 33855: Ensure that site-specific browser mode is disabled.
Bug 30682: Disable Intermediate CA Preloading.
Bug 40061: Omit the Windows default browser agent from the build
Bug 40322: Consider disabling network.connectivity-service.enabled
Bug 40408: Disallow SVG Context Paint in all web content
Bug 40308: Disable network partitioning until we evaluate dFPI
Bug 40322: Consider disabling network.connectivity-service.enabled
Bug 40383: Disable dom.enable_event_timing
Bug 40423: Disable http/3
Bug 40177: Update prefs for Fx91esr
Bug 40700: Disable addons and features recommendations
Bug 40682: Disable network.proxy.allow_bypass
Bug 40736: Disable third-party cookies in PBM
Bug 19850: Enabled HTTPS-Only by default
Bug 40912: Hide the screenshot menu
Bug 41292: Disable moreFromMozilla in preferences page
Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector
Bug 24686: Set network.http.tailing.enabled to true
Bug 40183: Disable TLS ciphersuites using SHA-1
Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102
We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them.
- - - - - 5346b6f8 by Pier Angelo Vendrame at 2023-04-04T10:33:34+02:00 fixup! Firefox preference overrides.
Bug 41647: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros
Changed TOR_BROWSER_VERSION with BASE_BROWSER_VERSION.
- - - - - f4fdbba5 by hackademix at 2023-04-04T10:33:35+02:00 fixup! Firefox preference overrides.
- - - - - aba403e3 by Pier Angelo Vendrame at 2023-04-04T10:33:35+02:00 fixup! Firefox preference overrides.
Bug 41668: Port some updater patches to Base Browser
Do not change app.update.auto in firefox.js, but add it to 001.
- - - - - b8f4b410 by Pier Angelo Vendrame at 2023-04-04T10:33:36+02:00 fixup! Firefox preference overrides.
Bug 41683: Disable the network process on Windows
- - - - - 79f97899 by Pier Angelo Vendrame at 2023-04-04T10:33:36+02:00 fixup! Firefox preference overrides.
Bug 41689: Do not customize startup.homepage_override_url in Base Browser.
(cherry picked from commit eff20896dedc966b4162bfa098a6dc065faf30eb) - - - - - b9584233 by Richard Pospesel at 2023-04-04T10:33:36+02:00 fixup! Firefox preference overrides.
Bug 41701: Reporting an extension does not work
- - - - - a36090e5 by Richard Pospesel at 2023-04-04T10:33:37+02:00 Bug 41659: Add canonical color definitions to base-browser
- - - - - 0b0bae79 by Pier Angelo Vendrame at 2023-04-04T10:33:37+02:00 Bug 41043: Hardcode the UI font on Linux
The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version.
Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese).
- - - - - cac51024 by Alex Catarineu at 2023-04-04T10:33:38+02:00 Bug 30605: Honor privacy.spoof_english in Android
This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly.
Bug 40198: Expose privacy.spoof_english pref in GeckoView
- - - - - 2da3bcd6 by Alex Catarineu at 2023-04-04T10:33:38+02:00 Bug 40199: Avoid using system locale for intl.accept_languages in GeckoView
- - - - - e513c5c2 by Alex Catarineu at 2023-04-04T10:33:38+02:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware
- - - - - 168c6f83 by Alex Catarineu at 2023-04-04T10:33:39+02:00 Bug 26345: Hide tracking protection UI
- - - - - 68369f24 by Pier Angelo Vendrame at 2023-04-04T10:49:14+02:00 Bug 9173: Change the default Firefox profile directory to be relative.
This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows.
On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle.
This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS).
- - - - - 74e04deb by Kathy Brade at 2023-04-04T10:49:26+02:00 Bug 18800: Remove localhost DNS lookup in nsProfileLock.cpp
Instead of using the local computer's IP address within symlink-based profile lock signatures, always use 127.0.0.1.
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1769028
- - - - - b3d8a441 by Alex Catarineu at 2023-04-04T10:49:27+02:00 Bug 27604: Fix addon issues when moving the profile directory
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838
- - - - - e94d25af by Mike Perry at 2023-04-04T10:49:27+02:00 Bug 13028: Prevent potential proxy bypass cases.
It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident.
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509
- - - - - 6e861d14 by Igor Oliveira at 2023-04-04T10:49:28+02:00 Bug 23104: Add a default line height compensation
Many fonts have issues with their vertical metrics. they are used to influence the height of ascenders and depth of descenders. Gecko uses it to calculate the line height (font height + ascender + descender), however because of that idiosyncratic behavior across multiple operating systems, it can be used to identify the user's OS.
The solution proposed in the patch uses a default factor to be multiplied with the font size, simulating the concept of ascender and descender. This way all operating systems will have the same line height only and only if the frame is outside the chrome.
- - - - - 9291cdd2 by Pier Angelo Vendrame at 2023-04-04T10:49:28+02:00 Bug 40309: Avoid using regional OS locales
Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled.
- - - - - e007176f by Matthew Finkel at 2023-04-04T10:49:28+02:00 Bug 40432: Prevent probing installed applications
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084
- - - - - a00f1e14 by hackademix at 2023-04-04T10:49:29+02:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs.
- - - - - b2a64169 by hackademix at 2023-04-04T10:49:29+02:00 Bug 41434: Letterboxing, improve logging.
- - - - - 971255f2 by hackademix at 2023-04-04T10:49:30+02:00 Bug 31064: Letterboxing, exempt browser extensions.
- - - - - 43b855b9 by hackademix at 2023-04-04T10:49:30+02:00 Bug 32411: Letterboxing, exempt view-source: URIs.
- - - - - 1716b70d by hackademix at 2023-04-04T10:49:30+02:00 Bug 32308: use direct browser sizing for letterboxing.
- - - - - ea5fc1ec by hackademix at 2023-04-04T10:49:31+02:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations
- - - - - bff4680a by Pier Angelo Vendrame at 2023-04-04T10:49:31+02:00 Bug 41369: Improve Firefox language settings for multi-lingual packages
Change the language selector to be sorted by language code, rather than name, and to display the language code to the user.
Bug 41372: Handle Japanese as a special case in preferences on macOS
Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs.
Bug 41378: Tell users that they can change their language at the first start
With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once.
- - - - - 1b7d7bca by Pier Angelo Vendrame at 2023-04-04T10:49:32+02:00 fixup! Bug 41369: Improve Firefox language settings for multi-lingual packages
Bug 41698: Reword the recommendation badges in about:addons
We need to add a new commit for all base browser strings
- - - - - 54a43376 by Henry Wilkes at 2023-04-04T10:49:32+02:00 Bug 41371: Temporary hack to fix language selector popup position
- - - - - bad85a45 by Pier Angelo Vendrame at 2023-04-04T10:49:33+02:00 Bug 41417: Always prompt users to restart after changing language
This is a temporary patch that we need until we switch our strings to Fluent. The reason is that we currently set strings when we populate our XUL content. We could rework the whole mechanism, but it is not worth it because we want to switch to Fluent, which will handle everything automatically.
- - - - - 78fa5fee by p13dz at 2023-04-04T10:49:33+02:00 Bug 40283: Workaround for the file upload bug
(cherry picked from commit c23f2f397327ee46a1a4de57acf206fd83e8e170) - - - - - 03ff0ff0 by Arthur Edelstein at 2023-04-04T10:49:33+02:00 Bug 18905: Hide unwanted items from help menu
Bug 25660: Remove the "New Private Window" option
- - - - - 61e43055 by Pier Angelo Vendrame at 2023-04-04T10:49:34+02:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL
MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/.
- - - - - 4aa1f346 by Henry Wilkes at 2023-04-04T10:49:34+02:00 Bug 31575: Disable Firefox Home (Activity Stream)
Treat about:blank as the default home page and new tab page.
Avoid loading AboutNewTab in BrowserGlue.jsm in order to avoid several network requests that we do not need.
Bug 41624: Disable about:pocket-* pages and about:firefoxview.
Bug 40144: Redirect about:privatebrowsing to the user's home
- - - - - 174ebe86 by Pier Angelo Vendrame at 2023-04-04T10:49:35+02:00 fixup! Bug 31575: Disable Firefox Home (Activity Stream)
Bug 41647: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros
Changed BASE_BROWSER with BASE_BROWSER_VERSION.
- - - - - 7bdb54b9 by Pier Angelo Vendrame at 2023-04-04T10:49:35+02:00 Bug 41542: Disable the creation of a default profile
Firefox creates a profile as a fallback for old versions. However, we do not need this, so we want to prevent Firefox from creating the related directories.
We comment out the code, but should Mozilla be interested in a compile-time flag, we could rewrite the patch to add one.
See also https://bugzilla.mozilla.org/show_bug.cgi?id=1770174.
- - - - - 9218fb5e by Pier Angelo Vendrame at 2023-04-04T10:49:35+02:00 fixup! Bug 41542: Disable the creation of a default profile
Bug 41647: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros
Changed TOR_BROWSER_VERSION with BASE_BROWSER_VERSION.
- - - - - eb16c8cc by Kathy Brade at 2023-04-04T10:49:36+02:00 Bug 13379: Allow using NSS to sign and verify MAR signatures
Allow using NSS on all platforms for checking MAR signatures (instead of using OS-native APIs, the default on Mac OS and Windows). So that the NSS and NSPR libraries the updater depends on can be found at runtime, we add the firefox directory to the shared library search path on macOS. On Linux, rpath is used to solve that problem, but that approach won't work on macOS because the updater executable is copied during the update process to a location that can vary.
- - - - - 16f42e30 by Pier Angelo Vendrame at 2023-04-04T10:49:36+02:00 fixup! Bug 13379: Allow using NSS to sign and verify MAR signatures
Bug 41668: Port some updater patches to Base Browser
Use a configure-time flag to force using NSS for MARs signatures.
- - - - - 30ba3988 by Pier Angelo Vendrame at 2023-04-04T10:49:37+02:00 fixup! Bug 13379: Allow using NSS to sign and verify MAR signatures
Bug 41668: Port some updater patches to Base Browser
Avoid using -rpath on macOS.
- - - - - 136387cd by Kathy Brade at 2023-04-04T10:49:37+02:00 Bug 4234: Use the Firefox Update Process for Base Browser.
Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909.
Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update.
Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality.
Bug 26048: potentially confusing "restart to update" message
Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string.
Bug 28885: notify users that update is downloading
Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress.
As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process.
Removed #28885 parts of this patch which have been uplifted to Firefox.
- - - - - 1a2f12fb by Pier Angelo Vendrame at 2023-04-04T10:49:37+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser.
Bug 41647: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros
Changed TOR_BROWSER_VERSION with BASE_BROWSER_VERSION.
- - - - - 27e74537 by Pier Angelo Vendrame at 2023-04-04T10:49:38+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser.
Bug 41668: Port some updater patches to Base Browser
Move the check on the update package version to this other commit.
- - - - - f325a6bc by Pier Angelo Vendrame at 2023-04-04T10:49:38+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser.
Bug 41668: Port some updater patches to Base Browser
Rename TOR_BROWSER_UPDATE to BASE_BROWSER_UPDATE. Also, do not change app.update.auto in firefox.js, but add it to 001.
- - - - - a6ab4b56 by Pier Angelo Vendrame at 2023-04-04T10:49:39+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser.
Bug 41668: Port some updater patches to Base Browser
Changes that will need to remain when actually cherry-picking to base-browser, because they contain name fixes, for example. Or, for UpdateService.jsm, they need to stay because they make the patch more understandable.
- - - - - 32b0c6ed by Pier Angelo Vendrame at 2023-04-04T10:49:39+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser.
Bug 41668: Port some updater patches to Base Browser
Remove Tor Browser-only additions to make the updater patches usable with Base Browser. This commit should be reverted, and become a commit on its own, to further adapt the updater to Tor Browser needs.
- - - - - cfc9319e by Pier Angelo Vendrame at 2023-04-04T10:49:39+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser.
Bug 41668: Port some updater patches to Base Browser
Fix a build error on Windows.
- - - - - 4b5c0a27 by Nicolas Vigier at 2023-04-04T10:49:40+02:00 Bug 41682: Add base-browser nightly mar signing key
- - - - - 48d6f9be by Pier Angelo Vendrame at 2023-04-04T10:49:40+02:00 Base Browser strings
This commit adds all the strings needed by following Base Browser patches.
- - - - - c9cdba48 by hackademix at 2023-04-04T10:49:41+02:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module
- - - - - b1c229b7 by Pier Angelo Vendrame at 2023-04-04T10:49:41+02:00 Bug 41698: Reword the recommendation badges in about:addons
Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them.
We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead.
Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033
- - - - - a63de36d by Alex Catarineu at 2023-04-04T10:49:41+02:00 Bug 40069: Add helpers for message passing with extensions
- - - - - d3becbdf by Matthew Finkel at 2023-04-04T10:49:42+02:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode.
- - - - - 3caac79e by Pier Angelo Vendrame at 2023-04-04T10:49:42+02:00 Bug 40925: Implemented the Security Level component
This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings.
Bug 40125: Expose Security Level pref in GeckoView
- - - - - 0c345330 by Henry Wilkes at 2023-04-04T15:31:59+02:00 fixup! Bug 40925: Implemented the Security Level component
Add cui-widget-panel class to the panel, which gives it the correct font.
- - - - - 622db29f by Pier Angelo Vendrame at 2023-04-04T15:31:59+02:00 Bug 40926: Implemented the New Identity feature
- - - - - b53567eb by Pier Angelo Vendrame at 2023-04-04T15:32:00+02:00 fixup! Bug 40926: Implemented the New Identity feature
Bug 41711: Wait for the new window when doing new identity
- - - - - ae868687 by Richard Pospesel at 2023-04-04T15:32:00+02:00 Bug 41649: Create rebase and security backport gitlab issue templates
- - - - - bf2a9526 by Richard Pospesel at 2023-04-04T15:32:00+02:00 Bug 41089: Add tor-browser build scripts + Makefile to tor-browser
- - - - - 0fb7d24e by Pier Angelo Vendrame at 2023-04-04T15:32:01+02:00 fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser
Bug 41684: Fix Android mozconfigs for local dev builds
The shell script matched x86 with x86_64. I do not know how to match an entire token in shell scripts, so I switched to a Python script, instead.
- - - - - 19b20c6a by Kathy Brade at 2023-04-04T15:32:01+02:00 Bug 11641: Disable remoting by default.
Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior.
- - - - - 5c899d82 by Mike Perry at 2023-04-04T15:32:02+02:00 Bug 2176: Rebrand Firefox to TorBrowser
See also Bugs #5194, #7187, #8115, #8219.
This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons.
Also fix bug 27905.
Bug 25702: Update Tor Browser icon to follow design guidelines
- Updated all of the branding in /browser/branding/official with new 'stable' icon series. - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory - Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654) - Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory - Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico) - Added default256.png and default512.png icons - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon - Use the Tor Browser icon within devtools/client/themes/images/.
Bug 30631: Blurry Tor Browser icon on macOS app switcher
It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil.
Bug 28196: preparations for using torbutton tor-browser-brand.ftl
A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser.
Bug 31803: Replaced about:debugging logo with flat version
Bug 21724: Make Firefox and Tor Browser distinct macOS apps
When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser.
Bug 32092: Fix Tor Browser Support link in preferences
For bug 40562, we moved onionPattern* from bug 27476 to here, as about:tor needs these files but it is included earlier.
Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one
- - - - - e73a37bc by Pier Angelo Vendrame at 2023-04-04T15:32:02+02:00 fixup! Bug 2176: Rebrand Firefox to TorBrowser
Bug 41689: Move the generic updated URL to the right place
- - - - - bb584c63 by Alex Catarineu at 2023-04-04T15:32:03+02:00 Bring back old Firefox onboarding
Revert "Bug 1462415 - Delete onboarding system add-on r=Standard8,k88hudson"
This reverts commit f7ffd78b62541d44d0102f8051d2f4080bdbc432.
Revert "Bug 1498378 - Actually remove the old onboarding add-on's prefs r=Gijs"
This reverts commit 057fe36fc6f3e93e265505c7dcc703a0941778e2.
Bug 28822: Convert onboarding to webextension
Partially revert 1564367 (controlCenter in UITour.jsm)
- - - - - 689345d4 by Henry Wilkes at 2023-04-04T15:33:55+02:00 fixup! Bring back old Firefox onboarding
Bug 41600 - We remove the additions for "controlCenter", i.e. the site identity panel, since the tor circuit display no longer lies within it, so our tour no longer uses it.
- - - - - 28f78753 by Kathy Brade at 2023-04-04T16:14:34+02:00 Bug 26961: New user onboarding.
Reuse the Firefox onboarding mechanism with minimal changes. Localizable strings are pulled in from Torbutton (if Torbutton is not installed, we lack about:tor and no tour will be shown). Replace SVG images with PNGs (see bug 27002), For defense in depth, omit include OnboardingTelemetry.jsm entirely. Added support for the following UITour page event: torBrowserOpenSecuritySettings
Also fix bug 27403: the onboarding bubble is not always displayed.
Arthur suggested to make the onboarding bubble visible on displays with less than 960px width available, so we choose 200px instead.
Also fix bug 28628: Change onboarding Security panel to open new Security Level panel.
Also fix bug 27484: Improve navigation within onboarding.
Bug 27082: enable a limited UITour
Disallow access to UITour functionality from all pages other than about:home, about:newtab, and about:tor. Implement a whitelist mechanism for page actions.
Bug 26962 - implement new features onboarding (part 1).
Add an "Explore" button to the "Circuit Display" panel within new user onboarding which opens the DuckDuckGo .onion and then guides users through a short circuit display tutorial.
Allow a few additional UITour actions while limiting as much as possible how it can be used.
Tweak the UITour styles to match the Tor Browser branding.
All user interface strings are retrieved from Torbutton's browserOnboarding.properties file.
Bug 27486 Avoid about:blank tabs when opening onboarding pages.
Instead of using a simple <a href>, programmatically open onboarding web pages by using tabBrowser.addTab(). The same technique is now used for "See My Path", "See FAQs", and "Visit an Onion".
Bug 29768: Introduce new features to users
Add an "update" tour for the Tor Browser 8.5 release that contains two panels: Toolbar and Security (with appropriate description text and images).
Display an attention-grabbing dot on the onboarding text bubble when the update tour is active. The animation lasts for 14 seconds.
Bug 31768: Introduce toolbar and network settings changes in onboarding
Update the "Tor Network" onboarding page to include a note that settings can now be accessed via the application preferences and add an "Adjust Your Tor Network Settings" action button which opens about:preferences#tor.
Replace the Tor Browser 8.5 "update" onboarding tour with a 9.0 one that includes the revised "Tor Network" page and a revised "Toolbar" page. The latter explains that Torbutton's toolbar item has been removed ("Goodbye Onion Button") and explains how to access the New Identity feature using the hamburger menu and new toolbar item.
Bug 34321 - Add Learn More onboarding item
Bug 40429: Update Onboarding for 10.5
- - - - - 77cdb8c7 by Henry Wilkes at 2023-04-04T16:15:00+02:00 fixup! Bug 26961: New user onboarding.
Bug 41600 - Change circuit display tour to use new button and panel.
This also fixes the "See My Path" button, which was broken before.
- - - - - 288586cb by sanketh at 2023-04-04T16:15:01+02:00 Bug 40209: Implement Basic Crypto Safety
Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning.
Closes #40209.
Bug 40428: Fix string attribute names
- - - - - 33f8b246 by Mike Perry at 2023-04-04T16:15:01+02:00 TB3: Tor Browser's official .mozconfigs.
Also: Add an --enable-tor-browser-data-outside-app-dir configure option
Add --with-tor-browser-version configure option
Bug 31457: disable per-installation profiles
The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data.
Bug 31935: Disable profile downgrade protection.
Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected.
Add --enable-tor-browser-update build option
Bug 40793: moved Tor configuration options from old-configure.in to moz.configure
Bug 41584: Move some configuration options to base-browser level
- - - - - 1c21c713 by Henry Wilkes at 2023-04-04T16:15:01+02:00 Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds
tor-browser#41285: Enable fluent warnings.
- - - - - 22758305 by Pier Angelo Vendrame at 2023-04-04T16:15:02+02:00 Bug 40562: Added Tor Browser preferences to 000-tor-browser.js
Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end.
In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply.
- - - - - fa55fc33 by hackademix at 2023-04-04T16:15:02+02:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js
- - - - - 2c4a4562 by Henry Wilkes at 2023-04-04T16:15:03+02:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js
Bug 41600 - Remove extensions.torbutton.display_circuit since it will no longer be used.
It also could not work as intended before because after disabling and re-enabling, all the circuits and browser credentials that were established whilst it was switched off would have been lost and were not recovered.
- - - - - 61aa6e49 by Pier Angelo Vendrame at 2023-04-04T16:15:03+02:00 Bug 13252: Customize profile management on macOS
On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode.
Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error.
- - - - - eb71bc29 by Pier Angelo Vendrame at 2023-04-04T16:15:03+02:00 Bug 40933: Add tor-launcher functionality
- - - - - 530b2162 by Pier Angelo Vendrame at 2023-04-04T19:45:50+02:00 fixup! Bug 40933: Add tor-launcher functionality
Bug 41709: Reimplement the failure logic for TorProtocolService.sendCommand
sendCommand tries to send a command forever every 250ms in case of failure. That is bad because some async code branch might be stuck in it forever.
We should have a number of maximum attempts and increase the delay after which we try again.
- - - - - 3ff3442d by Richard Pospesel at 2023-04-04T19:46:07+02:00 Bug 40597: Implement TorSettings module
- migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module - TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs - TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor - about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module - all tor settings live in the torbrowser.settings.* preference branch - removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm
Bug 40645: Migrate Moat APIs to Moat.jsm module
- - - - - 8b0fc790 by Alex Catarineu at 2023-04-04T19:46:07+02:00 Bug 10760: Integrate TorButton to TorBrowser core
Because of the non-restartless nature of Torbutton, it required a two-stage installation process. On mobile, it was a problem, because it was not loading when the user opened the browser for the first time.
Moving it to tor-browser and making it a system extension allows it to load when the user opens the browser for first time.
Additionally, this patch also fixes Bug 27611.
Bug 26321: New Circuit and New Identity menu items
Bug 14392: Make about:tor behave like other initial pages.
Bug 25013: Add torbutton as a tor-browser submodule
Bug 31575: Replace Firefox Home (newtab) with about:tor
- - - - - 3f92800f by Pier Angelo Vendrame at 2023-04-04T19:46:07+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core
Bug 40501: High CPU load after tor exits unexpectedly
When a peers (tor) disconnects, Firefox seems to keep the stream open, and return 0 on available, rather than throwing. So, as a matter of fact, we had a while trying to read 0 bytes without any pause in _readLine, hence the 100% CPU usage.
- - - - - 9d79898b by hackademix at 2023-04-04T19:46:08+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core
- - - - - f142bbf3 by Henry Wilkes at 2023-04-04T19:46:08+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core
Bug 41600 - Remove old circuit display.
- - - - - f335b937 by Henry Wilkes at 2023-04-04T19:46:09+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core
Bug 41600 - Add API to domain-isolator to get the stored SOCKS username and password for a given domain and user context ID.
Also get rid of unused newCircuitForUserContextId.
Also remove the return statement from tor-control-port's watchEvent since addNotificationCallback does not return a value.
- - - - - b16f52f3 by hackademix at 2023-04-04T19:46:09+02:00 Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs
- - - - - 4046a658 by Henry Wilkes at 2023-04-04T19:46:09+02:00 Bug 41600: Add a tor circuit display panel.
- - - - - 5c77f2c6 by Henry Wilkes at 2023-04-05T17:29:17+02:00 fixup! Bug 41600 - Add a tor circuit display panel.
- - - - - d6147627 by Amogh Pradeep at 2023-04-05T17:29:25+02:00 Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources.
See Bug 1357997 for partial uplift.
Also: Bug 28051 - Use our Orbot for proxying our connections
Bug 31144 - ESR68 Network Code Review
- - - - - c01e2d5e by Matthew Finkel at 2023-04-05T17:29:26+02:00 Bug 25741: TBA: Disable GeckoNetworkManager
The browser should not need information related to the network interface or network state, tor should take care of that.
- - - - - 6a429e12 by Alex Catarineu at 2023-04-05T17:29:26+02:00 Add TorStrings module for localization
- - - - - 6818ecc5 by Pier Angelo Vendrame at 2023-04-05T17:29:26+02:00 fixup! Add TorStrings module for localization
Restore the letterbox warning for 12.0
- - - - - 04ddfd20 by Henry Wilkes at 2023-04-05T17:29:27+02:00 fixup! Add TorStrings module for localization
Bug 41600 - Add new strings for the circuit display.
- - - - - 6ace50bf by Henry Wilkes at 2023-04-05T17:29:27+02:00 fixup! Add TorStrings module for localization
- - - - - 4491a2de by Pier Angelo Vendrame at 2023-04-06T10:23:45+02:00 fixup! Add TorStrings module for localization
Bug 41521: Improve localization notes
- - - - - bd6e41f4 by Kathy Brade at 2023-04-06T10:23:52+02:00 Bug 14631: Improve profile access error messages.
Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system".
To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts.
- - - - - ac746744 by Kathy Brade at 2023-04-06T10:23:52+02:00 Bug 19273: Avoid JavaScript patching of the external app helper dialog.
When handling an external URI or downloading a file, invoke Torbutton's external app blocker component (which will present a download warning dialog unless the user has checked the "Automatically download files from now on" box).
For e10s compatibility, avoid using a modal dialog and instead use a callback interface (nsIHelperAppWarningLauncher) to allow Torbutton to indicate the user's desire to cancel or continue each request.
Other bugs fixed: Bug 21766: Crash with e10s enabled while trying to download a file Bug 21886: Download is stalled in non-e10s mode Bug 22471: Downloading files via the PDF viewer download button is broken Bug 22472: Fix FTP downloads when external helper app dialog is shown Bug 22610: Avoid crashes when canceling external helper app downloads Bug 22618: Downloading pdf file via file:/// is stalling
- - - - - 49f44d37 by Pier Angelo Vendrame at 2023-04-06T10:23:53+02:00 Bug 40807: Added QRCode.js to toolkit/modules
- - - - - 803622ff by Richard Pospesel at 2023-04-06T10:23:53+02:00 Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present:
- Setting built-in bridges - Requesting bridges from BridgeDB via moat - Using user-provided bridges - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies - Setting firewall ports - Viewing and Copying Tor's logs - The Networking Settings in General preferences has been removed
Bug 40774: Update about:preferences page to match new UI designs
- - - - - 2e59d64a by Henry Wilkes at 2023-04-06T10:23:53+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
Bug 41600 - Update the SVG fetch update script for fetching bridge emojis and annotations, which we will also use for the flag emojis in the tor circuit display.
We also: + Placed the bridgemoji files in a sub-directory. + Added a generation note to the generated files/directory. + Split the bridge emoji list into an external file, which we fetch in connectionPane.js so that the generating file is less fragile to a change in the javascript. + Store the locale emoji annotations using the string hex value as the key, rather than the emoji string sequence. This keeps it in line with the SVG file names, and removes ambiguity about whether the emoji character sequence includes the emoji variant selector U+FE0F or not.
- - - - - 433dd49e by Richard Pospesel at 2023-04-06T10:23:54+02:00 Bug 27476: Implement about:torconnect captive portal within Tor Browser
- implements new about:torconnect page as tor-launcher replacement - adds tor connection status to url bar and tweaks UX when not online - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor - explicitly allows about:torconnect URIs to ignore Resist Fingerprinting (RFP) - various tweaks to info-pages.inc.css for about:torconnect (also affects other firefox info pages)
Bug 40773: Update the about:torconnect frontend page to match additional UI flows
- - - - - 3451137b by Dan Ballard at 2023-04-06T10:23:54+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser
bug 41526: make tor connection cancel button grey
- - - - - 15320bca by hackademix at 2023-04-06T10:23:55+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser
- - - - - e0d3a0ae by Dan Ballard at 2023-04-06T10:23:55+02:00 fixup! fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser
Bug 41526: revert removal of focus to cancle button + add prevention from keyboard input to trigger multiple buttons as focus switches
- - - - - 9b5887c6 by Arthur Edelstein at 2023-04-06T10:23:56+02:00 Bug 12620: TorBrowser regression tests
Regression tests for Bug #2950: Make Permissions Manager memory-only
Regression tests for TB4: Tor Browser's Firefox preference overrides.
Note: many more functional tests could be made here
Regression tests for #2874: Block Components.interfaces from content
Bug 18923: Add a script to run all Tor Browser specific tests
Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt.
- - - - - aef119cb by Pier Angelo Vendrame at 2023-04-06T10:23:56+02:00 Bug 41668: Tweaks to the Base Browser updater for Tor Browser
This commit was once part of "Bug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit.
- - - - - 1c0cc72e by Kathy Brade at 2023-04-06T10:23:56+02:00 Bug 12647: Support symlinks in the updater.
- - - - - f229b892 by Kathy Brade at 2023-04-06T10:23:57+02:00 Bug 19121: reinstate the update.xml hash check
This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122.
Revert most changes from Mozilla Bug 862173 "don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)."
We kept the addition to the AppConstants API in case other JS code references it in the future.
- - - - - e2700887 by Kathy Brade at 2023-04-06T10:23:58+02:00 Bug 16940: After update, load local change notes.
Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release).
Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts.
Also fix bug 29440. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor.
- - - - - 5f5ad377 by Pier Angelo Vendrame at 2023-04-06T10:24:37+02:00 fixup! Bug 16940: After update, load local change notes.
Bug 41521: Improve localization notes
- - - - - e70b349c by Georg Koppen at 2023-04-06T10:24:42+02:00 Bug 32658: Create a new MAR signing key
It's time for our rotation again: Move the backup key in the front position and add a new backup key.
Bug 33803: Move our primary nightly MAR signing key to tor-browser
Bug 33803: Add a secondary nightly MAR signing key
- - - - - bbb721fe by Mike Perry at 2023-04-06T10:24:43+02:00 Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed.
Also: Bug 16322: Update DuckDuckGo search engine
We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to bug 1061736 where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well.
Also: This fixes bug 20809: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly.
Also fixes bug 29798 by making sure we only specify the Google search engine we actually ship an .xml file for.
Also regression tests.
squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
Bug 40494: Update Startpage search provider
squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
Bug 40438: Add Blockchair as a search engine
Bug 33342: Avoid disconnect search addon error after removal.
We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore.
- - - - - e8f3d8cc by Alex Catarineu at 2023-04-06T10:24:43+02:00 Bug 40073: Disable remote Public Suffix List fetching
In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want.
- - - - - 2a10ce02 by Richard Pospesel at 2023-04-06T10:24:44+02:00 Bug 23247: Communicating security expectations for .onion
Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine.
Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services:
- HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure - HTTP Onion Service pages would be marked as unencrypted in the Page Info screen - Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content
This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content.
Strings for Onion Service Page Info page are pulled from Torbutton's localization strings.
- - - - - a85ccd69 by cypherpunks1 at 2023-04-06T10:24:48+02:00 fixup! Bug 23247: Communicating security expectations for .onion
Bug 41533: Fix onion detection on the page info window
- - - - - f7e09a92 by Kathy Brade at 2023-04-06T10:24:54+02:00 Bug 30237: Add v3 onion services client authentication prompt
When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key.
If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page.
If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt.
Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt.
Add support for onion services strings to the TorStrings module.
Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of bug 30025.
Also fixes bug 19757: Add a "Remember this key" checkbox to the client auth prompt.
Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk.
Also fixes bug 19251: use enhanced error pages for onion service errors.
- - - - - 091b61a6 by Alex Catarineu at 2023-04-06T10:24:55+02:00 Bug 21952: Implement Onion-Location
Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar.
- - - - - 06151bdd by Pier Angelo Vendrame at 2023-04-06T10:24:56+02:00 Bug 40458: Implement .tor.onion aliases
We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates.
- - - - - 8202b79d by Henry Wilkes at 2023-04-06T10:24:57+02:00 fixup! Bug 40458: Implement .tor.onion aliases
- - - - - 75a1ab1b by Pier Angelo Vendrame at 2023-04-06T10:24:57+02:00 Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser
This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation.
- - - - - 307d5a84 by Pier Angelo Vendrame at 2023-04-06T10:24:58+02:00 Bug 41435: Add a Tor Browser migration function
For now this function only deletes old language packs for which we are already packaging the strings with the application.
- - - - -
30 changed files:
- .eslintignore - .gitignore - + .gitlab/issue_templates/Backport Android Security Fixes.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - + .gitlab/issue_templates/UXBug.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - + browser/actors/AboutTBUpdateChild.jsm - + browser/actors/AboutTBUpdateParent.jsm - + browser/actors/CryptoSafetyChild.jsm - + browser/actors/CryptoSafetyParent.jsm - browser/actors/NetErrorChild.jsm - browser/actors/NetErrorParent.jsm - − browser/actors/RFPHelperChild.jsm - − browser/actors/RFPHelperParent.jsm - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/permissions - + browser/app/profile/000-tor-browser.js - + browser/app/profile/001-base-profile.js - browser/app/profile/firefox.js - browser/base/content/aboutDialog-appUpdater.js - browser/base/content/aboutDialog.js - browser/base/content/aboutDialog.xhtml - + browser/base/content/abouttbupdate/aboutTBUpdate.css - + browser/base/content/abouttbupdate/aboutTBUpdate.js - + browser/base/content/abouttbupdate/aboutTBUpdate.xhtml
The diff was not included because it is too large.
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/0c4c377...