
Pier Angelo Vendrame pushed to branch tor-browser-128.9.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: a6eda23a by Henry Wilkes at 2025-04-08T17:23:52+00:00 fixup! TB 41668: Tweaks to the Base Browser updater for Tor Browser TB 43567: Drop torbrowser.post_update.url. Also, no longer require an override page to be set to open about:tor after an update. - - - - - 4ef1a8dd by Henry Wilkes at 2025-04-08T17:23:52+00:00 fixup! TB 7494: Create local home page for TBB. TB 43567: Use the same update URL in about:tor as the about dialog. - - - - - bb06f3c6 by Henry Wilkes at 2025-04-08T17:23:52+00:00 fixup! TB 41435: Add a Tor Browser migration function TB 43567: Clear torbrowser.post_update.url. - - - - - 3 changed files: - browser/components/BrowserContentHandler.sys.mjs - browser/components/BrowserGlue.sys.mjs - browser/components/abouttor/AboutTorMessage.sys.mjs Changes: ===================================== browser/components/BrowserContentHandler.sys.mjs ===================================== @@ -876,18 +876,12 @@ nsBrowserContentHandler.prototype = { "%OLD_BASE_BROWSER_VERSION%", old_forkVersion ); - if (overridePage && AppConstants.BASE_BROWSER_UPDATE) { + if (AppConstants.BASE_BROWSER_UPDATE) { // Tor Browser: Instead of opening the post-update "override page" // directly, we ensure that about:tor will be opened, which should // notify the user that their browser was updated. - // - // The overridePage comes from the openURL attribute within the - // updates.xml file or, if no showURL action is present, from the - // startup.homepage_override_url pref. - Services.prefs.setCharPref( - "torbrowser.post_update.url", - overridePage - ); + // NOTE: We ignore any overridePage value, which can come from the + // openURL attribute within the updates.xml file. Services.prefs.setBoolPref( "torbrowser.post_update.shouldNotify", true ===================================== browser/components/BrowserGlue.sys.mjs ===================================== @@ -4830,7 +4830,9 @@ BrowserGlue.prototype = { // Version 6: Tor Browser 14.5a3: Clear preference for TorSettings that is // no longer used (tor-browser#41921). // Drop unused TorConnect setting (tor-browser#43462). - const TBB_MIGRATION_VERSION = 6; + // Version 6: Tor Browser 14.5a6: Clear home page update url preference + // (tor-browser#43567). + const TBB_MIGRATION_VERSION = 7; const MIGRATION_PREF = "torbrowser.migration.version"; // If we decide to force updating users to pass through any version @@ -4917,6 +4919,10 @@ BrowserGlue.prototype = { Services.prefs.clearUserPref("torbrowser.bootstrap.allow_internet_test"); } + if (currentVersion < 7) { + Services.prefs.clearUserPref("torbrowser.post_update.url"); + } + Services.prefs.setIntPref(MIGRATION_PREF, TBB_MIGRATION_VERSION); }, ===================================== browser/components/abouttor/AboutTorMessage.sys.mjs ===================================== @@ -26,13 +26,20 @@ export const AboutTorMessage = { const shouldNotifyPref = "torbrowser.post_update.shouldNotify"; if (Services.prefs.getBoolPref(shouldNotifyPref, false)) { Services.prefs.clearUserPref(shouldNotifyPref); + // Try use the same URL as the about dialog. See tor-browser#43567. + let updateURL = Services.urlFormatter.formatURLPref( + "app.releaseNotesURL.aboutDialog" + ); + if (updateURL === "about:blank") { + updateURL = Services.urlFormatter.formatURLPref( + "startup.homepage_override_url" + ); + } return { updateVersion: Services.prefs.getCharPref( "browser.startup.homepage_override.torbrowser.version" ), - updateURL: - Services.prefs.getCharPref("torbrowser.post_update.url", "") || - Services.urlFormatter.formatURLPref("startup.homepage_override_url"), + updateURL, }; } const number = this._count; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/f8f40d4... -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/f8f40d4... You're receiving this email because of your account on gitlab.torproject.org.