Pier Angelo Vendrame pushed to branch tor-browser-115.0esrbase-13.0-1 at The Tor Project / Applications / Tor Browser
Commits: 80150d98 by Pier Angelo Vendrame at 2023-06-29T12:06:57+02:00 Bug 1832523 - Allow using NSS to sign and verify MAR signatures. r=application-update-reviewers,glandium,bytesized
Allow using NSS for checking MAR signatures also in platforms where OS-native APIs are used by default, i.e., macOS and Windows.
Differential Revision: https://phabricator.services.mozilla.com/D177743 - - - - - 0368a31d by Henry Wilkes at 2023-06-29T12:06:58+02:00 Bug 41454: Move focus after calling openPreferences for a sub-category.
Temporary fix until mozilla bug 1799153 gets a patch upstream.
- - - - - 8204d110 by Henry Wilkes at 2023-06-29T12:06:58+02:00 Bug 41483: Remove the firefox override for appstrings.properties
Remove this patch after upstream bugzilla bug 1790187
- - - - - 01637eae by Pier Angelo Vendrame at 2023-06-29T12:06:59+02:00 Bug 41116: Normalize system fonts.
System fonts are an enormous fingerprinting vector. Even with font allow lists and with our custom configuration on Linux, which counter metrics measurements, getComputedStyle leaks several details. This patch counters both these kinds of attacks.
- - - - - 43cb46cb by Pier Angelo Vendrame at 2023-06-29T12:06:59+02:00 fixup! Bug 41116: Normalize system fonts.
Update to the latest proposal to upstream. It fixes build issues on macOS.
- - - - - db40f711 by Pier Angelo Vendrame at 2023-06-29T12:07:00+02:00 fixup! Bug 41116: Normalize system fonts.
ShouldResistFinterprinting now always wants a target.
- - - - - cecd8762 by Marco Simonelli at 2023-06-29T12:07:00+02:00 Bug 41459: WebRTC fails to build under mingw (Part 1)
- properly define NOMINMAX for just MSVC builds
- - - - - e3e4be18 by Marco Simonelli at 2023-06-29T12:07:01+02:00 Bug 41459: WebRTC fails to build under mingw (Part 2)
- fixes required to build third_party/libwebrtc
- - - - - cd6bbf55 by Pier Angelo Vendrame at 2023-06-29T12:07:01+02:00 fixup! Bug 41459: WebRTC fails to build under mingw (Part 2)
Reworked the _com_error conversion to string, to use functions that are available also to mingw.
- - - - - 88118f0b by Marco Simonelli at 2023-06-29T12:07:02+02:00 Bug 41459: WebRTC fails to build under mingw (Part 3)
- fixes required to build third_party/sipcc
- - - - - 9dac9da5 by Marco Simonelli at 2023-06-29T12:07:02+02:00 Bug 41459: WebRTC fails to build under mingw (Part 4)
- fixes requried to build netwerk/sctp
- - - - - f747579b by Pier Angelo Vendrame at 2023-06-29T12:07:02+02:00 fixup! Bug 41459: WebRTC fails to build under mingw (Part 4)
Define _CRT_RAND_S as a compiler flag, to avoid problems due to unified sources.
- - - - - 26639502 by Marco Simonelli at 2023-06-29T12:07:03+02:00 Bug 41459: WebRTC fails to build under mingw (Part 5)
- fixes required to build dom/media/webrtc
- - - - - 482b6b0e by Marco Simonelli at 2023-06-29T12:07:03+02:00 Bug 41459: WebRTC fails to build under mingw (Part 6)
- fixes required to build dom/media/systemservices
- - - - - 55b6c5ce by Gaba at 2023-06-29T12:07:04+02:00 Adding issue and merge request templates
- - - - - 6ec63423 by Richard Pospesel at 2023-06-29T12:07:04+02:00 fixup! Adding issue and merge request templates
- removed exta unneeded dashes - updated Backporting section to better match our desired process going forward: - discourage requests for backport to stable - provide justification for backport request from list proposed at last Tor meeting - added 'consistency' justification for patches/changes which can be difficult to context switch between but don't affect the final build output - added explicit merge destination selection
- - - - - 9408b55a by Pier Angelo Vendrame at 2023-06-29T12:07:05+02:00 Base Browser's .mozconfigs.
Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan.
Bug 21849: Don't allow SSL key logging.
Bug 25741 - TBA: Disable features at compile-time
Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION
Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds
This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android.
Bug 29859: Disable HLS support for now
Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING
Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT
Bug 33734: Set MOZ_NORMANDY to False
Bug 33851: Omit Parental Controls.
Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files
Bug 41584: Move some configuration options to base-browser level
- - - - - 51a83fc3 by Pier Angelo Vendrame at 2023-06-29T12:07:05+02:00 fixup! Base Browser's .mozconfigs.
Do not specify --{enable,disable}-verify-mar in mozconfigs, as this option does not exist anymore, and signed mars are enabled by default.
- - - - - 5cb79e69 by Pier Angelo Vendrame at 2023-06-29T12:07:05+02:00 fixup! Base Browser's .mozconfigs.
Use the new flag upstream to replace the Bug 41542 commit.
- - - - - fd968d51 by Pier Angelo Vendrame at 2023-06-29T12:07:06+02:00 fixup! Base Browser's .mozconfigs.
Disable the notification server because of the upstream Bug 1782837.
- - - - - d06b2145 by Pier Angelo Vendrame at 2023-06-29T12:07:06+02:00 fixup! Base Browser's .mozconfigs.
Explicitly say we want verified updates.
- - - - - f1df84ae by Kathy Brade at 2023-06-29T13:27:57+02:00 fixup! Base Browser's .mozconfigs.
Replaces bug 13379: Allow using NSS to sign and verify MAR signatures
We have uplifted this commit, so we just need to enable the option in our mozconfigs.
- - - - - 2f0bdbde by Pier Angelo Vendrame at 2023-06-29T13:28:06+02:00 Tweaks to the build system
Bug 40857: Modified the fat .aar creation file
This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build.
We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch.
See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770.
Bug 41458: Prevent `mach package-multi-locale` from actually creating a package
macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it.
- - - - - 8f30656f by Pier Angelo Vendrame at 2023-06-29T13:28:07+02:00 Bug 41108: Remove privileged macOS installation from 102
- - - - - 0d303919 by Dan Ballard at 2023-06-29T13:28:07+02:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies
- - - - - 3d49a99e by Matthew Finkel at 2023-06-29T13:28:07+02:00 Bug 24796: Comment out excess permissions from GeckoView
The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing.
- - - - - d6a5dbfc by Matthew Finkel at 2023-06-29T13:28:08+02:00 Bug 28125: Prevent non-Necko network connections
- - - - - 0275e9b9 by Mike Perry at 2023-06-29T13:28:08+02:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth
The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602
- - - - - 5edfd94e by Alex Catarineu at 2023-06-29T13:28:09+02:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899
- - - - - 2e69bcf7 by Georg Koppen at 2023-06-29T13:28:09+02:00 Bug 16285: Exclude ClearKey system for now
In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past.
- - - - - 53eb2d06 by Kathy Brade at 2023-06-29T13:28:10+02:00 Bug 21431: Clean-up system extensions shipped in Firefox
Only ship the pdfjs extension.
- - - - - f499f5a5 by Kathy Brade at 2023-06-29T13:28:10+02:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc.
Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps.
Disable the "Create New Login" button when security.nocertdb is true.
- - - - - 6534a3ce by Alex Catarineu at 2023-06-29T13:28:10+02:00 Bug 41457: Remove Mozilla permissions
Bug 40025: Remove Mozilla add-on install permissions
- - - - - 370f292d by Kathy Brade at 2023-06-29T13:28:11+02:00 Bug 40002: Remove about:ion
Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser.
Bug 41662: Disable about:sync-logs
Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component.
- - - - - 225ffc0c by Arthur Edelstein at 2023-06-29T13:28:11+02:00 Bug 26353: Prevent speculative connect that violated FPI.
Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term.
- - - - - 164c73eb by Alex Catarineu at 2023-06-29T13:28:12+02:00 Bug 31740: Remove some unnecessary RemoteSettings instances
More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls.
Avoid creating instance for 'anti-tracking-url-decoration'.
If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'.
Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps.
We also clear the collections database on the v2 -> v3 migration.
- - - - - 42bb0bb0 by Pier Angelo Vendrame at 2023-06-29T13:28:12+02:00 fixup! Bug 31740: Remove some unnecessary RemoteSettings instances
Linted
- - - - - d6f07ad0 by Pier Angelo Vendrame at 2023-06-29T13:28:13+02:00 Bug 41635: Disable the Normandy component
Do not include Normandy at all whenever MOZ_NORMANDY is False.
- - - - - 8e13721a by Georg Koppen at 2023-06-29T13:28:13+02:00 Bug 30541: Disable WebGL readPixel() for web content
Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034
- - - - - a415d539 by Pier Angelo Vendrame at 2023-06-29T13:28:13+02:00 fixup! Bug 30541: Disable WebGL readPixel() for web content
- - - - - ff014208 by Pier Angelo Vendrame at 2023-06-29T13:28:14+02:00 fixup! Bug 30541: Disable WebGL readPixel() for web content
ShouldResistFinterprinting now always wants a target.
- - - - - 806d7c14 by Alex Catarineu at 2023-06-29T13:28:14+02:00 Bug 28369: Stop shipping pingsender executable
- - - - - 4aeaa0dc by Pier Angelo Vendrame at 2023-06-29T13:28:15+02:00 fixup! Bug 28369: Stop shipping pingsender executable
Linted
- - - - - 8b087842 by cypherpunks1 at 2023-06-29T13:28:15+02:00 Bug 41568: Disable LaterRun
- - - - - 069ef79b by cypherpunks1 at 2023-06-29T13:28:16+02:00 Bug 40717: Hide Windows SSO in settings
- - - - - b0ac6019 by Pier Angelo Vendrame at 2023-06-29T13:28:16+02:00 Bug 41599: Always return an empty string as network ID
Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users.
We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756
- - - - - ea9c5901 by Mike Perry at 2023-06-29T13:28:17+02:00 Firefox preference overrides.
This hack directly includes our preference changes in omni.ja.
Bug 18292: Staged updates fail on Windows
Temporarily disable staged updates on Windows.
Bug 18297: Use separate Noto JP,KR,SC,TC fonts
Bug 23404: Add Noto Sans Buginese to the macOS whitelist
Bug 23745: Set dom.indexedDB.enabled = true
Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera@riseup.net>)
Bug 17252: Enable session identifiers with FPI
Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers".
The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049)
Bug 14952: Enable http/2 and AltSvc
In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2".
Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well.
(All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.)
However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false.
"network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197.
Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites
Enable ReaderView mode again (#27281).
Bug 29916: Make sure enterprise policies are disabled
Bug 2874: Block Components.interfaces from content
Bug 26146: Spoof HTTP User-Agent header for desktop platforms
In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs.
Bug 12885: Windows Jump Lists fail for Tor Browser
Jumplist entries are stored in a binary file in: %APPDATA%\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms
The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller.
However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past.
The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted.
Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996.
Bug 30845: Make sure default themes and other internal extensions are enabled
Bug 28896: Enable extensions in private browsing by default
Bug 31065: Explicitly allow proxying localhost
Bug 31598: Enable letterboxing
Disable Presentation API everywhere
Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels.
Bug 32321: Disable Mozilla's MitM pings
Bug 19890: Disable installation of system addons
By setting the URL to "" we make sure that already installed system addons get deleted as well.
Bug 22548: Firefox downgrades VP9 videos to VP8.
On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8.
This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available".
Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs
Bug 16441: Suppress "Reset Tor Browser" prompt.
Bug 29120: Use the in-memory media cache and increase its maximum size.
Bug 33697: use old search config based on list.json
Bug 33855: Ensure that site-specific browser mode is disabled.
Bug 30682: Disable Intermediate CA Preloading.
Bug 40061: Omit the Windows default browser agent from the build
Bug 40322: Consider disabling network.connectivity-service.enabled
Bug 40408: Disallow SVG Context Paint in all web content
Bug 40308: Disable network partitioning until we evaluate dFPI
Bug 40322: Consider disabling network.connectivity-service.enabled
Bug 40383: Disable dom.enable_event_timing
Bug 40423: Disable http/3
Bug 40177: Update prefs for Fx91esr
Bug 40700: Disable addons and features recommendations
Bug 40682: Disable network.proxy.allow_bypass
Bug 40736: Disable third-party cookies in PBM
Bug 19850: Enabled HTTPS-Only by default
Bug 40912: Hide the screenshot menu
Bug 41292: Disable moreFromMozilla in preferences page
Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector
Bug 24686: Set network.http.tailing.enabled to true
Bug 40183: Disable TLS ciphersuites using SHA-1
Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102
We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them.
- - - - - f605ed46 by Pier Angelo Vendrame at 2023-06-29T13:28:17+02:00 fixup! Firefox preference overrides.
Bug 41738: Drop the patch to disable live reload and use the pref
- - - - - e71c96cc by Henry Wilkes at 2023-06-29T13:28:20+02:00 fixup! Firefox preference overrides.
Bug 41736 - Stop setting the browser.uiCustomization.state preference.
- - - - - 15a8bc1b by Pier Angelo Vendrame at 2023-06-29T13:28:21+02:00 fixup! Firefox preference overrides.
- - - - - 4a51780d by hackademix at 2023-06-29T13:28:21+02:00 fixup! Firefox preference overrides.
tor-browser#41764, prevent automatic download stuffing / DOS
- - - - - 47ea65cf by Pier Angelo Vendrame at 2023-06-29T13:28:21+02:00 fixup! Firefox preference overrides.
Missing comments on tor-browser.git. To be moved there.
- - - - - 0f43f3a2 by Pier Angelo Vendrame at 2023-06-29T13:28:22+02:00 fixup! Firefox preference overrides.
Remove other references to Tor Browser prefs
- - - - - cd6ed8af by Pier Angelo Vendrame at 2023-06-29T13:28:22+02:00 fixup! Firefox preference overrides.
Ignore 001-base-profile.js during linting.
- - - - - c038d92b by Pier Angelo Vendrame at 2023-06-29T13:28:23+02:00 fixup! Firefox preference overrides.
Pref name change after uplifting.
- - - - - 12559c45 by Richard Pospesel at 2023-06-29T13:28:23+02:00 Bug 41659: Add canonical color definitions to base-browser
- - - - - f4d3ce96 by Pier Angelo Vendrame at 2023-06-29T13:28:24+02:00 Bug 41043: Hardcode the UI font on Linux
The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version.
Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese).
- - - - - 348ee770 by Alex Catarineu at 2023-06-29T13:28:24+02:00 Bug 30605: Honor privacy.spoof_english in Android
This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly.
Bug 40198: Expose privacy.spoof_english pref in GeckoView
- - - - - ec41c8be by Alex Catarineu at 2023-06-29T13:28:24+02:00 Bug 40199: Avoid using system locale for intl.accept_languages in GeckoView
- - - - - 8513b857 by Alex Catarineu at 2023-06-29T13:28:25+02:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware
- - - - - 2692cf93 by Alex Catarineu at 2023-06-29T13:28:25+02:00 Bug 26345: Hide tracking protection UI
- - - - - ceb9d0c7 by Pier Angelo Vendrame at 2023-06-29T13:28:26+02:00 Bug 9173: Change the default Firefox profile directory to be relative.
This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows.
On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle.
This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS).
- - - - - de069f2d by Alex Catarineu at 2023-06-29T13:28:26+02:00 Bug 27604: Fix addon issues when moving the profile directory
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838
- - - - - 7193a6ae by Mike Perry at 2023-06-29T13:28:27+02:00 Bug 13028: Prevent potential proxy bypass cases.
It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident.
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509
- - - - - badd9487 by Igor Oliveira at 2023-06-29T13:28:27+02:00 Bug 23104: Add a default line height compensation
Many fonts have issues with their vertical metrics. they are used to influence the height of ascenders and depth of descenders. Gecko uses it to calculate the line height (font height + ascender + descender), however because of that idiosyncratic behavior across multiple operating systems, it can be used to identify the user's OS.
The solution proposed in the patch uses a default factor to be multiplied with the font size, simulating the concept of ascender and descender. This way all operating systems will have the same line height.
- - - - - d2171f06 by Pier Angelo Vendrame at 2023-06-29T13:28:27+02:00 fixup! Bug 23104: Add a default line height compensation
- - - - - bd0c0b59 by Pier Angelo Vendrame at 2023-06-29T13:28:28+02:00 fixup! Bug 23104: Add a default line height compensation
Get the document from aPresContext, which Moz already checks and see it isn't null.
- - - - - cb75a2b5 by Pier Angelo Vendrame at 2023-06-29T13:28:28+02:00 Bug 40309: Avoid using regional OS locales
Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled.
- - - - - 43a6a55e by Matthew Finkel at 2023-06-29T13:28:29+02:00 Bug 40432: Prevent probing installed applications
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084
- - - - - 050a7003 by Pier Angelo Vendrame at 2023-06-29T13:28:29+02:00 Base Browser strings
This commit adds all the strings needed by following Base Browser patches.
- - - - - 0483bdeb by hackademix at 2023-06-29T13:28:30+02:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs.
- - - - - 24eeb607 by hackademix at 2023-06-29T13:28:30+02:00 Bug 41434: Letterboxing, improve logging.
- - - - - 441abe32 by hackademix at 2023-06-29T13:28:30+02:00 Bug 31064: Letterboxing, exempt browser extensions.
- - - - - 2766d4b2 by hackademix at 2023-06-29T13:28:31+02:00 Bug 32411: Letterboxing, exempt view-source: URIs.
- - - - - 309e715f by hackademix at 2023-06-29T13:28:31+02:00 Bug 32308: use direct browser sizing for letterboxing.
- - - - - eda36ce9 by hackademix at 2023-06-29T13:28:32+02:00 fixup! Bug 32308: use direct browser sizing for letterboxing.
- - - - - 85127be9 by hackademix at 2023-06-29T13:28:32+02:00 fixup! Bug 32308: use direct browser sizing for letterboxing.
- - - - - 3ec4554d by hackademix at 2023-06-29T13:28:32+02:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations
- - - - - d13e4947 by hackademix at 2023-06-29T13:28:33+02:00 fixup! Bug 41631: Prevent weird initial window dimensions caused by subpixel computations
- - - - - a05687ee by Pier Angelo Vendrame at 2023-06-29T13:28:33+02:00 Bug 41369: Improve Firefox language settings for multi-lingual packages
Change the language selector to be sorted by language code, rather than name, and to display the language code to the user.
Bug 41372: Handle Japanese as a special case in preferences on macOS
Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs.
Bug 41378: Tell users that they can change their language at the first start
With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once.
- - - - - 98f957e4 by p13dz at 2023-06-29T13:28:34+02:00 Bug 40283: Workaround for the file upload bug
- - - - - 44a9395d by Arthur Edelstein at 2023-06-29T13:28:34+02:00 Bug 18905: Hide unwanted items from help menu
Bug 25660: Remove the "New Private Window" option
- - - - - 5e06de21 by Pier Angelo Vendrame at 2023-06-29T13:28:35+02:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL
MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/.
- - - - - a2a539da by Henry Wilkes at 2023-06-29T13:28:40+02:00 Bug 31575: Disable Firefox Home (Activity Stream)
Treat about:blank as the default home page and new tab page.
Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need.
Bug 41624: Disable about:pocket-* pages.
Bug 40144: Redirect about:privatebrowsing to the user's home
- - - - - 20f790f2 by Kathy Brade at 2023-06-29T13:28:57+02:00 Bug 4234: Use the Firefox Update Process for Base Browser.
Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909.
Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update.
Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality.
Bug 26048: potentially confusing "restart to update" message
Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string.
Bug 28885: notify users that update is downloading
Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress.
As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process.
Removed #28885 parts of this patch which have been uplifted to Firefox.
- - - - - 3352b1c9 by Pier Angelo Vendrame at 2023-06-29T13:28:59+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser.
Bug 41654: Move UpdateInfo into Data again
- - - - - e80a7ab2 by Pier Angelo Vendrame at 2023-06-29T13:29:00+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser.
Linted
- - - - - f2425b67 by Pier Angelo Vendrame at 2023-06-29T13:29:00+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser.
Bug 41775: Avoid re-defining some macros in nsUpdateDriver.cpp.
They are already defined in toolkit/xre/nsUpdateDriver.h.
- - - - - 31f61b66 by Pier Angelo Vendrame at 2023-06-29T13:29:00+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser.
Fix another build error on macOS
- - - - - f1a7ad9a by Nicolas Vigier at 2023-06-29T13:29:01+02:00 Bug 41682: Add base-browser nightly mar signing key
- - - - - abface60 by hackademix at 2023-06-29T13:29:01+02:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module
- - - - - ff010b61 by Pier Angelo Vendrame at 2023-06-29T13:29:02+02:00 fixup! Bug 41695: Warn on window maximization without letterboxing in RFPHelper module
- - - - - f0c7c953 by Pier Angelo Vendrame at 2023-06-29T13:29:02+02:00 Bug 41698: Reword the recommendation badges in about:addons
Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them.
We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead.
Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033
- - - - - 146e7232 by Alex Catarineu at 2023-06-29T13:29:03+02:00 Bug 40069: Add helpers for message passing with extensions
- - - - - cab719a2 by Matthew Finkel at 2023-06-29T13:29:03+02:00 Bug 41598: Prevent NoScript from being removed/disabled.
Bug 40253: Explicitly allow NoScript in Private Browsing mode.
- - - - - dccd5f57 by Pier Angelo Vendrame at 2023-06-29T13:29:03+02:00 Bug 40925: Implemented the Security Level component
This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings.
Bug 40125: Expose Security Level pref in GeckoView
- - - - - 0b766d6b by Pier Angelo Vendrame at 2023-06-29T13:29:04+02:00 fixup! Bug 40925: Implemented the Security Level component
Linted
- - - - - 24ab2f48 by cypherpunks1 at 2023-06-29T13:29:04+02:00 fixup! Bug 40925: Implemented the Security Level component
Bug 26277: Skip the redirection page when searching with DuckDuckGo on the safest security level
- - - - - de446ffa by Pier Angelo Vendrame at 2023-06-29T13:29:05+02:00 fixup! Bug 40925: Implemented the Security Level component
Improve the patch to skip DDG redirection for 115.
- - - - - 8af214eb by Pier Angelo Vendrame at 2023-06-29T13:29:05+02:00 Bug 40926: Implemented the New Identity feature
- - - - - 7cf17d72 by Henry Wilkes at 2023-06-29T13:29:06+02:00 Bug 41736: Customize toolbar for base-browser.
- - - - - 57e825b9 by Richard Pospesel at 2023-06-29T13:29:06+02:00 Bug 41649: Create rebase and security backport gitlab issue templates
- - - - - 9100c324 by Richard Pospesel at 2023-06-29T13:29:06+02:00 fixup! Bug 41649: Create rebase and security backport gitlab issue templates
- made formatting consistent between each template - updated the directions around the base-browser rebase to better reflect how we *actually* do it with regards to only rarely needing to rebase base-browser seperately - fixed a few typos and incorrect git cherry-pick examples - moved signing and tagging to their own section in the rebase templates - changed instances of 'origin' to 'upstream' to be consistent with github/gitlab documentation - added firefox-android section and marked android-components and fenix sections as optional for esr102 only so we don't have to urently fix this once we swithc to esr115
- - - - - 4f4a60a4 by Richard Pospesel at 2023-06-29T13:29:07+02:00 Bug 41089: Add tor-browser build scripts + Makefile to tor-browser
- - - - - 6027cfff by Pier Angelo Vendrame at 2023-06-29T13:29:07+02:00 fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser
Added bridges.js to .eslintignore
- - - - - 937f00ae by Henry Wilkes at 2023-06-29T13:29:08+02:00 Bug 41803: Add some developer tools for working on tor-browser.
- - - - - 093cd756 by Kathy Brade at 2023-06-29T13:29:08+02:00 Bug 11641: Disable remoting by default.
Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior.
- - - - - a6ee7217 by Mike Perry at 2023-06-29T13:29:09+02:00 Bug 2176: Rebrand Firefox to TorBrowser
See also Bugs #5194, #7187, #8115, #8219.
This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons.
Also fix bug 27905.
Bug 25702: Update Tor Browser icon to follow design guidelines
- Updated all of the branding in /browser/branding/official with new 'stable' icon series. - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory - Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654) - Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory - Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico) - Added default256.png and default512.png icons - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon - Use the Tor Browser icon within devtools/client/themes/images/.
Bug 30631: Blurry Tor Browser icon on macOS app switcher
It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil.
Bug 28196: preparations for using torbutton tor-browser-brand.ftl
A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser.
Bug 31803: Replaced about:debugging logo with flat version
Bug 21724: Make Firefox and Tor Browser distinct macOS apps
When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser.
Bug 32092: Fix Tor Browser Support link in preferences
For bug 40562, we moved onionPattern* from bug 27476 to here, as about:tor needs these files but it is included earlier.
Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one
- - - - - ef582de0 by Pier Angelo Vendrame at 2023-06-29T13:29:09+02:00 fixup! Bug 2176: Rebrand Firefox to TorBrowser
Bug 41749: Replace the onion-glyph with dedicated icon for onion services
- - - - - fd1c2e3a by Pier Angelo Vendrame at 2023-06-29T13:29:09+02:00 fixup! Bug 2176: Rebrand Firefox to TorBrowser
Added placeholders for new PBM assets needed on Windows
- - - - - 227f099c by Dan Ballard at 2023-06-29T13:29:10+02:00 fixup! fixup! Bug 2176: Rebrand Firefox to TorBrowser
Bug 41809: restore onion glyph in locations outside location bar
- - - - - 6d782db3 by sanketh at 2023-06-29T13:29:10+02:00 Bug 40209: Implement Basic Crypto Safety
Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning.
Closes #40209.
Bug 40428: Fix string attribute names
- - - - - d46d45b9 by Pier Angelo Vendrame at 2023-06-29T13:29:11+02:00 fixup! Bug 40209: Implement Basic Crypto Safety
Use the new domain isolator interface
- - - - - 60ce49ae by Mike Perry at 2023-06-29T13:29:11+02:00 TB3: Tor Browser's official .mozconfigs.
Also: Add an --enable-tor-browser-data-outside-app-dir configure option
Add --with-tor-browser-version configure option
Bug 31457: disable per-installation profiles
The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data.
Bug 31935: Disable profile downgrade protection.
Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected.
Add --enable-tor-browser-update build option
Bug 40793: moved Tor configuration options from old-configure.in to moz.configure
Bug 41584: Move some configuration options to base-browser level
- - - - - 7d1bbb1d by Dan Ballard at 2023-06-29T13:29:12+02:00 fixup! TB3: Tor Browser's official .mozconfigs.
Bug 41828: Remove --with-tor-browser-version from tor-browser-android mozconfig
- - - - - 95613521 by Henry Wilkes at 2023-06-29T13:29:12+02:00 Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds
tor-browser#41285: Enable fluent warnings.
- - - - - 27558879 by Pier Angelo Vendrame at 2023-06-29T13:29:12+02:00 Bug 40562: Added Tor Browser preferences to 000-tor-browser.js
Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end.
In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply.
- - - - - 164c2310 by Pier Angelo Vendrame at 2023-06-29T13:29:13+02:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js
Moved from the Firefox preferences override commit. To remove from Base Browser and move to Tor Browser only.
- - - - - dcaf66d0 by Pier Angelo Vendrame at 2023-06-29T13:29:13+02:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js
Ignore 000-tor-browser.js during linting
- - - - - 097c9b55 by Pier Angelo Vendrame at 2023-06-29T13:29:19+02:00 Bug 13252: Customize profile management on macOS
On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode.
Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error.
- - - - - 1f26c168 by Pier Angelo Vendrame at 2023-06-29T13:29:19+02:00 Bug 40933: Add tor-launcher functionality
- - - - - 0ee02b12 by Pier Angelo Vendrame at 2023-06-29T13:29:20+02:00 fixup! Bug 40933: Add tor-launcher functionality
Switched to lazy.
- - - - - 3fc3b37e by Pier Angelo Vendrame at 2023-06-29T13:29:20+02:00 fixup! Bug 40933: Add tor-launcher functionality
Added a newnym function
- - - - - c0ea39b4 by Richard Pospesel at 2023-06-29T13:29:21+02:00 Bug 40597: Implement TorSettings module
- migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module - TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs - TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor - about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module - all tor settings live in the torbrowser.settings.* preference branch - removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm
Bug 40645: Migrate Moat APIs to Moat.jsm module
- - - - - 9846297e by Henry Wilkes at 2023-06-29T13:29:21+02:00 fixup! Bug 40597: Implement TorSettings module
Bug 41608 - Ignore tor connection errors when tor connection is cancelled by the user. This can happen if the bootstrap process is cancelled late in the process.
Also remove unused cancelAutoBootstrapping.
- - - - - cddbc1e2 by Pier Angelo Vendrame at 2023-06-29T13:29:21+02:00 fixup! Bug 40597: Implement TorSettings module
Bug 41801: Fix handleProcessReady in TorSettings.init
- - - - - ba6566ab by Alex Catarineu at 2023-06-29T13:29:22+02:00 Bug 10760: Integrate TorButton to TorBrowser core
Because of the non-restartless nature of Torbutton, it required a two-stage installation process. On mobile, it was a problem, because it was not loading when the user opened the browser for the first time.
Moving it to tor-browser and making it a system extension allows it to load when the user opens the browser for first time.
Additionally, this patch also fixes Bug 27611.
Bug 26321: New Circuit and New Identity menu items
Bug 14392: Make about:tor behave like other initial pages.
Bug 25013: Add torbutton as a tor-browser submodule
Bug 31575: Replace Firefox Home (newtab) with about:tor
- - - - - 88d31abc by Pier Angelo Vendrame at 2023-06-29T13:29:22+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core
Linted
- - - - - 94b1d59e by Pier Angelo Vendrame at 2023-06-29T13:29:23+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core
Bug 40938: Moving the domain isolator out of torbutton
- - - - - e55fdfad by Pier Angelo Vendrame at 2023-06-29T13:29:23+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core
Extract the new identity button from torbutton
- - - - - 63965afe by Pier Angelo Vendrame at 2023-06-29T13:29:24+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core
Remove string changes from Torbutton. We will add them back in the TorStrings commit.
- - - - - 21199f4f by Pier Angelo Vendrame at 2023-06-29T13:29:24+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core
Emergency modularization.
- - - - - 4c0d6049 by Pier Angelo Vendrame at 2023-06-29T13:29:25+02:00 fixup! Bug 10760: Integrate TorButton to TorBrowser core
Removed references to global.dtd.
- - - - - 1aa4ad4e by hackademix at 2023-06-29T13:29:25+02:00 Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop
Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs
- - - - - be5168d7 by cypherpunks1 at 2023-06-29T13:29:26+02:00 fixup! Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop
Bug 41792: Allow dragging downloads from about:downloads and the download panel
- - - - - 6f47dda8 by Pier Angelo Vendrame at 2023-06-29T13:29:26+02:00 fixup! Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop
Emergency modernization
- - - - - 8e033b30 by Pier Angelo Vendrame at 2023-06-29T13:29:27+02:00 fixup! Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop
Final part of the modernization: switched to an actual module, and moved out of Torbutton!
- - - - - 163fe8cb by Arthur Edelstein at 2023-06-29T13:29:27+02:00 Bug 3455: Add DomainIsolator, for isolating circuit by domain.
Add an XPCOM component that registers a ProtocolProxyChannelFilter which sets the username/password for each web request according to url bar domain.
Bug 9442: Add New Circuit button
Bug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ.
Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce.
Bug 19206: Clear out the domain isolator state on `New Identity`.
Bug 21201.2: Isolate by firstPartyDomain from OriginAttributes
Bug 21745: Fix handling of catch-all circuit
Bug 41741: Refactor the domain isolator and new circuit
- - - - - 2a56f627 by Pier Angelo Vendrame at 2023-06-29T13:29:28+02:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain.
Refactors to the old JS code.
- - - - - b6249f7f by Pier Angelo Vendrame at 2023-06-29T13:29:28+02:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain.
Manage NEWNYM here.
- - - - - de8767dc by Pier Angelo Vendrame at 2023-06-29T13:29:28+02:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain.
Removed the XPCOM definition of the domain isolator.
- - - - - 2cd8a2f3 by Pier Angelo Vendrame at 2023-06-29T13:29:29+02:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain.
Actually added the new circuit button.
- - - - - 9e185348 by Henry Wilkes at 2023-06-29T13:29:29+02:00 Bug 41600: Add a tor circuit display panel.
- - - - - 802b9689 by Pier Angelo Vendrame at 2023-06-29T13:29:30+02:00 fixup! Bug 41600: Add a tor circuit display panel.
Linted
- - - - - 39f0140f by Henry Wilkes at 2023-06-29T13:29:30+02:00 fixup! Bug 41600: Add a tor circuit display panel.
Bug 41770 - Stop blocking event propagation of keydown events that we do not handle. This lets the arrow key events pass on to ToolbarKeyboardNavigator.
- - - - - 9d211e10 by Pier Angelo Vendrame at 2023-06-29T13:29:31+02:00 fixup! Bug 41600: Add a tor circuit display panel.
Use the new domain isolator interface.
- - - - - 3ab80b59 by Henry Wilkes at 2023-06-29T13:29:31+02:00 fixup! Bug 41600: Add a tor circuit display panel.
Bug 41851: Keep circuit panel open when requesting a new circuit.
- - - - - 18bed7a3 by Amogh Pradeep at 2023-06-29T13:29:32+02:00 Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources.
See Bug 1357997 for partial uplift.
Also: Bug 28051 - Use our Orbot for proxying our connections
Bug 31144 - ESR68 Network Code Review
- - - - - 402103e0 by Matthew Finkel at 2023-06-29T13:29:32+02:00 Bug 25741: TBA: Disable GeckoNetworkManager
The browser should not need information related to the network interface or network state, tor should take care of that.
- - - - - 93759f8e by Alex Catarineu at 2023-06-29T13:29:32+02:00 Add TorStrings module for localization
- - - - - 94daf47c by Henry Wilkes at 2023-06-29T13:29:33+02:00 fixup! Add TorStrings module for localization
Bug 41608 - Add new connection status strings.
- - - - - bde08b87 by Pier Angelo Vendrame at 2023-06-29T13:29:34+02:00 fixup! Add TorStrings module for localization
Bug 40552: New texts for the add a bridge manually modal
- - - - - 6fe2cdad by Henry Wilkes at 2023-06-29T13:29:35+02:00 fixup! Add TorStrings module for localization
Bug 41734 - Add a connected label to the built-in bridge dialog.
- - - - - 72c444f8 by Henry Wilkes at 2023-06-29T13:29:35+02:00 fixup! Add TorStrings module for localization
Bug 41618 - Remove connect bar, and swap internet and connection icons in tor connection preferences.
- - - - - 8c2f90dc by Pier Angelo Vendrame at 2023-06-29T13:29:35+02:00 fixup! Add TorStrings module for localization
Bug 41818: Remove YEC 2022 strings
- - - - - 685a7e85 by Pier Angelo Vendrame at 2023-06-29T13:29:36+02:00 fixup! Add TorStrings module for localization
Add our DTDs where needed.
These changes were originally in the torbutton commit, but I think they are better fit here, with all the strings files.
- - - - - 6e0e3c74 by Kathy Brade at 2023-06-29T13:29:36+02:00 Bug 14631: Improve profile access error messages.
Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system".
To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts.
- - - - - 263633ff by Pier Angelo Vendrame at 2023-06-29T13:29:37+02:00 Bug 40807: Added QRCode.js to toolkit/modules
- - - - - b84dcbed by Richard Pospesel at 2023-06-29T13:29:37+02:00 Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present:
- Setting built-in bridges - Requesting bridges from BridgeDB via moat - Using user-provided bridges - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies - Setting firewall ports - Viewing and Copying Tor's logs - The Networking Settings in General preferences has been removed
Bug 40774: Update about:preferences page to match new UI designs
- - - - - e491f15d by Pier Angelo Vendrame at 2023-06-29T13:29:38+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
Linted
- - - - - 83f26a5b by Henry Wilkes at 2023-06-29T13:29:38+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
Bug 41608 - Use the torconnect icon for the onion slash.
- - - - - 25a70ab1 by Pier Angelo Vendrame at 2023-06-29T13:29:39+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
Bug 40552: Improve the description of the modal to provide a bridge manually.
- - - - - c2911585 by Pier Angelo Vendrame at 2023-06-29T13:29:39+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
Bug 41802: Improve the regex on parseBridgeLine
The previous version of the regex took for granted the bridge fingerprint was always available, but it is actually optional. So, parsing some bridge lines (e.g., Conjure) failed, and vanilla bridge was displayed instead of the actual transport.
- - - - - 94a9c8d5 by Dan Ballard at 2023-06-29T13:29:39+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
Bug 41623: Update connection assist's iconography
- - - - - fafa8778 by Henry Wilkes at 2023-06-29T13:29:40+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
Bug 41734 - Add a connected label to the built-in bridge dialog.
- - - - - 619fff39 by Henry Wilkes at 2023-06-29T13:29:40+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
Bug 41618 - Remove connect bar, and swap internet and connection icons in tor connection preferences.
- - - - - 72de7a73 by Henry Wilkes at 2023-06-29T13:29:41+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
Bug 41810 - Add "Connect" button instead of the "Submit" and "OK" button in the bridge request dialog and the manual bridge dialog, respectively.
- - - - - 0df37eb8 by Dan Ballard at 2023-06-29T13:29:41+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
Bug 41809: restore onion glyph in locations outside location bar
- - - - - 26e1ff7d by Henry Wilkes at 2023-06-29T13:29:42+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
Bug 41826 - Tweak tor connect status styling in titlebar and connection preferences.
- - - - - e270341b by Henry Wilkes at 2023-06-29T13:29:42+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
Bug 41848 - Consistently disable the accept/connect button in the bridge dialogs until the user gives some input.
- - - - - 9ba127a5 by Henry Wilkes at 2023-06-29T13:29:43+02:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection
Bug 41849: Use the firefox check.svg since we removed our own equivalent check.svg in tor-browser!663.
- - - - - a02c515f by Richard Pospesel at 2023-06-29T13:29:43+02:00 Bug 27476: Implement about:torconnect captive portal within Tor Browser
- implements new about:torconnect page as tor-launcher replacement - adds tor connection status to url bar and tweaks UX when not online - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor - explicitly allows about:torconnect URIs to ignore Resist Fingerprinting (RFP) - various tweaks to info-pages.inc.css for about:torconnect (also affects other firefox info pages)
Bug 40773: Update the about:torconnect frontend page to match additional UI flows
- - - - - 276b0ed6 by Pier Angelo Vendrame at 2023-06-29T13:29:43+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser
Linted
- - - - - 298856d2 by Henry Wilkes at 2023-06-29T13:29:44+02:00 amend! Bug 27476: Implement about:torconnect captive portal within Tor Browser
Bug 27476: Implement about:torconnect captive portal within Tor Browser
- implements new about:torconnect page as tor-launcher replacement - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor
Bug 40773: Update the about:torconnect frontend page to match additional UI flows.
Bug 41608: Add a toolbar status button and a urlbar "Connect" button.
- - - - - 471c809f by Henry Wilkes at 2023-06-29T13:29:44+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser
Bug 41608 and 41526 - Use KeyboardEvent.repeat to block triggering newly focused buttons in about:torconnect. The approach in tor-browser!607 prevented this by waiting for keyup, but keyup could still be triggered by a key event initialized elsewhere. E.g. when pressing Enter to close a modal dialog, the Enter's keyup event would be sent to the about:torconnect page and trigger the focused button.
- - - - - d24bd84a by Dan Ballard at 2023-06-29T13:29:45+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser
Bug 41623: Update connection assist's iconography
- - - - - 02d56da6 by Dan Ballard at 2023-06-29T13:29:45+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser
Bug 41623: Update connection assist's iconography
- - - - - 8d16683d by Pier Angelo Vendrame at 2023-06-29T13:29:46+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser
Bug 41815: Wrong connect icons
Swapped a couple of icons in about:torconnect, and split the offline CSS class from the connection assist/final error, since they now need a different icon. Also, removed the stroke property, since the new icons do not need it.
- - - - - 8d8af111 by Pier Angelo Vendrame at 2023-06-29T13:29:46+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser
Bug 41816: Workaround to fix the top navigation
Using the top navigation does not always work as expected, because we pass a null connection state, instead of the actual state. We could start storing the state as a member, however further refactors are planned (see tor-browser#41710), so also directly asking the parent for the current state works as a quick&dirty workaround.
- - - - - 0e3cd929 by Henry Wilkes at 2023-06-29T13:29:47+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser
Bug 41726 - Animate the connection icon.
- - - - - 01bb1519 by Henry Wilkes at 2023-06-29T13:29:47+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser
Bug 41836: Rename deinit to uninit.
- - - - - d73cf1d7 by Henry Wilkes at 2023-06-29T13:29:48+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser
Bug 41826 - Tweak tor connect status styling in titlebar and connection preferences.
- - - - - 4fa75c0e by Henry Wilkes at 2023-06-29T13:29:48+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser
Bug 41850: Don't show tor connection animation for new windows.
- - - - - c3637be5 by Pier Angelo Vendrame at 2023-06-29T13:29:48+02:00 fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser
Moved the logic of the about:tor redirects before the bootstrap
- - - - - c9ac3b9c by Arthur Edelstein at 2023-06-29T13:29:56+02:00 Bug 12620: TorBrowser regression tests
Regression tests for Bug #2950: Make Permissions Manager memory-only
Regression tests for TB4: Tor Browser's Firefox preference overrides.
Note: many more functional tests could be made here
Regression tests for #2874: Block Components.interfaces from content
Bug 18923: Add a script to run all Tor Browser specific tests
Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt.
- - - - - e961ef8a by Pier Angelo Vendrame at 2023-06-29T13:29:57+02:00 Bug 41668: Tweaks to the Base Browser updater for Tor Browser
This commit was once part of "Bug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit.
- - - - - df279d96 by Pier Angelo Vendrame at 2023-06-29T13:29:57+02:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser
Bug 41776: Keep shipping the old fontconfig file until users have one
- - - - - 3ec916f6 by Pier Angelo Vendrame at 2023-06-29T13:29:58+02:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser
Bug 41776 (fix): Added some missing lines to the previous patch
- - - - - ba0b3900 by Pier Angelo Vendrame at 2023-06-29T13:29:58+02:00 fixup! Bug 41668: Tweaks to the Base Browser updater for Tor Browser
Add back variables removed from the Base Browser part of the rebase.
- - - - - ae913bc6 by Kathy Brade at 2023-06-29T13:29:59+02:00 Bug 12647: Support symlinks in the updater.
- - - - - d82868ba by Kathy Brade at 2023-06-29T13:29:59+02:00 Bug 19121: reinstate the update.xml hash check
This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122.
Revert most changes from Mozilla Bug 862173 "don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)."
We kept the addition to the AppConstants API in case other JS code references it in the future.
- - - - - a5504656 by Kathy Brade at 2023-06-29T13:30:00+02:00 Bug 16940: After update, load local change notes.
Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release).
Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts.
Also fix bug 29440. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor.
- - - - - d7033579 by Pier Angelo Vendrame at 2023-06-29T13:30:00+02:00 fixup! Bug 16940: After update, load local change notes.
Define the remote capabilities of about:tbupdate in the correct commit.
- - - - - 6d89f788 by Pier Angelo Vendrame at 2023-06-29T13:30:01+02:00 fixup! Bug 16940: After update, load local change notes.
Removed global.dtd
- - - - - c1955e0b by Georg Koppen at 2023-06-29T13:30:01+02:00 Bug 32658: Create a new MAR signing key
It's time for our rotation again: Move the backup key in the front position and add a new backup key.
Bug 33803: Move our primary nightly MAR signing key to tor-browser
Bug 33803: Add a secondary nightly MAR signing key
- - - - - 118fb4cf by Mike Perry at 2023-06-29T13:30:02+02:00 Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed.
Also: Bug 16322: Update DuckDuckGo search engine
We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to bug 1061736 where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well.
Also: This fixes bug 20809: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly.
Also fixes bug 29798 by making sure we only specify the Google search engine we actually ship an .xml file for.
Also regression tests.
squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
Bug 40494: Update Startpage search provider
squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
Bug 40438: Add Blockchair as a search engine
Bug 33342: Avoid disconnect search addon error after removal.
We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore.
- - - - - 56543e97 by Pier Angelo Vendrame at 2023-06-29T13:30:02+02:00 fixup! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
Use the upstream DDG icon
- - - - - ee7e8dae by Alex Catarineu at 2023-06-29T13:30:03+02:00 Bug 40073: Disable remote Public Suffix List fetching
In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want.
- - - - - dbe18400 by Richard Pospesel at 2023-06-29T13:30:03+02:00 Bug 23247: Communicating security expectations for .onion
Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine.
Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services:
- HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure - HTTP Onion Service pages would be marked as unencrypted in the Page Info screen - Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content
This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content.
Strings for Onion Service Page Info page are pulled from Torbutton's localization strings.
- - - - - d178ce1b by Pier Angelo Vendrame at 2023-06-29T13:30:04+02:00 fixup! Bug 23247: Communicating security expectations for .onion
Reimplement the self-signed onion logic
- - - - - ef4ff7f5 by cypherpunks1 at 2023-06-29T13:30:04+02:00 fixup! Bug 23247: Communicating security expectations for .onion
Bug 33298: Warn when submitting form data from http onion sites over an insecure connection
- - - - - 8cd7740e by cypherpunks1 at 2023-06-29T13:30:05+02:00 fixup! Bug 23247: Communicating security expectations for .onion
Bug 41785: Show http onion resources as secure in network monitor
- - - - - a0df6e13 by Dan Ballard at 2023-06-29T13:30:05+02:00 fixup! Bug 23247: Communicating security expectations for .onion
Bug 41809: restore onion glyph in locations outside location bar
- - - - - 8853c8bd by Kathy Brade at 2023-06-29T13:30:06+02:00 Bug 30237: Add v3 onion services client authentication prompt
When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key.
If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page.
If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt.
Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt.
Add support for onion services strings to the TorStrings module.
Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of bug 30025.
Also fixes bug 19757: Add a "Remember this key" checkbox to the client auth prompt.
Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk.
Also fixes bug 19251: use enhanced error pages for onion service errors.
- - - - - 10a5f445 by Pier Angelo Vendrame at 2023-06-29T13:30:06+02:00 fixup! Bug 30237: Add v3 onion services client authentication prompt
Linted
- - - - - d116aba8 by Alex Catarineu at 2023-06-29T13:30:07+02:00 Bug 21952: Implement Onion-Location
Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar.
- - - - - a3e6af1c by Henry Wilkes at 2023-06-29T13:30:07+02:00 fixup! Bug 21952: Implement Onion-Location
Bug 41608 - Use the same styling for ".onion available" urlbar button as the tor-connect-urlbar-button. This also stops the button from overflowing its container like before. Also move to after the bookmark button.
- - - - - a8e34ae4 by Pier Angelo Vendrame at 2023-06-29T13:30:08+02:00 fixup! Bug 21952: Implement Onion-Location
Bug 41841: Use the new onion-site.svg icon in the onion-location pill
- - - - - d478e144 by Pier Angelo Vendrame at 2023-06-29T13:30:09+02:00 Bug 40458: Implement .tor.onion aliases
We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates.
- - - - - 21aa53ce by Pier Angelo Vendrame at 2023-06-29T13:30:09+02:00 fixup! Bug 40458: Implement .tor.onion aliases
Lint
- - - - - 034ae300 by Pier Angelo Vendrame at 2023-06-29T13:30:10+02:00 Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser
This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation.
- - - - - 972ef7d3 by Pier Angelo Vendrame at 2023-06-29T13:30:10+02:00 Bug 41435: Add a Tor Browser migration function
For now this function only deletes old language packs for which we are already packaging the strings with the application.
- - - - - 275c0c28 by Dan Ballard at 2023-06-29T13:31:57+02:00 Bug 40701: Add in pane security warning when downloading a file
- - - - - acab274e by Dan Ballard at 2023-06-29T13:32:28+02:00 amend! Bug 40701: Add in pane security warning when downloading a file
Bug 40701: Add security warning when downloading a file
Shown in the downloads panel, about:downloads and places.xhtml.
- - - - - 60ffb63e by Pier Angelo Vendrame at 2023-06-29T13:32:30+02:00 fixup! Bug 40701: Add in pane security warning when downloading a file
Missed a couple of removed lines.
- - - - - 8ec3f403 by Henry Wilkes at 2023-06-29T13:32:30+02:00 Bug 41736: Customize toolbar for tor-browser.
- - - - - eac41fb2 by hackademix at 2023-06-29T13:32:31+02:00 Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key
- - - - -
30 changed files:
- .eslintignore - .gitignore - + .gitlab/issue_templates/Backport Android Security Fixes.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - + .gitlab/issue_templates/UXBug.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - + browser/actors/AboutTBUpdateChild.jsm - + browser/actors/AboutTBUpdateParent.jsm - + browser/actors/CryptoSafetyChild.jsm - + browser/actors/CryptoSafetyParent.jsm - − browser/actors/RFPHelperChild.sys.mjs - − browser/actors/RFPHelperParent.sys.mjs - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/permissions - + browser/app/profile/000-tor-browser.js - + browser/app/profile/001-base-profile.js - browser/app/profile/firefox.js - browser/base/content/aboutDialog-appUpdater.js - browser/base/content/aboutDialog.js - browser/base/content/aboutDialog.xhtml - + browser/base/content/abouttbupdate/aboutTBUpdate.css - + browser/base/content/abouttbupdate/aboutTBUpdate.js - + browser/base/content/abouttbupdate/aboutTBUpdate.xhtml - browser/base/content/appmenu-viewcache.inc.xhtml - + browser/base/content/browser-doctype.inc
The diff was not included because it is too large.
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/9c13862...