- tor-commits - lists.torproject.org

[Git][tpo/applications/tor-browser-update-responses][main] 6 commits: alpha: new version, 15.0a1 (linux-i686)
by morgan (＠morgan) 30 Jul '25

30 Jul '25

morgan pushed to branch main at The Tor Project / Applications / Tor Browser update responses Commits: 7908070f by Morgan at 2025-07-30T13:16:44+00:00 alpha: new version, 15.0a1 (linux-i686) - - - - - 0ea6b430 by Morgan at 2025-07-30T13:16:44+00:00 alpha: new version, 15.0a1 (linux-x86_64) - - - - - 55e0aa50 by Morgan at 2025-07-30T13:16:44+00:00 alpha: new version, 15.0a1 (macos) - - - - - ce54652c by Morgan at 2025-07-30T13:16:45+00:00 alpha: new version, 15.0a1 (windows-i686) - - - - - 1d5dd3c0 by Morgan at 2025-07-30T13:16:45+00:00 alpha: new version, 15.0a1 (windows-x86_64) - - - - - 9029c1b9 by Morgan at 2025-07-30T13:16:45+00:00 alpha: new version, 15.0a1 - - - - - 47 changed files: - update_3/alpha/download-android-aarch64.json - update_3/alpha/download-android-armv7.json - update_3/alpha/download-android-x86.json - update_3/alpha/download-android-x86_64.json - update_3/alpha/download-linux-i686.json - update_3/alpha/download-linux-x86_64.json - update_3/alpha/download-macos.json - update_3/alpha/download-windows-i686.json - update_3/alpha/download-windows-x86_64.json - update_3/alpha/downloads.json - update_3/alpha/linux-i686/.htaccess - update_3/alpha/linux-i686/14.5a3-14.5a6-linux-i686.xml → update_3/alpha/linux-i686/update-14.5a4-15.0a1-linux-i686.xml - update_3/alpha/linux-i686/14.5a4-14.5a6-linux-i686.xml → update_3/alpha/linux-i686/update-14.5a5-15.0a1-linux-i686.xml - update_3/alpha/linux-i686/14.5a5-14.5a6-linux-i686.xml → update_3/alpha/linux-i686/update-14.5a6-15.0a1-linux-i686.xml - update_3/alpha/linux-i686/14.5a6-linux-i686.xml → update_3/alpha/linux-i686/update-15.0a1-linux-i686.xml - update_3/alpha/linux-x86_64/.htaccess - update_3/alpha/linux-x86_64/14.5a3-14.5a6-linux-x86_64.xml → update_3/alpha/linux-x86_64/update-14.5a4-15.0a1-linux-x86_64.xml - update_3/alpha/linux-x86_64/14.5a4-14.5a6-linux-x86_64.xml → update_3/alpha/linux-x86_64/update-14.5a5-15.0a1-linux-x86_64.xml - update_3/alpha/linux-x86_64/14.5a5-14.5a6-linux-x86_64.xml → update_3/alpha/linux-x86_64/update-14.5a6-15.0a1-linux-x86_64.xml - update_3/alpha/linux-x86_64/14.5a6-linux-x86_64.xml → update_3/alpha/linux-x86_64/update-15.0a1-linux-x86_64.xml - update_3/alpha/macos/.htaccess - − update_3/alpha/macos/14.5a3-14.5a6-macos.xml - − update_3/alpha/macos/14.5a4-14.5a6-macos.xml - − update_3/alpha/macos/14.5a5-14.5a6-macos.xml - − update_3/alpha/macos/14.5a6-macos.xml - + update_3/alpha/macos/update-14.5a4-15.0a1-macos.xml - + update_3/alpha/macos/update-14.5a5-15.0a1-macos.xml - + update_3/alpha/macos/update-14.5a6-15.0a1-macos.xml - + update_3/alpha/macos/update-15.0a1-macos.xml - update_3/alpha/windows-i686/.htaccess - − update_3/alpha/windows-i686/14.5a3-14.5a6-windows-i686.xml - − update_3/alpha/windows-i686/14.5a4-14.5a6-windows-i686.xml - − update_3/alpha/windows-i686/14.5a5-14.5a6-windows-i686.xml - − update_3/alpha/windows-i686/14.5a6-windows-i686.xml - + update_3/alpha/windows-i686/update-14.5a4-15.0a1-windows-i686.xml - + update_3/alpha/windows-i686/update-14.5a5-15.0a1-windows-i686.xml - + update_3/alpha/windows-i686/update-14.5a6-15.0a1-windows-i686.xml - + update_3/alpha/windows-i686/update-15.0a1-windows-i686.xml - update_3/alpha/windows-x86_64/.htaccess - − update_3/alpha/windows-x86_64/14.5a3-14.5a6-windows-x86_64.xml - − update_3/alpha/windows-x86_64/14.5a4-14.5a6-windows-x86_64.xml - − update_3/alpha/windows-x86_64/14.5a5-14.5a6-windows-x86_64.xml - − update_3/alpha/windows-x86_64/14.5a6-windows-x86_64.xml - + update_3/alpha/windows-x86_64/update-14.5a4-15.0a1-windows-x86_64.xml - + update_3/alpha/windows-x86_64/update-14.5a5-15.0a1-windows-x86_64.xml - + update_3/alpha/windows-x86_64/update-14.5a6-15.0a1-windows-x86_64.xml - + update_3/alpha/windows-x86_64/update-15.0a1-windows-x86_64.xml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-141.0a1-16.0-2
by brizental (＠brizental) 30 Jul '25

30 Jul '25

brizental pushed new branch tor-browser-141.0a1-16.0-2 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41527: Update libdmg-hfsplus and enable LZMA compression on dmgs.
by Pier Angelo Vendrame (＠pierov) 30 Jul '25

30 Jul '25

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 0bd556ab by Pier Angelo Vendrame at 2025-07-30T13:58:02+02:00 Bug 41527: Update libdmg-hfsplus and enable LZMA compression on dmgs. - - - - - 4 changed files: - projects/browser/ddmg.sh - projects/libdmg-hfsplus/config - tools/signing/ddmg.sh - tools/signing/gatekeeper-bundling.sh Changes: ===================================== projects/browser/ddmg.sh ===================================== @@ -37,7 +37,7 @@ hfsplus "$hfsfile" symlink /Applications /Applications # Show the volume icon hfsplus "$hfsfile" attr / C -dmg dmg "$hfsfile" [% c('dmg_out', { error_if_undef => 1 }) %] +dmg dmg --compression lzma --level 5 --run-sectors 2048 "$hfsfile" [% c('dmg_out', { error_if_undef => 1 }) %] popd rm -Rf "$dmg_tmpdir" ===================================== projects/libdmg-hfsplus/config ===================================== @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 version: '[% c("abbrev") %]' git_url: https://github.com/mozilla/libdmg-hfsplus -git_hash: a0a959bd25370c1c0a00c9ec525e3e78285adbf9 +git_hash: d6287b5afc2406b398de42f74eba432f2123b937 filename: '[% project %]-[% c("version") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]' container: use_container: 1 @@ -10,6 +10,7 @@ var: - build-essential - zlib1g-dev - libbz2-dev + - liblzma-dev input_files: - project: container-image - name: cmake ===================================== tools/signing/ddmg.sh ===================================== @@ -57,7 +57,7 @@ hfsplus "$hfsfile" symlink /Applications /Applications # Show the volume icon hfsplus "$hfsfile" attr / C -dmg dmg "$hfsfile" "$dest_file" +dmg dmg --compression lzma --level 5 --run-sectors 2048 "$hfsfile" "$dest_file" echo "Finished: " $(basename $dest_file) ===================================== tools/signing/gatekeeper-bundling.sh ===================================== @@ -39,7 +39,7 @@ test -f $faketime_path || \ exit_error "$faketime_path is missing" test -d $macos_stapled_dir || \ exit_error "The stapled macos zip files should be placed in directory $macos_stapled_dir" -libdmg_file="$script_dir/../../out/libdmg-hfsplus/libdmg-hfsplus-a0a959bd2537-f2819c.tar.zst" +libdmg_file="$script_dir/../../out/libdmg-hfsplus/libdmg-hfsplus-d6287b5afc24-6f206c.tar.zst" test -f "$libdmg_file" || \ exit_error "$libdmg_file is missing." \ "You can build it with:" \ View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-140.1.0esr-15.0-1] fixup! MB 37: Customization for the about dialog
by Pier Angelo Vendrame (＠pierov) 30 Jul '25

30 Jul '25

Pier Angelo Vendrame pushed to branch mullvad-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 1a5441f6 by Pier Angelo Vendrame at 2025-07-30T11:53:50+02:00 fixup! MB 37: Customization for the about dialog MB 451: The restart to apply button doesn't work - - - - - 1 changed file: - browser/base/content/aboutDialog.xhtml Changes: ===================================== browser/base/content/aboutDialog.xhtml ===================================== @@ -104,12 +104,10 @@ <label id="version" class="update"/> <label id="releasenotes" is="text-link" hidden="true" data-l10n-id="releaseNotes-link"/> </hbox> -#ifndef MULLVAD_BROWSER - <description class="text-blurb"> + <description class="text-blurb" hidden="true"> <label id="aboutDialogHelpLink" is="text-link" data-l10n-id="aboutdialog-help-user"/> <label id="submit-feedback" is="text-link" data-l10n-id="aboutdialog-submit-feedback"/> </description> -#endif </vbox> #endif </hbox> View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/1a5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/1a5… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-140.1.0esr-15.0-1] fixup! BB 43322: Customize the font visibility lists.
by Pier Angelo Vendrame (＠pierov) 30 Jul '25

30 Jul '25

Pier Angelo Vendrame pushed to branch mullvad-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Mullvad Browser Commits: ac53dfbf by Pier Angelo Vendrame at 2025-07-30T11:33:34+02:00 fixup! BB 43322: Customize the font visibility lists. BB 44046: Replace the macro we use in StandardFonts-win10.inc. For consistency with other changes in the same commit, we should use BASE_BROWSER_VERSION rather than BASE_BROWSER_UPDATE. - - - - - 1 changed file: - gfx/thebes/StandardFonts-win10.inc Changes: ===================================== gfx/thebes/StandardFonts-win10.inc ===================================== @@ -2,7 +2,7 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -#ifndef BASE_BROWSER_UPDATE +#ifndef BASE_BROWSER_VERSION // List of standard font families installed as part of Windows 10 // from https://docs.microsoft.com/en-us/typography/fonts/windows_10_font_list // TODO: check whether we need to list legacy styled family names like "... Light". View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/ac5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/ac5… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-140.1.0esr-15.0-1] fixup! BB 43322: Customize the font visibility lists.
by Pier Angelo Vendrame (＠pierov) 30 Jul '25

30 Jul '25

Pier Angelo Vendrame pushed to branch base-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 6b8311e7 by Pier Angelo Vendrame at 2025-07-30T11:32:07+02:00 fixup! BB 43322: Customize the font visibility lists. BB 44046: Replace the macro we use in StandardFonts-win10.inc. For consistency with other changes in the same commit, we should use BASE_BROWSER_VERSION rather than BASE_BROWSER_UPDATE. - - - - - 1 changed file: - gfx/thebes/StandardFonts-win10.inc Changes: ===================================== gfx/thebes/StandardFonts-win10.inc ===================================== @@ -2,7 +2,7 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -#ifndef BASE_BROWSER_UPDATE +#ifndef BASE_BROWSER_VERSION // List of standard font families installed as part of Windows 10 // from https://docs.microsoft.com/en-us/typography/fonts/windows_10_font_list // TODO: check whether we need to list legacy styled family names like "... Light". View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6b8311e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6b8311e… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-140.1.0esr-15.0-1] fixup! BB 43322: Customize the font visibility lists.
by Pier Angelo Vendrame (＠pierov) 30 Jul '25

30 Jul '25

Pier Angelo Vendrame pushed to branch tor-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: e4ee090b by Pier Angelo Vendrame at 2025-07-30T10:59:35+02:00 fixup! BB 43322: Customize the font visibility lists. BB 44046: Replace the macro we use in StandardFonts-win10.inc. For consistency with other changes in the same commit, we should use BASE_BROWSER_VERSION rather than BASE_BROWSER_UPDATE. - - - - - 1 changed file: - gfx/thebes/StandardFonts-win10.inc Changes: ===================================== gfx/thebes/StandardFonts-win10.inc ===================================== @@ -2,7 +2,7 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -#ifndef BASE_BROWSER_UPDATE +#ifndef BASE_BROWSER_VERSION // List of standard font families installed as part of Windows 10 // from https://docs.microsoft.com/en-us/typography/fonts/windows_10_font_list // TODO: check whether we need to list legacy styled family names like "... Light". View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e4ee090… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e4ee090… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-140.1.0esr-15.0-1] fixup! TB 27476: Implement about:torconnect captive portal within Tor Browser
by henry (＠henry) 29 Jul '25

29 Jul '25

henry pushed to branch tor-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 44539ee4 by Henry Wilkes at 2025-07-29T16:01:24+00:00 fixup! TB 27476: Implement about:torconnect captive portal within Tor Browser TB 43832: Drop eslint-env - - - - - 1 changed file: - toolkit/components/torconnect/content/torConnectUrlbarButton.js Changes: ===================================== toolkit/components/torconnect/content/torConnectUrlbarButton.js ===================================== @@ -1,5 +1,3 @@ -/* eslint-env mozilla/browser-window */ - /** * A "Connect" button shown in the urlbar when not connected to tor and in tabs * other than about:torconnect. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/44539ee… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/44539ee… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-140.1.0esr-15.0-1] TB 43817: Add tests for Tor Browser
by brizental (＠brizental) 29 Jul '25

29 Jul '25

brizental pushed to branch tor-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 692f39dc by Beatriz Rizental at 2025-07-29T17:03:46+02:00 TB 43817: Add tests for Tor Browser This is a catch all commits for adding any tests or testing infrastructure that doesn't obviously fit any other commit. - - - - - 3 changed files: - testing/moz.build - + testing/tor/marionette.toml - + testing/tor/test_network_check.py Changes: ===================================== testing/moz.build ===================================== @@ -17,3 +17,5 @@ DIRS += ["mozbase", "mozharness"] PERFTESTS_MANIFESTS += [ "performance/perftest.toml", ] + +MARIONETTE_MANIFESTS += ["tor/marionette.toml"] ===================================== testing/tor/marionette.toml ===================================== @@ -0,0 +1,3 @@ +[DEFAULT] + +["test_network_check.py"] ===================================== testing/tor/test_network_check.py ===================================== @@ -0,0 +1,68 @@ +from marionette_driver import By, Wait, errors +from marionette_driver.localization import L10n +from marionette_harness import MarionetteTestCase + +NETWORK_CHECK_URL = "https://check.torproject.org/" +TOR_BOOTSTRAP_TIMEOUT = 30 # 30s + +STRINGS_LOCATION = "chrome://torbutton/locale/torConnect.properties" + + +class TestNetworkCheck(MarionetteTestCase): + def setUp(self): + MarionetteTestCase.setUp(self) + + self.l10n = L10n(self.marionette) + + def attemptConnection(self, tries=1): + if tries > 3: + self.assertTrue(False, "Failed to connect to Tor after 3 attempts") + + connectBtn = self.marionette.find_element(By.ID, "connectButton") + Wait(self.marionette, timeout=10).until( + lambda _: connectBtn.is_displayed(), + message="Timed out waiting for tor connect button to show up.", + ) + connectBtn.click() + + try: + + def check(m): + if not m.get_url().startswith("about:torconnect"): + # We have finished connecting and have been redirected. + return True + + try: + heading = self.marionette.find_element(By.ID, "tor-connect-heading") + except errors.NoSuchElementException: + # Page is probably redirecting. + return False + + if heading.text not in [ + self.l10n.localize_property( + [STRINGS_LOCATION], "torConnect.torConnecting" + ), + self.l10n.localize_property( + [STRINGS_LOCATION], "torConnect.torConnected" + ), + ]: + raise ValueError("Tor connect page is not connecting or connected") + + return False + + Wait(self.marionette, timeout=TOR_BOOTSTRAP_TIMEOUT).until(check) + except (errors.TimeoutException, ValueError): + cancelBtn = self.marionette.find_element(By.ID, "cancelButton") + if cancelBtn.is_displayed(): + cancelBtn.click() + + self.attemptConnection(tries + 1) + + def test_network_check(self): + self.attemptConnection() + self.marionette.navigate(NETWORK_CHECK_URL) + self.assertRegex( + self.marionette.title, + r"^Congratulations\.", + f"{NETWORK_CHECK_URL} should have the expected title.", + ) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/692f39d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/692f39d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-140.1.0esr-15.0-1] fixup! BB 41581: Hide NoScript extension's toolbar button by default.
by morgan (＠morgan) 29 Jul '25

29 Jul '25

morgan pushed to branch mullvad-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 1168363d by Henry Wilkes at 2025-07-29T13:02:04+00:00 fixup! BB 41581: Hide NoScript extension's toolbar button by default. TB 43874: Incorporate our unified extension button hiding logic into mozilla's changes for ESR 140. - - - - - 2 changed files: - browser/base/content/browser-addons.js - browser/themes/shared/addons/unified-extensions.css Changes: ===================================== browser/base/content/browser-addons.js ===================================== @@ -2026,13 +2026,13 @@ var gUnifiedExtensions = { // extension.hideUnifiedWhenEmpty, which can effect the visibility of the // unified-extensions-button. // See tor-browser#41581. - this._hideNoScriptObserver = () => this._updateVisibility(); + this._hideNoScriptObserver = () => this._updateHideEmpty(); Services.prefs.addObserver(HIDE_NO_SCRIPT_PREF, this._hideNoScriptObserver); Services.prefs.addObserver( HIDE_UNIFIED_WHEN_EMPTY_PREF, this._hideNoScriptObserver ); - this._updateVisibility(); + this._updateHideEmpty(); // Will trigger updateButtonVisibility; this._initialized = true; }, @@ -2071,10 +2071,14 @@ var gUnifiedExtensions = { }, onAppMenuShowing() { + // Only show the extension menu item if the extension button is not pinned + // and the extension popup is not empty. + // NOTE: This condition is different than _shouldShowButton. + const hideExtensionItem = this.buttonAlwaysVisible || this._hideEmpty; document.getElementById("appMenu-extensions-themes-button").hidden = - !this.buttonAlwaysVisible; + !hideExtensionItem; document.getElementById("appMenu-unified-extensions-button").hidden = - this.buttonAlwaysVisible; + hideExtensionItem; }, onLocationChange(browser, webProgress, _request, _uri, flags) { @@ -2089,9 +2093,14 @@ var gUnifiedExtensions = { }, updateButtonVisibility() { + if (this._hideEmpty === null) { + return; + } // TODO: Bug 1778684 - Auto-hide button when there is no active extension. + // Hide the extension button when it is empty. See tor-browser#41581. + // Likely will conflict with mozilla's Bug 1778684. See tor-browser#42635. let shouldShowButton = - this.buttonAlwaysVisible || + this._shouldShowButton || // If anything is anchored to the button, keep it visible. this._button.open || // Button will be open soon - see ensureButtonShownBeforeAttachingPanel. @@ -2117,7 +2126,7 @@ var gUnifiedExtensions = { }, ensureButtonShownBeforeAttachingPanel(panel) { - if (!this.buttonAlwaysVisible && !this._button.open) { + if (!this._shouldShowButton && !this._button.open) { // When the panel is anchored to the button, its "open" attribute will be // set, which visually renders as a "button pressed". Until we get there, // we need to make sure that the button is visible so that it can serve @@ -2131,7 +2140,7 @@ var gUnifiedExtensions = { if (this._button.open) { this._buttonShownBeforeButtonOpen = false; } - if (!this.buttonAlwaysVisible && !this._button.open) { + if (!this._shouldShowButton && !this._button.open) { this.updateButtonVisibility(); } }, @@ -2261,18 +2270,35 @@ var gUnifiedExtensions = { }, /** - * Potentially hide the unified-extensions-button if it would be empty. + * Whether the extension button should be hidden because it is empty. Or + * `null` when uninitialised. + * + * @type {?boolean} */ - // See tor-browser#41581. - // The behaviour overlaps with a proposal in mozilla Bug 1778684, which has - // not yet been implemented as of June 2024 (start of ESR 128). - // See tor-browser#42635 - _updateVisibility() { - this.button.classList.toggle( - "hide-empty", + _hideEmpty: null, + + /** + * Update the _hideEmpty attribute when the preference or hasExtensionsInPanel + * value may have changed. + */ + _updateHideEmpty() { + const prevHideEmpty = this._hideEmpty; + this._hideEmpty = Services.prefs.getBoolPref(HIDE_UNIFIED_WHEN_EMPTY_PREF, true) && - !this.hasExtensionsInPanel() - ); + !this.hasExtensionsInPanel(); + if (this._hideEmpty !== prevHideEmpty) { + this.updateButtonVisibility(); + } + }, + + /** + * Whether we should show the extension button, regardless of whether it is + * needed as a popup anchor, etc. + * + * @type {boolean} + */ + get _shouldShowButton() { + return this.buttonAlwaysVisible && !this._hideEmpty; }, /** @@ -2860,15 +2886,18 @@ var gUnifiedExtensions = { }, onWidgetRemoved() { - this._updateVisibility(); + // hasExtensionsInPanel may have changed. + this._updateHideEmpty(); }, onWidgetDestroyed() { - this._updateVisibility(); + // hasExtensionsInPanel may have changed. + this._updateHideEmpty(); }, onWidgetAdded(aWidgetId, aArea) { - this._updateVisibility(); + // hasExtensionsInPanel may have changed. + this._updateHideEmpty(); // When we pin a widget to the toolbar from a narrow window, the widget // will be overflowed directly. In this case, we do not want to change the @@ -2885,7 +2914,8 @@ var gUnifiedExtensions = { }, onWidgetOverflow(aNode) { - this._updateVisibility(); + // hasExtensionsInPanel may have changed. + this._updateHideEmpty(); // We register a CUI listener for each window so we make sure that we // handle the event for the right window here. @@ -2897,7 +2927,8 @@ var gUnifiedExtensions = { }, onWidgetUnderflow(aNode) { - this._updateVisibility(); + // hasExtensionsInPanel may have changed. + this._updateHideEmpty(); // We register a CUI listener for each window so we make sure that we // handle the event for the right window here. ===================================== browser/themes/shared/addons/unified-extensions.css ===================================== @@ -294,21 +294,3 @@ unified-extensions-item.unified-extensions-item { } } } - -/* Extra rule for tor-browser. See tor-browser#41581. - * We want to hide the unified-extensions-button when it is empty. - * However, this button is needed as an anchor for addon notifications. E.g. - * when installing another addon and permissions pop up. - * If we simply marked it as "hidden" then it would not be used as an anchor, so - * the popup would fall back to using the identity button as an anchor instead. - * So instead, we use "visibility: collapse" whilst it is empty *and* it is not - * being used as an anchor (the open attribute is missing). */ -#unified-extensions-button.hide-empty:not([open]) { - visibility: collapse; - /* Ensure getBoundingClientRect().width returns 0. - * Even though this button is collapsed, and therefore should not take up any - * layout space, getBoundingClientRect will still measure the padding. - * If this was not zero, OverflowableToolbar#getOverflowInfo would - * over-measure the children width and would always overflow. */ - padding-inline: 0; -} View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/116… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/116… You're receiving this email because of your account on gitlab.torproject.org.

1 0