- tor-commits - lists.torproject.org

[Git][tpo/applications/tor-browser][tor-browser-140.1.0esr-15.0-1] fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 07 Aug '25

07 Aug '25

Pier Angelo Vendrame pushed to branch tor-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: fbc1f480 by Pier Angelo Vendrame at 2025-08-07T11:39:52+02:00 fixup! Firefox preference overrides. BB 44062: Enable touch events on Windows and Android. Auto-detection makes some properties available on the global scope only when touch support is actually available, but this introduces entorpy. Let's force touch enabled in Windows+Android and disable it elsewhere. This improves consistency with the spoofed number of touch points. - - - - - 2 changed files: - browser/app/profile/001-base-profile.js - mobile/android/app/000-tor-browser-android.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -443,9 +443,12 @@ pref("dom.webmidi.enabled", false); // Bug 41398: Disable Web MIDI API // randomized IDs when this pref is true). // Defense-in-depth (already the default value) from Firefox 119 or 120. pref("media.devices.enumerate.legacy.enabled", false); -// Bug 10286: Always disable Touch API. -// We might need to deepen this topic, see tor-browser#42069. +// Touch events (tor-browser#10286, tor-browser#42069, tor-browser#44062) +#if defined(XP_WIN) || defined(ANDROID) +pref("dom.w3c_touch_events.enabled", 1); +#else pref("dom.w3c_touch_events.enabled", 0); +#endif #ifndef ANDROID // Bug 42138: Disable touch-based overscroll UX pref("apz.overscroll.enabled", false); ===================================== mobile/android/app/000-tor-browser-android.js ===================================== @@ -23,9 +23,6 @@ pref("privacy.clearOnShutdown.siteSettings", true); // controls if we want camera support pref("media.realtime_decoder.enabled", false); -// Enable touch events on Android (highlighting text, etc) -pref("dom.w3c_touch_events.enabled", 2); - // No HLS support for now due to browser freezing, see: #29859. pref("media.hls.enabled", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/fbc1f48… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/fbc1f48… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41442: Update the generate-bugzilla-triage-csv script for Tor Browser 16.0
by Pier Angelo Vendrame (＠pierov) 07 Aug '25

07 Aug '25

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: c088e842 by Morgan at 2025-08-06T18:10:21+00:00 Bug 41442: Update the generate-bugzilla-triage-csv script for Tor Browser 16.0 - - - - - 1 changed file: - tools/browser/generate-bugzilla-triage-csv Changes: ===================================== tools/browser/generate-bugzilla-triage-csv ===================================== @@ -1,8 +1,14 @@ #!/usr/bin/env bash # gitlab labels for review tickets -browser_label="15.0 stable" -esr_label="esr-140" +browser_label="Apps::Product::TorBrowser" +esr_label="esr-next" +priority_label="Priority::Blocker" +impact_label="Impact::Unknown" +type_label="Apps::Type::Audit" + +# milestone for the next major Tor Browser release +milestone="Tor Browser 16.0" # prints to stderr function echoerr() { echo "$@" 1>&2; } @@ -10,18 +16,17 @@ function echoerr() { echo "$@" 1>&2; } script_dir=$(dirname "${BASH_ARGV0:-$0}") # help dialog -if [ "$#" -lt 5 ]; then - echoerr "Usage: $0 <ff-version> <begin-commit> <end-commit> <gitlab-audit-issue> <reviewers...>" +if [ "$#" -ne 4 ]; then + echoerr "Usage: $0 <ff-version> <begin-commit> <end-commit> <gitlab-audit-issue>" echoerr echoerr "ff-version rapid-release Firefox version to audit" - echoerr "begin-commit starting gecko-dev commit of this Firefox version" - echoerr "end-commit ending gecko-dev commit of this Firefox version" + echoerr "begin-commit starting firefox commit of this Firefox version" + echoerr "end-commit ending firefox commit of this Firefox version" echoerr "gitlab-audit-issue tor-browser GitLab issue number for this audit" - echoerr "reviewers... space-separated list of reviewers responsible for this audit" echoerr "" echoerr "Example:" echoerr "" - echoerr "$0 129 FIREFOX_NIGHTLY_128_END FIREFOX_NIGHTLY_129_END 43303 morgan pierov henry" + echoerr "$0 129 FIREFOX_NIGHTLY_128_END FIREFOX_NIGHTLY_129_END 43303" exit 1 fi @@ -219,7 +224,8 @@ jq '. | sort_by([.component, .id])[] | "\(.id)|\(.component)|\(.summary)"' ${uni # review issue title new_issue_title=$(url_encode "Review Mozilla ${id}: ${summary_short}") # review issue description + labeling (14.0 stable, FF128-esr, Next) - new_issue_description=$(url_encode "### Bugzilla: ${bugzilla_url}")%0A$(url_encode "/label ~\"${browser_label}\" ~\"${esr_label}\" ~\"Bugzilla Review\" ~Next")%0A$(url_encode "/relate tpo/applications/tor-browser#${audit_issue}")%0A%0A$(url_encode "")%0A + new_issue_description=$(url_encode "### Bugzilla: ${bugzilla_url}")%0A$(url_encode "/label ~\"${browser_label}\" ~\"${esr_label}\" ~\"${priority_label}\" ~\"${impact_label}\" ~\"${type_label}\"")%0A$(url_encode "/milestone %\"{milestone}\"")%0A$(url_encode "/relate tpo/applications/tor-browser#${audit_issue}")%0A%0A$(url_encode "")%0A + # url which create's new issue with title and description pre-populated new_issue_url="https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/new?iss…" @@ -231,12 +237,6 @@ jq '. | sort_by([.component, .id])[] | "\(.id)|\(.component)|\(.summary)"' ${uni fi done -echo -echo "\"Triaged by:\"" -for reviewer in $reviewers; do - reviewer=$(csv_escape "${reviewer}") - echo "\"FALSE\",\"${reviewer}\"" -done echo bugzilla_query="=HYPERLINK(\"${bugzilla_query}\", \"Bugzilla query\")" View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-140.1.0esr-15.0-1] fixup! Base Browser's .mozconfigs.
by Pier Angelo Vendrame (＠pierov) 06 Aug '25

06 Aug '25

Pier Angelo Vendrame pushed to branch mullvad-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Mullvad Browser Commits: fd1cb0c8 by Pier Angelo Vendrame at 2025-08-06T19:36:44+02:00 fixup! Base Browser's .mozconfigs. BB 44067: Build geckodriver only on Linux. After Bug 1908788, geckodriver has become a host tool. So, even when we cross-compile, we get Linux binaries, and we stopped shipping them in tor-browser-build. Therefore, we can disable also their compilation. - - - - - 2 changed files: - browser/config/mozconfigs/base-browser - mozconfig-linux-x86_64 Changes: ===================================== browser/config/mozconfigs/base-browser ===================================== @@ -41,6 +41,3 @@ ac_add_options --disable-legacy-profile-creation if test -z "$WASI_SYSROOT"; then ac_add_options --without-wasm-sandboxed-libraries fi - -# tor-browser#42337 -ac_add_options --enable-geckodriver ===================================== mozconfig-linux-x86_64 ===================================== @@ -11,3 +11,5 @@ ac_add_options --enable-default-toolkit=cairo-gtk3 # Let's make sure no preference is enabling either Adobe's or Google's CDM. ac_add_options --disable-eme +# tor-browser#44067: geckodriver has become a host-only tool +ac_add_options --enable-geckodriver View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/fd1… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/fd1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-140.1.0esr-15.0-1] fixup! Base Browser's .mozconfigs.
by Pier Angelo Vendrame (＠pierov) 06 Aug '25

06 Aug '25

Pier Angelo Vendrame pushed to branch base-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: d7bd2c46 by Pier Angelo Vendrame at 2025-08-06T19:35:36+02:00 fixup! Base Browser's .mozconfigs. BB 44067: Build geckodriver only on Linux. After Bug 1908788, geckodriver has become a host tool. So, even when we cross-compile, we get Linux binaries, and we stopped shipping them in tor-browser-build. Therefore, we can disable also their compilation. - - - - - 2 changed files: - browser/config/mozconfigs/base-browser - mozconfig-linux-x86_64 Changes: ===================================== browser/config/mozconfigs/base-browser ===================================== @@ -47,7 +47,4 @@ if test -z "$WASI_SYSROOT"; then ac_add_options --without-wasm-sandboxed-libraries fi -# tor-browser#42337 -ac_add_options --enable-geckodriver - ac_add_options --with-relative-data-dir=BaseBrowser/Data/Browser ===================================== mozconfig-linux-x86_64 ===================================== @@ -11,3 +11,5 @@ ac_add_options --enable-default-toolkit=cairo-gtk3 # Let's make sure no preference is enabling either Adobe's or Google's CDM. ac_add_options --disable-eme +# tor-browser#44067: geckodriver has become a host-only tool +ac_add_options --enable-geckodriver View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d7bd2c4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d7bd2c4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-140.1.0esr-15.0-1] fixup! Base Browser's .mozconfigs.
by Pier Angelo Vendrame (＠pierov) 06 Aug '25

06 Aug '25

Pier Angelo Vendrame pushed to branch tor-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 47265bc8 by Pier Angelo Vendrame at 2025-08-06T18:35:32+02:00 fixup! Base Browser's .mozconfigs. BB 44067: Build geckodriver only on Linux. After Bug 1908788, geckodriver has become a host tool. So, even when we cross-compile, we get Linux binaries, and we stopped shipping them in tor-browser-build. Therefore, we can disable also their compilation. - - - - - 2 changed files: - browser/config/mozconfigs/base-browser - mozconfig-linux-x86_64 Changes: ===================================== browser/config/mozconfigs/base-browser ===================================== @@ -43,6 +43,3 @@ ac_add_options --disable-legacy-profile-creation if test -z "$WASI_SYSROOT"; then ac_add_options --without-wasm-sandboxed-libraries fi - -# tor-browser#42337 -ac_add_options --enable-geckodriver ===================================== mozconfig-linux-x86_64 ===================================== @@ -11,3 +11,5 @@ ac_add_options --enable-default-toolkit=cairo-gtk3 # Let's make sure no preference is enabling either Adobe's or Google's CDM. ac_add_options --disable-eme +# tor-browser#44067: geckodriver has become a host-only tool +ac_add_options --enable-geckodriver View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/47265bc… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/47265bc… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-140.1.0esr-15.0-1] fixup! Firefox preference overrides.
by brizental (＠brizental) 05 Aug '25

05 Aug '25

brizental pushed to branch mullvad-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 392f3202 by Beatriz Rizental at 2025-08-05T18:33:36+02:00 fixup! Firefox preference overrides. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -225,6 +225,11 @@ pref("toolkit.telemetry.firstShutdownPing.enabled", false); // Added in tor-brow pref("toolkit.telemetry.updatePing.enabled", false); // Make sure updater telemetry is disabled; see #25909. pref("toolkit.telemetry.bhrPing.enabled", false); pref("toolkit.telemetry.coverage.opt-out", true); +// Force all telemtry identifier to their canary values tor-browser#43750 +pref("toolkit.telemetry.cachedClientID", "c0ffeec0-ffee-c0ff-eec0-ffeec0ffeec0", locked); +pref("toolkit.telemetry.cachedProfileGroupID", "decafdec-afde-cafd-ecaf-decafdecafde", locked); +pref("datareporting.dau.cachedUsageProfileID", "beefbeef-beef-beef-beef-beeefbeefbee", locked); +pref("datareporting.dau.cachedUsageProfileGroupID", "b0bacafe-b0ba-cafe-b0ba-cafeb0bacafe", locked); pref("toolkit.coverage.opt-out", true); pref("toolkit.coverage.endpoint.base", ""); pref("browser.tabs.crashReporting.sendReport", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/392… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/392… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-140.1.0esr-15.0-1] fixup! Firefox preference overrides.
by brizental (＠brizental) 05 Aug '25

05 Aug '25

brizental pushed to branch base-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: e7eb3783 by Beatriz Rizental at 2025-08-05T18:28:59+02:00 fixup! Firefox preference overrides. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -225,6 +225,11 @@ pref("toolkit.telemetry.firstShutdownPing.enabled", false); // Added in tor-brow pref("toolkit.telemetry.updatePing.enabled", false); // Make sure updater telemetry is disabled; see #25909. pref("toolkit.telemetry.bhrPing.enabled", false); pref("toolkit.telemetry.coverage.opt-out", true); +// Force all telemtry identifier to their canary values tor-browser#43750 +pref("toolkit.telemetry.cachedClientID", "c0ffeec0-ffee-c0ff-eec0-ffeec0ffeec0", locked); +pref("toolkit.telemetry.cachedProfileGroupID", "decafdec-afde-cafd-ecaf-decafdecafde", locked); +pref("datareporting.dau.cachedUsageProfileID", "beefbeef-beef-beef-beef-beeefbeefbee", locked); +pref("datareporting.dau.cachedUsageProfileGroupID", "b0bacafe-b0ba-cafe-b0ba-cafeb0bacafe", locked); pref("toolkit.coverage.opt-out", true); pref("toolkit.coverage.endpoint.base", ""); pref("browser.tabs.crashReporting.sendReport", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e7eb378… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e7eb378… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-140.1.0esr-15.0-1] fixup! Firefox preference overrides.
by brizental (＠brizental) 05 Aug '25

05 Aug '25

brizental pushed to branch tor-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 55b07453 by Beatriz Rizental at 2025-08-05T17:45:48+02:00 fixup! Firefox preference overrides. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -225,6 +225,11 @@ pref("toolkit.telemetry.firstShutdownPing.enabled", false); // Added in tor-brow pref("toolkit.telemetry.updatePing.enabled", false); // Make sure updater telemetry is disabled; see #25909. pref("toolkit.telemetry.bhrPing.enabled", false); pref("toolkit.telemetry.coverage.opt-out", true); +// Force all telemtry identifier to their canary values tor-browser#43750 +pref("toolkit.telemetry.cachedClientID", "c0ffeec0-ffee-c0ff-eec0-ffeec0ffeec0", locked); +pref("toolkit.telemetry.cachedProfileGroupID", "decafdec-afde-cafd-ecaf-decafdecafde", locked); +pref("datareporting.dau.cachedUsageProfileID", "beefbeef-beef-beef-beef-beeefbeefbee", locked); +pref("datareporting.dau.cachedUsageProfileGroupID", "b0bacafe-b0ba-cafe-b0ba-cafeb0bacafe", locked); pref("toolkit.coverage.opt-out", true); pref("toolkit.coverage.endpoint.base", ""); pref("browser.tabs.crashReporting.sendReport", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/55b0745… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/55b0745… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-140.1.0esr-15.0-1] 4 commits: dropme! fixup! MB 1: Mullvad Browser branding
by henry (＠henry) 05 Aug '25

05 Aug '25

henry pushed to branch mullvad-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Mullvad Browser Commits: f5000c1f by Henry Wilkes at 2025-08-05T16:34:57+01:00 dropme! fixup! MB 1: Mullvad Browser branding TB 43864: Move moz-support-link "preferences" patch out of mullvad-browser commits. The target commit no longer needs to modify moz-support-link.mjs since the changes were moved to base-browser. - - - - - 9ba2a7bf by Henry Wilkes at 2025-08-05T16:35:17+01:00 fixup! BB 42583: Modify moz-support-link for Base Browser. TB 43864: Move moz-support-link "preferences" patch to base-browser. - - - - - bf086fe6 by Henry Wilkes at 2025-08-05T16:35:18+01:00 fixup! MB 38: Mullvad Browser configuration TB 43864: Move to Mullvad Browser help URL to preferences. - - - - - 9fe4d6f4 by Henry Wilkes at 2025-08-05T16:35:19+01:00 BB 43864: Modify the urlbar for Base Browser. - - - - - 4 changed files: - browser/app/profile/000-mullvad-browser.js - browser/components/urlbar/QuickActionsLoaderDefault.sys.mjs - browser/components/urlbar/SearchModeSwitcher.sys.mjs - toolkit/content/widgets/moz-support-link/moz-support-link.mjs Changes: ===================================== browser/app/profile/000-mullvad-browser.js ===================================== @@ -2,6 +2,9 @@ pref("browser.startup.homepage", "about:mullvad-browser"); +// General browser support url. tor-browser#43864 and mullvad-browser#244. +pref("browser.base-browser-support-url", "https://mullvad.net/en/help/"); + // Do not show the bookmark panel for now, because it makes the initial browser // window (about:home) bigger, and regular pages will show letterbox margins as // a result. ===================================== browser/components/urlbar/QuickActionsLoaderDefault.sys.mjs ===================================== @@ -13,6 +13,7 @@ ChromeUtils.defineESModuleGetters(lazy, { ScreenshotsUtils: "resource:///modules/ScreenshotsUtils.sys.mjs", ActionsProviderQuickActions: "resource:///modules/ActionsProviderQuickActions.sys.mjs", + PrivateBrowsingUtils: "resource://gre/modules/PrivateBrowsingUtils.sys.mjs", }); import { AppConstants } from "resource://gre/modules/AppConstants.sys.mjs"; @@ -78,6 +79,9 @@ const DEFAULT_ACTIONS = { icon: "chrome://mozapps/skin/extensions/category-extensions.svg", label: "quickactions-addons", onPick: openAddonsUrl("addons://discover/"), + // Hide in base-browser, since we don't want to open extensions + // "recommendations" tab. tor-browser#43864. + disabled: () => true, }, bookmarks: { l10nCommands: ["quickactions-cmd-bookmarks", "quickactions-bookmarks2"], @@ -100,6 +104,12 @@ const DEFAULT_ACTIONS = { .document.getElementById("Tools:Sanitize") .doCommand(); }, + // Disable in permanent private browsing. tor-browser#43864. + // NOTE: This should also be disabled in private windows, but we don't have + // access to a Window element to check. See mozilla bug 1980912. + disabled: () => { + return lazy.PrivateBrowsingUtils.permanentPrivateBrowsing; + }, }, downloads: { l10nCommands: ["quickactions-cmd-downloads"], @@ -112,13 +122,18 @@ const DEFAULT_ACTIONS = { icon: "chrome://mozapps/skin/extensions/category-extensions.svg", label: "quickactions-extensions", onPick: openAddonsUrl("addons://list/extension"), + // Hide in base-browser since we do not want to encourage users to change + // their extensions/addons. tor-browser#43864. + disabled: () => true, }, help: { l10nCommands: ["quickactions-cmd-help"], icon: "chrome://global/skin/icons/help.svg", label: "quickactions-help", + // Open the base-browser support/help page, rather than Firefox's. + // tor-browser#43864. onPick: openUrlFun( - "https://support.mozilla.org/products/firefox?as=u&utm_source=inproduct" + Services.prefs.getStringPref("browser.base-browser-support-url", "") ), }, firefoxview: { @@ -128,6 +143,9 @@ const DEFAULT_ACTIONS = { onPick: () => { lazy.BrowserWindowTracker.getTopWindow().FirefoxViewHandler.openTab(); }, + // Hide in base-browser since firefoxview is disabled. + // tor-browser#43864 and tor-browser#42037. + disabled: () => true, }, inspect: { l10nCommands: ["quickactions-cmd-inspector2"], @@ -311,6 +329,9 @@ export class QuickActionsLoaderDefault { let keys = Object.keys(DEFAULT_ACTIONS); for (const key of keys) { let actionData = DEFAULT_ACTIONS[key]; + if (actionData.disabled?.()) { + continue; + } let messages = await lazy.gFluentStrings.formatMessages( actionData.l10nCommands.map(id => ({ id })) ); ===================================== browser/components/urlbar/SearchModeSwitcher.sys.mjs ===================================== @@ -413,6 +413,15 @@ export class SearchModeSwitcher { if (!lazy.UrlbarPrefs.get(pref)) { continue; } + if ( + source === lazy.UrlbarUtils.RESULT_SOURCE.HISTORY && + lazy.PrivateBrowsingUtils.permanentPrivateBrowsing + ) { + // Do not show the search history option in PBM. tor-browser#43864. + // Although, it can still be triggered with "^" restrict keyword or + // through an app menu item. See also mozilla bug 1980928. + continue; + } let name = lazy.UrlbarUtils.getResultSourceName(source); let { icon } = await this.#getDisplayedEngineDetails({ source, ===================================== toolkit/content/widgets/moz-support-link/moz-support-link.mjs ===================================== @@ -125,11 +125,21 @@ export default class MozSupportLink extends HTMLAnchorElement { return; } let supportPage = this.getAttribute("support-page") ?? ""; - // Customize the link in about:preferences. - // See mullvad-browser#244 and tor-browser#41910. - if (supportPage === "preferences") { - this.href = "https://mullvad.net/en/help/"; - return; + // For base-browser we sometimes want to override firefox support links with + // our own. + // See tor-browser#40899. + switch (supportPage) { + case "preferences": + // Shown twice in preferences, both as `{ -brand-short-name } Support`. + // Instead of directing to support for preferences, we link to general + // tor browser support. + // See tor-browser#32092. + this.href = Services.prefs.getStringPref( + "browser.base-browser-support-url", + "" + ); + return; + // Fall through to support.mozilla.org } let base = MozSupportLink.SUPPORT_URL + supportPage; this.href = this.hasAttribute("utm-content") View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/6e… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/6e… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-140.1.0esr-15.0-1] BB 43864: Modify the urlbar for Base Browser.
by henry (＠henry) 05 Aug '25

05 Aug '25

henry pushed to branch base-browser-140.1.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 1d477c7c by henry at 2025-08-05T15:33:07+00:00 BB 43864: Modify the urlbar for Base Browser. (cherry picked from commit 6167738479a9508101c62d2114939c3aa3a5e482) Co-authored-by: Henry Wilkes <henry(a)torproject.org> - - - - - 2 changed files: - browser/components/urlbar/QuickActionsLoaderDefault.sys.mjs - browser/components/urlbar/SearchModeSwitcher.sys.mjs Changes: ===================================== browser/components/urlbar/QuickActionsLoaderDefault.sys.mjs ===================================== @@ -13,6 +13,7 @@ ChromeUtils.defineESModuleGetters(lazy, { ScreenshotsUtils: "resource:///modules/ScreenshotsUtils.sys.mjs", ActionsProviderQuickActions: "resource:///modules/ActionsProviderQuickActions.sys.mjs", + PrivateBrowsingUtils: "resource://gre/modules/PrivateBrowsingUtils.sys.mjs", }); import { AppConstants } from "resource://gre/modules/AppConstants.sys.mjs"; @@ -78,6 +79,9 @@ const DEFAULT_ACTIONS = { icon: "chrome://mozapps/skin/extensions/category-extensions.svg", label: "quickactions-addons", onPick: openAddonsUrl("addons://discover/"), + // Hide in base-browser, since we don't want to open extensions + // "recommendations" tab. tor-browser#43864. + disabled: () => true, }, bookmarks: { l10nCommands: ["quickactions-cmd-bookmarks", "quickactions-bookmarks2"], @@ -100,6 +104,12 @@ const DEFAULT_ACTIONS = { .document.getElementById("Tools:Sanitize") .doCommand(); }, + // Disable in permanent private browsing. tor-browser#43864. + // NOTE: This should also be disabled in private windows, but we don't have + // access to a Window element to check. See mozilla bug 1980912. + disabled: () => { + return lazy.PrivateBrowsingUtils.permanentPrivateBrowsing; + }, }, downloads: { l10nCommands: ["quickactions-cmd-downloads"], @@ -112,13 +122,18 @@ const DEFAULT_ACTIONS = { icon: "chrome://mozapps/skin/extensions/category-extensions.svg", label: "quickactions-extensions", onPick: openAddonsUrl("addons://list/extension"), + // Hide in base-browser since we do not want to encourage users to change + // their extensions/addons. tor-browser#43864. + disabled: () => true, }, help: { l10nCommands: ["quickactions-cmd-help"], icon: "chrome://global/skin/icons/help.svg", label: "quickactions-help", + // Open the base-browser support/help page, rather than Firefox's. + // tor-browser#43864. onPick: openUrlFun( - "https://support.mozilla.org/products/firefox?as=u&utm_source=inproduct" + Services.prefs.getStringPref("browser.base-browser-support-url", "") ), }, firefoxview: { @@ -128,6 +143,9 @@ const DEFAULT_ACTIONS = { onPick: () => { lazy.BrowserWindowTracker.getTopWindow().FirefoxViewHandler.openTab(); }, + // Hide in base-browser since firefoxview is disabled. + // tor-browser#43864 and tor-browser#42037. + disabled: () => true, }, inspect: { l10nCommands: ["quickactions-cmd-inspector2"], @@ -311,6 +329,9 @@ export class QuickActionsLoaderDefault { let keys = Object.keys(DEFAULT_ACTIONS); for (const key of keys) { let actionData = DEFAULT_ACTIONS[key]; + if (actionData.disabled?.()) { + continue; + } let messages = await lazy.gFluentStrings.formatMessages( actionData.l10nCommands.map(id => ({ id })) ); ===================================== browser/components/urlbar/SearchModeSwitcher.sys.mjs ===================================== @@ -413,6 +413,15 @@ export class SearchModeSwitcher { if (!lazy.UrlbarPrefs.get(pref)) { continue; } + if ( + source === lazy.UrlbarUtils.RESULT_SOURCE.HISTORY && + lazy.PrivateBrowsingUtils.permanentPrivateBrowsing + ) { + // Do not show the search history option in PBM. tor-browser#43864. + // Although, it can still be triggered with "^" restrict keyword or + // through an app menu item. See also mozilla bug 1980928. + continue; + } let name = lazy.UrlbarUtils.getResultSourceName(source); let { icon } = await this.#getDisplayedEngineDetails({ source, View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/1d477c7… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/1d477c7… You're receiving this email because of your account on gitlab.torproject.org.

1 0