- tor-commits - lists.torproject.org

[Git][tpo/applications/tor-browser-build][main] 2 commits: Update rbm for rbm#40079 (make `fetch: if_needed` fetch existing branches)
by morgan (＠morgan) 29 Jan '25

29 Jan '25

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 8ed4f7ac by Nicolas Vigier at 2025-01-29T13:24:56+01:00 Update rbm for rbm#40079 (make `fetch: if_needed` fetch existing branches) - - - - - c928d6ef by Nicolas Vigier at 2025-01-29T13:42:07+01:00 Bug 41281: Remove `fetch: 1` from nightly target With rbm#40079, when we have `fetch: if_needed` (the default), rbm will now do a fetch when `git_hash` is pointing to a branch. The reason for setting `fetch: 1` in the nightly target was that we are using some git branches, which were not fetched automatically with `fetch: if_needed`. - - - - - 3 changed files: - rbm - rbm.conf - rbm.local.conf.example Changes: ===================================== rbm ===================================== @@ -1 +1 @@ -Subproject commit c6a40950607fa73861f81185764dff2bab150010 +Subproject commit 8c773150bc10133f3903841c233458dc07456d2e ===================================== rbm.conf ===================================== @@ -252,7 +252,6 @@ targets: alpha: 1 channel: alpha nightly: - fetch: 1 var: nightly: 1 channel: nightly ===================================== rbm.local.conf.example ===================================== @@ -114,15 +114,14 @@ targets: nightly: - ### By default 'fetch' is set to 1 for nightly builds, meaning that new - ### commits will be fetched automatically during each build. You can - ### disable this during development if you want to do rebuilds to test - ### a specific change, but don't want rebuilds caused by unrelated - ### changes, or if you want to decide at which point new commits are - ### fetched. When 'fetch' is set to 'if_needed', new commits will only - ### be fetched if the selected commit (or branch, or tag) is not present, - ### which means that existing branches won't be updated. In that case - ### you can fetch new commits by running 'make fetch'. - #fetch: 'if_needed' + ### By default 'fetch' is set to 'if_needed', meaning that new + ### commits will be fetched automatically during each build, if + ### the selected commit (or branch, or tag) is not present, or if + ### it is pointing to a branch. With the nightly target, some projects + ### are pointing to a branch, meaning they will be fetched for each + ### build. If you want to disable automatic fetchs and decide at + ### which point new commits are fetched, you can set 'fetch' to '0' + ### and run `make fetch` when you want to fetch new commits. + #fetch: 0 # vim: filetype=yaml sw=2 View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/rbm][main] Bug 40079: make `fetch: if_needed` fetch existing branches
by morgan (＠morgan) 29 Jan '25

29 Jan '25

morgan pushed to branch main at The Tor Project / Applications / RBM Commits: 8c773150 by Nicolas Vigier at 2025-01-29T13:24:00+01:00 Bug 40079: make `fetch: if_needed` fetch existing branches Currently, `fetch: if_needed` will avoid doing a fetch if `git_hash` can be resolved to a valid git revision. If `git_hash` is a hash or a tag, there is no need to do a fetch, since those are not supposed to be changing after a fetch. However, a branch is expected to change, so doing a fetch in this case is useful. - - - - - 2 changed files: - doc/rbm_config.asc - lib/RBM.pm Changes: ===================================== doc/rbm_config.asc ===================================== @@ -191,7 +191,8 @@ fetch:: from the remote git or hg repository should be fetched automatically. If the value is +if_needed+, the git or hg repository is fetched only if the selected commit cannot be - found in the local clone. The default is +if_needed+. + found in the local clone, or if +git_hash+ is not pointing to + a git tag or full hash. The default is +if_needed+. ENV:: This option, defined in the workspace config, is a hash ===================================== lib/RBM.pm ===================================== @@ -424,8 +424,16 @@ sub git_need_fetch { if ($fetch eq 'if_needed') { my $git_hash = project_config($project, 'git_hash', $options) || exit_error "No git_hash specified for project $project"; - my (undef, undef, $success) = capture_exec('git', 'rev-parse', + my ($stdout, undef, $success) = capture_exec('git', 'rev-parse', '--verify', "$git_hash^{commit}"); + return 1 unless $success; + # If rev-parse returns the same as git_hash, then git_hash is + # a hash and there is no need to fetch + return 0 if $stdout eq $git_hash; + # Check if git_hash is a tag. If it's not a tag or hash then + # it's probably a branch and we should do a fetch. + (undef, undef, $success) = capture_exec('git', 'rev-parse', + '--verify', "$git_hash^{tag}"); return !$success; } return $fetch; View it on GitLab: https://gitlab.torproject.org/tpo/applications/rbm/-/commit/8c773150bc10133… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/rbm/-/commit/8c773150bc10133… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.7.0esr-14.0-1] fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 28 Jan '25

28 Jan '25

Pier Angelo Vendrame pushed to branch mullvad-browser-128.7.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 8abdbbdf by Pier Angelo Vendrame at 2025-01-28T17:15:21+01:00 fixup! Firefox preference overrides. BB 43366: Do not use system accent color in inputs. We did not manage to write a reliable proof of concept for fingerprinting this, but I managed to get the color once (with Firefox on Android, which is the worse case, as the system offers to use colors from the wallpaper). - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -475,6 +475,9 @@ pref("pdfjs.disabled", false, locked); #endif // Bug 40057: Ensure system colors are not used for CSS4 colors pref("browser.display.use_system_colors", false); +// tor-browser#43366: do not use system accent color in inputs. +// See also https://bugzilla.mozilla.org/show_bug.cgi?id=1861362. +pref("widget.non-native-theme.use-theme-accent", false); // tor-browser#43236: Disable vsync on Wayland to prevent refresh rate leaks. pref("widget.wayland.vsync.enabled", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/8ab… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/8ab… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.7.0esr-14.0-1] fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 28 Jan '25

28 Jan '25

Pier Angelo Vendrame pushed to branch tor-browser-128.7.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 22f2382b by Pier Angelo Vendrame at 2025-01-28T17:14:29+01:00 fixup! Firefox preference overrides. BB 43366: Do not use system accent color in inputs. We did not manage to write a reliable proof of concept for fingerprinting this, but I managed to get the color once (with Firefox on Android, which is the worse case, as the system offers to use colors from the wallpaper). - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -475,6 +475,9 @@ pref("pdfjs.disabled", false, locked); #endif // Bug 40057: Ensure system colors are not used for CSS4 colors pref("browser.display.use_system_colors", false); +// tor-browser#43366: do not use system accent color in inputs. +// See also https://bugzilla.mozilla.org/show_bug.cgi?id=1861362. +pref("widget.non-native-theme.use-theme-accent", false); // tor-browser#43236: Disable vsync on Wayland to prevent refresh rate leaks. pref("widget.wayland.vsync.enabled", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/22f2382… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/22f2382… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.7.0esr-14.0-1] fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 28 Jan '25

28 Jan '25

Pier Angelo Vendrame pushed to branch base-browser-128.7.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: faf55dd5 by Pier Angelo Vendrame at 2025-01-28T17:14:53+01:00 fixup! Firefox preference overrides. BB 43366: Do not use system accent color in inputs. We did not manage to write a reliable proof of concept for fingerprinting this, but I managed to get the color once (with Firefox on Android, which is the worse case, as the system offers to use colors from the wallpaper). - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -475,6 +475,9 @@ pref("pdfjs.disabled", false, locked); #endif // Bug 40057: Ensure system colors are not used for CSS4 colors pref("browser.display.use_system_colors", false); +// tor-browser#43366: do not use system accent color in inputs. +// See also https://bugzilla.mozilla.org/show_bug.cgi?id=1861362. +pref("widget.non-native-theme.use-theme-accent", false); // tor-browser#43236: Disable vsync on Wayland to prevent refresh rate leaks. pref("widget.wayland.vsync.enabled", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/faf55dd… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/faf55dd… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41356: Make 14.0a4 a watershed alpha release
by boklm (＠boklm) 28 Jan '25

28 Jan '25

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 69f1477f by Nicolas Vigier at 2025-01-28T16:51:43+01:00 Bug 41356: Make 14.0a4 a watershed alpha release - - - - - 1 changed file: - projects/release/update_responses_config.yml Changes: ===================================== projects/release/update_responses_config.yml ===================================== @@ -89,6 +89,8 @@ htaccess_rewrite_rules: RewriteRule ^[^/]+/1[012]\..*/.* https://aus1.torproject.org/torbrowser/update_pre13.5a10/alpha/$0 [last] RewriteRule ^[^/]+/13\.0.*/.* https://aus1.torproject.org/torbrowser/update_pre13.5a10/alpha/$0 [last] RewriteRule ^[^/]+/13\.5a\d/.* https://aus1.torproject.org/torbrowser/update_pre13.5a10/alpha/$0 [last] + # tor-browser-build41356: Make 14.0a4 a watershed alpha release + RewriteRule ^[^/]+/14\.0a[123]/.* https://aus1.torproject.org/torbrowser/update_pre14.0a4/alpha/$0 [last] release: | # bug 26570: Redirect pre-8.0 stable users to a separate update directory RewriteRule ^[^/]+/[4567]\..*/.* https://aus1.torproject.org/torbrowser/update_pre8.0/release/$0 [last] View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/6… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-14.0] Bug 41328: Exclude tor dependencies from LD_LIBRARY_PATH.
by Pier Angelo Vendrame (＠pierov) 28 Jan '25

28 Jan '25

Pier Angelo Vendrame pushed to branch maint-14.0 at The Tor Project / Applications / tor-browser-build Commits: 3451c57c by Pier Angelo Vendrame at 2025-01-28T16:46:30+01:00 Bug 41328: Exclude tor dependencies from LD_LIBRARY_PATH. We discovered in tor-browser#43326 that adding our OpenSSL to LD_LIBRARY_PATH might cause the browser not to work in some distros. So, we decided to add them to LD_LIBRARY_PATH only for the tor daemon, instead. - - - - - 1 changed file: - projects/firefox/start-firefox Changes: ===================================== projects/firefox/start-firefox ===================================== @@ -17,9 +17,6 @@ add_LD_LIBRARY_PATH() { if [ $? -ne 0 ]; then add_LD_LIBRARY_PATH "$basedir/[% IF c("var/tor-browser") -%]TorBrowser/Tor/[% END -%]libstdc++/" fi -[% IF c("var/tor-browser") -%] -add_LD_LIBRARY_PATH "$basedir/TorBrowser/Tor/" -[% END -%] export LD_LIBRARY_PATH exec "$basedir/[% c("var/exe_name") %].real" "$@" View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/3… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/3… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.7.0esr-14.0-1] 3 commits: fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 28 Jan '25

28 Jan '25

Pier Angelo Vendrame pushed to branch mullvad-browser-128.7.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: c0e63369 by Pier Angelo Vendrame at 2025-01-28T16:41:32+01:00 fixup! Firefox preference overrides. BB 41065: Hardcode the limit of storage quota. Currently, we return min(10GB, 0.2 * available space in the fs). This is bad for systems that have less than 50GB free, especially live systems, such as Tails. Set a pref to replace the available space with a hardcoded limit (5GiB). - - - - - 59e74f2f by Pier Angelo Vendrame at 2025-01-28T16:41:34+01:00 Bug 43386: Use Firefox in the UA in RFP-exempt request. XHR requests initiated by extensions are exempt from RFP. Therefore, they report the actual app name, instead of Firefox, and the actual Firefox minor version. This happens whenever the app name has been customized and does not match a hardcoded "Firefox". - - - - - 59a91478 by Pier Angelo Vendrame at 2025-01-28T16:41:35+01:00 fixup! Firefox preference overrides. BB 43236: Disable vsync on Wayland. Vsync leaks the monitor refresh rate, therefore it is already disabled on other platforms, including Linux/X11 and Windows. - - - - - 2 changed files: - browser/app/profile/001-base-profile.js - netwerk/protocol/http/nsHttpHandler.cpp Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -87,6 +87,15 @@ pref("browser.sessionstore.privacy_level", 2); // Use the in-memory media cache and increase its maximum size (#29120) pref("browser.privatebrowsing.forceMediaMemoryCache", true); pref("media.memory_cache_max_size", 65536); +// tor-browser#41065: lie about the available quota. +// This value is in KiB, and will be divided by 5. Currently: 50GiB, to be +// coherent with Firefox's usual value. However, this might be too much for live +// systems. +// This will be the limit also after granting the persistent storage permission, +// but we are not interested in it, since we support only PBM. +// We can come back to it, and hardcode the two spaced differently, if we ever +// think we need it. +pref("dom.quotaManager.temporaryStorage.fixedLimit", 52428800); // Disable restore in case of crash (tor-browser#41503) // This should not be needed in PBM, but we added it anyway like other options. pref("browser.sessionstore.resume_from_crash", false); @@ -466,6 +475,8 @@ pref("pdfjs.disabled", false, locked); #endif // Bug 40057: Ensure system colors are not used for CSS4 colors pref("browser.display.use_system_colors", false); +// tor-browser#43236: Disable vsync on Wayland to prevent refresh rate leaks. +pref("widget.wayland.vsync.enabled", false); // tor-browser#41943: defense-in-depth, but do not lock anymore (enabled in Firefox 119, http://bugzil.la/1851162) pref("javascript.options.spectre.disable_for_isolated_content", false); ===================================== netwerk/protocol/http/nsHttpHandler.cpp ===================================== @@ -867,7 +867,7 @@ void nsHttpHandler::BuildUserAgent() { mUserAgent += '/'; mUserAgent += mProductSub; - bool isFirefox = mAppName.EqualsLiteral("Firefox"); + bool isFirefox = true; if (isFirefox || mCompatFirefoxEnabled) { // "Firefox/x.y" (compatibility) app token mUserAgent += ' '; View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/7f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/7f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.7.0esr-14.0-1] 3 commits: fixup! Firefox preference overrides.
by Pier Angelo Vendrame (＠pierov) 28 Jan '25

28 Jan '25

Pier Angelo Vendrame pushed to branch base-browser-128.7.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 95637e62 by Pier Angelo Vendrame at 2025-01-28T16:39:42+01:00 fixup! Firefox preference overrides. BB 41065: Hardcode the limit of storage quota. Currently, we return min(10GB, 0.2 * available space in the fs). This is bad for systems that have less than 50GB free, especially live systems, such as Tails. Set a pref to replace the available space with a hardcoded limit (5GiB). - - - - - dc62e33f by Pier Angelo Vendrame at 2025-01-28T16:39:56+01:00 Bug 43386: Use Firefox in the UA in RFP-exempt request. XHR requests initiated by extensions are exempt from RFP. Therefore, they report the actual app name, instead of Firefox, and the actual Firefox minor version. This happens whenever the app name has been customized and does not match a hardcoded "Firefox". - - - - - 54e4f8f0 by Pier Angelo Vendrame at 2025-01-28T16:40:39+01:00 fixup! Firefox preference overrides. BB 43236: Disable vsync on Wayland. Vsync leaks the monitor refresh rate, therefore it is already disabled on other platforms, including Linux/X11 and Windows. - - - - - 2 changed files: - browser/app/profile/001-base-profile.js - netwerk/protocol/http/nsHttpHandler.cpp Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -87,6 +87,15 @@ pref("browser.sessionstore.privacy_level", 2); // Use the in-memory media cache and increase its maximum size (#29120) pref("browser.privatebrowsing.forceMediaMemoryCache", true); pref("media.memory_cache_max_size", 65536); +// tor-browser#41065: lie about the available quota. +// This value is in KiB, and will be divided by 5. Currently: 50GiB, to be +// coherent with Firefox's usual value. However, this might be too much for live +// systems. +// This will be the limit also after granting the persistent storage permission, +// but we are not interested in it, since we support only PBM. +// We can come back to it, and hardcode the two spaced differently, if we ever +// think we need it. +pref("dom.quotaManager.temporaryStorage.fixedLimit", 52428800); // Disable restore in case of crash (tor-browser#41503) // This should not be needed in PBM, but we added it anyway like other options. pref("browser.sessionstore.resume_from_crash", false); @@ -466,6 +475,8 @@ pref("pdfjs.disabled", false, locked); #endif // Bug 40057: Ensure system colors are not used for CSS4 colors pref("browser.display.use_system_colors", false); +// tor-browser#43236: Disable vsync on Wayland to prevent refresh rate leaks. +pref("widget.wayland.vsync.enabled", false); // tor-browser#41943: defense-in-depth, but do not lock anymore (enabled in Firefox 119, http://bugzil.la/1851162) pref("javascript.options.spectre.disable_for_isolated_content", false); ===================================== netwerk/protocol/http/nsHttpHandler.cpp ===================================== @@ -867,7 +867,7 @@ void nsHttpHandler::BuildUserAgent() { mUserAgent += '/'; mUserAgent += mProductSub; - bool isFirefox = mAppName.EqualsLiteral("Firefox"); + bool isFirefox = true; if (isFirefox || mCompatFirefoxEnabled) { // "Firefox/x.y" (compatibility) app token mUserAgent += ' '; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/022a95… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/022a95… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-update-responses][main] Fix typo in 14.0a4 watershed redirect rule
by boklm (＠boklm) 28 Jan '25

28 Jan '25

boklm pushed to branch main at The Tor Project / Applications / Tor Browser update responses Commits: fdb6d9d0 by Nicolas Vigier at 2025-01-28T16:39:39+01:00 Fix typo in 14.0a4 watershed redirect rule - - - - - 1 changed file: - update_3/alpha/.htaccess Changes: ===================================== update_3/alpha/.htaccess ===================================== @@ -8,7 +8,7 @@ RewriteRule ^[^/]+/1[012]\..*/.* https://aus1.torproject.org/torbrowser/update_p RewriteRule ^[^/]+/13\.0.*/.* https://aus1.torproject.org/torbrowser/update_pre13.5a10/alpha/$0 [last] RewriteRule ^[^/]+/13\.5a\d/.* https://aus1.torproject.org/torbrowser/update_pre13.5a10/alpha/$0 [last] # Make 14.0a4 a watershed alpha release -RewriteRule ^[^/]+/14\.5a[123]/.* https://aus1.torproject.org/torbrowser/update_pre14.0a4/alpha/$0 [last] +RewriteRule ^[^/]+/14\.0a[123]/.* https://aus1.torproject.org/torbrowser/update_pre14.0a4/alpha/$0 [last] RewriteRule ^[^/]+/14.5a2/ no-update.xml [last] RewriteRule ^Linux_x86-gcc3/14.0a8/ALL 14.0a8-14.5a2-linux-i686-ALL.xml [last] RewriteRule ^Linux_x86-gcc3/14.0a9/ALL 14.0a9-14.5a2-linux-i686-ALL.xml [last] View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… You're receiving this email because of your account on gitlab.torproject.org.

1 0