- tor-commits - lists.torproject.org

[Git][tpo/applications/tor-browser][base-browser-102.10.0esr-12.5-1] 5 commits: Bug 1685403 - Use NS_GetFinalChannelURI at some places, r=necko-reviewers, valentin
by Richard Pospesel (＠richard) 12 Apr '23

12 Apr '23

Richard Pospesel pushed to branch base-browser-102.10.0esr-12.5-1 at The Tor Project / Applications / Tor Browser Commits: c2c2ae6b by Kershaw Chang at 2023-04-12T16:33:02+00:00 Bug 1685403 - Use NS_GetFinalChannelURI at some places, r=necko-reviewers,valentin Differential Revision: https://phabricator.services.mozilla.com/D164656 - - - - - 6e2aeeed by Hubert Boma Manilla at 2023-04-12T16:33:03+00:00 Bug 1790542 - [devtools] Do not allow redirects on the 'sourceMappingUrl' r=jdescottes,devtools-reviewers - Block redirects on sourceMappingUrl - Add debugger test Differential Revision: https://phabricator.services.mozilla.com/D168648 - - - - - 56ac62b9 by Hubert Boma Manilla at 2023-04-12T16:33:03+00:00 Bug 1790542 - [devtools] Convert browser_source_map-reload.js test from using .sjs files to createTestHTTPServer r=ochameau,devtools-reviewers .sjs files depend on redirects to load static files. In D168648 we block redirects on sourceMappingUrl, so this browser_source_map-reload.js fails because we use .sjs to serve the content. This patch refactors to no longer use .sjs files Differential Revision: https://phabricator.services.mozilla.com/D169739 - - - - - fd6ffb84 by Jon Coppeard at 2023-04-12T16:33:04+00:00 Bug 1816158 - Part 1: Disallow GC while iterating global's debugger vector r=sfink GC can mutate this vector so don't allow that while we are iterating. I think it would be safe to use index-based iteration but it's safer to just ban it entirely. This fixes the crash produced by the testcase. Differential Revision: https://phabricator.services.mozilla.com/D169701 - - - - - 52a82664 by Jon Coppeard at 2023-04-12T16:33:04+00:00 Bug 1816158 - Part 2: Require no GC when giving out references to the realm's debugger vector r=sfink To prevent any other instances of this problme we can update the getDebuggers() methods on the global and the realm to require no GC. Depends on D169701 Differential Revision: https://phabricator.services.mozilla.com/D169702 - - - - - 30 changed files: - devtools/client/debugger/packages/devtools-source-map/src/source-map.js - devtools/client/debugger/packages/devtools-source-map/src/utils/fetchSourceMap.js - devtools/client/debugger/packages/devtools-source-map/src/utils/privileged-network-request.js - devtools/client/debugger/test/mochitest/browser.ini - + devtools/client/debugger/test/mochitest/browser_dbg-sourcemaps-redirect.js - devtools/client/debugger/test/mochitest/shared-head.js - devtools/client/framework/test/browser.ini - devtools/client/framework/test/browser_source_map-reload.js - − devtools/client/framework/test/code_bundle_reload_1.js - − devtools/client/framework/test/code_bundle_reload_1.js.map - − devtools/client/framework/test/code_bundle_reload_2.js - − devtools/client/framework/test/code_bundle_reload_2.js.map - + devtools/client/framework/test/reload/.eslintrc.js - + devtools/client/framework/test/reload/README.md - + devtools/client/framework/test/reload/package.json - + devtools/client/framework/test/reload/v1/code_bundle_reload.js - + devtools/client/framework/test/reload/v1/code_bundle_reload.js.map - devtools/client/framework/test/code_reload_1.js → devtools/client/framework/test/reload/v1/code_reload_1.js - devtools/client/framework/test/doc_reload.html → devtools/client/framework/test/reload/v1/doc_reload.html - + devtools/client/framework/test/reload/v2/code_bundle_reload.js - + devtools/client/framework/test/reload/v2/code_bundle_reload.js.map - devtools/client/framework/test/code_reload_2.js → devtools/client/framework/test/reload/v2/code_reload_2.js - + devtools/client/framework/test/reload/v2/doc_reload.html - + devtools/client/framework/test/reload/webpack.config.js - − devtools/client/framework/test/sjs_code_bundle_reload_map.sjs - − devtools/client/framework/test/sjs_code_reload.sjs - devtools/client/shared/test/shared-head.js - dom/fetch/FetchDriver.cpp - js/src/debugger/DebugAPI-inl.h - js/src/debugger/DebugAPI.h The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/b53567… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/b53567… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag base-browser-102.10.0esr-12.0-1-build2
by Richard Pospesel (＠richard) 12 Apr '23

12 Apr '23

Richard Pospesel pushed new tag base-browser-102.10.0esr-12.0-1-build2 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-102.10.0esr-12.0-1] 5 commits: Bug 1685403 - Use NS_GetFinalChannelURI at some places, r=necko-reviewers, valentin
by Richard Pospesel (＠richard) 12 Apr '23

12 Apr '23

Richard Pospesel pushed to branch base-browser-102.10.0esr-12.0-1 at The Tor Project / Applications / Tor Browser Commits: 08871ddf by Kershaw Chang at 2023-04-12T16:30:10+00:00 Bug 1685403 - Use NS_GetFinalChannelURI at some places, r=necko-reviewers,valentin Differential Revision: https://phabricator.services.mozilla.com/D164656 - - - - - 23e3a6b7 by Hubert Boma Manilla at 2023-04-12T16:30:10+00:00 Bug 1790542 - [devtools] Do not allow redirects on the 'sourceMappingUrl' r=jdescottes,devtools-reviewers - Block redirects on sourceMappingUrl - Add debugger test Differential Revision: https://phabricator.services.mozilla.com/D168648 - - - - - 583826d1 by Hubert Boma Manilla at 2023-04-12T16:30:11+00:00 Bug 1790542 - [devtools] Convert browser_source_map-reload.js test from using .sjs files to createTestHTTPServer r=ochameau,devtools-reviewers .sjs files depend on redirects to load static files. In D168648 we block redirects on sourceMappingUrl, so this browser_source_map-reload.js fails because we use .sjs to serve the content. This patch refactors to no longer use .sjs files Differential Revision: https://phabricator.services.mozilla.com/D169739 - - - - - 0e00f51b by Jon Coppeard at 2023-04-12T16:30:11+00:00 Bug 1816158 - Part 1: Disallow GC while iterating global's debugger vector r=sfink GC can mutate this vector so don't allow that while we are iterating. I think it would be safe to use index-based iteration but it's safer to just ban it entirely. This fixes the crash produced by the testcase. Differential Revision: https://phabricator.services.mozilla.com/D169701 - - - - - c4086539 by Jon Coppeard at 2023-04-12T16:30:12+00:00 Bug 1816158 - Part 2: Require no GC when giving out references to the realm's debugger vector r=sfink To prevent any other instances of this problme we can update the getDebuggers() methods on the global and the realm to require no GC. Depends on D169701 Differential Revision: https://phabricator.services.mozilla.com/D169702 - - - - - 30 changed files: - devtools/client/debugger/packages/devtools-source-map/src/source-map.js - devtools/client/debugger/packages/devtools-source-map/src/utils/fetchSourceMap.js - devtools/client/debugger/packages/devtools-source-map/src/utils/privileged-network-request.js - devtools/client/debugger/test/mochitest/browser.ini - + devtools/client/debugger/test/mochitest/browser_dbg-sourcemaps-redirect.js - devtools/client/debugger/test/mochitest/shared-head.js - devtools/client/framework/test/browser.ini - devtools/client/framework/test/browser_source_map-reload.js - − devtools/client/framework/test/code_bundle_reload_1.js - − devtools/client/framework/test/code_bundle_reload_1.js.map - − devtools/client/framework/test/code_bundle_reload_2.js - − devtools/client/framework/test/code_bundle_reload_2.js.map - + devtools/client/framework/test/reload/.eslintrc.js - + devtools/client/framework/test/reload/README.md - + devtools/client/framework/test/reload/package.json - + devtools/client/framework/test/reload/v1/code_bundle_reload.js - + devtools/client/framework/test/reload/v1/code_bundle_reload.js.map - devtools/client/framework/test/code_reload_1.js → devtools/client/framework/test/reload/v1/code_reload_1.js - devtools/client/framework/test/doc_reload.html → devtools/client/framework/test/reload/v1/doc_reload.html - + devtools/client/framework/test/reload/v2/code_bundle_reload.js - + devtools/client/framework/test/reload/v2/code_bundle_reload.js.map - devtools/client/framework/test/code_reload_2.js → devtools/client/framework/test/reload/v2/code_reload_2.js - + devtools/client/framework/test/reload/v2/doc_reload.html - + devtools/client/framework/test/reload/webpack.config.js - − devtools/client/framework/test/sjs_code_bundle_reload_map.sjs - − devtools/client/framework/test/sjs_code_reload.sjs - devtools/client/shared/test/shared-head.js - dom/fetch/FetchDriver.cpp - js/src/debugger/DebugAPI-inl.h - js/src/debugger/DebugAPI.h The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/33ad10… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/33ad10… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-102.10.0esr-12.0-1-build2
by Richard Pospesel (＠richard) 12 Apr '23

12 Apr '23

Richard Pospesel pushed new tag tor-browser-102.10.0esr-12.0-1-build2 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-102.10.0esr-12.0-1] 5 commits: Bug 1685403 - Use NS_GetFinalChannelURI at some places, r=necko-reviewers, valentin
by Richard Pospesel (＠richard) 12 Apr '23

12 Apr '23

Richard Pospesel pushed to branch tor-browser-102.10.0esr-12.0-1 at The Tor Project / Applications / Tor Browser Commits: 299c2669 by Kershaw Chang at 2023-04-11T20:04:48+00:00 Bug 1685403 - Use NS_GetFinalChannelURI at some places, r=necko-reviewers,valentin Differential Revision: https://phabricator.services.mozilla.com/D164656 - - - - - 85ac56c0 by Hubert Boma Manilla at 2023-04-11T20:04:49+00:00 Bug 1790542 - [devtools] Do not allow redirects on the 'sourceMappingUrl' r=jdescottes,devtools-reviewers - Block redirects on sourceMappingUrl - Add debugger test Differential Revision: https://phabricator.services.mozilla.com/D168648 - - - - - 6c6c0e3e by Hubert Boma Manilla at 2023-04-11T20:04:49+00:00 Bug 1790542 - [devtools] Convert browser_source_map-reload.js test from using .sjs files to createTestHTTPServer r=ochameau,devtools-reviewers .sjs files depend on redirects to load static files. In D168648 we block redirects on sourceMappingUrl, so this browser_source_map-reload.js fails because we use .sjs to serve the content. This patch refactors to no longer use .sjs files Differential Revision: https://phabricator.services.mozilla.com/D169739 - - - - - 049f5f77 by Jon Coppeard at 2023-04-11T20:04:49+00:00 Bug 1816158 - Part 1: Disallow GC while iterating global's debugger vector r=sfink GC can mutate this vector so don't allow that while we are iterating. I think it would be safe to use index-based iteration but it's safer to just ban it entirely. This fixes the crash produced by the testcase. Differential Revision: https://phabricator.services.mozilla.com/D169701 - - - - - 957cd5b1 by Jon Coppeard at 2023-04-11T20:04:50+00:00 Bug 1816158 - Part 2: Require no GC when giving out references to the realm's debugger vector r=sfink To prevent any other instances of this problme we can update the getDebuggers() methods on the global and the realm to require no GC. Depends on D169701 Differential Revision: https://phabricator.services.mozilla.com/D169702 - - - - - 30 changed files: - devtools/client/debugger/packages/devtools-source-map/src/source-map.js - devtools/client/debugger/packages/devtools-source-map/src/utils/fetchSourceMap.js - devtools/client/debugger/packages/devtools-source-map/src/utils/privileged-network-request.js - devtools/client/debugger/test/mochitest/browser.ini - + devtools/client/debugger/test/mochitest/browser_dbg-sourcemaps-redirect.js - devtools/client/debugger/test/mochitest/shared-head.js - devtools/client/framework/test/browser.ini - devtools/client/framework/test/browser_source_map-reload.js - − devtools/client/framework/test/code_bundle_reload_1.js - − devtools/client/framework/test/code_bundle_reload_1.js.map - − devtools/client/framework/test/code_bundle_reload_2.js - − devtools/client/framework/test/code_bundle_reload_2.js.map - + devtools/client/framework/test/reload/.eslintrc.js - + devtools/client/framework/test/reload/README.md - + devtools/client/framework/test/reload/package.json - + devtools/client/framework/test/reload/v1/code_bundle_reload.js - + devtools/client/framework/test/reload/v1/code_bundle_reload.js.map - devtools/client/framework/test/code_reload_1.js → devtools/client/framework/test/reload/v1/code_reload_1.js - devtools/client/framework/test/doc_reload.html → devtools/client/framework/test/reload/v1/doc_reload.html - + devtools/client/framework/test/reload/v2/code_bundle_reload.js - + devtools/client/framework/test/reload/v2/code_bundle_reload.js.map - devtools/client/framework/test/code_reload_2.js → devtools/client/framework/test/reload/v2/code_reload_2.js - + devtools/client/framework/test/reload/v2/doc_reload.html - + devtools/client/framework/test/reload/webpack.config.js - − devtools/client/framework/test/sjs_code_bundle_reload_map.sjs - − devtools/client/framework/test/sjs_code_reload.sjs - devtools/client/shared/test/shared-head.js - dom/fetch/FetchDriver.cpp - js/src/debugger/DebugAPI-inl.h - js/src/debugger/DebugAPI.h The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/cebb3c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/cebb3c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/fenix] Pushed new tag tor-browser-102.2.1-12.0-2-build4
by Richard Pospesel (＠richard) 12 Apr '23

12 Apr '23

Richard Pospesel pushed new tag tor-browser-102.2.1-12.0-2-build4 at The Tor Project / Applications / fenix -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/fenix/-/tree/tor-browser-102… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/fenix][tor-browser-102.2.1-12.0-2] 2 commits: Bug 1816059 - Show the notification for entering fullscreen as a Toast
by Richard Pospesel (＠richard) 12 Apr '23

12 Apr '23

Richard Pospesel pushed to branch tor-browser-102.2.1-12.0-2 at The Tor Project / Applications / fenix Commits: 36285ece by Mugurell at 2023-04-11T20:38:05+00:00 Bug 1816059 - Show the notification for entering fullscreen as a Toast - - - - - 216f33a3 by Alexandru2909 at 2023-04-11T20:46:41+00:00 Add FLAG_SECURE to SearchDialogFragment - - - - - 3 changed files: - app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt - app/src/main/java/org/mozilla/fenix/search/SearchDialogFragment.kt - + app/src/test/java/org/mozilla/fenix/search/SearchDialogFragmentTest.kt Changes: ===================================== app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt ===================================== @@ -17,6 +17,7 @@ import android.view.LayoutInflater import android.view.View import android.view.ViewGroup import android.view.accessibility.AccessibilityManager +import android.widget.Toast import androidx.annotation.CallSuper import androidx.annotation.VisibleForTesting import androidx.appcompat.app.AlertDialog @@ -1381,12 +1382,8 @@ abstract class BaseBrowserFragment : if (inFullScreen) { // Close find in page bar if opened findInPageIntegration.onBackPressed() - FenixSnackbar.make( - view = binding.dynamicSnackbarContainer, - duration = Snackbar.LENGTH_SHORT, - isDisplayedWithBrowserToolbar = false - ) - .setText(getString(R.string.full_screen_notification)) + Toast + .makeText(requireContext(), R.string.full_screen_notification, Toast.LENGTH_SHORT) .show() activity?.enterToImmersiveMode() browserToolbarView.collapse() ===================================== app/src/main/java/org/mozilla/fenix/search/SearchDialogFragment.kt ===================================== @@ -78,6 +78,7 @@ import org.mozilla.fenix.databinding.SearchSuggestionsHintBinding import org.mozilla.fenix.ext.components import org.mozilla.fenix.ext.increaseTapArea import org.mozilla.fenix.ext.requireComponents +import org.mozilla.fenix.ext.secure import org.mozilla.fenix.ext.settings import org.mozilla.fenix.search.awesomebar.AwesomeBarView import org.mozilla.fenix.search.awesomebar.toSearchProviderState @@ -151,6 +152,10 @@ class SearchDialogFragment : AppCompatDialogFragment(), UserInteractionHandler { override fun onBackPressed() { this(a)SearchDialogFragment.onBackPressed() } + }.apply { + if ((requireActivity() as HomeActivity).browsingModeManager.mode.isPrivate) { + this.secure(requireActivity()) + } } } ===================================== app/src/test/java/org/mozilla/fenix/search/SearchDialogFragmentTest.kt ===================================== @@ -0,0 +1,212 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +package org.mozilla.fenix.search + +import android.view.WindowManager.LayoutParams +import androidx.fragment.app.Fragment +import androidx.navigation.NavBackStackEntry +import androidx.navigation.NavController +import androidx.navigation.fragment.findNavController +import io.mockk.Called +import io.mockk.Runs +import io.mockk.every +import io.mockk.just +import io.mockk.mockk +import io.mockk.mockkStatic +import io.mockk.spyk +import io.mockk.unmockkStatic +import io.mockk.verify +import mozilla.components.browser.state.search.SearchEngine +import mozilla.components.browser.state.state.SearchState +import mozilla.components.browser.state.state.searchEngines +import mozilla.components.browser.state.state.selectedOrDefaultSearchEngine +import mozilla.components.support.test.robolectric.testContext +import org.junit.After +import org.junit.Assert.assertEquals +import org.junit.Assert.assertNull +import org.junit.Assert.assertSame +import org.junit.Before +import org.junit.Test +import org.junit.runner.RunWith +import org.mozilla.fenix.HomeActivity +import org.mozilla.fenix.components.Components +import org.mozilla.fenix.ext.requireComponents +import org.mozilla.fenix.helpers.FenixRobolectricTestRunner + +@RunWith(FenixRobolectricTestRunner::class) +internal class SearchDialogFragmentTest { + private val navController: NavController = mockk() + private val fragment = SearchDialogFragment() + + @Before + fun setup() { + mockkStatic("androidx.navigation.fragment.FragmentKt") + every { any<Fragment>().findNavController() } returns navController + } + + @After + fun teardown() { + unmockkStatic("androidx.navigation.fragment.FragmentKt") + } + + @Test + fun `GIVEN this is the only visible fragment WHEN asking for the previous destination THEN return null`() { + every { navController.backQueue } returns ArrayDeque(listOf(getDestination(fragmentName))) + + assertNull(fragment.getPreviousDestination()) + } + + @Test + fun `GIVEN this and FragmentB on top of this are visible WHEN asking for the previous destination THEN return null`() { + every { navController.backQueue } returns ArrayDeque( + listOf( + getDestination(fragmentName), + getDestination("FragmentB"), + ), + ) + + assertNull(fragment.getPreviousDestination()) + } + + @Test + fun `GIVEN FragmentA, this and FragmentB are visible WHEN asking for the previous destination THEN return FragmentA`() { + val fragmentADestination = getDestination("FragmentA") + every { navController.backQueue } returns ArrayDeque( + listOf( + fragmentADestination, + getDestination(fragmentName), + getDestination("FragmentB"), + ), + ) + + assertSame(fragmentADestination, fragment.getPreviousDestination()) + } + + @Test + fun `GIVEN FragmentA and this on top of it are visible WHEN asking for the previous destination THEN return FragmentA`() { + val fragmentADestination = getDestination("FragmentA") + every { navController.backQueue } returns ArrayDeque( + listOf( + fragmentADestination, + getDestination(fragmentName), + ), + ) + + assertSame(fragmentADestination, fragment.getPreviousDestination()) + } + + @Test + fun `GIVEN the default search engine is currently selected WHEN checking the need to update the current search engine THEN don't to anything`() { + fragment.interactor = mockk() + val defaultSearchEngine: SearchEngine = mockk { + every { id } returns "default" + } + val otherSearchEngine: SearchEngine = mockk { + every { id } returns "other" + } + val components: Components = mockk { + every { core.store.state.search } returns mockk(relaxed = true) { + every { searchEngines } returns listOf(otherSearchEngine, defaultSearchEngine) + } + } + mockkStatic( + "org.mozilla.fenix.ext.FragmentKt", + "mozilla.components.browser.state.state.SearchStateKt", + ) { + every { any<Fragment>().requireComponents } returns components + every { any<SearchState>().selectedOrDefaultSearchEngine } returns defaultSearchEngine + + fragment.maybeSelectShortcutEngine(defaultSearchEngine.id) + + verify { fragment.interactor wasNot Called } + } + } + + @Test + fun `GIVEN the default search engine is not currently selected WHEN checking the need to update the current search engine THEN update it to the current engine`() { + fragment.interactor = mockk { + every { onSearchShortcutEngineSelected(any()) } just Runs + } + val defaultSearchEngine: SearchEngine = mockk { + every { id } returns "default" + } + val otherSearchEngine: SearchEngine = mockk { + every { id } returns "other" + } + val components: Components = mockk { + every { core.store.state.search } returns mockk(relaxed = true) { + every { searchEngines } returns listOf(otherSearchEngine, defaultSearchEngine) + } + } + mockkStatic( + "org.mozilla.fenix.ext.FragmentKt", + "mozilla.components.browser.state.state.SearchStateKt", + ) { + every { any<Fragment>().requireComponents } returns components + every { any<SearchState>().selectedOrDefaultSearchEngine } returns defaultSearchEngine + + fragment.maybeSelectShortcutEngine(otherSearchEngine.id) + + verify { fragment.interactor.onSearchShortcutEngineSelected(otherSearchEngine) } + } + } + + @Test + fun `GIVEN the currently selected search engine is unknown WHEN checking the need to update the current search engine THEN don't do anything`() { + fragment.interactor = mockk() + + fragment.maybeSelectShortcutEngine(null) + + verify { fragment.interactor wasNot Called } + } + + @Test + fun `GIVEN app is in private mode WHEN search dialog is created THEN the dialog is secure`() { + val activity: HomeActivity = mockk(relaxed = true) + val fragment = spyk(SearchDialogFragment()) + val layoutParams = LayoutParams() + layoutParams.flags = LayoutParams.FLAG_SECURE + + every { activity.browsingModeManager.mode.isPrivate } returns true + every { activity.window } returns mockk(relaxed = true) { + every { attributes } returns LayoutParams().apply { flags = LayoutParams.FLAG_SECURE } + } + every { fragment.requireActivity() } returns activity + every { fragment.requireContext() } returns testContext + + val dialog = fragment.onCreateDialog(null) + + assertEquals(LayoutParams.FLAG_SECURE, dialog.window?.attributes?.flags!! and LayoutParams.FLAG_SECURE) + } + + @Test + fun `GIVEN app is in normal mode WHEN search dialog is created THEN the dialog is not secure`() { + val activity: HomeActivity = mockk(relaxed = true) + val fragment = spyk(SearchDialogFragment()) + val layoutParams = LayoutParams() + layoutParams.flags = LayoutParams.FLAG_SECURE + + every { activity.browsingModeManager.mode.isPrivate } returns false + every { activity.window } returns mockk(relaxed = true) { + every { attributes } returns LayoutParams().apply { flags = LayoutParams.FLAG_SECURE } + } + every { fragment.requireActivity() } returns activity + every { fragment.requireContext() } returns testContext + + val dialog = fragment.onCreateDialog(null) + + assertEquals(0, dialog.window?.attributes?.flags!! and LayoutParams.FLAG_SECURE) + } +} + +private val fragmentName = SearchDialogFragment::class.java.canonicalName?.substringAfterLast('.')!! + +private fun getDestination(destinationName: String): NavBackStackEntry { + return mockk { + every { destination } returns mockk { + every { displayName } returns "test.id/$destinationName" + } + } +} View it on GitLab: https://gitlab.torproject.org/tpo/applications/fenix/-/compare/cf3ce1ddef47… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/fenix/-/compare/cf3ce1ddef47… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[pluggable-transports/snowflake-webext] branch main updated (b8b7900 -> 5617b95)
by gitolite role 10 Apr '23

10 Apr '23

This is an automated email from the git hooks/post-receive script. cohosh pushed a change to branch main in repository pluggable-transports/snowflake-webext. from b8b7900 bump version to 0.7.2 new b8b13cb Update npm package version in package-lock.json new 5617b95 Update documentation to reference main branch The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: README.md | 2 +- package-lock.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 2

[pluggable-transports/snowflake-webext] tag webext-undefined created (now 665b0fe)
by gitolite role 10 Apr '23

10 Apr '23

This is an automated email from the git hooks/post-receive script. cohosh pushed a change to tag webext-undefined in repository pluggable-transports/snowflake-webext. at 665b0fe (commit) This tag includes the following new commits: new 665b0fe bump version to undefined The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 1

[pluggable-transports/snowflake-webext] tag webext-0.7.2 created (now b8b7900)
by gitolite role 10 Apr '23

10 Apr '23

This is an automated email from the git hooks/post-receive script. cohosh pushed a change to tag webext-0.7.2 in repository pluggable-transports/snowflake-webext. at b8b7900 (commit) No new revisions were added by this update. -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0