- tor-commits - lists.torproject.org

[Git][tpo/applications/tor-browser][base-browser-115.2.0esr-13.0-1] 2 commits: Bug 42019: Empty browser's clipboard on browser shutdown
by richard (＠richard) 23 Aug '23

23 Aug '23

richard pushed to branch base-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: cde79442 by hackademix at 2023-08-22T15:53:12+00:00 Bug 42019: Empty browser's clipboard on browser shutdown - - - - - ed48588b by cypherpunks1 at 2023-08-22T15:53:31+00:00 fixup! Firefox preference overrides. Bug 41876: Disable the Firefox View tab - - - - - 2 changed files: - browser/app/profile/001-base-profile.js - browser/components/BrowserGlue.sys.mjs Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -17,6 +17,9 @@ pref("startup.homepage_welcome_url.additional", ""); // Disable Firefox Welcome Dialog pref("browser.aboutwelcome.enabled", false); +// Disable the Firefox View tab (tor-browser#41876) +pref("browser.tabs.firefox-view", false); + // Bug 41668: allow users to apply updates. This is set also in firefox.js for // all platforms, except for Windows. As explained on firefox.js, Firefox uses a // per-installation preference on Windows. However, we patch this behavior, and ===================================== browser/components/BrowserGlue.sys.mjs ===================================== @@ -1909,6 +1909,7 @@ BrowserGlue.prototype = { lazy.UpdateListener.reset(); } }, + () => Services.clipboard.emptyClipboard(Ci.nsIClipboard.kGlobalClipboard) // tor-browser#42019 ]; for (let task of tasks) { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/225930… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/225930… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] fixup! Bug 16940: After update, load local change notes.
by Pier Angelo Vendrame (＠pierov) 23 Aug '23

23 Aug '23

Pier Angelo Vendrame pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: d17f3162 by Pier Angelo Vendrame at 2023-08-22T17:53:33+02:00 fixup! Bug 16940: After update, load local change notes. Remove the doubled and unused aboutTBUpdate.dtd - - - - - 2 changed files: - − browser/locales/en-US/chrome/browser/aboutTBUpdate.dtd - browser/locales/jar.mn Changes: ===================================== browser/locales/en-US/chrome/browser/aboutTBUpdate.dtd deleted ===================================== @@ -1,14 +0,0 @@ -<!ENTITY aboutTBUpdate.changelogTitle "Tor Browser Changelog"> -<!ENTITY aboutTBUpdate.updated "Tor Browser has been updated."> - -<!ENTITY aboutTBUpdate.linkPrefix "For the most up-to-date information about this release, "> -<!ENTITY aboutTBUpdate.linkLabel "visit our website"> -<!ENTITY aboutTBUpdate.linkSuffix "."> -<!ENTITY aboutTBUpdate.version "Version"> -<!ENTITY aboutTBUpdate.releaseDate "Release Date"> -<!ENTITY aboutTBUpdate.releaseNotes "Release Notes"> ===================================== browser/locales/jar.mn ===================================== @@ -18,9 +18,6 @@ @AB_CD@.jar: % locale browser @AB_CD@ %locale/browser/ -#ifdef BASE_BROWSER_UPDATE - locale/browser/aboutTBUpdate.dtd (%chrome/browser/aboutTBUpdate.dtd) -#endif locale/browser/browser.properties (%chrome/browser/browser.properties) locale/browser/customizableui/customizableWidgets.properties (%chrome/browser/customizableui/customizableWidgets.properties) locale/browser/uiDensity.properties (%chrome/browser/uiDensity.properties) View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d17f316… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d17f316… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] fixup! Firefox preference overrides.
by richard (＠richard) 23 Aug '23

23 Aug '23

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 68e4526d by cypherpunks1 at 2023-08-22T03:48:36-08:00 fixup! Firefox preference overrides. Bug 41876: Disable the Firefox View tab - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -17,6 +17,9 @@ pref("startup.homepage_welcome_url.additional", ""); // Disable Firefox Welcome Dialog pref("browser.aboutwelcome.enabled", false); +// Disable the Firefox View tab (tor-browser#41876) +pref("browser.tabs.firefox-view", false); + // Bug 41668: allow users to apply updates. This is set also in firefox.js for // all platforms, except for Windows. As explained on firefox.js, Firefox uses a // per-installation preference on Windows. However, we patch this behavior, and View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/68e4526… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/68e4526… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new tag tor-browser-115.2.0esr-13.0-1-build2
by richard (＠richard) 22 Aug '23

22 Aug '23

richard pushed new tag tor-browser-115.2.0esr-13.0-1-build2 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] 3 commits: fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain.
by ma1 (＠ma1) 22 Aug '23

22 Aug '23

ma1 pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 255203a3 by cypherpunks1 at 2023-08-21T19:11:56+00:00 fixup! Bug 3455: Add DomainIsolator, for isolating circuit by domain. Bug 40175: Use first-party isolation on reader view - - - - - 3f596978 by cypherpunks1 at 2023-08-21T19:11:56+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 40175: Support circuit display on about:reader - - - - - 5073f134 by cypherpunks1 at 2023-08-21T19:11:56+00:00 Bug 40175: Add origin attributes to about:reader top-level requests - - - - - 4 changed files: - browser/components/torcircuit/content/torCircuitPanel.js - toolkit/components/reader/AboutReader.sys.mjs - toolkit/components/reader/ReaderMode.sys.mjs - toolkit/components/tor-launcher/TorDomainIsolator.sys.mjs Changes: ===================================== browser/components/torcircuit/content/torCircuitPanel.js ===================================== @@ -276,7 +276,18 @@ var gTorCircuitPanel = { // will match up with the domain. // In contrast, documentURI corresponds to the shown page. E.g. it could // point to "about:certerror". - const scheme = browser.currentURI?.scheme; + let scheme = browser.currentURI?.scheme; + if (scheme === "about" && browser.currentURI?.filePath === "reader") { + const searchParams = new URLSearchParams(browser.currentURI.query); + if (searchParams.has("url")) { + try { + const uri = Services.io.newURI(searchParams.get("url")); + scheme = uri.scheme; + } catch (err) { + this._log.error(err); + } + } + } if ( this._currentBrowserData && ===================================== toolkit/components/reader/AboutReader.sys.mjs ===================================== @@ -788,6 +788,7 @@ AboutReader.prototype = { try { article = await ReaderMode.downloadAndParseDocument( url, + { ...this._doc.nodePrincipal?.originAttributes }, docContentType ); } catch (e) { ===================================== toolkit/components/reader/ReaderMode.sys.mjs ===================================== @@ -231,11 +231,12 @@ export var ReaderMode = { * Downloads and parses a document from a URL. * * @param url URL to download and parse. + * @param attrs OriginAttributes to use for the request. * @return {Promise} * @resolves JS object representing the article, or null if no article is found. */ - async downloadAndParseDocument(url, docContentType = "document") { - let result = await this._downloadDocument(url, docContentType); + async downloadAndParseDocument(url, attrs = {}, docContentType = "document") { + let result = await this._downloadDocument(url, attrs, docContentType); if (!result?.doc) { return null; } @@ -258,9 +259,11 @@ export var ReaderMode = { return article; }, - _downloadDocument(url, docContentType = "document") { + _downloadDocument(url, attrs = {}, docContentType = "document") { + let uri; try { - if (!lazy.Readerable.shouldCheckUri(Services.io.newURI(url))) { + uri = Services.io.newURI(url); + if (!lazy.Readerable.shouldCheckUri(uri)) { return null; } } catch (ex) { @@ -272,9 +275,15 @@ export var ReaderMode = { let histogram = Services.telemetry.getHistogramById( "READER_MODE_DOWNLOAD_RESULT" ); + try { + attrs.firstPartyDomain = Services.eTLD.getSchemelessSite(uri); + } catch (e) { + console.error("Failed to get first party domain for about:reader", e); + } return new Promise((resolve, reject) => { let xhr = new XMLHttpRequest(); xhr.open("GET", url, true); + xhr.setOriginAttributes(attrs); xhr.onerror = evt => reject(evt.error); xhr.responseType = docContentType === "text/plain" ? "text" : "document"; xhr.onload = evt => { ===================================== toolkit/components/tor-launcher/TorDomainIsolator.sys.mjs ===================================== @@ -300,6 +300,17 @@ class TorDomainIsolatorImpl { const channel = aChannel.QueryInterface(Ci.nsIChannel); let firstPartyDomain = channel.loadInfo.originAttributes.firstPartyDomain; const userContextId = channel.loadInfo.originAttributes.userContextId; + const loadingPrincipalURI = channel.loadInfo.loadingPrincipal?.URI; + if (loadingPrincipalURI?.spec.startsWith("about:reader")) { + try { + const searchParams = new URLSearchParams(loadingPrincipalURI.query); + if (searchParams.has("url")) { + firstPartyDomain = Services.eTLD.getSchemelessSite(Services.io.newURI(searchParams.get("url"))); + } + } catch (e) { + logger.error("Failed to get first party domain for about:reader", e); + } + } if (!firstPartyDomain) { firstPartyDomain = CATCHALL_DOMAIN; if (Date.now() - this.#catchallDirtySince > CATCHALL_MAX_LIFETIME) { @@ -629,36 +640,43 @@ class TorDomainIsolatorImpl { function getDomainForBrowser(browser) { let fpd = browser.contentPrincipal.originAttributes.firstPartyDomain; - // Bug 31562: For neterror or certerror, get the original URL from - // browser.currentURI and use it to calculate the firstPartyDomain. - const knownErrors = [ - "about:neterror", - "about:certerror", - "about:httpsonlyerror", - ]; const { documentURI } = browser; - if ( - documentURI && - documentURI.schemeIs("about") && - knownErrors.some(x => documentURI.spec.startsWith(x)) - ) { - const knownSchemes = ["http", "https"]; - const currentURI = browser.currentURI; - if (currentURI && knownSchemes.some(x => currentURI.schemeIs(x))) { + if (documentURI && documentURI.schemeIs("about")) { + // Bug 31562: For neterror or certerror, get the original URL from + // browser.currentURI and use it to calculate the firstPartyDomain. + const knownErrors = [ + "about:neterror", + "about:certerror", + "about:httpsonlyerror", + ]; + if (knownErrors.some(x => documentURI.spec.startsWith(x))) { + const knownSchemes = ["http", "https"]; + const currentURI = browser.currentURI; + if (currentURI && knownSchemes.some(x => currentURI.schemeIs(x))) { + try { + fpd = Services.eTLD.getBaseDomainFromHost(currentURI.host); + } catch (e) { + if ( + e.result === Cr.NS_ERROR_HOST_IS_IP_ADDRESS || + e.result === Cr.NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS + ) { + fpd = currentURI.host; + } else { + logger.error( + `Failed to get first party domain for host ${currentURI.host}`, + e + ); + } + } + } + } else if (documentURI.spec.startsWith("about:reader")) { try { - fpd = Services.eTLD.getBaseDomainFromHost(currentURI.host); - } catch (e) { - if ( - e.result === Cr.NS_ERROR_HOST_IS_IP_ADDRESS || - e.result === Cr.NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS - ) { - fpd = currentURI.host; - } else { - logger.error( - `Failed to get first party domain for host ${currentURI.host}`, - e - ); + const searchParams = new URLSearchParams(documentURI.query); + if (searchParams.has("url")) { + fpd = Services.eTLD.getSchemelessSite(Services.io.newURI(searchParams.get("url"))); } + } catch (e) { + logger.error("Failed to get first party domain for about:reader", e); } } } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/968d39… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/968d39… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] Bug 42019: Empty browser's clipboard on browser shutdown
by richard (＠richard) 22 Aug '23

22 Aug '23

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 968d3923 by hackademix at 2023-08-21T19:08:38+00:00 Bug 42019: Empty browser's clipboard on browser shutdown - - - - - 1 changed file: - browser/components/BrowserGlue.sys.mjs Changes: ===================================== browser/components/BrowserGlue.sys.mjs ===================================== @@ -2007,6 +2007,7 @@ BrowserGlue.prototype = { } }, () => lazy.OnionAliasStore.uninit(), + () => Services.clipboard.emptyClipboard(Ci.nsIClipboard.kGlobalClipboard) // tor-browser#42019 ]; for (let task of tasks) { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/968d392… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/968d392… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.2.0esr-13.0-1] fixup! Bug 18905: Hide unwanted items from help menu
by richard (＠richard) 22 Aug '23

22 Aug '23

richard pushed to branch base-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 225930cb by cypherpunks1 at 2023-08-21T18:55:53+00:00 fixup! Bug 18905: Hide unwanted items from help menu Bug 41642: Hide the new private window option only when autostart of PBM is enabled - - - - - 2 changed files: - browser/base/content/appmenu-viewcache.inc.xhtml - browser/base/content/browser.js Changes: ===================================== browser/base/content/appmenu-viewcache.inc.xhtml ===================================== @@ -53,8 +53,7 @@ class="subviewbutton" data-l10n-id="appmenuitem-new-private-window" key="key_privatebrowsing" - command="Tools:PrivateBrowsing" - hidden="true"/> + command="Tools:PrivateBrowsing"/> <toolbarseparator/> <toolbarbutton id="appMenu-new-identity" class="subviewbutton" ===================================== browser/base/content/browser.js ===================================== @@ -1762,7 +1762,7 @@ var gBrowserInit = { this._boundDelayedStartup = this._delayedStartup.bind(this); window.addEventListener("MozAfterPaint", this._boundDelayedStartup); - if (!PrivateBrowsingUtils.enabled) { + if (PrivateBrowsingUtils.permanentPrivateBrowsing || !PrivateBrowsingUtils.enabled) { document.getElementById("Tools:PrivateBrowsing").hidden = true; // Setting disabled doesn't disable the shortcut, so we just remove // the keybinding. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/225930c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/225930c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] fixup! Bug 18905: Hide unwanted items from help menu
by richard (＠richard) 22 Aug '23

22 Aug '23

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 2791be7c by cypherpunks1 at 2023-08-21T09:36:11-08:00 fixup! Bug 18905: Hide unwanted items from help menu Bug 41642: Hide the new private window option only when autostart of PBM is enabled - - - - - 2 changed files: - browser/base/content/appmenu-viewcache.inc.xhtml - browser/base/content/browser.js Changes: ===================================== browser/base/content/appmenu-viewcache.inc.xhtml ===================================== @@ -53,8 +53,7 @@ class="subviewbutton" data-l10n-id="appmenuitem-new-private-window" key="key_privatebrowsing" - command="Tools:PrivateBrowsing" - hidden="true"/> + command="Tools:PrivateBrowsing"/> <toolbarseparator/> <toolbarbutton id="appMenu-new-identity" class="subviewbutton" ===================================== browser/base/content/browser.js ===================================== @@ -1801,7 +1801,7 @@ var gBrowserInit = { this._boundDelayedStartup = this._delayedStartup.bind(this); window.addEventListener("MozAfterPaint", this._boundDelayedStartup); - if (!PrivateBrowsingUtils.enabled) { + if (PrivateBrowsingUtils.permanentPrivateBrowsing || !PrivateBrowsingUtils.enabled) { document.getElementById("Tools:PrivateBrowsing").hidden = true; // Setting disabled doesn't disable the shortcut, so we just remove // the keybinding. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2791be7… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2791be7… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.2.0esr-13.0-1] fixup! Firefox preference overrides.
by richard (＠richard) 22 Aug '23

22 Aug '23

richard pushed to branch base-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: 174014d9 by hackademix at 2023-08-21T17:22:51+00:00 fixup! Firefox preference overrides. Bug 42029 - Defense-in-depth: disable non-proxied UDP WebRTC - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -381,12 +381,17 @@ pref("network.http.http2.enable-hpack-dump", false, locked); // (defense in depth measure) pref("network.gio.supported-protocols", ""); pref("media.peerconnection.enabled", false); // Disable WebRTC interfaces -// Mullvad browser enables WebRTC by default, therefore the following 2 prefs +// Mullvad Browser enables WebRTC by default, meaning that there the following prefs // are first-line defense, rather than "in depth" (mullvad-browser#40) // tor-browser#41667 - Defense in depth: use mDNS to avoid local IP leaks on Android too if user enables WebRTC pref("media.peerconnection.ice.obfuscate_host_addresses", true); // tor-browser#41671 - Defense in depth: connect using TURN only, to avoid IP leaks if user enables WebRTC pref("media.peerconnection.ice.relay_only", true); +// tor-browser#42029 - Defense-in-depth: disable non-proxied UDP WebRTC +pref("media.peerconnection.ice.default_address_only", true); +pref("media.peerconnection.ice.no_host", true); +pref("media.peerconnection.ice.proxy_only_if_behind_proxy", true); + // Disables media devices but only if `media.peerconnection.enabled` is set to // `false` as well. (see bug 16328 for this defense-in-depth measure) pref("media.navigator.enabled", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/174014d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/174014d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.2.0esr-13.0-1] fixup! Firefox preference overrides.
by richard (＠richard) 22 Aug '23

22 Aug '23

richard pushed to branch tor-browser-115.2.0esr-13.0-1 at The Tor Project / Applications / Tor Browser Commits: fd6517c1 by hackademix at 2023-08-21T19:16:27+02:00 fixup! Firefox preference overrides. Bug 42029 - Defense-in-depth: disable non-proxied UDP WebRTC - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -381,12 +381,17 @@ pref("network.http.http2.enable-hpack-dump", false, locked); // (defense in depth measure) pref("network.gio.supported-protocols", ""); pref("media.peerconnection.enabled", false); // Disable WebRTC interfaces -// Mullvad browser enables WebRTC by default, therefore the following 2 prefs +// Mullvad Browser enables WebRTC by default, meaning that there the following prefs // are first-line defense, rather than "in depth" (mullvad-browser#40) // tor-browser#41667 - Defense in depth: use mDNS to avoid local IP leaks on Android too if user enables WebRTC pref("media.peerconnection.ice.obfuscate_host_addresses", true); // tor-browser#41671 - Defense in depth: connect using TURN only, to avoid IP leaks if user enables WebRTC pref("media.peerconnection.ice.relay_only", true); +// tor-browser#42029 - Defense-in-depth: disable non-proxied UDP WebRTC +pref("media.peerconnection.ice.default_address_only", true); +pref("media.peerconnection.ice.no_host", true); +pref("media.peerconnection.ice.proxy_only_if_behind_proxy", true); + // Disables media devices but only if `media.peerconnection.enabled` is set to // `false` as well. (see bug 16328 for this defense-in-depth measure) pref("media.navigator.enabled", false); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/fd6517c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/fd6517c… You're receiving this email because of your account on gitlab.torproject.org.

1 0