- tor-commits - lists.torproject.org

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 8475e6c0 by Henry Wilkes at 2024-02-13T18:02:44+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42415: Improve focus styling of bridge settings headings. We make sure the focus outline has a 2px offset from the text. Also make the "N days until you unlock:" text semantically a heading for its own section. - - - - - 3 changed files: - browser/components/torpreferences/content/connectionPane.js - browser/components/torpreferences/content/connectionPane.xhtml - browser/components/torpreferences/content/torPreferences.css Changes: ===================================== browser/components/torpreferences/content/connectionPane.js ===================================== @@ -1525,7 +1525,8 @@ const gLoxStatus = { } if (alertHadFocus && !showAlert) { - // Has become hidden. + // Alert has become hidden, move focus back up to the now revealed details + // area. this._nextUnlockCounterEl.focus(); } else if (detailsHadFocus && showAlert) { this._unlockAlertButton.focus(); ===================================== browser/components/torpreferences/content/connectionPane.xhtml ===================================== @@ -67,7 +67,11 @@  <hbox class="subcategory" data-category="paneConnection" hidden="true"> - <html:h1 id="torPreferences-bridges-header" tabindex="-1" /> + <html:h1 + id="torPreferences-bridges-header" + class="tor-focusable-heading" + tabindex="-1" + ></html:h1> </hbox> <groupbox id="torPreferences-bridges-group" @@ -157,22 +161,26 @@ <html:div id="tor-bridges-current-header-bar"> <html:h2 id="tor-bridges-current-heading" + class="tor-focusable-heading" tabindex="-1" data-l10n-id="tor-bridges-your-bridges" ></html:h2> <html:span id="tor-bridges-user-label" + class="tor-bridges-source-label" data-l10n-id="tor-bridges-source-user" ></html:span> <html:span id="tor-bridges-built-in-label" + class="tor-bridges-source-label" data-l10n-id="tor-bridges-source-built-in" ></html:span> <html:span id="tor-bridges-requested-label" + class="tor-bridges-source-label" data-l10n-id="tor-bridges-source-requested" ></html:span> - <html:span id="tor-bridges-lox-label"> + <html:span id="tor-bridges-lox-label" class="tor-bridges-source-label"> <html:img id="tor-bridges-lox-label-icon" alt="" /> <html:span data-l10n-id="tor-bridges-source-lox"></html:span> </html:span> @@ -307,11 +315,11 @@ > <html:img alt="" class="tor-bridges-lox-image-inner" /> <html:img alt="" class="tor-bridges-lox-image-outer" /> - <html:div + <html:h3 id="tor-bridges-lox-next-unlock-counter" - class="tor-bridges-lox-intro" + class="tor-bridges-lox-intro tor-focusable-heading" tabindex="-1" - ></html:div> + ></html:h3> <html:ul class="tor-bridges-lox-list"> <html:li id="tor-bridges-lox-next-unlock-gain-bridges" ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -70,6 +70,10 @@ /* Bridge settings */ +.tor-focusable-heading:focus-visible { + outline-offset: var(--in-content-focus-outline-offset); +} + .bridge-status-badge { display: flex; min-width: max-content; @@ -210,16 +214,31 @@ } #tor-bridges-current-header-bar { - display: flex; + display: grid; min-width: max-content; + grid-template: "heading source button" min-content / max-content 1fr max-content; align-items: center; border-block-end: 1px solid var(--in-content-border-color); padding-block-end: 16px; margin-block-end: 16px; + white-space: nowrap; } -#tor-bridges-current-header-bar > * { - flex: 0 0 auto; +#tor-bridges-current-heading { + margin: 0; + font-size: inherit; + grid-area: heading; +} + +.tor-bridges-source-label { + margin-inline-start: 2em; + margin-inline-end: 8px; + grid-area: source; + justify-self: end; +} + +#tor-bridges-all-options-button { + grid-area: button; } #tor-bridges-lox-label { @@ -240,13 +259,6 @@ fill: var(--in-content-icon-color); } -#tor-bridges-current-heading { - margin: 0; - margin-inline-end: 2em; - font-size: inherit; - flex: 1 0 auto; -} - .tor-bridges-options-button { padding: 3px; margin: 0; @@ -264,10 +276,6 @@ fill: currentColor; } -#tor-bridges-all-options-button { - margin-inline-start: 8px; -} - #tor-bridges-built-in-display { display: grid; grid-template: @@ -552,7 +560,10 @@ .tor-bridges-lox-intro { grid-area: intro; font-weight: 700; + font-size: inherit; align-self: center; + justify-self: start; + margin: 0; } .tor-bridges-lox-list { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8475e6c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/8475e6c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 94081cf4 by Henry Wilkes at 2024-02-13T17:46:34+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42414: Make address overflow ellipsis show in bridge grid. - - - - - 5 changed files: - browser/components/torpreferences/content/connectionPane.js - browser/components/torpreferences/content/connectionPane.xhtml - browser/components/torpreferences/content/provideBridgeDialog.js - browser/components/torpreferences/content/provideBridgeDialog.xhtml - browser/components/torpreferences/content/torPreferences.css Changes: ===================================== browser/components/torpreferences/content/connectionPane.js ===================================== @@ -675,7 +675,7 @@ const gBridgeGrid = { }); } - row.element.querySelector(".tor-bridges-address-cell").textContent = + row.element.querySelector(".tor-bridges-address-cell-text").textContent = bridgeLine; row.statusEl = row.element.querySelector( ===================================== browser/components/torpreferences/content/connectionPane.xhtml ===================================== @@ -238,7 +238,9 @@ <html:span class="tor-bridges-address-cell tor-bridges-grid-cell" role="gridcell" - ></html:span> + > + <html:span class="tor-bridges-address-cell-text"></html:span> + </html:span> <html:span class="tor-bridges-status-cell tor-bridges-grid-cell" role="gridcell" ===================================== browser/components/torpreferences/content/provideBridgeDialog.js ===================================== @@ -487,7 +487,8 @@ const gProvideBridgeDialog = { }); } - rowEl.querySelector(".tor-bridges-address-cell").textContent = bridgeLine; + rowEl.querySelector(".tor-bridges-address-cell-text").textContent = + bridgeLine; this._bridgeGrid.append(rowEl); } ===================================== browser/components/torpreferences/content/provideBridgeDialog.xhtml ===================================== @@ -82,7 +82,9 @@ <html:span class="tor-bridges-address-cell tor-bridges-grid-cell" role="gridcell" - ></html:span> + > + <html:span class="tor-bridges-address-cell-text"></html:span> + </html:span> </html:span> </html:div> </html:template> ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -395,6 +395,9 @@ /* base size */ width: 10em; flex: 1 0 auto; +} + +.tor-bridges-address-cell-text { white-space: nowrap; overflow: hidden; text-overflow: ellipsis; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/94081cf… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/94081cf… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new branch mullvad-browser-115.8.0esr-13.5-1
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed new branch mullvad-browser-115.8.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser] Pushed new branch mullvad-browser-115.8.0esr-13.0-1
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed new branch mullvad-browser-115.8.0esr-13.0-1 at The Tor Project / Applications / Mullvad Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/tree/mullv… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-115.8.0esr-13.5-1
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed new branch tor-browser-115.8.0esr-13.5-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-115.8.0esr-13.0-1
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed new branch tor-browser-115.8.0esr-13.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.7.0esr-13.5-1] Bug 42376: Pass the locale list when constructing l10n in datetimebox
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed to branch mullvad-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: 69328375 by Pier Angelo Vendrame at 2024-02-13T15:16:43+01:00 Bug 42376: Pass the locale list when constructing l10n in datetimebox The datetime input is inconsistent with other inputs when using spoof English: its placeholder is not translated, unlike the default values and texts of all the other inputs. - - - - - 1 changed file: - toolkit/content/widgets/datetimebox.js Changes: ===================================== toolkit/content/widgets/datetimebox.js ===================================== @@ -22,7 +22,9 @@ this.DateTimeBoxWidget = class { // createEditFieldAndAppend() call. this.l10n = new this.window.DOMLocalization( ["toolkit/global/datetimebox.ftl"], - /* aSync = */ true + /* aSync = */ true, + undefined, + this.window.getWebExposedLocales() ); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/693… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/693… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.7.0esr-13.5-1] Bug 42376: Pass the locale list when constructing l10n in datetimebox
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed to branch base-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: c0f52a3e by Pier Angelo Vendrame at 2024-02-13T15:16:17+01:00 Bug 42376: Pass the locale list when constructing l10n in datetimebox The datetime input is inconsistent with other inputs when using spoof English: its placeholder is not translated, unlike the default values and texts of all the other inputs. - - - - - 1 changed file: - toolkit/content/widgets/datetimebox.js Changes: ===================================== toolkit/content/widgets/datetimebox.js ===================================== @@ -22,7 +22,9 @@ this.DateTimeBoxWidget = class { // createEditFieldAndAppend() call. this.l10n = new this.window.DOMLocalization( ["toolkit/global/datetimebox.ftl"], - /* aSync = */ true + /* aSync = */ true, + undefined, + this.window.getWebExposedLocales() ); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c0f52a3… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c0f52a3… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.7.0esr-13.5-1] Bug 42376: Pass the locale list when constructing l10n in datetimebox
by Pier Angelo Vendrame (＠pierov) 13 Feb '24

13 Feb '24

Pier Angelo Vendrame pushed to branch tor-browser-115.7.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: a7f6c970 by Pier Angelo Vendrame at 2024-02-13T14:59:52+01:00 Bug 42376: Pass the locale list when constructing l10n in datetimebox The datetime input is inconsistent with other inputs when using spoof English: its placeholder is not translated, unlike the default values and texts of all the other inputs. - - - - - 1 changed file: - toolkit/content/widgets/datetimebox.js Changes: ===================================== toolkit/content/widgets/datetimebox.js ===================================== @@ -22,7 +22,9 @@ this.DateTimeBoxWidget = class { // createEditFieldAndAppend() call. this.l10n = new this.window.DOMLocalization( ["toolkit/global/datetimebox.ftl"], - /* aSync = */ true + /* aSync = */ true, + undefined, + this.window.getWebExposedLocales() ); } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a7f6c97… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/a7f6c97… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][main] Bug 41080: Re-pack omni.ja with 7-zip on Android.
by boklm (＠boklm) 09 Feb '24

09 Feb '24

boklm pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 56df6e4c by Pier Angelo Vendrame at 2024-02-08T16:06:11+01:00 Bug 41080: Re-pack omni.ja with 7-zip on Android. In this way we can shave a few additional MBs, and get further from the APK size limit. - - - - - 2 changed files: - projects/browser/build.android - rbm Changes: ===================================== projects/browser/build.android ===================================== @@ -24,18 +24,23 @@ cd /var/tmp/build mv $rootdir/[% c('input_files_by_name/noscript') %] "$noscript_path" [%IF c("var/tor-browser") -%] - unzip -j "$apk" assets/omni.ja tar -xaf "$rootdir/[% c("input_files_by_name/tor-expert-bundle") %]" tor/pluggable_transports/pt_config.json - mkdir omni - pushd omni - unzip ../omni.ja - cp ../tor/pluggable_transports/pt_config.json chrome/toolkit/content/global/pt_config.json - [% c('zip', { - zip_src => [ '.' ], - zip_args => '../assets/omni.ja', - }) %] - popd [% END -%] +unzip -j "$apk" assets/omni.ja +mkdir omni +pushd omni +unzip ../omni.ja +[%IF c("var/tor-browser") -%] + cp -a ../tor/pluggable_transports/pt_config.json chrome/toolkit/content/global/pt_config.json +[% END -%] +[% c('zip', { + zip_src => [ '.' ], + zip_args => '../assets/omni.ja', + use_7z => 1, + '7z_bin' => '7zz', + '7z_opts' => '-mx9', + }) %] +popd [% IF c("var/verify_allowed_addons") %] ===================================== rbm ===================================== @@ -1 +1 @@ -Subproject commit b5e5b04aaf677c4bacfb5ace45598313286bfdf6 +Subproject commit 10c6b24e90e3dc9c2578290a7d82a87b7f4eb9a3 View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/5… You're receiving this email because of your account on gitlab.torproject.org.

1 0