- tor-commits - lists.torproject.org

[Git][tpo/applications/tor-browser-build][main] Bug 40551: Remove our patch for the Go compiler.
by Pier Angelo Vendrame (＠pierov) 20 Aug '25

20 Aug '25

Pier Angelo Vendrame pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: b484354a by Pier Angelo Vendrame at 2025-08-19T18:44:06+02:00 Bug 40551: Remove our patch for the Go compiler. - - - - - 4 changed files: - − projects/go/0001-Use-fixed-go-build-tmp-directory.patch - projects/go/README.md - projects/go/build - projects/go/config Changes: ===================================== projects/go/0001-Use-fixed-go-build-tmp-directory.patch deleted ===================================== @@ -1,36 +0,0 @@ -From 2c1c98d6404284df744a194dd23bd3660f365387 Mon Sep 17 00:00:00 2001 -From: Georg Koppen <gk(a)torproject.org> -Date: Fri, 17 Apr 2020 10:24:23 +0000 -Subject: [PATCH] Use fixed go-build tmp directory - -Use fixed go-build tmp directory, when the directory does not exist, in -order to avoid some reproducibility issues where build directory gets -embedded in generated binaries. ---- - src/cmd/go/internal/work/action.go | 10 +++++++--- - 1 file changed, 7 insertions(+), 3 deletions(-) - -diff --git a/src/cmd/go/internal/work/action.go b/src/cmd/go/internal/work/action.go -index 8beb1345d0..dccf39c1c1 100644 ---- a/src/cmd/go/internal/work/action.go -+++ b/src/cmd/go/internal/work/action.go -@@ -279,9 +279,13 @@ func NewBuilder(workDir string) *Builder { - if !buildInitStarted { - panic("internal error: NewBuilder called before BuildInit") - } -- tmp, err := os.MkdirTemp(cfg.Getenv("GOTMPDIR"), "go-build") -- if err != nil { -- base.Fatalf("go: creating work dir: %v", err) -+ tmp := filepath.Join(cfg.Getenv("GOTMPDIR"), "go-build-workdir") -+ _, err := os.Stat(tmp) -+ if !os.IsNotExist(err) { -+ tmp, err = os.MkdirTemp(cfg.Getenv("GOTMPDIR"), "go-build") -+ if err != nil { -+ base.Fatalf("go: creating work dir: %v", err) -+ } - } - if !filepath.IsAbs(tmp) { - abs, err := filepath.Abs(tmp) --- -2.39.2 - ===================================== projects/go/README.md ===================================== @@ -7,7 +7,5 @@ We use it to build the various pluggable transports. We have another project (`go-bootstrap`) to provide it, and we make all targets use the `linux-x86_64` bootstrapper, since we don't need to cross-compile anything with it. -- On Android, we include a patch to fix a temporary directory whose path might - end up on binaries under some circumstances. - We create a compiler wrapper to include our custom arguments on macOS and on Windows because the `make.bash` script seems to lose our arguments. ===================================== projects/go/build ===================================== @@ -43,7 +43,6 @@ cd /var/tmp/dist/go/src chmod +x "$CC_FOR_TARGET" CGO_ENABLED=1 CC_FOR_TARGET="$CC_FOR_TARGET" CC= CFLAGS= LDFLAGS= ./make.bash [% ELSIF c("var/android") -%] - patch -p2 < $rootdir/0001-Use-fixed-go-build-tmp-directory.patch CGO_ENABLED=1 CC_FOR_TARGET=[% c("var/CC") %] CC= CFLAGS= LDFLAGS= ./make.bash [% END -%] ===================================== projects/go/config ===================================== @@ -92,5 +92,3 @@ input_files: name: go-bootstrap target_replace: '^.*browser-(?!testbuild).*': 'basebrowser-linux-x86_64' - - filename: 0001-Use-fixed-go-build-tmp-directory.patch - enable: '[% c("var/android") %]' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-update-responses][main] 7 commits: release: new version, 14.5.6 (linux-i686)
by ma1 (＠ma1) 19 Aug '25

19 Aug '25

ma1 pushed to branch main at The Tor Project / Applications / Tor Browser update responses Commits: 596b78fe by hackademix at 2025-08-19T19:29:29+02:00 release: new version, 14.5.6 (linux-i686) - - - - - e2740434 by hackademix at 2025-08-19T19:29:29+02:00 release: new version, 14.5.6 (linux-x86_64) - - - - - 77a900e4 by hackademix at 2025-08-19T19:29:29+02:00 release: new version, 14.5.6 (macos) - - - - - b87e16a5 by hackademix at 2025-08-19T19:29:30+02:00 release: new version, 14.5.6 (windows-i686) - - - - - 6fad930b by hackademix at 2025-08-19T19:29:30+02:00 release: new version, 14.5.6 (windows-x86_64) - - - - - 9e5b15f6 by hackademix at 2025-08-19T19:29:31+02:00 release: new version, 14.5.6 (android) - - - - - c913ee8f by hackademix at 2025-08-19T19:29:31+02:00 release: new version, 14.5.6 - - - - - 73 changed files: - update_3/release/download-android-aarch64.json - update_3/release/download-android-armv7.json - update_3/release/download-android-x86.json - update_3/release/download-android-x86_64.json - update_3/release/download-linux-i686.json - update_3/release/download-linux-x86_64.json - update_3/release/download-macos.json - update_3/release/download-windows-i686.json - update_3/release/download-windows-x86_64.json - update_3/release/downloads.json - update_3/release/linux-i686/.htaccess - − update_3/release/linux-i686/update-14.5.2-14.5.5+13.5.20-linux-i686.xml - − update_3/release/linux-i686/update-14.5.3-14.5.5+13.5.20-linux-i686.xml - + update_3/release/linux-i686/update-14.5.3-14.5.6+13.5.21-linux-i686.xml - − update_3/release/linux-i686/update-14.5.4-14.5.5+13.5.20-linux-i686.xml - + update_3/release/linux-i686/update-14.5.4-14.5.6+13.5.21-linux-i686.xml - − update_3/release/linux-i686/update-14.5.5+13.5.20-linux-i686.xml - + update_3/release/linux-i686/update-14.5.5-14.5.6+13.5.21-linux-i686.xml - + update_3/release/linux-i686/update-14.5.6+13.5.21-linux-i686.xml - update_3/release/linux-x86_64/.htaccess - − update_3/release/linux-x86_64/update-14.5.2-14.5.5+13.5.20-linux-x86_64.xml - − update_3/release/linux-x86_64/update-14.5.3-14.5.5+13.5.20-linux-x86_64.xml - + update_3/release/linux-x86_64/update-14.5.3-14.5.6+13.5.21-linux-x86_64.xml - − update_3/release/linux-x86_64/update-14.5.4-14.5.5+13.5.20-linux-x86_64.xml - + update_3/release/linux-x86_64/update-14.5.4-14.5.6+13.5.21-linux-x86_64.xml - − update_3/release/linux-x86_64/update-14.5.5+13.5.20-linux-x86_64.xml - + update_3/release/linux-x86_64/update-14.5.5-14.5.6+13.5.21-linux-x86_64.xml - + update_3/release/linux-x86_64/update-14.5.6+13.5.21-linux-x86_64.xml - update_3/release/macos/.htaccess - − update_3/release/macos/update-13.5.17-14.5.5+13.5.20-macos.xml - − update_3/release/macos/update-13.5.18-14.5.5+13.5.20-macos.xml - + update_3/release/macos/update-13.5.18-14.5.6+13.5.21-macos.xml - − update_3/release/macos/update-13.5.19-14.5.5+13.5.20-macos.xml - + update_3/release/macos/update-13.5.19-14.5.6+13.5.21-macos.xml - + update_3/release/macos/update-13.5.20-14.5.6+13.5.21-macos.xml - − update_3/release/macos/update-14.5.2-14.5.5+13.5.20-macos.xml - − update_3/release/macos/update-14.5.3-14.5.5+13.5.20-macos.xml - + update_3/release/macos/update-14.5.3-14.5.6+13.5.21-macos.xml - − update_3/release/macos/update-14.5.4-14.5.5+13.5.20-macos.xml - + update_3/release/macos/update-14.5.4-14.5.6+13.5.21-macos.xml - − update_3/release/macos/update-14.5.5+13.5.20-macos.xml - + update_3/release/macos/update-14.5.5-14.5.6+13.5.21-macos.xml - + update_3/release/macos/update-14.5.6+13.5.21-macos.xml - update_3/release/windows-i686/.htaccess - − update_3/release/windows-i686/update-13.5.17-14.5.5+13.5.20-windows-i686.xml - − update_3/release/windows-i686/update-13.5.18-14.5.5+13.5.20-windows-i686.xml - + update_3/release/windows-i686/update-13.5.18-14.5.6+13.5.21-windows-i686.xml - − update_3/release/windows-i686/update-13.5.19-14.5.5+13.5.20-windows-i686.xml - + update_3/release/windows-i686/update-13.5.19-14.5.6+13.5.21-windows-i686.xml - + update_3/release/windows-i686/update-13.5.20-14.5.6+13.5.21-windows-i686.xml - − update_3/release/windows-i686/update-14.5.2-14.5.5+13.5.20-windows-i686.xml - − update_3/release/windows-i686/update-14.5.3-14.5.5+13.5.20-windows-i686.xml - + update_3/release/windows-i686/update-14.5.3-14.5.6+13.5.21-windows-i686.xml - − update_3/release/windows-i686/update-14.5.4-14.5.5+13.5.20-windows-i686.xml - + update_3/release/windows-i686/update-14.5.4-14.5.6+13.5.21-windows-i686.xml - − update_3/release/windows-i686/update-14.5.5+13.5.20-windows-i686.xml - + update_3/release/windows-i686/update-14.5.5-14.5.6+13.5.21-windows-i686.xml - + update_3/release/windows-i686/update-14.5.6+13.5.21-windows-i686.xml - update_3/release/windows-x86_64/.htaccess - − update_3/release/windows-x86_64/update-13.5.17-14.5.5+13.5.20-windows-x86_64.xml - − update_3/release/windows-x86_64/update-13.5.18-14.5.5+13.5.20-windows-x86_64.xml - + update_3/release/windows-x86_64/update-13.5.18-14.5.6+13.5.21-windows-x86_64.xml - − update_3/release/windows-x86_64/update-13.5.19-14.5.5+13.5.20-windows-x86_64.xml - + update_3/release/windows-x86_64/update-13.5.19-14.5.6+13.5.21-windows-x86_64.xml - + update_3/release/windows-x86_64/update-13.5.20-14.5.6+13.5.21-windows-x86_64.xml - − update_3/release/windows-x86_64/update-14.5.2-14.5.5+13.5.20-windows-x86_64.xml - − update_3/release/windows-x86_64/update-14.5.3-14.5.5+13.5.20-windows-x86_64.xml - + update_3/release/windows-x86_64/update-14.5.3-14.5.6+13.5.21-windows-x86_64.xml - − update_3/release/windows-x86_64/update-14.5.4-14.5.5+13.5.20-windows-x86_64.xml - + update_3/release/windows-x86_64/update-14.5.4-14.5.6+13.5.21-windows-x86_64.xml - − update_3/release/windows-x86_64/update-14.5.5+13.5.20-windows-x86_64.xml - + update_3/release/windows-x86_64/update-14.5.5-14.5.6+13.5.21-windows-x86_64.xml - + update_3/release/windows-x86_64/update-14.5.6+13.5.21-windows-x86_64.xml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-140.2.0esr-15.0-1] fixup! BB 18905: Hide unwanted items from help menu
by morgan (＠morgan) 19 Aug '25

19 Aug '25

morgan pushed to branch mullvad-browser-140.2.0esr-15.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 518cccfe by Henry Wilkes at 2025-08-19T12:53:57+00:00 fixup! BB 18905: Hide unwanted items from help menu TB 43903: Hide "Report broken site" items. - - - - - 1 changed file: - browser/components/reportbrokensite/ReportBrokenSite.sys.mjs Changes: ===================================== browser/components/reportbrokensite/ReportBrokenSite.sys.mjs ===================================== @@ -452,9 +452,8 @@ export var ReportBrokenSite = new (class ReportBrokenSite { // Altering the disabled attribute on the command does not propagate // the change to the related menuitems (see bug 805653), so we change them all. const cmd = document.getElementById("cmd_reportBrokenSite"); - const allowedByPolicy = Services.policies.isAllowed( - "DisableFeedbackCommands" - ); + // Hide the items in base-browser. tor-browser#43903. + const allowedByPolicy = false; if (allowedByPolicy) { cmd.setAttribute("hidden", "false"); // see bug 805653 } else { View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/518… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/518… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-140.2.0esr-15.0-1] fixup! BB 18905: Hide unwanted items from help menu
by morgan (＠morgan) 19 Aug '25

19 Aug '25

morgan pushed to branch base-browser-140.2.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 836e8132 by Henry Wilkes at 2025-08-19T12:52:18+00:00 fixup! BB 18905: Hide unwanted items from help menu TB 43903: Hide "Report broken site" items. - - - - - 1 changed file: - browser/components/reportbrokensite/ReportBrokenSite.sys.mjs Changes: ===================================== browser/components/reportbrokensite/ReportBrokenSite.sys.mjs ===================================== @@ -452,9 +452,8 @@ export var ReportBrokenSite = new (class ReportBrokenSite { // Altering the disabled attribute on the command does not propagate // the change to the related menuitems (see bug 805653), so we change them all. const cmd = document.getElementById("cmd_reportBrokenSite"); - const allowedByPolicy = Services.policies.isAllowed( - "DisableFeedbackCommands" - ); + // Hide the items in base-browser. tor-browser#43903. + const allowedByPolicy = false; if (allowedByPolicy) { cmd.setAttribute("hidden", "false"); // see bug 805653 } else { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/836e813… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/836e813… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-140.2.0esr-15.0-1] fixup! BB 18905: Hide unwanted items from help menu
by morgan (＠morgan) 19 Aug '25

19 Aug '25

morgan pushed to branch tor-browser-140.2.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 4be90537 by Henry Wilkes at 2025-08-19T12:34:59+00:00 fixup! BB 18905: Hide unwanted items from help menu TB 43903: Hide "Report broken site" items. - - - - - 1 changed file: - browser/components/reportbrokensite/ReportBrokenSite.sys.mjs Changes: ===================================== browser/components/reportbrokensite/ReportBrokenSite.sys.mjs ===================================== @@ -452,9 +452,8 @@ export var ReportBrokenSite = new (class ReportBrokenSite { // Altering the disabled attribute on the command does not propagate // the change to the related menuitems (see bug 805653), so we change them all. const cmd = document.getElementById("cmd_reportBrokenSite"); - const allowedByPolicy = Services.policies.isAllowed( - "DisableFeedbackCommands" - ); + // Hide the items in base-browser. tor-browser#43903. + const allowedByPolicy = false; if (allowedByPolicy) { cmd.setAttribute("hidden", "false"); // see bug 805653 } else { View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4be9053… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/4be9053… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-140.2.0esr-15.0-1] fixup! MB 213: Customize the search engines list
by morgan (＠morgan) 19 Aug '25

19 Aug '25

morgan pushed to branch mullvad-browser-140.2.0esr-15.0-1 at The Tor Project / Applications / Mullvad Browser Commits: fc0be3f5 by Pier Angelo Vendrame at 2025-08-19T12:33:56+00:00 fixup! MB 213: Customize the search engines list TB 43728: Update search engine icon size. Update the .ico sizes in mullvadBrowserSearchEngineIcons.json to match the biggest available size. Add a 32x32 icon for Startpage and update its 16x16 one. - - - - - 4 changed files: - toolkit/components/search/content/mullvadBrowserSearchEngineIcons.json - + toolkit/components/search/content/startpage-16.png - + toolkit/components/search/content/startpage-32.png - − toolkit/components/search/content/startpage.png Changes: ===================================== toolkit/components/search/content/mullvadBrowserSearchEngineIcons.json ===================================== @@ -1,23 +1,27 @@ { "ddg": [ - { "url": "chrome://global/content/search/duckduckgo.ico", "iconSize": 16 } + { "url": "chrome://global/content/search/duckduckgo.ico", "iconSize": 32 } ], "ddg-html": [ - { "url": "chrome://global/content/search/duckduckgo.ico", "iconSize": 16 } + { "url": "chrome://global/content/search/duckduckgo.ico", "iconSize": 32 } ], "mullvad-leta": [ { "url": "chrome://global/content/search/mullvad-leta.svg", "iconSize": 16 } ], "mojeek": [ - { "url": "chrome://global/content/search/mojeek.ico", "iconSize": 16 } + { "url": "chrome://global/content/search/mojeek.ico", "iconSize": 32 } ], "brave": [ { "url": "chrome://global/content/search/brave.svg", "iconSize": 16 } ], "startpage": [ - { "url": "chrome://global/content/search/startpage.png", "iconSize": 16 } + { + "url": "chrome://global/content/search/startpage-16.png", + "iconSize": 16 + }, + { "url": "chrome://global/content/search/startpage-32.png", "iconSize": 32 } ], "metager": [ - { "url": "chrome://global/content/search/metager.ico", "iconSize": 16 } + { "url": "chrome://global/content/search/metager.ico", "iconSize": 196 } ] } ===================================== toolkit/components/search/content/startpage-16.png ===================================== Binary files /dev/null and b/toolkit/components/search/content/startpage-16.png differ ===================================== toolkit/components/search/content/startpage-32.png ===================================== Binary files /dev/null and b/toolkit/components/search/content/startpage-32.png differ ===================================== toolkit/components/search/content/startpage.png deleted ===================================== Binary files a/toolkit/components/search/content/startpage.png and /dev/null differ View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/fc0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/fc0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-140.2.0esr-15.0-1] fixup! TB 42891: Set the bundled search engine for Tor Browser.
by morgan (＠morgan) 19 Aug '25

19 Aug '25

morgan pushed to branch tor-browser-140.2.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 56d378c4 by Pier Angelo Vendrame at 2025-08-19T12:30:46+00:00 fixup! TB 42891: Set the bundled search engine for Tor Browser. TB 43728: Update search engine icon sizes. The .ico we're using for DDG and Wikipedia already contains the 32px variant, so update the size. Firefox should already do the best choice between the two available sizes. For Startpage, update the favicon, and ship both the 16px and the 32px icons. - - - - - 4 changed files: - + toolkit/components/search/content/startpage-16.png - + toolkit/components/search/content/startpage-32.png - − toolkit/components/search/content/startpage.png - toolkit/components/search/content/torBrowserSearchEngineIcons.json Changes: ===================================== toolkit/components/search/content/startpage-16.png ===================================== Binary files /dev/null and b/toolkit/components/search/content/startpage-16.png differ ===================================== toolkit/components/search/content/startpage-32.png ===================================== Binary files /dev/null and b/toolkit/components/search/content/startpage-32.png differ ===================================== toolkit/components/search/content/startpage.png deleted ===================================== Binary files a/toolkit/components/search/content/startpage.png and /dev/null differ ===================================== toolkit/components/search/content/torBrowserSearchEngineIcons.json ===================================== @@ -2,31 +2,39 @@ "ddg": [ { "url": "chrome://global/content/search/duckduckgo.ico", - "imageSize": 16 + "imageSize": 32 } ], "ddg-onion": [ { "url": "chrome://global/content/search/duckduckgo.ico", - "imageSize": 16 + "imageSize": 32 } ], "startpage": [ { - "url": "chrome://global/content/search/startpage.png", + "url": "chrome://global/content/search/startpage-16.png", "imageSize": 16 + }, + { + "url": "chrome://global/content/search/startpage-32.png", + "imageSize": 32 } ], "startpage-onion": [ { - "url": "chrome://global/content/search/startpage.png", + "url": "chrome://global/content/search/startpage-16.png", "imageSize": 16 + }, + { + "url": "chrome://global/content/search/startpage-32.png", + "imageSize": 32 } ], "wikipedia": [ { "url": "chrome://global/content/search/wikipedia.ico", - "imageSize": 16 + "imageSize": 32 } ] } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/56d378c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/56d378c… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-140.2.0esr-15.0-1] BB 43902: Modify the new sidebar for Base Browser.
by morgan (＠morgan) 19 Aug '25

19 Aug '25

morgan pushed to branch mullvad-browser-140.2.0esr-15.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 4f240699 by Henry Wilkes at 2025-08-19T12:09:22+00:00 BB 43902: Modify the new sidebar for Base Browser. - - - - - 1 changed file: - browser/components/sidebar/browser-sidebar.js Changes: ===================================== browser/components/sidebar/browser-sidebar.js ===================================== @@ -113,6 +113,9 @@ var SidebarController = { gleanEvent: Glean.history.sidebarToggle, gleanClickEvent: Glean.sidebar.historyIconClick, recordSidebarVersion: true, + // In permanent private browsing, the history panel can be opened, but + // we hide the sidebar button to control this. tor-browser#43902. + visible: !PrivateBrowsingUtils.permanentPrivateBrowsing, }), ], [ @@ -131,6 +134,15 @@ var SidebarController = { ? "sidebar-synced-tabs-context-menu" : undefined, gleanClickEvent: Glean.sidebar.syncedTabsIconClick, + // firefoxview is disabled. tor-browser#42037 and tor-browser#43902. + // See bugzilla bug 1983505. + // NOTE: The menuId and elementId menu items (sidebar switchers) + // should be hidden via the `sync-ui-item` class, which will *one* + // time hide the menu items via gSync.init. + // #sidebar-switcher-tabs is already in the initial browser DOM, + // and #menu_tabsSidebar is created during SidebarController.init, + // which seems to run prior to gSync.init. + visible: false, }), ], [ View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/4f2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/4f2… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-140.2.0esr-15.0-1] BB 43902: Modify the new sidebar for Base Browser.
by morgan (＠morgan) 19 Aug '25

19 Aug '25

morgan pushed to branch base-browser-140.2.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 76412dec by Henry Wilkes at 2025-08-19T12:08:17+00:00 BB 43902: Modify the new sidebar for Base Browser. - - - - - 1 changed file: - browser/components/sidebar/browser-sidebar.js Changes: ===================================== browser/components/sidebar/browser-sidebar.js ===================================== @@ -113,6 +113,9 @@ var SidebarController = { gleanEvent: Glean.history.sidebarToggle, gleanClickEvent: Glean.sidebar.historyIconClick, recordSidebarVersion: true, + // In permanent private browsing, the history panel can be opened, but + // we hide the sidebar button to control this. tor-browser#43902. + visible: !PrivateBrowsingUtils.permanentPrivateBrowsing, }), ], [ @@ -131,6 +134,15 @@ var SidebarController = { ? "sidebar-synced-tabs-context-menu" : undefined, gleanClickEvent: Glean.sidebar.syncedTabsIconClick, + // firefoxview is disabled. tor-browser#42037 and tor-browser#43902. + // See bugzilla bug 1983505. + // NOTE: The menuId and elementId menu items (sidebar switchers) + // should be hidden via the `sync-ui-item` class, which will *one* + // time hide the menu items via gSync.init. + // #sidebar-switcher-tabs is already in the initial browser DOM, + // and #menu_tabsSidebar is created during SidebarController.init, + // which seems to run prior to gSync.init. + visible: false, }), ], [ View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/76412de… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/76412de… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-140.2.0esr-15.0-1] BB 43902: Modify the new sidebar for Base Browser.
by morgan (＠morgan) 19 Aug '25

19 Aug '25

morgan pushed to branch tor-browser-140.2.0esr-15.0-1 at The Tor Project / Applications / Tor Browser Commits: 2c5430c0 by Henry Wilkes at 2025-08-18T14:04:47+01:00 BB 43902: Modify the new sidebar for Base Browser. - - - - - 1 changed file: - browser/components/sidebar/browser-sidebar.js Changes: ===================================== browser/components/sidebar/browser-sidebar.js ===================================== @@ -113,6 +113,9 @@ var SidebarController = { gleanEvent: Glean.history.sidebarToggle, gleanClickEvent: Glean.sidebar.historyIconClick, recordSidebarVersion: true, + // In permanent private browsing, the history panel can be opened, but + // we hide the sidebar button to control this. tor-browser#43902. + visible: !PrivateBrowsingUtils.permanentPrivateBrowsing, }), ], [ @@ -131,6 +134,15 @@ var SidebarController = { ? "sidebar-synced-tabs-context-menu" : undefined, gleanClickEvent: Glean.sidebar.syncedTabsIconClick, + // firefoxview is disabled. tor-browser#42037 and tor-browser#43902. + // See bugzilla bug 1983505. + // NOTE: The menuId and elementId menu items (sidebar switchers) + // should be hidden via the `sync-ui-item` class, which will *one* + // time hide the menu items via gSync.init. + // #sidebar-switcher-tabs is already in the initial browser DOM, + // and #menu_tabsSidebar is created during SidebarController.init, + // which seems to run prior to gSync.init. + visible: false, }), ], [ View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2c5430c… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/2c5430c… You're receiving this email because of your account on gitlab.torproject.org.

1 0