- tor-commits - lists.torproject.org

[Git][tpo/applications/tor-browser-build] Pushed new branch maint-14.0
by morgan (＠morgan) 16 Oct '24

16 Oct '24

morgan pushed new branch maint-14.0 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/mai… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-115.16.0esr-13.5-1] Bug 1886222 - Start reload by calling reload in the parent....
by ma1 (＠ma1) 16 Oct '24

16 Oct '24

ma1 pushed to branch mullvad-browser-115.16.0esr-13.5-1 at The Tor Project / Applications / Mullvad Browser Commits: c893bf36 by Andreas Farre at 2024-10-16T14:46:55+02:00 Bug 1886222 - Start reload by calling reload in the parent. r=Gijs,canadahonk,smaug, a=dsmith (esr128->esr115 backport) Differential Revision: https://phabricator.services.mozilla.com/D211519 - - - - - 3 changed files: - browser/actors/BrowserTabChild.sys.mjs - browser/base/content/browser.js - docshell/shistory/nsISHistory.idl Changes: ===================================== browser/actors/BrowserTabChild.sys.mjs ===================================== @@ -3,12 +3,6 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -const lazy = {}; - -ChromeUtils.defineESModuleGetters(lazy, { - E10SUtils: "resource://gre/modules/E10SUtils.sys.mjs", -}); - export class BrowserTabChild extends JSWindowActorChild { constructor() { super(); @@ -19,34 +13,6 @@ export class BrowserTabChild extends JSWindowActorChild { let docShell = context.docShell; switch (message.name) { - // XXX(nika): Should we try to call this in the parent process instead? - case "Browser:Reload": - /* First, we'll try to use the session history object to reload so - * that framesets are handled properly. If we're in a special - * window (such as view-source) that has no session history, fall - * back on using the web navigation's reload method. - */ - let webNav = docShell.QueryInterface(Ci.nsIWebNavigation); - try { - if (webNav.sessionHistory) { - webNav = webNav.sessionHistory; - } - } catch (e) {} - - let reloadFlags = message.data.flags; - if (message.data.handlingUserInput) { - reloadFlags |= Ci.nsIWebNavigation.LOAD_FLAGS_USER_ACTIVATION; - } - - try { - lazy.E10SUtils.wrapHandlingUserInput( - this.document.defaultView, - message.data.handlingUserInput, - () => webNav.reload(reloadFlags) - ); - } catch (e) {} - break; - case "ForceEncodingDetection": docShell.forceEncodingDetection(); break; ===================================== browser/base/content/browser.js ===================================== @@ -3509,17 +3509,29 @@ function BrowserReloadWithFlags(reloadFlags) { gIdentityHandler.hidePopup(); gPermissionPanel.hidePopup(); - let handlingUserInput = document.hasValidTransientUserGestureActivation; + if (document.hasValidTransientUserGestureActivation) { + reloadFlags |= Ci.nsIWebNavigation.LOAD_FLAGS_USER_ACTIVATION; + } for (let tab of unchangedRemoteness) { if (tab.linkedPanel) { - sendReloadMessage(tab); + const { browsingContext } = tab.linkedBrowser; + const { sessionHistory } = browsingContext; + if (sessionHistory) { + sessionHistory.reload(reloadFlags); + } else { + browsingContext.reload(reloadFlags); + } } else { // Shift to fully loaded browser and make // sure load handler is instantiated. - tab.addEventListener("SSTabRestoring", () => sendReloadMessage(tab), { - once: true, - }); + tab.addEventListener( + "SSTabRestoring", + () => tab.linkedBrowser.browsingContext.reload(reloadFlags), + { + once: true, + } + ); gBrowser._insertBrowser(tab); } } @@ -3531,13 +3543,6 @@ function BrowserReloadWithFlags(reloadFlags) { }); } - function sendReloadMessage(tab) { - tab.linkedBrowser.sendMessageToActor( - "Browser:Reload", - { flags: reloadFlags, handlingUserInput }, - "BrowserTab" - ); - } } // TODO: can we pull getPEMString in from pippki.js instead of ===================================== docshell/shistory/nsISHistory.idl ===================================== @@ -268,8 +268,7 @@ interface nsISHistory: nsISupports [noscript, notxpcom] void RemoveFrameEntries(in nsISHEntry aEntry); - [noscript] - void Reload(in unsigned long aReloadFlags); + void reload(in unsigned long aReloadFlags); [notxpcom] void EnsureCorrectEntryAtCurrIndex(in nsISHEntry aEntry); View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/c89… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/c89… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-115.16.0esr-13.5-1] Bug 1886222 - Start reload by calling reload in the parent....
by ma1 (＠ma1) 16 Oct '24

16 Oct '24

ma1 pushed to branch base-browser-115.16.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: d2d5566b by Andreas Farre at 2024-10-16T14:46:47+02:00 Bug 1886222 - Start reload by calling reload in the parent. r=Gijs,canadahonk,smaug, a=dsmith (esr128->esr115 backport) Differential Revision: https://phabricator.services.mozilla.com/D211519 - - - - - 3 changed files: - browser/actors/BrowserTabChild.sys.mjs - browser/base/content/browser.js - docshell/shistory/nsISHistory.idl Changes: ===================================== browser/actors/BrowserTabChild.sys.mjs ===================================== @@ -3,12 +3,6 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -const lazy = {}; - -ChromeUtils.defineESModuleGetters(lazy, { - E10SUtils: "resource://gre/modules/E10SUtils.sys.mjs", -}); - export class BrowserTabChild extends JSWindowActorChild { constructor() { super(); @@ -19,34 +13,6 @@ export class BrowserTabChild extends JSWindowActorChild { let docShell = context.docShell; switch (message.name) { - // XXX(nika): Should we try to call this in the parent process instead? - case "Browser:Reload": - /* First, we'll try to use the session history object to reload so - * that framesets are handled properly. If we're in a special - * window (such as view-source) that has no session history, fall - * back on using the web navigation's reload method. - */ - let webNav = docShell.QueryInterface(Ci.nsIWebNavigation); - try { - if (webNav.sessionHistory) { - webNav = webNav.sessionHistory; - } - } catch (e) {} - - let reloadFlags = message.data.flags; - if (message.data.handlingUserInput) { - reloadFlags |= Ci.nsIWebNavigation.LOAD_FLAGS_USER_ACTIVATION; - } - - try { - lazy.E10SUtils.wrapHandlingUserInput( - this.document.defaultView, - message.data.handlingUserInput, - () => webNav.reload(reloadFlags) - ); - } catch (e) {} - break; - case "ForceEncodingDetection": docShell.forceEncodingDetection(); break; ===================================== browser/base/content/browser.js ===================================== @@ -3507,17 +3507,29 @@ function BrowserReloadWithFlags(reloadFlags) { gIdentityHandler.hidePopup(); gPermissionPanel.hidePopup(); - let handlingUserInput = document.hasValidTransientUserGestureActivation; + if (document.hasValidTransientUserGestureActivation) { + reloadFlags |= Ci.nsIWebNavigation.LOAD_FLAGS_USER_ACTIVATION; + } for (let tab of unchangedRemoteness) { if (tab.linkedPanel) { - sendReloadMessage(tab); + const { browsingContext } = tab.linkedBrowser; + const { sessionHistory } = browsingContext; + if (sessionHistory) { + sessionHistory.reload(reloadFlags); + } else { + browsingContext.reload(reloadFlags); + } } else { // Shift to fully loaded browser and make // sure load handler is instantiated. - tab.addEventListener("SSTabRestoring", () => sendReloadMessage(tab), { - once: true, - }); + tab.addEventListener( + "SSTabRestoring", + () => tab.linkedBrowser.browsingContext.reload(reloadFlags), + { + once: true, + } + ); gBrowser._insertBrowser(tab); } } @@ -3529,13 +3541,6 @@ function BrowserReloadWithFlags(reloadFlags) { }); } - function sendReloadMessage(tab) { - tab.linkedBrowser.sendMessageToActor( - "Browser:Reload", - { flags: reloadFlags, handlingUserInput }, - "BrowserTab" - ); - } } // TODO: can we pull getPEMString in from pippki.js instead of ===================================== docshell/shistory/nsISHistory.idl ===================================== @@ -268,8 +268,7 @@ interface nsISHistory: nsISupports [noscript, notxpcom] void RemoveFrameEntries(in nsISHEntry aEntry); - [noscript] - void Reload(in unsigned long aReloadFlags); + void reload(in unsigned long aReloadFlags); [notxpcom] void EnsureCorrectEntryAtCurrIndex(in nsISHEntry aEntry); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d2d5566… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d2d5566… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.3.0esr-14.0-1] Bug 1501744 [Linux] Fill PointerEvents on the Gtk backend r=emilio
by Pier Angelo Vendrame (＠pierov) 15 Oct '24

15 Oct '24

Pier Angelo Vendrame pushed to branch mullvad-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 666891c7 by stransky at 2024-10-15T22:24:49+02:00 Bug 1501744 [Linux] Fill PointerEvents on the Gtk backend r=emilio Patch author is tpxp <tpxp(a)live.fr> Differential Revision: https://phabricator.services.mozilla.com/D215201 - - - - - 1 changed file: - widget/gtk/nsWindow.cpp Changes: ===================================== widget/gtk/nsWindow.cpp ===================================== @@ -784,6 +784,53 @@ void nsWindow::ReparentNativeWidget(nsIWidget* aNewParent) { GtkWindowSetTransientFor(GTK_WINDOW(mShell), newParentWidget); } +static void InitPenEvent(WidgetMouseEvent& aGeckoEvent, GdkEvent* aEvent) { + // Find the source of the event + GdkDevice* device = gdk_event_get_source_device(aEvent); + GdkInputSource eSource = gdk_device_get_source(device); + gdouble value; + + // We distinguish touch screens from pens using the event type + // Eraser corresponds to the pen with the "erase" button pressed + if (eSource != GDK_SOURCE_PEN && eSource != GDK_SOURCE_ERASER) { + bool XWaylandPen = false; +#ifdef MOZ_X11 + // Workaround : When using Xwayland, pens are reported as + // GDK_SOURCE_TOUCHSCREEN If eSource is GDK_SOURCE_TOUCHSCREEN and the + // GDK_AXIS_XTILT and GDK_AXIS_YTILT axes are reported then it's a pen and + // not a finger on a screen. Yes, that's a stupid heuristic but it works... + // Note, however, that the tilt values are not reliable + // Another approach could be use the device tool type, but that's only + // available in GTK > 3.22 + XWaylandPen = (eSource == GDK_SOURCE_TOUCHSCREEN && GdkIsX11Display() && + gdk_event_get_axis(aEvent, GDK_AXIS_XTILT, &value) && + gdk_event_get_axis(aEvent, GDK_AXIS_YTILT, &value)); +#endif + if (!XWaylandPen) { + return; + } + LOGW("InitPenEvent(): Is XWayland pen"); + } + + aGeckoEvent.mInputSource = dom::MouseEvent_Binding::MOZ_SOURCE_PEN; + aGeckoEvent.pointerId = 1; + + // The range of xtilt and ytilt are -1 to 1. Normalize it to -90 to 90. + if (gdk_event_get_axis(aEvent, GDK_AXIS_XTILT, &value)) { + aGeckoEvent.tiltX = int32_t(NS_round(value * 90)); + } + if (gdk_event_get_axis(aEvent, GDK_AXIS_YTILT, &value)) { + aGeckoEvent.tiltY = int32_t(NS_round(value * 90)); + } + if (gdk_event_get_axis(aEvent, GDK_AXIS_PRESSURE, &value)) { + aGeckoEvent.mPressure = (float)value; + // Make sure the pression is acceptable + MOZ_ASSERT(aGeckoEvent.mPressure >= 0.0 && aGeckoEvent.mPressure <= 1.0); + } + + LOGW("InitPenEvent(): pressure %f\n", aGeckoEvent.mPressure); +} + void nsWindow::SetModal(bool aModal) { LOG("nsWindow::SetModal %d\n", aModal); if (mIsDestroyed) { @@ -4530,6 +4577,7 @@ void nsWindow::OnMotionNotifyEvent(GdkEventMotion* aEvent) { event.AssignEventTime(GetWidgetEventTime(aEvent->time)); KeymapWrapper::InitInputEvent(event, aEvent->state); + InitPenEvent(event, (GdkEvent*)aEvent); DispatchInputEvent(&event); } @@ -4806,6 +4854,7 @@ void nsWindow::OnButtonPressEvent(GdkEventButton* aEvent) { InitButtonEvent(event, aEvent, refPoint); event.mPressure = mLastMotionPressure; + InitPenEvent(event, (GdkEvent*)aEvent); nsIWidget::ContentAndAPZEventStatus eventStatus = DispatchInputEvent(&event); const bool defaultPrevented = @@ -4875,6 +4924,8 @@ void nsWindow::OnButtonReleaseEvent(GdkEventButton* aEvent) { // to use it for the doubleclick position check. const LayoutDeviceIntPoint pos = event.mRefPoint; + InitPenEvent(event, (GdkEvent*)aEvent); + nsIWidget::ContentAndAPZEventStatus eventStatus = DispatchInputEvent(&event); const bool defaultPrevented = View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/666… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/666… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.3.0esr-14.0-1] Bug 1501744 [Linux] Fill PointerEvents on the Gtk backend r=emilio
by Pier Angelo Vendrame (＠pierov) 15 Oct '24

15 Oct '24

Pier Angelo Vendrame pushed to branch base-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: e9810c42 by stransky at 2024-10-15T22:22:35+02:00 Bug 1501744 [Linux] Fill PointerEvents on the Gtk backend r=emilio Patch author is tpxp <tpxp(a)live.fr> Differential Revision: https://phabricator.services.mozilla.com/D215201 - - - - - 1 changed file: - widget/gtk/nsWindow.cpp Changes: ===================================== widget/gtk/nsWindow.cpp ===================================== @@ -784,6 +784,53 @@ void nsWindow::ReparentNativeWidget(nsIWidget* aNewParent) { GtkWindowSetTransientFor(GTK_WINDOW(mShell), newParentWidget); } +static void InitPenEvent(WidgetMouseEvent& aGeckoEvent, GdkEvent* aEvent) { + // Find the source of the event + GdkDevice* device = gdk_event_get_source_device(aEvent); + GdkInputSource eSource = gdk_device_get_source(device); + gdouble value; + + // We distinguish touch screens from pens using the event type + // Eraser corresponds to the pen with the "erase" button pressed + if (eSource != GDK_SOURCE_PEN && eSource != GDK_SOURCE_ERASER) { + bool XWaylandPen = false; +#ifdef MOZ_X11 + // Workaround : When using Xwayland, pens are reported as + // GDK_SOURCE_TOUCHSCREEN If eSource is GDK_SOURCE_TOUCHSCREEN and the + // GDK_AXIS_XTILT and GDK_AXIS_YTILT axes are reported then it's a pen and + // not a finger on a screen. Yes, that's a stupid heuristic but it works... + // Note, however, that the tilt values are not reliable + // Another approach could be use the device tool type, but that's only + // available in GTK > 3.22 + XWaylandPen = (eSource == GDK_SOURCE_TOUCHSCREEN && GdkIsX11Display() && + gdk_event_get_axis(aEvent, GDK_AXIS_XTILT, &value) && + gdk_event_get_axis(aEvent, GDK_AXIS_YTILT, &value)); +#endif + if (!XWaylandPen) { + return; + } + LOGW("InitPenEvent(): Is XWayland pen"); + } + + aGeckoEvent.mInputSource = dom::MouseEvent_Binding::MOZ_SOURCE_PEN; + aGeckoEvent.pointerId = 1; + + // The range of xtilt and ytilt are -1 to 1. Normalize it to -90 to 90. + if (gdk_event_get_axis(aEvent, GDK_AXIS_XTILT, &value)) { + aGeckoEvent.tiltX = int32_t(NS_round(value * 90)); + } + if (gdk_event_get_axis(aEvent, GDK_AXIS_YTILT, &value)) { + aGeckoEvent.tiltY = int32_t(NS_round(value * 90)); + } + if (gdk_event_get_axis(aEvent, GDK_AXIS_PRESSURE, &value)) { + aGeckoEvent.mPressure = (float)value; + // Make sure the pression is acceptable + MOZ_ASSERT(aGeckoEvent.mPressure >= 0.0 && aGeckoEvent.mPressure <= 1.0); + } + + LOGW("InitPenEvent(): pressure %f\n", aGeckoEvent.mPressure); +} + void nsWindow::SetModal(bool aModal) { LOG("nsWindow::SetModal %d\n", aModal); if (mIsDestroyed) { @@ -4530,6 +4577,7 @@ void nsWindow::OnMotionNotifyEvent(GdkEventMotion* aEvent) { event.AssignEventTime(GetWidgetEventTime(aEvent->time)); KeymapWrapper::InitInputEvent(event, aEvent->state); + InitPenEvent(event, (GdkEvent*)aEvent); DispatchInputEvent(&event); } @@ -4806,6 +4854,7 @@ void nsWindow::OnButtonPressEvent(GdkEventButton* aEvent) { InitButtonEvent(event, aEvent, refPoint); event.mPressure = mLastMotionPressure; + InitPenEvent(event, (GdkEvent*)aEvent); nsIWidget::ContentAndAPZEventStatus eventStatus = DispatchInputEvent(&event); const bool defaultPrevented = @@ -4875,6 +4924,8 @@ void nsWindow::OnButtonReleaseEvent(GdkEventButton* aEvent) { // to use it for the doubleclick position check. const LayoutDeviceIntPoint pos = event.mRefPoint; + InitPenEvent(event, (GdkEvent*)aEvent); + nsIWidget::ContentAndAPZEventStatus eventStatus = DispatchInputEvent(&event); const bool defaultPrevented = View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e9810c4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e9810c4… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.16.0esr-13.5-1] Bug 1886222 - Start reload by calling reload in the parent....
by ma1 (＠ma1) 15 Oct '24

15 Oct '24

ma1 pushed to branch tor-browser-115.16.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 10897e71 by Andreas Farre at 2024-10-15T22:08:54+02:00 Bug 1886222 - Start reload by calling reload in the parent. r=Gijs,canadahonk,smaug, a=dsmith (esr128->esr115 backport) Differential Revision: https://phabricator.services.mozilla.com/D211519 - - - - - 3 changed files: - browser/actors/BrowserTabChild.sys.mjs - browser/base/content/browser.js - docshell/shistory/nsISHistory.idl Changes: ===================================== browser/actors/BrowserTabChild.sys.mjs ===================================== @@ -3,12 +3,6 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -const lazy = {}; - -ChromeUtils.defineESModuleGetters(lazy, { - E10SUtils: "resource://gre/modules/E10SUtils.sys.mjs", -}); - export class BrowserTabChild extends JSWindowActorChild { constructor() { super(); @@ -19,34 +13,6 @@ export class BrowserTabChild extends JSWindowActorChild { let docShell = context.docShell; switch (message.name) { - // XXX(nika): Should we try to call this in the parent process instead? - case "Browser:Reload": - /* First, we'll try to use the session history object to reload so - * that framesets are handled properly. If we're in a special - * window (such as view-source) that has no session history, fall - * back on using the web navigation's reload method. - */ - let webNav = docShell.QueryInterface(Ci.nsIWebNavigation); - try { - if (webNav.sessionHistory) { - webNav = webNav.sessionHistory; - } - } catch (e) {} - - let reloadFlags = message.data.flags; - if (message.data.handlingUserInput) { - reloadFlags |= Ci.nsIWebNavigation.LOAD_FLAGS_USER_ACTIVATION; - } - - try { - lazy.E10SUtils.wrapHandlingUserInput( - this.document.defaultView, - message.data.handlingUserInput, - () => webNav.reload(reloadFlags) - ); - } catch (e) {} - break; - case "ForceEncodingDetection": docShell.forceEncodingDetection(); break; ===================================== browser/base/content/browser.js ===================================== @@ -3571,17 +3571,29 @@ function BrowserReloadWithFlags(reloadFlags) { gIdentityHandler.hidePopup(); gPermissionPanel.hidePopup(); - let handlingUserInput = document.hasValidTransientUserGestureActivation; + if (document.hasValidTransientUserGestureActivation) { + reloadFlags |= Ci.nsIWebNavigation.LOAD_FLAGS_USER_ACTIVATION; + } for (let tab of unchangedRemoteness) { if (tab.linkedPanel) { - sendReloadMessage(tab); + const { browsingContext } = tab.linkedBrowser; + const { sessionHistory } = browsingContext; + if (sessionHistory) { + sessionHistory.reload(reloadFlags); + } else { + browsingContext.reload(reloadFlags); + } } else { // Shift to fully loaded browser and make // sure load handler is instantiated. - tab.addEventListener("SSTabRestoring", () => sendReloadMessage(tab), { - once: true, - }); + tab.addEventListener( + "SSTabRestoring", + () => tab.linkedBrowser.browsingContext.reload(reloadFlags), + { + once: true, + } + ); gBrowser._insertBrowser(tab); } } @@ -3593,13 +3605,6 @@ function BrowserReloadWithFlags(reloadFlags) { }); } - function sendReloadMessage(tab) { - tab.linkedBrowser.sendMessageToActor( - "Browser:Reload", - { flags: reloadFlags, handlingUserInput }, - "BrowserTab" - ); - } } // TODO: can we pull getPEMString in from pippki.js instead of ===================================== docshell/shistory/nsISHistory.idl ===================================== @@ -268,8 +268,7 @@ interface nsISHistory: nsISupports [noscript, notxpcom] void RemoveFrameEntries(in nsISHEntry aEntry); - [noscript] - void Reload(in unsigned long aReloadFlags); + void reload(in unsigned long aReloadFlags); [notxpcom] void EnsureCorrectEntryAtCurrIndex(in nsISHEntry aEntry); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/10897e7… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/10897e7… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.3.0esr-14.0-1] Bug 1501744 [Linux] Fill PointerEvents on the Gtk backend r=emilio
by Pier Angelo Vendrame (＠pierov) 15 Oct '24

15 Oct '24

Pier Angelo Vendrame pushed to branch tor-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 53e645fe by stransky at 2024-10-15T21:56:36+02:00 Bug 1501744 [Linux] Fill PointerEvents on the Gtk backend r=emilio Patch author is tpxp <tpxp(a)live.fr> Differential Revision: https://phabricator.services.mozilla.com/D215201 - - - - - 1 changed file: - widget/gtk/nsWindow.cpp Changes: ===================================== widget/gtk/nsWindow.cpp ===================================== @@ -784,6 +784,53 @@ void nsWindow::ReparentNativeWidget(nsIWidget* aNewParent) { GtkWindowSetTransientFor(GTK_WINDOW(mShell), newParentWidget); } +static void InitPenEvent(WidgetMouseEvent& aGeckoEvent, GdkEvent* aEvent) { + // Find the source of the event + GdkDevice* device = gdk_event_get_source_device(aEvent); + GdkInputSource eSource = gdk_device_get_source(device); + gdouble value; + + // We distinguish touch screens from pens using the event type + // Eraser corresponds to the pen with the "erase" button pressed + if (eSource != GDK_SOURCE_PEN && eSource != GDK_SOURCE_ERASER) { + bool XWaylandPen = false; +#ifdef MOZ_X11 + // Workaround : When using Xwayland, pens are reported as + // GDK_SOURCE_TOUCHSCREEN If eSource is GDK_SOURCE_TOUCHSCREEN and the + // GDK_AXIS_XTILT and GDK_AXIS_YTILT axes are reported then it's a pen and + // not a finger on a screen. Yes, that's a stupid heuristic but it works... + // Note, however, that the tilt values are not reliable + // Another approach could be use the device tool type, but that's only + // available in GTK > 3.22 + XWaylandPen = (eSource == GDK_SOURCE_TOUCHSCREEN && GdkIsX11Display() && + gdk_event_get_axis(aEvent, GDK_AXIS_XTILT, &value) && + gdk_event_get_axis(aEvent, GDK_AXIS_YTILT, &value)); +#endif + if (!XWaylandPen) { + return; + } + LOGW("InitPenEvent(): Is XWayland pen"); + } + + aGeckoEvent.mInputSource = dom::MouseEvent_Binding::MOZ_SOURCE_PEN; + aGeckoEvent.pointerId = 1; + + // The range of xtilt and ytilt are -1 to 1. Normalize it to -90 to 90. + if (gdk_event_get_axis(aEvent, GDK_AXIS_XTILT, &value)) { + aGeckoEvent.tiltX = int32_t(NS_round(value * 90)); + } + if (gdk_event_get_axis(aEvent, GDK_AXIS_YTILT, &value)) { + aGeckoEvent.tiltY = int32_t(NS_round(value * 90)); + } + if (gdk_event_get_axis(aEvent, GDK_AXIS_PRESSURE, &value)) { + aGeckoEvent.mPressure = (float)value; + // Make sure the pression is acceptable + MOZ_ASSERT(aGeckoEvent.mPressure >= 0.0 && aGeckoEvent.mPressure <= 1.0); + } + + LOGW("InitPenEvent(): pressure %f\n", aGeckoEvent.mPressure); +} + void nsWindow::SetModal(bool aModal) { LOG("nsWindow::SetModal %d\n", aModal); if (mIsDestroyed) { @@ -4530,6 +4577,7 @@ void nsWindow::OnMotionNotifyEvent(GdkEventMotion* aEvent) { event.AssignEventTime(GetWidgetEventTime(aEvent->time)); KeymapWrapper::InitInputEvent(event, aEvent->state); + InitPenEvent(event, (GdkEvent*)aEvent); DispatchInputEvent(&event); } @@ -4806,6 +4854,7 @@ void nsWindow::OnButtonPressEvent(GdkEventButton* aEvent) { InitButtonEvent(event, aEvent, refPoint); event.mPressure = mLastMotionPressure; + InitPenEvent(event, (GdkEvent*)aEvent); nsIWidget::ContentAndAPZEventStatus eventStatus = DispatchInputEvent(&event); const bool defaultPrevented = @@ -4875,6 +4924,8 @@ void nsWindow::OnButtonReleaseEvent(GdkEventButton* aEvent) { // to use it for the doubleclick position check. const LayoutDeviceIntPoint pos = event.mRefPoint; + InitPenEvent(event, (GdkEvent*)aEvent); + nsIWidget::ContentAndAPZEventStatus eventStatus = DispatchInputEvent(&event); const bool defaultPrevented = View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/53e645f… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/53e645f… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build] Pushed new tag tbb-13.5.8-build1
by Pier Angelo Vendrame (＠pierov) 14 Oct '24

14 Oct '24

Pier Angelo Vendrame pushed new tag tbb-13.5.8-build1 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/tbb… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser-build][maint-13.5] Bug 41271: Prepare Tor Browser 13.5.8
by Pier Angelo Vendrame (＠pierov) 14 Oct '24

14 Oct '24

Pier Angelo Vendrame pushed to branch maint-13.5 at The Tor Project / Applications / tor-browser-build Commits: 329a359c by Pier Angelo Vendrame at 2024-10-14T19:40:11+02:00 Bug 41271: Prepare Tor Browser 13.5.8 - - - - - 6 changed files: - projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt - projects/browser/allowed_addons.json - projects/browser/config - projects/firefox-android/config - projects/translation/config - rbm.conf Changes: ===================================== projects/browser/Bundle-Data/Docs-TBB/ChangeLog.txt ===================================== @@ -1,3 +1,16 @@ +Tor Browser 13.5.8 - October 14 2024 + * Android + * Updated NoScript to 11.4.42 + * Bug 43099: YEC 2024 Takeover for Android Stable [tor-browser] + * Bug 43173: Backport security fixes from Firefox 131 [tor-browser] + +Tor Browser 14.0a9 - October 08 2024 + * All Platforms + * Bug 43197: Disable automatic exception for HTTPS-First [tor-browser] + * Bug 43201: Security fixes from Firefox 131.0.2 [tor-browser] + * Android + * Bug 43132: Enable extensions installation on Tor Browser 14 for Android. [tor-browser] + Tor Browser 13.5.7 - October 08 2024 * All Platforms * Bug 43201: Security fixes from Firefox 131.0.2 [tor-browser] ===================================== projects/browser/allowed_addons.json ===================================== @@ -17,7 +17,7 @@ "picture_url": "https://addons.mozilla.org/user-media/userpics/34/9734/13299734/13299734.pn…" } ], - "average_daily_users": 1207497, + "average_daily_users": 1213636, "categories": { "firefox": [ "web-development", @@ -218,10 +218,10 @@ "category": "recommended" }, "ratings": { - "average": 4.5261, - "bayesian_average": 4.525030500981792, - "count": 5891, - "text_count": 1850 + "average": 4.5267, + "bayesian_average": 4.5256323562411405, + "count": 5907, + "text_count": 1856 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/darkreader/reviews/", "requires_payment": false, @@ -318,7 +318,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/darkreader/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/darkreader/versions/", - "weekly_downloads": 27615 + "weekly_downloads": 28552 }, "notes": null }, @@ -334,7 +334,7 @@ "picture_url": "https://addons.mozilla.org/user-media/userpics/56/7656/6937656/6937656.png?…" } ], - "average_daily_users": 257450, + "average_daily_users": 257891, "categories": { "firefox": [ "privacy-security" @@ -547,9 +547,9 @@ "category": "recommended" }, "ratings": { - "average": 4.7941, - "bayesian_average": 4.7894866719280875, - "count": 1462, + "average": 4.7939, + "bayesian_average": 4.789290984643476, + "count": 1465, "text_count": 263 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/decentraleyes/reviews/", @@ -635,7 +635,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/decentraleyes/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/decentraleyes/versions/", - "weekly_downloads": 2882 + "weekly_downloads": 2980 }, "notes": null }, @@ -651,7 +651,7 @@ "picture_url": "https://addons.mozilla.org/user-media/userpics/73/4073/5474073/5474073.png?…" } ], - "average_daily_users": 1287220, + "average_daily_users": 1310964, "categories": { "firefox": [ "privacy-security" @@ -1170,10 +1170,10 @@ "category": "recommended" }, "ratings": { - "average": 4.8036, - "bayesian_average": 4.800921192769993, - "count": 2525, - "text_count": 474 + "average": 4.8041, + "bayesian_average": 4.801419862395535, + "count": 2527, + "text_count": 476 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-badger17/reviews/", "requires_payment": false, @@ -1197,7 +1197,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-badger17/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-badger17/versions/", - "weekly_downloads": 15616 + "weekly_downloads": 14939 }, "notes": null }, @@ -1213,7 +1213,7 @@ "picture_url": null } ], - "average_daily_users": 8491310, + "average_daily_users": 8542786, "categories": { "firefox": [ "privacy-security" @@ -1378,7 +1378,7 @@ }, "is_disabled": false, "is_experimental": false, - "last_updated": "2024-10-07T16:05:33Z", + "last_updated": "2024-10-12T13:25:21Z", "name": { "ar": "uBlock Origin", "bg": "uBlock Origin", @@ -1523,10 +1523,10 @@ "category": "recommended" }, "ratings": { - "average": 4.7911, - "bayesian_average": 4.790736675455798, - "count": 18576, - "text_count": 4852 + "average": 4.7922, + "bayesian_average": 4.791837346304233, + "count": 18640, + "text_count": 4871 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/reviews/", "requires_payment": false, @@ -1589,7 +1589,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/versions/", - "weekly_downloads": 203502 + "weekly_downloads": 217905 }, "notes": null }, @@ -1605,7 +1605,7 @@ "picture_url": null } ], - "average_daily_users": 186764, + "average_daily_users": 187335, "categories": { "firefox": [ "photos-music-videos", @@ -1701,10 +1701,10 @@ "category": "recommended" }, "ratings": { - "average": 4.4529, - "bayesian_average": 4.448102217920827, - "count": 1285, - "text_count": 499 + "average": 4.45, + "bayesian_average": 4.445212842032069, + "count": 1289, + "text_count": 501 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/video-background-play-fix/re…", "requires_payment": false, @@ -1742,7 +1742,7 @@ "picture_url": null } ], - "average_daily_users": 62883, + "average_daily_users": 62764, "categories": { "firefox": [ "privacy-security", @@ -1877,7 +1877,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-possum/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/privacy-possum/versions/", - "weekly_downloads": 252 + "weekly_downloads": 382 }, "notes": null }, @@ -1893,7 +1893,7 @@ "picture_url": "https://addons.mozilla.org/user-media/userpics/64/9064/12929064/12929064.pn…" } ], - "average_daily_users": 363798, + "average_daily_users": 364513, "categories": { "firefox": [ "search-tools", @@ -2110,10 +2110,10 @@ "category": "recommended" }, "ratings": { - "average": 4.6156, - "bayesian_average": 4.611450519760037, - "count": 1553, - "text_count": 311 + "average": 4.6173, + "bayesian_average": 4.613162490310139, + "count": 1560, + "text_count": 313 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/search_by_image/reviews/", "requires_payment": false, @@ -2136,7 +2136,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/search_by_image/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/search_by_image/versions/", - "weekly_downloads": 4249 + "weekly_downloads": 4344 }, "notes": null }, @@ -2159,7 +2159,7 @@ "picture_url": null } ], - "average_daily_users": 122492, + "average_daily_users": 122483, "categories": { "firefox": [ "search-tools", @@ -2440,10 +2440,10 @@ "category": "recommended" }, "ratings": { - "average": 4.38, - "bayesian_average": 4.375681327971426, - "count": 1400, - "text_count": 392 + "average": 4.3776, + "bayesian_average": 4.373284794488685, + "count": 1401, + "text_count": 393 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/google-search-fixer/reviews/", "requires_payment": false, @@ -2463,7 +2463,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/google-search-fixer/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/google-search-fixer/versions/", - "weekly_downloads": 18 + "weekly_downloads": 19 }, "notes": null }, @@ -2479,7 +2479,7 @@ "picture_url": "https://addons.mozilla.org/user-media/userpics/43/0143/143/143.png?modified…" } ], - "average_daily_users": 290667, + "average_daily_users": 290837, "categories": { "firefox": [ "privacy-security", @@ -2489,7 +2489,7 @@ "contributions_url": "https://www.paypal.com/donate/?hosted_button_id=9ERKTU5MBH4EW&utm_content=p…", "created": "2005-05-13T10:51:32Z", "current_version": { - "id": 5813035, + "id": 5819422, "compatibility": { "firefox": { "min": "59.0", @@ -2500,7 +2500,7 @@ "max": "*" } }, - "edit_url": "https://addons.mozilla.org/en-US/developers/addon/noscript/versions/5813035", + "edit_url": "https://addons.mozilla.org/en-US/developers/addon/noscript/versions/5819422", "is_strict_compatibility_enabled": false, "license": { "id": 13, @@ -2511,22 +2511,22 @@ "url": "https://www.gnu.org/licenses/gpl-2.0.html" }, "release_notes": { - "en-US": "11.4.40\n============================================================\nx [nscl] Fix patched workers failures caused by Firefox\n webRequest filters disconnect() breaking on large files\n (thanks barbaz for reporting)\n\nv 11.4.39\n============================================================\nx [nscl] Improved WebGL-hooking and worker patching\n stability\nx [L10n] Lower to 90% the threshold for including a new\n translation\nx [L10n] Updated he, pt_PT\nx [nscl] Prevent patchWindow from throwing on SOP violations\nx [nscl] Correctly propagate extra arguments to shadowed\n worker constructors" + "en-US": "v 11.4.42\n============================================================\nx [nscl] Further SyncMessage simplification\nx Mitigate race conditions on startup\n\nv 11.4.41\n============================================================\nx [nscl] Fixed Chromium worker patching regression caused by\n failSafe scope\nx [nscl] Force service workers to be patched bypassing cache\nx [nscl] More robust SyncMessage implementation\nx [nscl] Enhanced remote worker patching\nx [nscl] Remove missing source map warning for\n browser-polyfill.js\nx [nscl] Better console handling in execution context\n patches\nx Reduce console spam on non-debugging instances\nx [nscl] Avoid patched workers breakage if console API is\n disabled (thanks ayi for reporting)" }, - "reviewed": "2024-09-26T09:59:52Z", - "version": "11.4.40", + "reviewed": "2024-10-09T08:34:17Z", + "version": "11.4.42", "files": [ { - "id": 4357325, - "created": "2024-09-22T06:25:28Z", - "hash": "sha256:242ead426159d871480a13062cbee08abc97da746cdc5c643aee2692e9adbbb2", + "id": 4363712, + "created": "2024-10-03T20:53:07Z", + "hash": "sha256:fd2d420afd93829bb6fe30ec6f8ba926d3d54d7583b8bbd822053b8cd13c0472", "is_restart_required": false, "is_webextension": true, "is_mozilla_signed_extension": false, "platform": "all", - "size": 965455, + "size": 965445, "status": "public", - "url": "https://addons.mozilla.org/firefox/downloads/file/4357325/noscript-11.4.40.…", + "url": "https://addons.mozilla.org/firefox/downloads/file/4363712/noscript-11.4.42.…", "permissions": [ "contextMenus", "storage", @@ -2593,7 +2593,7 @@ }, "is_disabled": false, "is_experimental": false, - "last_updated": "2024-10-03T20:10:23Z", + "last_updated": "2024-10-09T08:34:17Z", "name": { "de": "NoScript", "el": "NoScript", @@ -2665,10 +2665,10 @@ "category": "recommended" }, "ratings": { - "average": 4.4106, - "bayesian_average": 4.407931581210998, - "count": 2287, - "text_count": 870 + "average": 4.408, + "bayesian_average": 4.405333664117888, + "count": 2289, + "text_count": 871 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/noscript/reviews/", "requires_payment": false, @@ -2712,7 +2712,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/noscript/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/noscript/versions/", - "weekly_downloads": 8114 + "weekly_downloads": 8154 }, "notes": null }, @@ -2728,7 +2728,7 @@ "picture_url": null } ], - "average_daily_users": 164800, + "average_daily_users": 165178, "categories": { "firefox": [ "photos-music-videos", @@ -2838,10 +2838,10 @@ "category": "recommended" }, "ratings": { - "average": 3.8349, - "bayesian_average": 3.830907392554808, + "average": 3.8255, + "bayesian_average": 3.8215152080376273, "count": 1284, - "text_count": 465 + "text_count": 464 }, "ratings_url": "https://addons.mozilla.org/en-US/firefox/addon/youtube-high-definition/revi…", "requires_payment": false, @@ -2860,7 +2860,7 @@ "type": "extension", "url": "https://addons.mozilla.org/en-US/firefox/addon/youtube-high-definition/", "versions_url": "https://addons.mozilla.org/en-US/firefox/addon/youtube-high-definition/vers…", - "weekly_downloads": 1706 + "weekly_downloads": 1940 }, "notes": null } ===================================== projects/browser/config ===================================== @@ -104,9 +104,9 @@ input_files: enable: '[% ! c("var/android") %]' - filename: Bundle-Data enable: '[% ! c("var/android") %]' - - URL: https://addons.mozilla.org/firefox/downloads/file/4357325/noscript-11.4.40.… + - URL: https://addons.mozilla.org/firefox/downloads/file/4363712/noscript-11.4.42.… name: noscript - sha256sum: 242ead426159d871480a13062cbee08abc97da746cdc5c643aee2692e9adbbb2 + sha256sum: fd2d420afd93829bb6fe30ec6f8ba926d3d54d7583b8bbd822053b8cd13c0472 - URL: https://addons.mozilla.org/firefox/downloads/file/4359936/ublock_origin-1.6… name: ublock-origin sha256sum: e2cda9b2a1b0a7f6e5ef0da9f87f28df52f8560587ba2e51a3003121cfb81600 ===================================== projects/firefox-android/config ===================================== @@ -16,7 +16,7 @@ container: var: fenix_version: 115.2.1 browser_branch: 13.5-1 - browser_build: 15 + browser_build: 16 variant: Beta # This should be updated when the list of gradle dependencies is changed. gradle_dependencies_version: 3 ===================================== projects/translation/config ===================================== @@ -18,7 +18,7 @@ steps: git_hash: 'base-browser' tor-browser: tor-browser: '[% INCLUDE build %]' - git_hash: dbf1454fdbd3256d65985cc1c46391ce0ec159e7 + git_hash: 2e5133bd3f271bafc4578465103ae07567452b15 targets: nightly: git_hash: 'tor-browser' @@ -32,7 +32,7 @@ steps: fenix: '[% INCLUDE build %]' # We need to bump the commit before releasing but just pointing to a branch # might cause too much rebuidling of the Firefox part. - git_hash: 669ea989fa07933df7ab03ec0077e166e0dcc961 + git_hash: 0c637c9fa2c1ddf1e2bda1a63a0b0d974074d593 compress_tar: 'zst' targets: nightly: ===================================== rbm.conf ===================================== @@ -73,20 +73,20 @@ buildconf: git_signtag_opt: '-s' var: - torbrowser_version: '13.5.7' - torbrowser_build: 'build3' + torbrowser_version: '13.5.8' + torbrowser_build: 'build1' # This should be the date of when the build is started. For the build # to be reproducible, browser_release_date should always be in the past. - browser_release_date: '2024/10/08 18:28:00' + browser_release_date: '2024/10/14 17:30:00' browser_release_date_timestamp: '[% USE date; date.format(c("var/browser_release_date"), "%s") %]' updater_enabled: 1 build_mar: 1 torbrowser_incremental_from: + # 13.5.8 was Android-only + - 13.5.7 - 13.5.6 - '[% IF c("var/tor-browser") %]13.5.5[% END %]' - - '[% IF c("var/tor-browser") %]13.5.4[% END %]' - '[% IF c("var/mullvad-browser") %]13.5.3[% END %]' - - '[% IF c("var/mullvad-browser") %]13.5.2[% END %]' mar_channel_id: '[% c("var/projectname") %]-torproject-[% c("var/channel") %]' # By default, we sort the list of installed packages. This allows sharing View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/3… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/3… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/firefox-android] Pushed new tag firefox-android-115.2.1-13.5-1-build16
by Pier Angelo Vendrame (＠pierov) 14 Oct '24

14 Oct '24

Pier Angelo Vendrame pushed new tag firefox-android-115.2.1-13.5-1-build16 at The Tor Project / Applications / firefox-android -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/tree/firef… You're receiving this email because of your account on gitlab.torproject.org.

1 0