- tor-commits - lists.torproject.org

[Git][tpo/applications/tor-browser] Pushed new branch base-browser-115.17.0esr-13.5-1
by Pier Angelo Vendrame (＠pierov) 22 Oct '24

22 Oct '24

Pier Angelo Vendrame pushed new branch base-browser-115.17.0esr-13.5-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/base-brow… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-115.17.0esr-13.5-1] 218 commits: Bug 1644383 - add mutexs to avoid data race. r=media-playback-reviewers, padenot
by Pier Angelo Vendrame (＠pierov) 22 Oct '24

22 Oct '24

Pier Angelo Vendrame pushed to branch tor-browser-115.17.0esr-13.5-1 at The Tor Project / Applications / Tor Browser Commits: 15e42dc2 by alwu at 2024-10-21T19:20:39+02:00 Bug 1644383 - add mutexs to avoid data race. r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D206943 - - - - - 2fb39426 by Edgar Chen at 2024-10-21T19:20:40+02:00 Bug 1743329 - Handle ESC key to release pointer lock in parent process; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D211621 - - - - - 45a8a295 by Edgar Chen at 2024-10-21T19:20:40+02:00 Bug 1743329 - Release pointer lock when xul popup is open; r=smaug,pbz Differential Revision: https://phabricator.services.mozilla.com/D211620 - - - - - 8e1dc38d by Edgar Chen at 2024-10-21T19:20:40+02:00 Bug 1743329 - Use nsMenuPopupFrame in GetVisiblePopups(); r=smaug Differential Revision: https://phabricator.services.mozilla.com/D211619 A further change was needed in nsCaret.cpp, see https://gitlab.torproject.org/tpo/applications/tor-browser/-/merge_requests… - - - - - f6424cac by Otto Länd at 2024-10-21T19:20:40+02:00 Bug 1743329: apply code formatting via Lando # ignore-this-changeset - - - - - 69789163 by Anna Weine at 2024-10-21T19:20:41+02:00 Bug 1760806 - WebCrypto: ECDH and ECDSA JWK import to check that the crv in params and crv in alg are the same r=keeler https://treeherder.mozilla.org/jobs?repo=try&revision=ed7936b105dea8e58… Differential Revision: https://phabricator.services.mozilla.com/D217273 - - - - - 256a5f5c by Pier Angelo Vendrame at 2024-10-21T19:20:41+02:00 Bug 1787790: Normalize system fonts with RFP on. r=emilio System fonts can leak any user customization of system fonts, or user's locale (e.g., en-US and ja Windows have different system fonts). Also, Linux distributions/desktop environments set default fonts in different ways. Customization can be detected either with font metrics, the font allowed list is not enabled or the font is included in it, or with getComputedStyle, that leaks the name of the font that Firefox tries to apply. This patch try to prevent these leaks by using a generic "sans-serif" for all system fonts, except on macOS, where it uses "-apple-system", and on Android, where these fonts always use Roboto. Differential Revision: https://phabricator.services.mozilla.com/D163576 - - - - - f372515f by Eitan Isaacson at 2024-10-21T19:20:41+02:00 Bug 1819160 - Map Android ids to doc/accessible id pairs. r=Jamie Differential Revision: https://phabricator.services.mozilla.com/D179737 - - - - - 07f4196a by Fatih at 2024-10-21T19:20:41+02:00 Bug 1830629: Remove unnecessary checks for pdf.js for RFP. r=tjr resource:// is exempt from RFP, so we no longer need to check pdf.js specifically. Differential Revision: https://phabricator.services.mozilla.com/D209359 - - - - - c4cfdc82 by Pier Angelo Vendrame at 2024-10-21T19:20:41+02:00 Bug 1832523 - Allow using NSS to sign and verify MAR signatures. r=application-update-reviewers,glandium,bytesized Allow using NSS for checking MAR signatures also in platforms where OS-native APIs are used by default, i.e., macOS and Windows. Differential Revision: https://phabricator.services.mozilla.com/D177743 - - - - - 0a3a9011 by Pier Angelo Vendrame at 2024-10-21T19:20:42+02:00 Bug 1849129: Prevent exceptions caused by extensions from interrupting the SearchService initialization. r=search-reviewers,Standard8 Differential Revision: https://phabricator.services.mozilla.com/D186456 - - - - - a40c23a5 by Emilio Cobos Álvarez at 2024-10-21T19:20:42+02:00 Bug 1853731 - Use html:img for message-bar-icon. r=Gijs,dao,settings-reviewers,desktop-theme-reviewers,sfoster Differential Revision: https://phabricator.services.mozilla.com/D188521 - - - - - e305a97e by Pier Angelo Vendrame at 2024-10-21T19:20:42+02:00 Bug 1854117 - Sort the DLL blocklist flags. r=mossop,win-reviewers,gstoll Differential Revision: https://phabricator.services.mozilla.com/D188716 - - - - - 830f4baa by Eden Chuang at 2024-10-21T19:20:42+02:00 Bug 1738426 - Ignoring status 206 and vary header checking for opaque response in Cache API. r=asuth Differential Revision: https://phabricator.services.mozilla.com/D186431 - - - - - ef97c9fd by edgul at 2024-10-21T19:20:42+02:00 Bug 1802057 - Block the following characters from use in the cookie name in the cookie string: 0x3B (semi-colon), 0x3D (equals), and 0x7F (del) r=dveditz,cookie-reviewers Differential Revision: https://phabricator.services.mozilla.com/D182373 - - - - - c210215c by Kelsey Gilbert at 2024-10-21T19:20:43+02:00 Bug 1819497 - Don't race on static bool for initialization. r=gfx-reviewers,aosmond We could do non-racy static init here (e.g. with a static initializer self-calling-closure), but there doesn't seem to be a strong reason for this. Let's just use a switch and get robustness from -Werror=switch. Differential Revision: https://phabricator.services.mozilla.com/D188054 - - - - - 8ede21fc by Edgar Chen at 2024-10-21T19:20:43+02:00 Bug 1828259 - Close XUL popup when entering/exiting fullscreen; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D209355 - - - - - a48d10d2 by hackademix at 2024-10-21T19:20:43+02:00 Bug 1835987 - Change RFP-spoofed TZ to Atlantic/Reykjavik. r=tjr Atlantic/Reykjavik stays on UTC during all the year, but it is less likely to be blocked than plan UTC. Differential Revision: https://phabricator.services.mozilla.com/D212131 - - - - - 0312764e by edgul at 2024-10-21T19:20:43+02:00 Bug 1879952 - Fix test expectations with samesite=lax turned on r=tschuster Differential Revision: https://phabricator.services.mozilla.com/D201639 - - - - - 8c7c5b87 by edgul at 2024-10-21T19:20:43+02:00 Bug 1844827 - Added checks for sub-document navigations from cross-site to same-site in third-party checks when setting a cookie. r=cookie-reviewers,valentin,bvandersloot a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D204074 - - - - - defb76e0 by Ed at 2024-10-21T19:20:44+02:00 Bug 1844827 - Update the cookie test expectations for iframe samesite r=cookie-reviewers,valentin a=RyanVM Depends on D199770 Differential Revision: https://phabricator.services.mozilla.com/D199772 - - - - - e1dcb5b0 by Mark Banner at 2024-10-21T19:20:44+02:00 Bug 1845752. r=ckerschb Differential Revision: https://phabricator.services.mozilla.com/D186676 - - - - - f99b92b4 by Pier Angelo Vendrame at 2024-10-21T19:20:44+02:00 Bug 1849186 - Add a preference not to expose the content title in the window title. r=Gijs,tabbrowser-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D190496 - - - - - c843cb7a by Bob Owen at 2024-10-21T19:20:44+02:00 Bug 1850072: Initialize RecordedDrawTargetCreation::mHasExistingData. r=jrmuizel This also specializes ElementStreamFormat for bool. Differential Revision: https://phabricator.services.mozilla.com/D187794 - - - - - a62a9c8b by Malte Juergens at 2024-10-21T19:20:45+02:00 Bug 1850200 - Add delay to HTTPS-Only "Continue to HTTPS Site" button r=freddyb Differential Revision: https://phabricator.services.mozilla.com/D187887 - - - - - 932e9d86 by Henry Wilkes at 2024-10-21T19:20:45+02:00 Bug 1851618 - Allow removing packaged locales from requestedLocales. r=settings-reviewers,eemeli,Gijs We open up the UI to allow the user to remove locales from their requestedLocales list, except for the default locale. Differential Revision: https://phabricator.services.mozilla.com/D209930 - - - - - 10b908b5 by Andreas Pehrson at 2024-10-21T19:20:45+02:00 Bug 1851803 - Introduce SourceMediaTrack::mDirectDisabledMode. r=karlt Similar to MediaTrack::mDisabledMode, but this is for uses on the SourceMediaTrack producer thread. It is still signaled via a control message from the control thread to maintain order of operations, and is protected by the SourceMediaTrack mutex. Differential Revision: https://phabricator.services.mozilla.com/D187554 - - - - - bb4d4ff4 by Pier Angelo Vendrame at 2024-10-21T19:20:45+02:00 Bug 1860020 - Remove the assertion on the value of toolkit.telemetry.enabled. r=KrisWright,chutten Bug 1444275 introduced an assertion on the parent process to check that the value of toolkit.telemetry.enabled is the expected one. However, this expected value could be different from the one set and locked e.g. in some forks. Therefore, the assertion prevented debug builds from working in these cases. Differential Revision: https://phabricator.services.mozilla.com/D195080 - - - - - f1ffff8c by Kagami Sascha Rosylight at 2024-10-21T19:20:45+02:00 Bug 1865238 - Use One UI Sans KR VF for Korean sans-serif font on Android r=jfkthame Per /etc/fonts.xml, there are now only two `<family lang="ko">` nodes there: * OneUISansKRVF series * SECCJK series (but no KR postfix anymore?) This patch uses One UI Sans KR VF as the replacement as this is newer and is a variable font (tested with https://codepen.io/SaschaNaz/pen/ExrdYXJ) Differential Revision: https://phabricator.services.mozilla.com/D195078 - - - - - f1770bf2 by Nuohan Li at 2024-10-21T19:20:46+02:00 Bug 1871109 - generateHash in Manifest.sys.mjs should use sha256 r=peterv, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D204928 - - - - - 6a832628 by Tom Ritter at 2024-10-21T19:20:46+02:00 Bug 1873526: Refactor the restriction override list from a big if statement to a list r=KrisWright Differential Revision: https://phabricator.services.mozilla.com/D198081 - - - - - eeef9257 by Nika Layzell at 2024-10-21T19:20:46+02:00 Bug 1875248 - Check for network error preventing ExternalHelperAppService before DONT_RETARGET, r=smaug This reverts the change from 30cde47f9364e5c7da78fd08fa8ab21737d22399, and instead re-orders the NS_ERROR_FILE_NOT_FOUND check before DONT_RETARGET. Testing suggests that a-download-click-404.html behaviour isn't impacted, and this improves the handling of this edge-case when doing process switching. Differential Revision: https://phabricator.services.mozilla.com/D202007 - - - - - 85f3bae4 by Pier Angelo Vendrame at 2024-10-21T19:20:46+02:00 Bug 1875306 - Localize numbers in the underflow and overflow error messages. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D198965 - - - - - 655cf983 by Pier Angelo Vendrame at 2024-10-21T19:20:46+02:00 Bug 1875313 - Use en-US as a fallback when spoof English is enabled in ICUUtils. r=timhuang,tjr Differential Revision: https://phabricator.services.mozilla.com/D198967 - - - - - 5768df7a by Julian Descottes at 2024-10-21T19:20:47+02:00 Bug 1880374 - Disable DNS prefetching if document nodePrincipal is systemPrincipal r=valentin Differential Revision: https://phabricator.services.mozilla.com/D210830 - - - - - fc2f0f4c by Pier Angelo Vendrame at 2024-10-21T19:20:47+02:00 Bug 1880988 - Apply spoof English to the default detail summary. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D202203 - - - - - 11e3c55d by Nika Layzell at 2024-10-21T19:24:45+02:00 Bug 1881037 - Part 1: Stop showing unknown protocol error pages for web-triggered loads, r=smaug,necko-reviewers,kershaw, a=dsmith Differential Revision: https://phabricator.services.mozilla.com/D217495 - - - - - ae0c1bb5 by Edgar Chen at 2024-10-21T19:24:45+02:00 Bug 1883396 - Exit fullscreen when two Escape keyup events occur in a short time; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D209667 - - - - - a8a015ab by Fatih at 2024-10-21T19:24:45+02:00 Bug 1885101: Match screen and window properties with top window for ScreenRect, ScreenAvailRect and WindowOuterSize. r=timhuang,emilio This patch removes test_iframe.html. We remove it because the newly introduced test covers the tests done in that test. The reason for removing it in the first place is now that screen properties are inherited/spoofed xorigin, we get a 4px difference. The reasosn for 4px difference is the test runner runs tests in an iframe with a 2px border on each side. Differential Revision: https://phabricator.services.mozilla.com/D215509 - - - - - 5aa668b9 by Tom Ritter at 2024-10-21T19:24:45+02:00 Bug 1885258: Hidden fonts should obey the allow list r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D204571 - - - - - 4d143dec by Andreas Farre at 2024-10-21T19:24:46+02:00 Bug 1886222 - Start reload by calling reload in the parent. r=Gijs,canadahonk,smaug, a=dsmith (esr128->esr115 backport) Differential Revision: https://phabricator.services.mozilla.com/D211519 - - - - - c399c809 by Jonathan Kew at 2024-10-21T19:24:46+02:00 Bug 1886598 - Struct with Pointer member may not be memmove-able. r=gfx-reviewers,lsalzman Differential Revision: https://phabricator.services.mozilla.com/D206633 - - - - - 940b6f1b by Jonathan Kew at 2024-10-21T19:24:46+02:00 Bug 1890204 - Ensure font entry's unitsPerEm and font extents are initialized when gfxFont is created. r=gfx-reviewers,lsalzman This means that by the time we potentially call GetFontExtents() when drawing, the extents fields are guaranteed to have been been initialized, and there's no risk of the (read-only) access here racing with setting them in UnitsPerEm(). Differential Revision: https://phabricator.services.mozilla.com/D206920 - - - - - cbc4e0f1 by Kershaw Chang at 2024-10-21T19:24:46+02:00 Bug 1892449 - Set network.http.digest_auth_cnonce_length to 16, a=dmeehan Apparently, setting this value to 64 breaks some sites. We should use the same length as Chrome. Original Revision: https://phabricator.services.mozilla.com/D208103 Differential Revision: https://phabricator.services.mozilla.com/D208119 - - - - - aa9da3a6 by cypherpunks1 at 2024-10-21T19:24:46+02:00 Bug 1892052 - Do not persist custom network requests on PBM. r=devtools-reviewers,bomsy,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D207762 - - - - - 06ea7c6a by Jonathan Kew at 2024-10-21T19:24:47+02:00 Bug 1893891 - Clear mSharedBlobData if blob creation failed. a=dmeehan Original Revision: https://phabricator.services.mozilla.com/D208983 Differential Revision: https://phabricator.services.mozilla.com/D209209 - - - - - 310454ed by cypherpunks1 at 2024-10-21T19:24:47+02:00 Bug 1892046 - Add origin attributes to about:reader requests. r=reader-mode-reviewers,cmkm Differential Revision: https://phabricator.services.mozilla.com/D207759 - - - - - c3a99784 by Timothy Nikkel at 2024-10-21T19:24:47+02:00 Bug 1899180. If a channel is not nsIPrivateBrowsingChannel and has no load context, use the private browsing field from it's origin attributes. r=necko-reviewers,anti-tracking-reviewers,valentin If the channel is not a nsIPrivateBrowsingChannel, and it also has no load context (eg inside svg images) then we will over write a non-zero mPrivateBrowsingId on the OriginAttributes of the channel with 0, making NS_UsePrivateBrowsing return false for the channel. Differential Revision: https://phabricator.services.mozilla.com/D212083 - - - - - a0124a74 by Jan de Mooij at 2024-10-21T19:24:47+02:00 Bug 1900523 - Don't use bailout data for JSJitToWasm frames. r=iain Differential Revision: https://phabricator.services.mozilla.com/D212554 - - - - - 420e147e by Jan de Mooij at 2024-10-21T19:24:47+02:00 Bug 1902983 - Don't use bailout data after iterating Wasm frames. a=RyanVM This is similar to bug 1900523, but the fix there was incomplete because the `JSJitToWasm` frame type is only used when we go through the Wasm JIT entry trampoline. Ion can also call Wasm functions directly and in that case the type will be `FrameType::Exit`. Original Revision: https://phabricator.services.mozilla.com/D214098 Differential Revision: https://phabricator.services.mozilla.com/D214375 - - - - - db3f8d1e by Jon Coppeard at 2024-10-21T19:24:48+02:00 Bug 1904011 - Ignore finalized scripts when iterating code covarage tables r=iain Differential Revision: https://phabricator.services.mozilla.com/D214799 - - - - - 12052dfa by Kershaw Chang at 2024-10-21T19:24:48+02:00 Bug 1907726 - Make sure WebTransportSessionProxy::NotifyDatagramReceived is called after OnStopRequest, a=RyanVM The crash occurs because WebTransportSessionProxy::OnDatagramReceivedInternal is called before WebTransportSessionProxy::OnStopRequest. When this happens, WebTransportSessionProxy::mTarget is the main thread, so a task is dispatched to the main thread. This causes WebTransportSessionProxy::NotifyDatagramReceived to be called on the main thread. If WebTransportSessionProxy::NotifyDatagramReceived is invoked while WebTransportSessionProxy::mStopRequestCalled is true, it can lead to OnDatagramReceived being called on the main thread (instead of the socket thread), resulting in a crash. Original Revision: https://phabricator.services.mozilla.com/D220013 Differential Revision: https://phabricator.services.mozilla.com/D221661 - - - - - aea2ea2a by Sam Foster at 2024-10-21T19:24:48+02:00 Bug 1909099 - Always clean up old session restore and sync log files. r=markh,sessionstore-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D217520 - - - - - e42b03cd by Nika Layzell at 2024-10-21T19:24:48+02:00 Bug 1911745 - Unify BrowsingContext flag coherency checks, r=mccr8 Previously these checks were largely diagnostic tools for finding bugs in other code as it evolves. This unifies the checks a bit more and makes them stronger for BrowsingContexts created over IPC, providing a place for more coherency checks to be added in the future. Differential Revision: https://phabricator.services.mozilla.com/D218860 - - - - - 77021b25 by Steve Fink at 2024-10-21T19:24:49+02:00 Bug 1912471 - Disallow deserializing structured clone buffers with transferables more than once r=iain, a=dsmith Differential Revision: https://phabricator.services.mozilla.com/D220644 - - - - - c67ec7dd by Emilio Cobos Álvarez at 2024-10-21T19:24:49+02:00 Bug 1914106 - Deal with insertRule edge-case. r=jwatt a=RyanVM When there's trailing garbage after an @import rule we throw, but we still trigger the load (that's not great but not trivial to change). Deal with that case before calling ImportRuleLoaded(). Differential Revision: https://phabricator.services.mozilla.com/D219783 - - - - - 5cbd4cb6 by André Bargull at 2024-10-21T19:24:49+02:00 Bug 1915249: Add more nodiscard. a=RyanVM Original Revision: https://phabricator.services.mozilla.com/D220311 Differential Revision: https://phabricator.services.mozilla.com/D221663 - - - - - e265819d by Paul Zuehlcke at 2024-10-21T19:24:49+02:00 Bug 1916659, a=diannaS Original Revision: https://phabricator.services.mozilla.com/D222629 Differential Revision: https://phabricator.services.mozilla.com/D222934 - - - - - 92c9fcda by Henry Wilkes at 2024-10-21T19:24:49+02:00 Bug 41454: Move focus after calling openPreferences for a sub-category. Temporary fix until mozilla bug 1799153 gets a patch upstream. - - - - - d657ae62 by hackademix at 2024-10-21T19:24:50+02:00 Bug 42194: Fix blank net error page on failed DNS resolution with active proxy. - - - - - d6c1dc01 by Henry Wilkes at 2024-10-21T19:24:50+02:00 Bug 41483: Remove the firefox override for appstrings.properties Remove this patch after upstream bugzilla bug 1790187 - - - - - 0d65a480 by Marco Simonelli at 2024-10-21T19:24:50+02:00 Bug 41459: WebRTC fails to build under mingw (Part 1) - properly define NOMINMAX for just MSVC builds - - - - - 38409e5b by Marco Simonelli at 2024-10-21T19:24:50+02:00 Bug 41459: WebRTC fails to build under mingw (Part 2) - fixes required to build third_party/libwebrtc - - - - - 31afb04d by Marco Simonelli at 2024-10-21T19:24:50+02:00 Bug 41459: WebRTC fails to build under mingw (Part 3) - fixes required to build third_party/sipcc - - - - - 3a19fff3 by Marco Simonelli at 2024-10-21T19:24:51+02:00 Bug 41459: WebRTC fails to build under mingw (Part 4) - fixes requried to build netwerk/sctp - - - - - c6e8edd7 by Marco Simonelli at 2024-10-21T19:24:51+02:00 Bug 41459: WebRTC fails to build under mingw (Part 5) - fixes required to build dom/media/webrtc - - - - - 23eb92a3 by Marco Simonelli at 2024-10-21T19:24:51+02:00 Bug 41459: WebRTC fails to build under mingw (Part 6) - fixes required to build dom/media/systemservices - - - - - 1ade3e05 by hackademix at 2024-10-21T19:24:51+02:00 Bug 41854: Allow overriding download spam protection. - - - - - ffa20eee by hackademix at 2024-10-21T19:24:51+02:00 Bug 42835: Create an actor to filter file data transfers - - - - - 93ac479d by Gaba at 2024-10-21T19:24:52+02:00 Adding issue and merge request templates - - - - - 7630bc80 by Pier Angelo Vendrame at 2024-10-21T19:24:52+02:00 Base Browser's .mozconfigs. Bug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Bug 21849: Don't allow SSL key logging. Bug 25741 - TBA: Disable features at compile-time Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds This fixes a problem where some preferences had the wrong default value. Also see bug 27472 where we made a similar fix for Android. Bug 29859: Disable HLS support for now Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT Bug 33734: Set MOZ_NORMANDY to False Bug 33851: Omit Parental Controls. Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files Bug 41584: Move some configuration options to base-browser level - - - - - 305a8962 by Pier Angelo Vendrame at 2024-10-21T19:24:52+02:00 Tweaks to the build system Bug 40857: Modified the fat .aar creation file This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build. We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770. Bug 41458: Prevent `mach package-multi-locale` from actually creating a package macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it. - - - - - 3b0529d1 by Pier Angelo Vendrame at 2024-10-21T19:24:52+02:00 Bug 41108: Remove privileged macOS installation from 102 - - - - - dc226763 by Dan Ballard at 2024-10-21T19:24:52+02:00 Bug 41149: Re-enable DLL injection protection in all builds not just nightlies - - - - - 575c519d by Matthew Finkel at 2024-10-21T19:24:53+02:00 Bug 24796: Comment out excess permissions from GeckoView The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. - - - - - 6eea9a35 by Matthew Finkel at 2024-10-21T19:24:53+02:00 Bug 28125: Prevent non-Necko network connections - - - - - 8b174219 by Mike Perry at 2024-10-21T19:24:53+02:00 Bug 12974: Disable NTLM and Negotiate HTTP Auth The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602 - - - - - 3883b709 by Alex Catarineu at 2024-10-21T19:24:53+02:00 Bug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899 - - - - - 30b2a38d by Georg Koppen at 2024-10-21T19:24:54+02:00 Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. - - - - - 400cc0bf by Kathy Brade at 2024-10-21T19:24:54+02:00 Bug 21431: Clean-up system extensions shipped in Firefox Only ship the pdfjs extension. - - - - - c17e6c4a by Kathy Brade at 2024-10-21T19:24:54+02:00 Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps. Disable the "Create New Login" button when security.nocertdb is true. - - - - - 6a01ff12 by Alex Catarineu at 2024-10-21T19:24:54+02:00 Bug 41457: Remove Mozilla permissions Bug 40025: Remove Mozilla add-on install permissions - - - - - 423fe880 by Kathy Brade at 2024-10-21T19:24:54+02:00 Bug 40002: Remove about:ion Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Bug 41662: Disable about:sync-logs Even though we disable sync by default with `identity.fxaccounts.enabled`, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component. - - - - - b83ac777 by Arthur Edelstein at 2024-10-21T19:24:55+02:00 Bug 26353: Prevent speculative connect that violated FPI. Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. - - - - - 5eb344bb by Alex Catarineu at 2024-10-21T19:24:55+02:00 Bug 31740: Remove some unnecessary RemoteSettings instances More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls. Avoid creating instance for 'anti-tracking-url-decoration'. If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'. Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps. We also clear the collections database on the v2 -> v3 migration. - - - - - e3aeadb8 by cypherpunks1 at 2024-10-21T19:24:55+02:00 Bug 41092: Add a RemoteSettings JSON dump for query-stripping - - - - - d7e810b5 by Pier Angelo Vendrame at 2024-10-21T19:24:55+02:00 Bug 41635: Disable the Normandy component Do not include Normandy at all whenever MOZ_NORMANDY is False. - - - - - 4911d42b by Georg Koppen at 2024-10-21T19:24:55+02:00 Bug 30541: Disable WebGL readPixel() for web content Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034 - - - - - d4d2011e by Alex Catarineu at 2024-10-21T19:24:56+02:00 Bug 28369: Stop shipping pingsender executable - - - - - e1645e96 by cypherpunks1 at 2024-10-21T19:24:56+02:00 Bug 41568: Disable LaterRun - - - - - d7a44b7f by cypherpunks1 at 2024-10-21T19:24:56+02:00 Bug 40717: Hide Windows SSO in settings - - - - - 7876ccf2 by Pier Angelo Vendrame at 2024-10-21T19:24:56+02:00 Bug 41599: Always return an empty string as network ID Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users. We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756 - - - - - 74d23166 by Richard Pospesel at 2024-10-21T19:24:56+02:00 Bug 41327: Disable UrlbarProviderInterventions - - - - - d73f257d by Richard Pospesel at 2024-10-21T19:24:57+02:00 Bug 42037: Disable about:firefoxview page - - - - - f0512bb8 by Mike Perry at 2024-10-21T19:24:57+02:00 Firefox preference overrides. This hack directly includes our preference changes in omni.ja. Bug 18292: Staged updates fail on Windows Temporarily disable staged updates on Windows. Bug 18297: Use separate Noto JP,KR,SC,TC fonts Bug 23404: Add Noto Sans Buginese to the macOS whitelist Bug 23745: Set dom.indexedDB.enabled = true Bug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera(a)riseup.net>) Bug 17252: Enable session identifiers with FPI Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers". The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049) Bug 14952: Enable http/2 and AltSvc In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2". Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well. (All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.) However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false. "network.http.spdy.enabled.http2draft" was removed in Bug 1132357. "network.http.sped.enabled.v2" was removed in Bug 912550. "network.http.sped.enabled.v3" was removed in Bug 1097944. "network.http.sped.enabled.v3-1" was removed in Bug 1248197. Bug 26114: addons.mozilla.org is not special * Don't expose navigator.mozAddonManager on any site * Don't block NoScript from modifying addons.mozilla.org or other sites Enable ReaderView mode again (#27281). Bug 29916: Make sure enterprise policies are disabled Bug 2874: Block Components.interfaces from content Bug 26146: Spoof HTTP User-Agent header for desktop platforms In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs. Bug 12885: Windows Jump Lists fail for Tor Browser Jumplist entries are stored in a binary file in: %APPDATA%\\Microsoft\Windows\Recent\CustomDestinations\ and has a name in the form [a-f0-9]+.customDestinations-ms The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller. However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past. The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted. Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See bug 28996. Bug 30845: Make sure default themes and other internal extensions are enabled Bug 28896: Enable extensions in private browsing by default Bug 31065: Explicitly allow proxying localhost Bug 31598: Enable letterboxing Disable Presentation API everywhere Bug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels. Bug 32321: Disable Mozilla's MitM pings Bug 19890: Disable installation of system addons By setting the URL to "" we make sure that already installed system addons get deleted as well. Bug 22548: Firefox downgrades VP9 videos to VP8. On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8. This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available". Bug 25741 - TBA: Add mobile-override of 000-tor-browser prefs Bug 16441: Suppress "Reset Tor Browser" prompt. Bug 29120: Use the in-memory media cache and increase its maximum size. Bug 33697: use old search config based on list.json Bug 33855: Ensure that site-specific browser mode is disabled. Bug 30682: Disable Intermediate CA Preloading. Bug 40061: Omit the Windows default browser agent from the build Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40408: Disallow SVG Context Paint in all web content Bug 40308: Disable network partitioning until we evaluate dFPI Bug 40322: Consider disabling network.connectivity-service.enabled Bug 40383: Disable dom.enable_event_timing Bug 40423: Disable http/3 Bug 40177: Update prefs for Fx91esr Bug 40700: Disable addons and features recommendations Bug 40682: Disable network.proxy.allow_bypass Bug 40736: Disable third-party cookies in PBM Bug 19850: Enabled HTTPS-Only by default Bug 40912: Hide the screenshot menu Bug 41292: Disable moreFromMozilla in preferences page Bug 40057: Ensure the CSS4 system colors are not a fingerprinting vector Bug 24686: Set network.http.tailing.enabled to true Bug 40183: Disable TLS ciphersuites using SHA-1 Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102 We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them. - - - - - 39aa6950 by hackademix at 2024-10-21T19:24:57+02:00 fixup! Firefox preference overrides. MB361: Disable only cyphersuites using SH1 for signing (ECDSA). - - - - - ddd07850 by Pier Angelo Vendrame at 2024-10-21T19:24:57+02:00 Bug 41043: Hardcode the UI font on Linux The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version. Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese). - - - - - 8ea8fcc9 by Pier Angelo Vendrame at 2024-10-21T19:24:57+02:00 Bug 41901: Hardcode normalized FontSubstitutes. Windows has a system to set font aliases through the registry. This allows some customization that could be used as a fingerprinting vector. Moreover, this mechanism is used by Windows itself, and different SKUs might have different default FontSubstitutes. - - - - - 467bc60a by Alex Catarineu at 2024-10-21T19:24:58+02:00 Bug 30605: Honor privacy.spoof_english in Android This checks `privacy.spoof_english` whenever `setLocales` is called from Fenix side and sets `intl.accept_languages` accordingly. Bug 40198: Expose privacy.spoof_english pref in GeckoView - - - - - 14c09a65 by Pier Angelo Vendrame at 2024-10-21T19:24:58+02:00 Bug 42562: Normalized the Accepted Languages on Android. The OS language might be outside the list of actually supported languages and it might leak the user's region. Therefore, we force the locale reported in Accept-Language to match one we support with translations, even when it means using a not exact region tag. - - - - - 5c376262 by Alex Catarineu at 2024-10-21T19:24:58+02:00 Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware - - - - - 79a2cb0b by Alex Catarineu at 2024-10-21T19:24:58+02:00 Bug 26345: Hide tracking protection UI - - - - - 5d7a8b45 by Pier Angelo Vendrame at 2024-10-21T19:24:59+02:00 Bug 9173: Change the default Firefox profile directory to be relative. This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows. On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle. This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS). - - - - - daa2e752 by Alex Catarineu at 2024-10-21T19:24:59+02:00 Bug 27604: Fix addon issues when moving the profile directory Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838 - - - - - d5d736d1 by Mike Perry at 2024-10-21T19:24:59+02:00 Bug 13028: Prevent potential proxy bypass cases. It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509 - - - - - 4053744c by Pier Angelo Vendrame at 2024-10-21T19:24:59+02:00 Bug 40309: Avoid using regional OS locales Avoid regional OS locales if the pref `intl.regional_prefs.use_os_locales` is false but RFP is enabled. - - - - - 1e8f584a by Matthew Finkel at 2024-10-21T19:24:59+02:00 Bug 40432: Prevent probing installed applications Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084 - - - - - 12f36478 by cypherpunks1 at 2024-10-21T19:25:00+02:00 Bug 33955: When copying an image only copy the image contents to the clipboard - - - - - 85ded2f2 by cypherpunks1 at 2024-10-21T19:25:00+02:00 Bug 41791: Omit the source URL when copying page contents to the clipboard - - - - - ad09f7a0 by hackademix at 2024-10-21T19:25:00+02:00 Bug 42288: Allow language spoofing in status messages. - - - - - 72644e77 by Richard Pospesel at 2024-10-21T19:25:00+02:00 Bug 41659: Add canonical color definitions to base-browser - - - - - dcb1e5c4 by Pier Angelo Vendrame at 2024-10-21T19:25:00+02:00 Base Browser strings This commit adds all the strings needed by following Base Browser patches. - - - - - 197bab6d by Pier Angelo Vendrame at 2024-10-21T19:25:01+02:00 Bug 41369: Improve Firefox language settings for multi-lingual packages Change the language selector to be sorted by language code, rather than name, and to display the language code to the user. Bug 41372: Handle Japanese as a special case in preferences on macOS Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs. Bug 41378: Tell users that they can change their language at the first start With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once. - - - - - 0dfa3209 by p13dz at 2024-10-21T19:25:01+02:00 Bug 40283: Workaround for the file upload bug - - - - - 45d937ec by Arthur Edelstein at 2024-10-21T19:25:01+02:00 Bug 18905: Hide unwanted items from help menu Bug 25660: Remove the "New Private Window" option - - - - - d13be5f6 by Pier Angelo Vendrame at 2024-10-21T19:25:01+02:00 Bug 41739: Remove "Website appearance" from about:preferences. It is ignored because of RFP and it is confusing for users. - - - - - 8efe9e13 by hackademix at 2024-10-21T19:25:01+02:00 Bug 42019: Empty browser's clipboard on browser shutdown - - - - - a9063258 by hackademix at 2024-10-21T19:25:02+02:00 fixup! Bug 42019: Empty browser's clipboard on browser shutdown Bug 43209: Check if any data is available before trying to retrieve it from the clipboard. - - - - - 4d813266 by hackademix at 2024-10-21T19:25:02+02:00 Bug 42084: Ensure English spoofing works even if preferences are set out of order. - - - - - 34e4b2f3 by Pier Angelo Vendrame at 2024-10-21T19:25:02+02:00 Bug 41930: Remove the UI to customize accept_languages. - - - - - 23e2b0c5 by Pier Angelo Vendrame at 2024-10-21T19:25:02+02:00 Bug 42376: Pass the locale list when constructing l10n in datetimebox The datetime input is inconsistent with other inputs when using spoof English: its placeholder is not translated, unlike the default values and texts of all the other inputs. - - - - - 8ca163fd by Pier Angelo Vendrame at 2024-10-21T19:25:02+02:00 Bug 42428: Make RFP spoof the timezone of document.lastModified. - - - - - ffede0aa by Pier Angelo Vendrame at 2024-10-21T19:25:03+02:00 Bug 42472: Spoof timezone in XSLT. - - - - - 5d983815 by hackademix at 2024-10-21T19:25:03+02:00 Bug 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs. - - - - - 875ed88f by hackademix at 2024-10-21T19:25:03+02:00 Bug 41434: Letterboxing, improve logging. - - - - - 39df1548 by hackademix at 2024-10-21T19:25:03+02:00 Bug 31064: Letterboxing, exempt browser extensions. - - - - - 1bf8c959 by hackademix at 2024-10-21T19:25:04+02:00 Bug 32411: Letterboxing, exempt view-source: URIs. - - - - - 8be9c6e6 by hackademix at 2024-10-21T19:25:04+02:00 Bug 42574: Letterboxing, exempt pdf.js. - - - - - 6850b28c by hackademix at 2024-10-21T19:25:04+02:00 Bug 32308: Use direct browser sizing for letterboxing. Bug 30556: align letterboxing with 200x100 new win width stepping - - - - - 17803ad5 by hackademix at 2024-10-21T19:25:04+02:00 Bug 41631: Prevent weird initial window dimensions caused by subpixel computations - - - - - b5b74738 by hackademix at 2024-10-21T19:25:04+02:00 Bug 41918: Option to reuse last window size when letterboxing is enabled. - - - - - 62d5b9a5 by hackademix at 2024-10-21T19:25:05+02:00 Bug 41916: Letterboxing preferences UI - - - - - da24d7f2 by hackademix at 2024-10-21T19:25:05+02:00 Bug 41695: Warn on window maximization without letterboxing in RFPHelper module - - - - - f8c2c09c by hackademix at 2024-10-21T19:25:05+02:00 Bug 42443: Shrink window to match letterboxing size when the emtpy area is clicked. - - - - - e8721bd0 by Henry Wilkes at 2024-10-21T19:25:05+02:00 Bug 42528: Don't leak system scrollbar size on windows. - - - - - 1d9927ec by Henry Wilkes at 2024-10-21T19:25:05+02:00 Bug 31575: Disable Firefox Home (Activity Stream) Treat about:blank as the default home page and new tab page. Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need. Bug 41624: Disable about:pocket-* pages. Bug 40144: Redirect about:privatebrowsing to the user's home - - - - - 1bf01d0d by Kathy Brade at 2024-10-21T19:25:06+02:00 Bug 4234: Use the Firefox Update Process for Base Browser. Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909. Also fix bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update. Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality. Bug 26048: potentially confusing "restart to update" message Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string. Bug 28885: notify users that update is downloading Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress. As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process. Removed #28885 parts of this patch which have been uplifted to Firefox. - - - - - 0807d898 by Pier Angelo Vendrame at 2024-10-21T19:25:06+02:00 fixup! Bug 4234: Use the Firefox Update Process for Base Browser. Bug 42747: Discard unsupported updates earlier. Firefox's updater has a function to select updates, which checks mainly the version number. Therefore, a more recent update that is unsupported will be chosen over a compatible one. We patch this to be able to provide an alternative update path to Windows 7. - - - - - bd0e929f by Pier Angelo Vendrame at 2024-10-21T19:25:06+02:00 Bug 42061: Create an alpha update channel. - - - - - e432a6eb by Nicolas Vigier at 2024-10-21T19:25:06+02:00 Bug 41682: Add base-browser nightly mar signing key - - - - - 120ba80c by Pier Angelo Vendrame at 2024-10-21T19:25:07+02:00 Bug 41603: Customize the creation of MOZ_SOURCE_URL MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/. - - - - - b9909d3b by Pier Angelo Vendrame at 2024-10-21T19:25:07+02:00 Bug 41698: Reword the recommendation badges in about:addons Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them. We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead. Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033 - - - - - 39a3cb81 by Pier Angelo Vendrame at 2024-10-21T19:25:07+02:00 Bug 42438: Tweaks to the migration wizard. Remove the items not compatible with our features (such as history) from the migration wizard. On Linux, allow to specify an alternative home directory, since we usually change $HOME in our startup script. - - - - - 9e928583 by Alex Catarineu at 2024-10-21T19:25:07+02:00 Bug 40069: Add helpers for message passing with extensions - - - - - 168c25bb by Matthew Finkel at 2024-10-21T19:25:07+02:00 Bug 41598: Prevent NoScript from being removed/disabled. Bug 40253: Explicitly allow NoScript in Private Browsing mode. - - - - - 9edc1d32 by Henry Wilkes at 2024-10-21T19:25:08+02:00 Bug 41736: Hide NoScript extension's toolbar button by default. This hides it from both the toolbar and the unified extensions panel. We also hide the unified-extension-button if the panel would be empty: not including the NoScript button when it is hidden. As a result, this will be hidden by default until a user installs another extension (or shows the NoScript button and unpins it). - - - - - fbd763f5 by hackademix at 2024-10-21T19:25:08+02:00 Bug 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons - - - - - 4bbb885b by Pier Angelo Vendrame at 2024-10-21T19:25:08+02:00 Bug 40925: Implemented the Security Level component This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings. Bug 40125: Expose Security Level pref in GeckoView - - - - - 4e28af5f by Pier Angelo Vendrame at 2024-10-21T19:25:08+02:00 Bug 40926: Implemented the New Identity feature - - - - - 841b555b by Henry Wilkes at 2024-10-21T19:25:08+02:00 Bug 41736: Customize toolbar for base-browser. - - - - - 5a2e7786 by Pier Angelo Vendrame at 2024-10-21T19:25:09+02:00 Bug 42027: Base Browser migration procedures. This commit implmenents the the Base Browser's version of _migrateUI. - - - - - 69651b32 by Henry Wilkes at 2024-10-21T19:25:09+02:00 Bug 42583: Modify moz-support-link for Base Browser. - - - - - 08d38e7e by Henry Wilkes at 2024-10-21T19:25:09+02:00 Bug 42347: Add a notification for dropped OS version support. - - - - - 86dabbed by hackademix at 2024-10-21T19:25:09+02:00 Bug 42832: Download spam prevention exemption for browser extensions. - - - - - c07f3047 by Pier Angelo Vendrame at 2024-10-21T19:25:09+02:00 Bug 42467: Make OS HTTP User-Agent OS spoofing configurable by pref This commits makes it possible to disable OS spoofing in the HTTP User-Agent header, to see if matching header and JS property improve usability. - - - - - b481d201 by Henry Wilkes at 2024-10-21T19:31:15+02:00 Bug 42308: Create README for tor-browser. We drop the README.txt that comes from Mozilla Firefox and add README.md for tor-browser. - - - - - 04118a85 by Richard Pospesel at 2024-10-21T19:31:15+02:00 Bug 41649: Create rebase and security backport gitlab issue templates - - - - - 8b7855e2 by Beatriz Rizental at 2024-10-21T19:31:15+02:00 Add CI for Tor Browser - - - - - 155b360c by Richard Pospesel at 2024-10-21T19:31:15+02:00 Bug 41089: Add tor-browser build scripts + Makefile to tor-browser - - - - - 2d5e9de9 by Henry Wilkes at 2024-10-21T19:31:15+02:00 Bug 41803: Add some developer tools for working on tor-browser. - - - - - 370eea58 by Kathy Brade at 2024-10-21T19:31:16+02:00 Bug 11641: Disable remoting by default. Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior. - - - - - bd865126 by Alex Catarineu at 2024-10-21T19:31:16+02:00 Add TorStrings module for localization - - - - - bb2a4991 by Henry Wilkes at 2024-10-21T19:31:46+02:00 Tor Browser strings This commit adds all the strings needed for Tor Browser patches. - - - - - 6258013c by Henry Wilkes at 2024-10-21T19:31:46+02:00 Tor Browser localization migration scripts. - - - - - 2bf720d1 by Henry Wilkes at 2024-10-21T19:31:47+02:00 Bug 42305: Add script to combine translation files across versions. - - - - - 775ce552 by Mike Perry at 2024-10-21T19:31:47+02:00 Bug 2176: Rebrand Firefox to TorBrowser See also Bugs #5194, #7187, #8115, #8219. This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons. Also fix bug 27905. Bug 25702: Update Tor Browser icon to follow design guidelines - Updated all of the branding in /browser/branding/official with new 'stable' icon series. - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory - Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654) - Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory - Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico) - Added default256.png and default512.png icons - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon - Use the Tor Browser icon within devtools/client/themes/images/. Bug 30631: Blurry Tor Browser icon on macOS app switcher It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil. Bug 28196: preparations for using torbutton tor-browser-brand.ftl A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser. Bug 31803: Replaced about:debugging logo with flat version Bug 21724: Make Firefox and Tor Browser distinct macOS apps When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser. Bug 32092: Fix Tor Browser Support link in preferences For bug 40562, we moved onionPattern* from bug 27476 to here, as about:tor needs these files but it is included earlier. Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one Bug 42088: New application icons (used in-app and on linux). Bug 42087: New application icons (windows). - - - - - 8b38b1a1 by Henry Wilkes at 2024-10-21T19:31:47+02:00 Bug 42583: Modify moz-support-link for Tor Browser. - - - - - 0f2d443b by hackademix at 2024-10-21T19:31:47+02:00 Bug 41917: Tor brand-specific styles. - - - - - 034bd451 by Henry Wilkes at 2024-10-21T19:31:47+02:00 Add purple tor version of the loading APNG. - - - - - ae499b11 by sanketh at 2024-10-21T19:31:48+02:00 Bug 40209: Implement Basic Crypto Safety Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning. Closes #40209. Bug 40428: Fix string attribute names - - - - - 9366190b by Mike Perry at 2024-10-21T19:31:48+02:00 TB3: Tor Browser's official .mozconfigs. Also: Add an --enable-tor-browser-data-outside-app-dir configure option Add --with-tor-browser-version configure option Bug 31457: disable per-installation profiles The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data. Bug 31935: Disable profile downgrade protection. Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected. Add --enable-tor-browser-update build option Bug 40793: moved Tor configuration options from old-configure.in to moz.configure Bug 41584: Move some configuration options to base-browser level - - - - - ddd2824b by Henry Wilkes at 2024-10-21T19:31:48+02:00 Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds tor-browser#41285: Enable fluent warnings. - - - - - 3432e5b6 by Pier Angelo Vendrame at 2024-10-21T19:31:48+02:00 Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end. In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply. - - - - - e8a550ac by Morgan at 2024-10-21T19:33:24+02:00 fixup! Bug 40562: Added Tor Browser preferences to 000-tor-browser.js Bug 43170: Disable user-agent spoofing in HTTP header - - - - - 359f47ca by Pier Angelo Vendrame at 2024-10-21T19:33:24+02:00 Bug 13252: Customize profile management on macOS On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode. Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error. - - - - - 25530d34 by Pier Angelo Vendrame at 2024-10-21T19:33:24+02:00 Bug 40933: Add tor-launcher functionality Bug 41926: Reimplement the control port - - - - - 78f5cad7 by Cecylia Bocovich at 2024-10-21T19:33:24+02:00 Lox integration - - - - - 2128db61 by Richard Pospesel at 2024-10-21T19:33:25+02:00 Bug 40597: Implement TorSettings module - migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module - TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs - TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor - about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module - all tor settings live in the torbrowser.settings.* preference branch - removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm Bug 40645: Migrate Moat APIs to Moat.jsm module - - - - - 2f5c4c03 by hackademix at 2024-10-21T19:33:25+02:00 fixup! Bug 40597: Implement TorSettings module - - - - - fa4df7fe by Arthur Edelstein at 2024-10-21T19:33:25+02:00 Bug 3455: Add DomainIsolator, for isolating circuit by domain. Add an XPCOM component that registers a ProtocolProxyChannelFilter which sets the username/password for each web request according to url bar domain. Bug 9442: Add New Circuit button Bug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ. Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce. Bug 19206: Clear out the domain isolator state on `New Identity`. Bug 21201.2: Isolate by firstPartyDomain from OriginAttributes Bug 21745: Fix handling of catch-all circuit Bug 41741: Refactor the domain isolator and new circuit - - - - - 4085ef5a by Henry Wilkes at 2024-10-21T19:33:25+02:00 Bug 41600: Add a tor circuit display panel. - - - - - 2dba20a4 by Pier Angelo Vendrame at 2024-10-21T19:33:25+02:00 Bug 42247: Android helpers for the TorProvider GeckoView is missing some API we use on desktop for the integration with the tor daemon, such as subprocess. Therefore, we need to implement them in Java and plumb the data back and forth between JS and Java. - - - - - 5c8d8969 by hackademix at 2024-10-21T19:33:26+02:00 Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs - - - - - 9dc9b29b by Amogh Pradeep at 2024-10-21T19:33:26+02:00 Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources. See Bug 1357997 for partial uplift. Also: Bug 28051 - Use our Orbot for proxying our connections Bug 31144 - ESR68 Network Code Review - - - - - 5e294aac by Matthew Finkel at 2024-10-21T19:33:26+02:00 Bug 25741: TBA: Disable GeckoNetworkManager The browser should not need information related to the network interface or network state, tor should take care of that. - - - - - 9b49c86a by Kathy Brade at 2024-10-21T19:33:26+02:00 Bug 14631: Improve profile access error messages. Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system". To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts. - - - - - 78cfcd83 by Pier Angelo Vendrame at 2024-10-21T19:33:26+02:00 Bug 40807: Added QRCode.js to toolkit/modules - - - - - a9706922 by Richard Pospesel at 2024-10-21T19:33:27+02:00 Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present: - Setting built-in bridges - Requesting bridges from BridgeDB via moat - Using user-provided bridges - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies - Setting firewall ports - Viewing and Copying Tor's logs - The Networking Settings in General preferences has been removed Bug 40774: Update about:preferences page to match new UI designs - - - - - ebf6231b by Richard Pospesel at 2024-10-21T19:33:27+02:00 Bug 27476: Implement about:torconnect captive portal within Tor Browser - implements new about:torconnect page as tor-launcher replacement - adds new torconnect component to browser - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module - adds warning/error box to about:preferences#tor when not connected to tor Bug 40773: Update the about:torconnect frontend page to match additional UI flows. Bug 41608: Add a toolbar status button and a urlbar "Connect" button. - - - - - 013dff6d by Pier Angelo Vendrame at 2024-10-21T19:33:27+02:00 Temporary changes to about:torconnect for Android. We are planning of tempoorarily using about:torconnect on Android, until the native UX is ready. - - - - - 535147ff by Henry Wilkes at 2024-10-21T19:33:27+02:00 Bug 7494: Create local home page for TBB. Bug 41333: Update about:tor to new design. Including: + make the favicon match the branding icon. + make the location bar show a search icon. - - - - - 2e69e97a by Arthur Edelstein at 2024-10-21T19:33:28+02:00 Bug 12620: TorBrowser regression tests Regression tests for Bug #2950: Make Permissions Manager memory-only Regression tests for TB4: Tor Browser's Firefox preference overrides. Note: many more functional tests could be made here Regression tests for #2874: Block Components.interfaces from content Bug 18923: Add a script to run all Tor Browser specific tests Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt. - - - - - fde4bc1f by Pier Angelo Vendrame at 2024-10-21T19:33:28+02:00 Bug 41668: Tweaks to the Base Browser updater for Tor Browser This commit was once part of "Bug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit. - - - - - 7a88ba4a by Kathy Brade at 2024-10-21T19:33:28+02:00 Bug 12647: Support symlinks in the updater. - - - - - a94e77a6 by Kathy Brade at 2024-10-21T19:33:28+02:00 Bug 19121: reinstate the update.xml hash check This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122. Revert most changes from Mozilla Bug 862173 "don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)." We kept the addition to the AppConstants API in case other JS code references it in the future. - - - - - 3d6346cb by Pier Angelo Vendrame at 2024-10-21T19:33:28+02:00 fixup! Bug 19121: reinstate the update.xml hash check Revert "Bug 19121: reinstate the update.xml hash check" This reverts commit 39a712fbaf18cb64b6dc601c71bac82718de1a01. - - - - - 99f89be8 by Kathy Brade at 2024-10-21T19:33:29+02:00 Bug 16940: After update, load local change notes. Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release). Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts. Also fix bug 29440. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor. - - - - - 21f2261a by Georg Koppen at 2024-10-21T19:33:29+02:00 Bug 32658: Create a new MAR signing key It's time for our rotation again: Move the backup key in the front position and add a new backup key. Bug 33803: Move our primary nightly MAR signing key to tor-browser Bug 33803: Add a secondary nightly MAR signing key - - - - - e9fc02b8 by Mike Perry at 2024-10-21T19:33:29+02:00 Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed. Also: Bug 16322: Update DuckDuckGo search engine We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to bug 1061736 where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well. Also: This fixes bug 20809: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly. Also fixes bug 29798 by making sure we only specify the Google search engine we actually ship an .xml file for. Also regression tests. squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40494: Update Startpage search provider squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing Bug 40438: Add Blockchair as a search engine Bug 33342: Avoid disconnect search addon error after removal. We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore. - - - - - 8f445b90 by Alex Catarineu at 2024-10-21T19:33:29+02:00 Bug 40073: Disable remote Public Suffix List fetching In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want. - - - - - beadda14 by Henry Wilkes at 2024-10-21T19:33:29+02:00 Bug 41906: Hide DNS over HTTPS preferences. - - - - - 2aca0083 by Richard Pospesel at 2024-10-21T19:33:30+02:00 Bug 23247: Communicating security expectations for .onion Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine. Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services: - HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure - HTTP Onion Service pages would be marked as unencrypted in the Page Info screen - Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content. Strings for Onion Service Page Info page are pulled from Torbutton's localization strings. - - - - - 4c59607a by Kathy Brade at 2024-10-21T19:33:30+02:00 Bug 30237: Add v3 onion services client authentication prompt When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key. If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page. If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt. Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt. Add support for onion services strings to the TorStrings module. Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of bug 30025. Also fixes bug 19757: Add a "Remember this key" checkbox to the client auth prompt. Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk. Also fixes bug 19251: use enhanced error pages for onion service errors. - - - - - e95970c6 by Alex Catarineu at 2024-10-21T19:33:30+02:00 Bug 21952: Implement Onion-Location Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar. - - - - - 2b4a33c6 by Pier Angelo Vendrame at 2024-10-21T19:33:30+02:00 Bug 40458: Implement .tor.onion aliases We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates. - - - - - 82fa2a9b by Pier Angelo Vendrame at 2024-10-21T19:33:31+02:00 Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation. - - - - - 6688758a by Pier Angelo Vendrame at 2024-10-21T19:33:31+02:00 Bug 41435: Add a Tor Browser migration function For now this function only deletes old language packs for which we are already packaging the strings with the application. - - - - - b396dcae by Henry Wilkes at 2024-10-21T19:33:31+02:00 Bug 42110: Add TorUIUtils module for common tor component methods. - - - - - 8fc341e0 by Dan Ballard at 2024-10-21T19:33:31+02:00 Bug 40701: Add security warning when downloading a file Shown in the downloads panel, about:downloads and places.xhtml. - - - - - 9380256b by Henry Wilkes at 2024-10-21T19:33:31+02:00 Bug 41736: Customize toolbar for tor-browser. - - - - - 07f8fcfb by hackademix at 2024-10-21T19:33:32+02:00 Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key - - - - - ec3d77b5 by Henry Wilkes at 2024-10-21T19:33:32+02:00 Customize moz-toggle for tor-browser. - - - - - 5eab3226 by Richard Pospesel at 2024-10-21T19:33:32+02:00 Bug 41822: Unconditionally disable default browser UX in about:preferences - - - - - 4ad5f76a by Cecylia Bocovich at 2024-10-21T19:33:32+02:00 Temporary commit: manually place generated wasm files These files are built reproducibly using tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_re… We're manually adding them here while working on the interface, but eventually these should be placed in the right location using tor-browser-build. - - - - - 320c29f3 by Henry Wilkes at 2024-10-21T19:33:32+02:00 TEMPORARY: Copy torbrowser_strings.xml to the 13.5 branch. NOTE: Only needed for the `tor-browser` `13.5` branches. Bug 42480: Make sure the torbrowser_strings.xml file is in the 13.5 branch for the tor-browser `update-translations` CI. The file should otherwise remain unused for the 13.5 branch. File was copied from https://gitlab.torproject.org/tpo/translation/-/blob/f27eda6d10a4585a8402c5… - - - - - 78175ba2 by Henry Wilkes at 2024-10-21T19:33:33+02:00 Bug 43125: Extend the 13.5 EOL expiry date for tor-browser. - - - - - cae4eb5d by Henry Wilkes at 2024-10-21T19:33:33+02:00 Bug 43098: Year End Campaign 2024. Implements YEC 2024 for about:tor. - - - - - 18d48e81 by Henry Wilkes at 2024-10-21T19:33:33+02:00 fixup! Bug 43098: Year End Campaign 2024. Bug 43149: Use special YEC 2024 donate url. - - - - - 30 changed files: - .eslintignore - .gitignore - + .gitlab-ci.yml - + .gitlab/ci/update-translations.yml - + .gitlab/issue_templates/Backport Android Security Fixes.md - + .gitlab/issue_templates/Emergency Security Issue.md - + .gitlab/issue_templates/Rebase Browser - Alpha.md - + .gitlab/issue_templates/Rebase Browser - Stable.md - + .gitlab/issue_templates/bug.md - + .gitlab/merge_request_templates/default.md - + README.md - − README.txt - accessible/android/SessionAccessibility.cpp - accessible/android/SessionAccessibility.h - accessible/ipc/DocAccessibleParent.cpp - accessible/ipc/DocAccessibleParent.h - accessible/ipc/moz.build - + browser/actors/AboutTBUpdateChild.jsm - + browser/actors/AboutTBUpdateParent.jsm - browser/actors/BrowserTabChild.sys.mjs - + browser/actors/CryptoSafetyChild.jsm - + browser/actors/CryptoSafetyParent.jsm - − browser/actors/RFPHelperChild.sys.mjs - − browser/actors/RFPHelperParent.sys.mjs - browser/actors/moz.build - browser/app/Makefile.in - browser/app/macbuild/Contents/Info.plist.in - browser/app/macbuild/Contents/MacOS-files.in - browser/app/moz.build - browser/app/permissions The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/359ca1… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/359ca1… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser] Pushed new branch tor-browser-128.4.0esr-14.0-1
by Pier Angelo Vendrame (＠pierov) 22 Oct '24

22 Oct '24

Pier Angelo Vendrame pushed new branch tor-browser-128.4.0esr-14.0-1 at The Tor Project / Applications / Tor Browser -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/tree/tor-brows… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.3.0esr-14.0-1] fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 22 Oct '24

22 Oct '24

Pier Angelo Vendrame pushed to branch mullvad-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: b9153ddf by Beatriz Rizental at 2024-10-22T10:35:30+02:00 fixup! Add CI for Base Browser Run file-whitespace linter for .java file changes. - - - - - 1 changed file: - .gitlab/ci/lint.yml Changes: ===================================== .gitlab/ci/lint.yml ===================================== @@ -264,6 +264,7 @@ file-whitespace: - '**/*.rst' - '**/*.webidl' - '**/*.xhtml' + - '**/*.java' - 'tools/lint/file-whitespace.yml' # Run job whenever a commit is merged to a protected branch - if: $CI_COMMIT_REF_PROTECTED == 'true' View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/b91… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/b91… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.3.0esr-14.0-1] 2 commits: fixup! Bug 42716: Disable unwanted about: pages
by Pier Angelo Vendrame (＠pierov) 22 Oct '24

22 Oct '24

Pier Angelo Vendrame pushed to branch base-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: cf87b58a by Beatriz Rizental at 2024-10-22T10:34:01+02:00 fixup! Bug 42716: Disable unwanted about: pages - - - - - 6b8bd60d by Beatriz Rizental at 2024-10-22T10:34:13+02:00 fixup! Add CI for Base Browser Run file-whitespace linter for .java file changes. - - - - - 2 changed files: - .gitlab/ci/lint.yml - docshell/base/nsAboutRedirector.cpp Changes: ===================================== .gitlab/ci/lint.yml ===================================== @@ -264,6 +264,7 @@ file-whitespace: - '**/*.rst' - '**/*.webidl' - '**/*.xhtml' + - '**/*.java' - 'tools/lint/file-whitespace.yml' # Run job whenever a commit is merged to a protected branch - if: $CI_COMMIT_REF_PROTECTED == 'true' ===================================== docshell/base/nsAboutRedirector.cpp ===================================== @@ -193,7 +193,7 @@ static const RedirEntry kRedirMap[] = { # endif {"telemetry", "chrome://global/content/aboutTelemetry.xhtml", nsIAboutModule::ALLOW_SCRIPT | nsIAboutModule::IS_SECURE_CHROME_UI}, -#endif +#endif {"translations", "chrome://global/content/translations/translations.html", nsIAboutModule::ALLOW_SCRIPT | nsIAboutModule::URI_SAFE_FOR_UNTRUSTED_CONTENT | View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/f06a46… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/f06a46… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.3.0esr-14.0-1] 4 commits: fixup! Bug 42660: Disable ProxySelector.openConnectionWithProxy and NOPify...
by Pier Angelo Vendrame (＠pierov) 22 Oct '24

22 Oct '24

Pier Angelo Vendrame pushed to branch tor-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: aad5e9c7 by Beatriz Rizental at 2024-10-22T10:15:38+02:00 fixup! Bug 42660: Disable ProxySelector.openConnectionWithProxy and NOPify CrashReporter.sendCrashReport - - - - - b27ebe80 by Beatriz Rizental at 2024-10-22T10:16:06+02:00 fixup! [android] Modify add-on support - - - - - 7d9e9856 by Beatriz Rizental at 2024-10-22T10:20:38+02:00 fixup! Add CI for Base Browser Run file-whitespace linter for .java file changes. - - - - - 638726b3 by Beatriz Rizental at 2024-10-22T10:24:10+02:00 fixup! Bug 42716: Disable unwanted about: pages - - - - - 5 changed files: - .gitlab/ci/lint.yml - docshell/base/nsAboutRedirector.cpp - mobile/android/geckoview/src/main/java/org/mozilla/geckoview/CrashReporter.java - toolkit/mozapps/extensions/AddonManager.sys.mjs - toolkit/mozapps/extensions/internal/XPIInstall.sys.mjs Changes: ===================================== .gitlab/ci/lint.yml ===================================== @@ -264,6 +264,7 @@ file-whitespace: - '**/*.rst' - '**/*.webidl' - '**/*.xhtml' + - '**/*.java' - 'tools/lint/file-whitespace.yml' # Run job whenever a commit is merged to a protected branch - if: $CI_COMMIT_REF_PROTECTED == 'true' ===================================== docshell/base/nsAboutRedirector.cpp ===================================== @@ -193,7 +193,7 @@ static const RedirEntry kRedirMap[] = { # endif {"telemetry", "chrome://global/content/aboutTelemetry.xhtml", nsIAboutModule::ALLOW_SCRIPT | nsIAboutModule::IS_SECURE_CHROME_UI}, -#endif +#endif {"torconnect", "chrome://global/content/torconnect/aboutTorConnect.html", nsIAboutModule::URI_SAFE_FOR_UNTRUSTED_CONTENT | nsIAboutModule::URI_CAN_LOAD_IN_CHILD | nsIAboutModule::ALLOW_SCRIPT | ===================================== mobile/android/geckoview/src/main/java/org/mozilla/geckoview/CrashReporter.java ===================================== @@ -173,7 +173,7 @@ public class CrashReporter { if (true) { return GeckoResult.fromValue("0"); } - + Log.d(LOGTAG, "Sending crash report: " + minidumpFile.getPath()); HttpURLConnection conn = null; ===================================== toolkit/mozapps/extensions/AddonManager.sys.mjs ===================================== @@ -2541,7 +2541,8 @@ var AddonManagerInternal = { if (installAllowed) { if (AppConstants.platform == "android") { aInstall.cancel(); - return this.installGeckoViewWebExtension(aInstall.sourceURI); + this.installGeckoViewWebExtension(aInstall.sourceURI); + return; } startInstall("AMO"); } else if (installPerm === Ci.nsIPermissionManager.DENY_ACTION) { ===================================== toolkit/mozapps/extensions/internal/XPIInstall.sys.mjs ===================================== @@ -4476,7 +4476,10 @@ export var XPIInstall = { } // tor-browser#43132: short-circuit permission check on Android scriptless install from AMO - if (AppConstants.platform == "android" && uri.prePath == "https://addons.mozilla.org") { + if ( + AppConstants.platform == "android" && + uri.prePath == "https://addons.mozilla.org" + ) { return true; } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/ff517b… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/ff517b… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.3.0esr-14.0-1] fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 22 Oct '24

22 Oct '24

Pier Angelo Vendrame pushed to branch base-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: f06a4621 by Beatriz Rizental at 2024-10-22T09:51:04+02:00 fixup! Add CI for Base Browser - - - - - 1 changed file: - .gitlab/ci/lint.yml Changes: ===================================== .gitlab/ci/lint.yml ===================================== @@ -23,7 +23,7 @@ - git fetch --depth 500 local - git remote add origin "$CI_REPOSITORY_URL" - git fetch origin ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} - - git checkout ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} + - git checkout origin/${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} eslint: extends: .base View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f06a462… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/f06a462… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.3.0esr-14.0-1] fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 22 Oct '24

22 Oct '24

Pier Angelo Vendrame pushed to branch mullvad-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 2c841ad2 by Beatriz Rizental at 2024-10-22T09:51:21+02:00 fixup! Add CI for Base Browser - - - - - 1 changed file: - .gitlab/ci/lint.yml Changes: ===================================== .gitlab/ci/lint.yml ===================================== @@ -23,7 +23,7 @@ - git fetch --depth 500 local - git remote add origin "$CI_REPOSITORY_URL" - git fetch origin ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} - - git checkout ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} + - git checkout origin/${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} eslint: extends: .base View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/2c8… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/2c8… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.3.0esr-14.0-1] fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 22 Oct '24

22 Oct '24

Pier Angelo Vendrame pushed to branch tor-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: ff517bad by Beatriz Rizental at 2024-10-22T09:46:10+02:00 fixup! Add CI for Base Browser - - - - - 1 changed file: - .gitlab/ci/lint.yml Changes: ===================================== .gitlab/ci/lint.yml ===================================== @@ -23,7 +23,7 @@ - git fetch --depth 500 local - git remote add origin "$CI_REPOSITORY_URL" - git fetch origin ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} - - git checkout ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} + - git checkout origin/${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} eslint: extends: .base View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/ff517ba… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/ff517ba… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.3.0esr-14.0-1] 2 commits: fixup! Add CI for Base Browser
by Pier Angelo Vendrame (＠pierov) 22 Oct '24

22 Oct '24

Pier Angelo Vendrame pushed to branch mullvad-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 1b763c7e by Beatriz Rizental at 2024-10-22T09:41:23+02:00 fixup! Add CI for Base Browser Use tb-build dedicated runners for lint CI. - - - - - eefd74b3 by Beatriz Rizental at 2024-10-22T09:41:24+02:00 fixup! Add CI for Base Browser Re-enable lint jobs for default branches - - - - - 3 changed files: - .gitlab-ci.yml - .gitlab/ci/lint.yml - − .gitlab/ci/setup.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -1,10 +1,9 @@ stages: - - setup - lint variables: IMAGE_PATH: containers.torproject.org/tpo/applications/tor-browser/base:latest + LOCAL_REPO_PATH: /srv/apps-repos/${CI_PROJECT_NAME}.git include: - - local: '.gitlab/ci/setup.yml' - local: '.gitlab/ci/lint.yml' ===================================== .gitlab/ci/lint.yml ===================================== @@ -2,13 +2,9 @@ stage: lint image: $IMAGE_PATH interruptible: true - needs: - - job: setup-env - artifacts: true - - job: create-bundle - artifacts: true variables: MOZBUILD_STATE_PATH: "$CI_PROJECT_DIR/.cache/mozbuild" + # A copy of the repository already is available in the runner. GIT_STRATEGY: "none" cache: paths: @@ -18,26 +14,21 @@ when: 'always' # Share the cache throughout all pipelines running for a given branch key: $CI_COMMIT_REF_SLUG + tags: + # Run these jobs in the browser dedicated runners. + - firefox before_script: - # DEBUG: Are all artifacts here? - - ls -a - - mkdir app && cd app - # Initialize a fresh git repo - git init - # Add app.bundle as the remote. All operations that communicate with the remote will be local. - - git remote add origin ../app.bundle - # shallow.txt contains the SHA of the base commit of the bundle. - # The bundle is shallow, therefore it's base commit will not have a parent. - # Adding the SHA of the base commit to .git/shallow tells git that it doesn't need - # to crash when it realizes said base commit doesn't have a parent. - - cp ../shallow.txt .git/shallow - # Finally, unpack the bundle. Time it for debugging purposes. - - time git pull origin $BRANCH_NAME + - git remote add local "$LOCAL_REPO_PATH" + - git fetch --depth 500 local + - git remote add origin "$CI_REPOSITORY_URL" + - git fetch origin ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} + - git checkout ${CI_COMMIT_BRANCH:-$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME} eslint: extends: .base script: - - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l eslint + - .gitlab/ci/scripts/helpers.py --get-changed-files | xargs -d '\n' ./mach lint -l eslint rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -61,12 +52,12 @@ eslint: - 'tools/lint/eslint/eslint-plugin-mozilla/**' - 'tools/lint/eslint/eslint-plugin-spidermonkey-js/**' # Run job whenever a commit is merged to a protected branch - # - if: $CI_COMMIT_REF_PROTECTED == 'true' + - if: $CI_COMMIT_REF_PROTECTED == 'true' stylelint: extends: .base script: - - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l stylelint + - .gitlab/ci/scripts/helpers.py --get-changed-files | xargs -d '\n' ./mach lint -l stylelint rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -79,12 +70,12 @@ stylelint: - '**/.stylelintignore' - '**/*stylelintrc*' # Run job whenever a commit is merged to a protected branch - # - if: $CI_COMMIT_REF_PROTECTED == 'true' + - if: $CI_COMMIT_REF_PROTECTED == 'true' py-black: extends: .base script: - - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l black + - .gitlab/ci/scripts/helpers.py --get-changed-files | xargs -d '\n' ./mach lint -l black rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -98,12 +89,12 @@ py-black: - 'pyproject.toml' - 'tools/lint/black.yml' # Run job whenever a commit is merged to a protected branch - # - if: $CI_COMMIT_REF_PROTECTED == 'true' + - if: $CI_COMMIT_REF_PROTECTED == 'true' py-ruff: extends: .base script: - - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l ruff + - .gitlab/ci/scripts/helpers.py --get-changed-files | xargs -d '\n' ./mach lint -l ruff rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -117,12 +108,12 @@ py-ruff: - 'tools/lint/python/ruff.py' - 'tools/lint/python/ruff_requirements.txt' # Run job whenever a commit is merged to a protected branch - # - if: $CI_COMMIT_REF_PROTECTED == 'true' + - if: $CI_COMMIT_REF_PROTECTED == 'true' yaml: extends: .base script: - - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l yaml + - .gitlab/ci/scripts/helpers.py --get-changed-files | xargs -d '\n' ./mach lint -l yaml rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -132,12 +123,12 @@ yaml: - '**/*.yaml' - '**/.ymllint' # Run job whenever a commit is merged to a protected branch - # - if: $CI_COMMIT_REF_PROTECTED == 'true' + - if: $CI_COMMIT_REF_PROTECTED == 'true' shellcheck: extends: .base script: - - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l shellcheck + - .gitlab/ci/scripts/helpers.py --get-changed-files | xargs -d '\n' ./mach lint -l shellcheck rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -146,13 +137,13 @@ shellcheck: - '**/*.sh' - 'tools/lint/shellcheck.yml' # Run job whenever a commit is merged to a protected branch - # - if: $CI_COMMIT_REF_PROTECTED == 'true' + - if: $CI_COMMIT_REF_PROTECTED == 'true' clang-format: extends: .base script: - ./mach configure --without-wasm-sandboxed-libraries --with-base-browser-version=0.0.0 - - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l clang-format + - .gitlab/ci/scripts/helpers.py --get-changed-files | xargs -d '\n' ./mach lint -l clang-format rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -166,12 +157,12 @@ clang-format: - '**/*.mm' - 'tools/lint/clang-format.yml' # Run job whenever a commit is merged to a protected branch - # - if: $CI_COMMIT_REF_PROTECTED == 'true' + - if: $CI_COMMIT_REF_PROTECTED == 'true' rustfmt: extends: .base script: - - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l rustfmt + - .gitlab/ci/scripts/helpers.py --get-changed-files | xargs -d '\n' ./mach lint -l rustfmt rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -180,12 +171,12 @@ rustfmt: - '**/*.rs' - 'tools/lint/rustfmt.yml' # Run job whenever a commit is merged to a protected branch - # - if: $CI_COMMIT_REF_PROTECTED == 'true' + - if: $CI_COMMIT_REF_PROTECTED == 'true' fluent-lint: extends: .base script: - - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l fluent-lint + - .gitlab/ci/scripts/helpers.py --get-changed-files | xargs -d '\n' ./mach lint -l fluent-lint rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -195,12 +186,12 @@ fluent-lint: - 'tools/lint/fluent-lint.yml' - 'tools/lint/fluent-lint/exclusions.yml' # Run job whenever a commit is merged to a protected branch - # - if: $CI_COMMIT_REF_PROTECTED == 'true' + - if: $CI_COMMIT_REF_PROTECTED == 'true' localization: extends: .base script: - - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l l10n + - .gitlab/ci/scripts/helpers.py --get-changed-files | xargs -d '\n' ./mach lint -l l10n rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -212,12 +203,12 @@ localization: - 'third_party/python/fluent/**' - 'tools/lint/l10n.yml' # Run job whenever a commit is merged to a protected branch - # - if: $CI_COMMIT_REF_PROTECTED == 'true' + - if: $CI_COMMIT_REF_PROTECTED == 'true' mingw-capitalization: extends: .base script: - - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l mingw-capitalization + - .gitlab/ci/scripts/helpers.py --get-changed-files | xargs -d '\n' ./mach lint -l mingw-capitalization rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -229,12 +220,12 @@ mingw-capitalization: - '**/*.h' - 'tools/lint/mingw-capitalization.yml' # Run job whenever a commit is merged to a protected branch - # - if: $CI_COMMIT_REF_PROTECTED == 'true' + - if: $CI_COMMIT_REF_PROTECTED == 'true' mscom-init: extends: .base script: - - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l mscom-init + - .gitlab/ci/scripts/helpers.py --get-changed-files | xargs -d '\n' ./mach lint -l mscom-init rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -246,12 +237,12 @@ mscom-init: - '**/*.h' - 'tools/lint/mscom-init.yml' # Run job whenever a commit is merged to a protected branch - # - if: $CI_COMMIT_REF_PROTECTED == 'true' + - if: $CI_COMMIT_REF_PROTECTED == 'true' file-whitespace: extends: .base script: - - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l file-whitespace + - .gitlab/ci/scripts/helpers.py --get-changed-files | xargs -d '\n' ./mach lint -l file-whitespace rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -275,12 +266,12 @@ file-whitespace: - '**/*.xhtml' - 'tools/lint/file-whitespace.yml' # Run job whenever a commit is merged to a protected branch - # - if: $CI_COMMIT_REF_PROTECTED == 'true' + - if: $CI_COMMIT_REF_PROTECTED == 'true' test-manifest: extends: .base script: - - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l test-manifest-alpha -l test-manifest-disable -l test-manifest-skip-if + - .gitlab/ci/scripts/helpers.py --get-changed-files | xargs -d '\n' ./mach lint -l test-manifest-alpha -l test-manifest-disable -l test-manifest-skip-if rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -290,12 +281,12 @@ test-manifest: - 'python/mozlint/**' - 'tools/lint/**' # Run job whenever a commit is merged to a protected branch - # - if: $CI_COMMIT_REF_PROTECTED == 'true' + - if: $CI_COMMIT_REF_PROTECTED == 'true' trojan-source: extends: .base script: - - cat ../changedfiles.txt | xargs -d '\n' ./mach lint -l trojan-source + - .gitlab/ci/scripts/helpers.py --get-changed-files | xargs -d '\n' ./mach lint -l trojan-source rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' changes: @@ -309,4 +300,4 @@ trojan-source: - '**/*.rs' - 'tools/lint/trojan-source.yml' # Run job whenever a commit is merged to a protected branch - # - if: $CI_COMMIT_REF_PROTECTED == 'true' + - if: $CI_COMMIT_REF_PROTECTED == 'true' ===================================== .gitlab/ci/setup.yml deleted ===================================== @@ -1,56 +0,0 @@ -setup-env: - stage: setup - interruptible: true - variables: - GIT_STRATEGY: "none" - rules: - - if: $CI_PIPELINE_SOURCE == 'merge_request_event' || $CI_COMMIT_REF_PROTECTED == 'true' - script: - - | - if [ -n "$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME" ]; then - echo "BRANCH_NAME=$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME" > build.env - else - echo "BRANCH_NAME=$CI_COMMIT_REF_NAME" > build.env - fi - artifacts: - reports: - dotenv: - - build.env - -create-bundle: - stage: setup - # TODO: Find a better suited image, this one just has git. - image: python - needs: - - job: setup-env - artifacts: true - rules: - - if: $CI_PIPELINE_SOURCE == 'merge_request_event' || $CI_COMMIT_REF_PROTECTED == 'true' - variables: - GIT_DEPTH: "1" - interruptible: true - script: - # DEBUG: Check repository status. - - git status - # DEBUG: Check branches in repository - - git branch - # Force switch to a named branch. We force it in case there is already - # a branch with the same name from previous runs. - - git switch -C $BRANCH_NAME - # Create a git bundle -- this will generate the app.bundle file, - # which can be used as a git remote for offline fetching. - - git bundle create app.bundle $BRANCH_NAME - # Retain the SHA of the base of this shallow repository. - - cat .git/shallow > shallow.txt - # DEBUG: Check sizes. - - du -sh .git - - du -sh app.bundle - # Since this is the only job we have access to the Gitlab remote, - # let's get a list of changed files to use in the next jobs. - - .gitlab/ci/scripts/helpers.py --get-changed-files > changedfiles.txt - artifacts: - paths: - - app.bundle - - shallow.txt - - changedfiles.txt - expire_in: 1 hour View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/e8… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/e8… You're receiving this email because of your account on gitlab.torproject.org.

1 0