- tor-commits - lists.torproject.org

[arm/master] Minor readability improvements.
by atagar＠torproject.org 04 Jun '11

04 Jun '11

commit 69de93464909606a930451a626fbe54fc50ca387 Author: Kamran Riaz Khan <krkhan(a)inspirated.com> Date: Wed Jun 1 16:13:26 2011 +0500 Minor readability improvements. --- src/cli/menu.py | 29 +++++++++++++++++------------ 1 files changed, 17 insertions(+), 12 deletions(-) diff --git a/src/cli/menu.py b/src/cli/menu.py index 9aadf8d..da45309 100644 --- a/src/cli/menu.py +++ b/src/cli/menu.py @@ -119,7 +119,7 @@ class Menu(): elif key == curses.KEY_LEFT: self._moveTopLevelLeft(width) elif key == curses.KEY_DOWN: - self._showNLevel() + self._cascadeNLevel() break elif key == 27: break @@ -130,6 +130,14 @@ class Menu(): finally: popups.finalize() + def _appendLevel(self): + self._first.append(0) + self._selection.append(0) + + def _removeLevel(self): + self._first.pop() + self._selection.pop() + def _getCurrentTopLevelItem(self): index = self._first[TOPLEVEL] + self._selection[TOPLEVEL] return self._rootItem.getChildren()[index] @@ -233,15 +241,14 @@ class Menu(): popup.addch(top, left, curses.ACS_VLINE) left = left + 1 - def _showNLevel(self): - self._first.append(0) - self._selection.append(0) - - parent = self._getCurrentItem(level=PARENTLEVEL) + def _cascadeNLevel(self): + parent = self._getCurrentItem() if parent.isLeaf(): return + self._appendLevel() + labelwidth = self._calculateNLevelWidths(level=PARENTLEVEL) printable = self._calculateNLevelHeights(level=PARENTLEVEL) @@ -271,16 +278,14 @@ class Menu(): elif key == curses.KEY_UP: self._moveNLevelUp(height) elif key == curses.KEY_RIGHT: - self._showNLevel() + self._cascadeNLevel() break elif key == 27: - self._first.pop() - self._selection.pop() + self._removeLevel() break elif uiTools.isSelectionKey(key): self._handleEvent() - self._first.pop() - self._selection.pop() + self._removeLevel() break finally: @@ -345,7 +350,7 @@ class Menu(): if item.isLeaf(): item.select() else: - self._showNLevel() + self._cascadeNLevel() def _callbackDefault(self, item): log.log(log.NOTICE, "%s selected" % item.getLabel())

1 0

[arm/master] Next top-level item is dropped down in case right/left arrow keys
by atagar＠torproject.org 04 Jun '11

04 Jun '11

commit 5ffd3b0506cc6acb618456ae276dd0238c1e3936 Author: Kamran Riaz Khan <krkhan(a)inspirated.com> Date: Wed Jun 1 17:06:27 2011 +0500 Next top-level item is dropped down in case right/left arrow keys are pressed on leaf submenus. In order to let the controller redraw before next top-level item is dropped down, "menu keys" are calculated and returned back to the controller. The controller overrides its key so that menu is redrawn, redraws all other panels and sends back the "menu keys" to the new menu instance. This maintains the illusion of top-level drop-down moving right/left while screen is cleared and redrawn once in between. --- src/cli/controller.py | 6 +++++- src/cli/menu.py | 36 +++++++++++++++++++++++++++++++----- 2 files changed, 36 insertions(+), 6 deletions(-) diff --git a/src/cli/controller.py b/src/cli/controller.py index 25c3051..d073312 100644 --- a/src/cli/controller.py +++ b/src/cli/controller.py @@ -477,6 +477,8 @@ def drawTorMonitor(stdscr, startTime): # main draw loop overrideKey = None # uses this rather than waiting on user input isUnresponsive = False # flag for heartbeat responsiveness check + + menuKeys = [] while True: displayPanels = control.getDisplayPanels() @@ -514,7 +516,9 @@ def drawTorMonitor(stdscr, startTime): control.setPaused(not control.isPaused()) elif key == ord('m') or key == ord('M'): menu = cli.menu.Menu() - menu.showMenu() + menuKeys = menu.showMenu(keys=menuKeys) + if menuKeys != []: + overrideKey = ord('m') elif key == ord('q') or key == ord('Q'): # provides prompt to confirm that arm should exit if CONFIG["features.confirmQuit"]: diff --git a/src/cli/menu.py b/src/cli/menu.py index da45309..29b6f82 100644 --- a/src/cli/menu.py +++ b/src/cli/menu.py @@ -99,7 +99,10 @@ class Menu(): else: self._rootItem = DEFAULT_ROOT - def showMenu(self): + def showMenu(self, keys=[]): + keys.reverse() + returnkeys = [] + popup, width, height = popups.init(height=3) if popup: try: @@ -112,14 +115,18 @@ class Menu(): popup.win.refresh() control = cli.controller.getController() - key = control.getScreen().getch() + + if keys == []: + key = control.getScreen().getch() + else: + key = keys.pop() if key == curses.KEY_RIGHT: self._moveTopLevelRight(width) elif key == curses.KEY_LEFT: self._moveTopLevelLeft(width) elif key == curses.KEY_DOWN: - self._cascadeNLevel() + cascaded, returnkeys = self._cascadeNLevel() break elif key == 27: break @@ -130,6 +137,8 @@ class Menu(): finally: popups.finalize() + return returnkeys + def _appendLevel(self): self._first.append(0) self._selection.append(0) @@ -245,7 +254,7 @@ class Menu(): parent = self._getCurrentItem() if parent.isLeaf(): - return + return (False, []) self._appendLevel() @@ -261,6 +270,7 @@ class Menu(): self._moveNLevelDown(height) if popup.win: + returnkeys = [] try: while True: popup.win.erase() @@ -278,7 +288,19 @@ class Menu(): elif key == curses.KEY_UP: self._moveNLevelUp(height) elif key == curses.KEY_RIGHT: - self._cascadeNLevel() + cascaded, returnkeys = self._cascadeNLevel() + if cascaded == False: + index = self._first[TOPLEVEL] + self._selection[TOPLEVEL] + 1 + for i in range(index): + returnkeys.append(curses.KEY_RIGHT) + returnkeys.append(curses.KEY_DOWN) + break + elif key == curses.KEY_LEFT: + index = self._first[TOPLEVEL] + self._selection[TOPLEVEL] - 1 + index = index % self._rootItem.getChildrenCount() + for i in range(index): + returnkeys.append(curses.KEY_RIGHT) + returnkeys.append(curses.KEY_DOWN) break elif key == 27: self._removeLevel() @@ -291,6 +313,10 @@ class Menu(): finally: popups.finalize() + return (True, returnkeys) + + return (False, []) + def _drawNLevel(self, popup, width, height): printable = self._calculateNLevelHeights(level=PARENTLEVEL) parent = self._getCurrentItem(level=PARENTLEVEL)

1 0

[arm/master] Controller page isn't changed in case the required panel isn't currently
by atagar＠torproject.org 04 Jun '11

04 Jun '11

commit a2937170af8f17ff048cccc1093776f174467352 Author: Kamran Riaz Khan <krkhan(a)inspirated.com> Date: Wed Jun 1 17:12:35 2011 +0500 Controller page isn't changed in case the required panel isn't currently being displayed. --- src/cli/menu.py | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/src/cli/menu.py b/src/cli/menu.py index 29b6f82..beceb01 100644 --- a/src/cli/menu.py +++ b/src/cli/menu.py @@ -407,8 +407,6 @@ class Menu(): return False def _callbackSet(self, panel, attr, value, key=None): - self._callbackView(panel) - control = cli.controller.getController() panel = control.getPanel(panel) @@ -427,8 +425,6 @@ class Menu(): break def _callbackPressKey(self, panel, key): - self._callbackView(panel) - control = cli.controller.getController() panel = control.getPanel(panel) panel.handleKey(key)

1 0

[arm/master] fix: installation wasn't adding uninstall script
by atagar＠torproject.org 04 Jun '11

04 Jun '11

commit 8b8b4230ce305d8aadc4eebc36b4bd9506bd096f Author: Damian Johnson <atagar(a)torproject.org> Date: Thu May 26 07:02:37 2011 -0700 fix: installation wasn't adding uninstall script The uninstall wasn't among the set of non-python resources copied into /usr/share/arm during installation. --- setup.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/setup.py b/setup.py index cb0069f..cdda907 100644 --- a/setup.py +++ b/setup.py @@ -90,7 +90,7 @@ setup(name='arm', data_files=[("/usr/bin", ["arm"]), ("/usr/share/man/man1", [manFilename]), (docPath, ["armrc.sample"]), - ("/usr/share/arm", ["src/settings.cfg"])], + ("/usr/share/arm", ["src/settings.cfg", "src/uninstall"])], ) # Cleans up the temporary compressed man page.

1 0

r24803: {website} match the vidalia 0.3.0 filename to the tarball on the serve (website/trunk/projects/en)
by Andrew Lewman 04 Jun '11

04 Jun '11

Author: phobos Date: 2011-06-04 11:41:40 +0000 (Sat, 04 Jun 2011) New Revision: 24803 Modified: website/trunk/projects/en/vidalia.wml Log: match the vidalia 0.3.0 filename to the tarball on the server. Modified: website/trunk/projects/en/vidalia.wml =================================================================== --- website/trunk/projects/en/vidalia.wml 2011-06-04 11:40:40 UTC (rev 24802) +++ website/trunk/projects/en/vidalia.wml 2011-06-04 11:41:40 UTC (rev 24803) @@ -91,7 +91,7 @@ (<a href="https://archive.torproject.org/tor-package-archive/technology-preview/vidal…">sig</a>) </li> <li> - <a href="../dist/vidalia/vidalia-0.3.0.tar.gz">Source Tarball</a> + <a href="../dist/vidalia/vidalia-0.3.0-alpha.tar.gz">Source Tarball</a> (<a href="../dist/vidalia/vidalia-0.3.0-alpha.tar.gz.asc">sig</a>) </li> </ul>

1 0

r24802: {website} fix a grammar mistake. (website/trunk/projects/en)
by Andrew Lewman 04 Jun '11

04 Jun '11

Author: phobos Date: 2011-06-04 11:40:40 +0000 (Sat, 04 Jun 2011) New Revision: 24802 Modified: website/trunk/projects/en/vidalia.wml Log: fix a grammar mistake. Modified: website/trunk/projects/en/vidalia.wml =================================================================== --- website/trunk/projects/en/vidalia.wml 2011-06-04 03:00:06 UTC (rev 24801) +++ website/trunk/projects/en/vidalia.wml 2011-06-04 11:40:40 UTC (rev 24802) @@ -80,7 +80,7 @@ <h4>Alpha Releases</h4> The most recent alpha release is: 0.3.0 - WARNING this are very alpha bundles. + WARNING these are very alpha bundles. <ul> <li> <a href="https://archive.torproject.org/tor-package-archive/technology-preview/vidal…">Windows Installer</a>

1 0

[torbutton/master] Bug 3345: Make Google Captcha redirect work again.
by mikeperry＠torproject.org 04 Jun '11

04 Jun '11

commit e42dc36ceb914766c3337a655b4998f07407ddfb Author: Mike Perry <mikeperry-git(a)fscked.org> Date: Fri Jun 3 20:00:19 2011 -0700 Bug 3345: Make Google Captcha redirect work again. --- src/chrome/content/torbutton.js | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/chrome/content/torbutton.js b/src/chrome/content/torbutton.js index 401443a..720e281 100644 --- a/src/chrome/content/torbutton.js +++ b/src/chrome/content/torbutton.js @@ -3035,7 +3035,8 @@ function torbutton_check_google_captcha(subject, topic, data) { redirURI.init(Ci.nsIStandardURL.URLTYPE_STANDARD, 80, redir, subject.URI.originCharset, null); redirURI = redirURI.QueryInterface(Components.interfaces.nsIURI); - if (redirURI.host == "sorry.google.com") { + if (redirURI.host == "sorry.google.com" + || redirURI.path.match("^/sorry/")) { var browser = null; if(m_tb_ff3 && subject.notificationCallbacks) { // Arg. google.timers.load.t is fucking us up!

1 0

r24801: {} Write down my thoughts on a simplified product package roadm (projects/roadmaps)
by Andrew Lewman 04 Jun '11

04 Jun '11

Author: phobos Date: 2011-06-04 03:00:06 +0000 (Sat, 04 Jun 2011) New Revision: 24801 Added: projects/roadmaps/proposed-package-roadmap.txt Log: Write down my thoughts on a simplified product package roadmap. Added: projects/roadmaps/proposed-package-roadmap.txt =================================================================== --- projects/roadmaps/proposed-package-roadmap.txt (rev 0) +++ projects/roadmaps/proposed-package-roadmap.txt 2011-06-04 03:00:06 UTC (rev 24801) @@ -0,0 +1,132 @@ +Proposed Package Roadmap + +I've been thinking about how we can simplify our product list and get +back to focusing on what we're good at producing. At the same time, +getting more people involved in each others products can get us back +to the idea we had at the 2010 Potsdam meeting where we had primary and +secondary developers for each product. + +I propose we radically simplify our packages to the following four, for +all operating systems we support: + +1. tor-client. This is the tor browser bundle. +2. tor-relay. This is the tor binary with geoipdb, pre-configured as +a non-exit relay. +3. tor-exit-relay. This is the tor binary with geoipdb, pre-configured +as an exit relay. +4. tor-bridge. This is the tor binary with geoipdb, pre-configured as +a publishing bridge. + +Why? + +We support a dizzying array of packages for an ever increasing number of +operating systems. Some packages you install, some are setup via native +operating system packaging systems, some are just download and run. +Developing a standard set of packages that contain the same things on +different OSes should be possible. Users currently have to configure +their software in varying ways, and then interact with their operating +system and network devices to help the Tor network. We should make it +very easy to get tor running as the user wishes. + +It would make the user choice clear. "I want to run tor as" can be +answered by which package they download and install. There is minimal +configuration to be done, and the packages should just work 'out of the +box'. + +This could also reduce support load. Instead of supporting a billion +apps and configs that may or may not be as anonymous/private as TBB, we +just support TBB. TBB becomes the focus on making it as zero-footprint +and anonymous as possible. + +(Where does this leave TAILS? If one wants to 'torify' everything, then +use TAILS; in a virtual machine, natively, whatever. If downloading TBB +sucks, downloading TAILS would be horrible. thandy updater for TAILS, +or does that defeat the point of a read-only OS?) + +What does this mean practically for each major operating system we +support? + +Microsoft Windows + +1. tor-client. The same TBB we ship today. +2. tor-relay. Vidalia and tor pre-configured as a non-exit relay. Look +at the current bridge-by-default bundle, just change the vidalia.conf to +be a non-exit relay. +3. tor-exit-relay. Vidalia and tor pre-configured as an exit relay. Look +at the current bridge-by-default bundle, just change the vidalia.conf to +be an exit relay. +4. tor-bridge. Vidalia and tor pre-configured as a bridge. Look +at the current bridge-by-default bundle. + +Apple OS X + +1. tor-client. The same TBB we ship today. +2. tor-relay. Vidalia and tor pre-configured as a non-exit relay. +Using TBB portable tor and vidalia, ship a vidalia.conf to be a non-exit +relay. +3. tor-exit-relay. Vidalia and tor pre-configured as an exit relay. +Using TBB portable tor and vidalia, ship a vidalia.conf to be an exit +relay. +4. tor-bridge. Vidalia and tor pre-configured as a bridge. +Using TBB portable tor and vidalia, ship a vidalia.conf to be a bridge. + +GNU/Linux (deb and rpm) + +1. tor-client. The same TBB we ship today. +2. tor-relay. Create tor-relay.(deb|rpm) that includes geoipdb and a +pre-configured torrc that is for a non-exit relay. +3. tor-exit-relay. Create tor-exit-relay.(deb|rpm) that includes geoipdb and a +pre-configured torrc that is for an exit relay. +4. tor-bridge. Create tor-bridge.(deb|rpm) that includes geoipdb and a +pre-configured torrc that is for a bridge. + +Obvious issues (to me) + +1. If a user wants to run both a tor-client and +tor-(relay|exit-relay|bridge) on the same host, we run into port +conflicts. At a minimum, the tor socks port, 9050 and control port, +9051 show up right away. For the tor-(relay|exit-relay|bridge) +packages, one can disable the socks port altogether, and just leave the +control port. I believe there is some work to make vidalia and tor +negotiate a control port number and choose that, assuming nothing else +uses it. This could be true for tor-* on start. It can default to +9050/9051, but if already taken, pick the next free port for socks and +control. + +Alternatively, each package chooses a different socksport/control port +combination. + +2. Users will still run into firewalls, NAT routers, and the like while +trying to get their tor relay working. This is the same situation we +have now, but it grossly simplifies the ability to get tor working. +Step 1: install tor package of your choice +Step 2: fight with your firewall/nat port-forwards +If we get upnp working in tor itself, this may or may not make it easier +for the users. + +3. The conversion from legacy to new packaging could be a mess. Relay +operators used to doing things one way will have to change. Users used +to installing tor and then configuring their apps will have to adjust. + +4. Installing a new tbb for every new release sucks, especially in +places with little bandwidth. Getting thandy working would solve this +issue. Having standardized packages for tor-clients may also make +thandy deployment easier, as it's the same software in each package, +just different binaries. + +5. The *BSD ports system would need to create different ports, or offer +make options that enable the different configs for non-exit, exit, and +bridge relay. This is also true for fink/macports. + +Of course, users should be able to create their own packages, based on +our published packaging scripts. + +Conclusion + +While a migration to a new set of packages could be painful, the world +after the flag day would get easier and easier over time. The package +sets are simplified, nearly all of our problems with configuring tor as +a relay or bridge go away, and it simplifies product management to +defined channels. We can then focus on security, anonymity, and +usability fixes for each of the defined channels. Improvements are +pushed out across all operating systems for each channel. Property changes on: projects/roadmaps/proposed-package-roadmap.txt ___________________________________________________________________ Added: svn:mime-type + text/plain Added: svn:eol-style + native

1 0

[tor/release-0.2.2] prepare for tomorrow's release
by arma＠torproject.org 03 Jun '11

03 Jun '11

commit e084c6fd14caba9567af19cf33f25c4d7a0ac323 Author: Roger Dingledine <arma(a)torproject.org> Date: Fri Jun 3 17:43:09 2011 -0400 prepare for tomorrow's release --- configure.in | 2 +- contrib/tor-mingw.nsi.in | 2 +- src/win32/orconfig.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.in b/configure.in index a440c17..95e90e6 100644 --- a/configure.in +++ b/configure.in @@ -4,7 +4,7 @@ dnl Copyright (c) 2007-2008, The Tor Project, Inc. dnl See LICENSE for licensing information AC_INIT -AM_INIT_AUTOMAKE(tor, 0.2.2.27-beta) +AM_INIT_AUTOMAKE(tor, 0.2.2.28-beta) AM_CONFIG_HEADER(orconfig.h) AC_CANONICAL_HOST diff --git a/contrib/tor-mingw.nsi.in b/contrib/tor-mingw.nsi.in index 7fe0304..d4b74f4 100644 --- a/contrib/tor-mingw.nsi.in +++ b/contrib/tor-mingw.nsi.in @@ -8,7 +8,7 @@ !include "LogicLib.nsh" !include "FileFunc.nsh" !insertmacro GetParameters -!define VERSION "0.2.2.27-beta" +!define VERSION "0.2.2.28-beta" !define INSTALLER "tor-${VERSION}-win32.exe" !define WEBSITE "https://www.torproject.org/" !define LICENSE "LICENSE" diff --git a/src/win32/orconfig.h b/src/win32/orconfig.h index e9b98f0..36f1fc1 100644 --- a/src/win32/orconfig.h +++ b/src/win32/orconfig.h @@ -233,5 +233,5 @@ #define USING_TWOS_COMPLEMENT /* Version number of package */ -#define VERSION "0.2.2.27-beta" +#define VERSION "0.2.2.28-beta"

1 0

[tor/release-0.2.2] whoops
by arma＠torproject.org 03 Jun '11

03 Jun '11

commit bb6ba2a17cdef37f919f71661f7004606f4ffd00 Author: Roger Dingledine <arma(a)torproject.org> Date: Fri Jun 3 17:41:06 2011 -0400 whoops --- ChangeLog | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index b526380..5c9b96c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -240,7 +240,7 @@ Changes in version 0.2.2.26-beta - 2011-05-17 on 0.2.0.10-alpha. o Removed features: - - Caches no longer download and serve e2 networkstatus documents + - Caches no longer download and serve v2 networkstatus documents unless FetchV2Networkstatus flag is set: these documents haven't haven't been used by clients or relays since 0.2.0.x. Resolves bug 3022.

1 0